From nobody Sun Feb 8 22:58:22 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE98235FF6F for ; Wed, 7 Jan 2026 15:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767798580; cv=none; b=VKnncSvpkdE4ftO5O/eRKX5uW6Eq3VARUQ9FEvJI3o4XGsn1G3hTnBlDF/I5PfgKV8B9D8/fKg5YTFKconDd32PexCnuPIddyryrZuYJMoBkMelyt+7Yk4fZmmGQ429JiH9XyRv1rd2e2unx4RmnTUjrvYgEHtpgPJyIq8EyO8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767798580; c=relaxed/simple; bh=mnmqm+sV4J6xoZuyVc6SiEB8yZ+1Lv05//8FJGOKXHc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u5WkYjzoTvesnh+/v69DTP8MEJaH14r4laixUyG5RcT+AkmoEOJZGWf6CorhYW6bxS144CfBczZqiu6Q/hGpl3hVSW+L3JSPzkbRfhkdiYyjwzYPuJi4rQHVUKYQfktgSz1235FLxe3vs9ptoNMULw/NOboNmRslKRSAiL8uYVw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NdYpryTR; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NdYpryTR" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7acd9a03ba9so1576001b3a.1 for ; Wed, 07 Jan 2026 07:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767798578; x=1768403378; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KeBDx+YUjGbbLJYP7ioCQ7iYFylmc1DSRE5Jg3YEh+4=; b=NdYpryTRT8DeqDFTuENaXQt+tw4jVqWla45qCIb0JafqUARiubDnXtQbrZTTlZCVXt EEeeLqKmA+TilH34yoA329POF7y8O3+juOCdXuhpvF9/3v4dUzQW4+egEj0DimDOSAC+ XKhPkhpZk31s2znobARvlqFSpkWDp4WPcWrbel/z54HrOc16U4qBh2Af896IlBD1yNhU 73FcbA1r43x1oUsrC4/BLv6Gf3MWCijLmTqFrb1KTk3j4NFLx5bCuK5csJ7uBTSuPkPJ 9u0wsKoacmDt03WuVJ02zF/DZZgDUllFVYYYospAjdpEVwHUN9MvZ1K4V/65SVVW67nF 4BYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767798578; x=1768403378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KeBDx+YUjGbbLJYP7ioCQ7iYFylmc1DSRE5Jg3YEh+4=; b=YV3VW1EHtve6GyOp9ZAhA1xkGZXQQATSLhBBX9TehHNbwbS3PcAdbMVA3cttz7IIwd YDQwk+39XHL/OnJQsHrRs5IJupJidatm0JBdUu8KSFlcq4QtlHoE4nOaOxgLIh5EU4Ab 4juDN1nJafySPLw5BJCRd/XQTUoFDYIwOxAXd4lnTzRs3F5YjC3ObDIeXJPNn4F5JMp4 2cfEwe3AkdBrVt7wEsWCkktVfcOKGJg7PKMIim6zCggZyb/dtfgq+itbvwVQ0lTtKbCO Pj7sWeYcYMLOxIBDA/mDXqY/KS+9B92N28Lam5DUu7vk4p3egg0CB1t8AJuWDKZiUrxZ Hfaw== X-Forwarded-Encrypted: i=1; AJvYcCUYmuSUaT7hJhxx1PuKSIFy5z2wjkeUlN/g3Hq/KlIgQZOWEuw+8tuX8AfqGoWuCMH4Ifl2ubWEq03WYeE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz77C0tJ0syxlRRFziathiY+pgBntPsdKnAm4e/5i50jag8d4qV zjRx1EYXrq/LAMGQv8+hLm1/OM1Zn2YjY9WMU5JVDxkPn2r/MawuPOeG X-Gm-Gg: AY/fxX4QDteu2oun2VQmtzgGmsQnTCDSA7Dtyd+Vg2v1ZDtxCd670JyiO8Mv1oWW/pk VwvkwykrV6nnOUBtRgVhlpojL9j4WNMRZSa8sIatdiUvU9j0Kor2SviSfacpnd/iBoepUkcVUA5 ZE93EJQM1wqeA+FSiSJiqVJThKp29NAb3jhdnsJQ7j00gdA5NsaT6zX48B+zKKwy3mAeoJ2/M7I gDaHpktl8OtbzxuHMU2sJ3HVPHzbfl0w3yxgYI3k7Z97QSIED9QEgmPG4HcbBcEBp2VMGkXiAZM BFPogCd5IpVCipbKh7AOb5mGoMgOYyBHw2Y4y5FvdQ386yPpTUEqNeMJZOB12mqUUopbMQeyGuE DjkfnSox76N+83PFh79bJvCvz7owS7H3lfbe+Hs6ae/NljXrvZrqNfLlUfrAeL/gafbAkLuU3wM vcWEqINy924es= X-Google-Smtp-Source: AGHT+IGMs2B36viuuAnfjeiIBdzTg9KYUmjvbamIyDu2pKeCZP0v+ieVtRSjbeiTwNmI0J2gSr8EKg== X-Received: by 2002:a05:6a00:4103:b0:7f7:850:dbed with SMTP id d2e1a72fcca58-81b7f7e2ae4mr2318127b3a.44.1767798577923; Wed, 07 Jan 2026 07:09:37 -0800 (PST) Received: from karthik.. ([43.247.159.43]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c59df961sm5246114b3a.47.2026.01.07.07.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:09:37 -0800 (PST) From: Karthikey D Kadati To: Hans de Goede , Mauro Carvalho Chehab Cc: Dan Carpenter , Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Karthikey D Kadati Subject: [PATCH v4 3/3] media: atomisp: propagate errors from ISP xnr and IRQ enable Date: Wed, 7 Jan 2026 20:38:58 +0530 Message-ID: <20260107150858.79818-4-karthikey3608@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107150858.79818-1-karthikey3608@gmail.com> References: <20260107150858.79818-1-karthikey3608@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate the return value of atomisp_css_capture_enable_xnr() in atomisp_xnr(). Also print an error message if atomisp_css_irq_enable() fails. Signed-off-by: Karthikey D Kadati --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/stag= ing/media/atomisp/pci/atomisp_cmd.c index 677c460fe..0f5b2e90d 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -874,7 +874,8 @@ void atomisp_assert_recovery_work(struct work_struct *w= ork) if (!isp->asd.streaming) goto out_unlock; =20 - atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, false); + if (atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, false)) + dev_err_once(isp->dev, "atomisp_css_irq_enable failed\n"); =20 spin_lock_irqsave(&isp->lock, flags); isp->asd.streaming =3D false; @@ -925,8 +926,9 @@ void atomisp_assert_recovery_work(struct work_struct *w= ork) =20 atomisp_csi2_configure(&isp->asd); =20 - atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, - atomisp_css_valid_sof(isp)); + if (atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, + atomisp_css_valid_sof(isp))) + dev_err_once(isp->dev, "atomisp_css_irq_enable failed\n"); =20 if (atomisp_freq_scaling(isp, ATOMISP_DFS_MODE_AUTO, true) < 0) dev_dbg(isp->dev, "DFS auto failed while recovering!\n"); @@ -1196,9 +1198,7 @@ int atomisp_xnr(struct atomisp_sub_device *asd, int f= lag, return 0; } =20 - atomisp_css_capture_enable_xnr(asd, !!*xnr_enable); - - return 0; + return atomisp_css_capture_enable_xnr(asd, !!*xnr_enable); } =20 /* --=20 2.43.0