From nobody Mon Feb 9 13:00:55 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 666E7332EA4 for ; Wed, 7 Jan 2026 13:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767793760; cv=none; b=l5Se280JqB5HGrV4tHsVx4ievoUViknFnruLEh5q278ykQCHAHgaGeqS8WNjZ/aU+KOBU//XNjrJLu2EW8OVvibb46TMh+QafytRAGUBdJWWSXB/hH9Sqk0Av2ulKA8xSbYxQY5P7ZF5lKbeEXsTCjqY1/KV5lBWcJiQiUBAs5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767793760; c=relaxed/simple; bh=VcJC7sCWJodERaoTS9t7XlGBxL7hprZHiIDPn09Ne7s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cjWWfQwl+Nl56JPuzQlVQm09pfXzTT0XD4vfQn6CGrw0rYD0AnRwiL6+Qh7QU4pPrMlKvRYCNpJQoLccHTmKdWgLImN44eX0cKDCD5gekI6vG27zC5MOYHqO7v4cU0ocTRgjFT6jJSy86ayjoBbxU6aFvGZ8nWw+ussOcMmwJHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gxJYz8bt; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gxJYz8bt" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7b9387df58cso2491137b3a.3 for ; Wed, 07 Jan 2026 05:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767793758; x=1768398558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bw6fgNtZmBe2W56ugS12P5lnC0TRTn4SZrhJOxug+wQ=; b=gxJYz8bt/oZWkgpgaOd6u2u1vp5NupVrTV28o7GAMqG/gNb/5MIwE/mQ+eLk16y44C /SwwjQa/mMB9W9jIEPqQgxLYMi6DKCjrI0bEh8TjBDduUp3OHS18IQkfsE+xoEO8uw97 zi0ZsPBBF9cVtWgNKEc2Hu32F9kQRoFkTagClrG7GI4cT5NIFpn+8Y8aFvyVPZrLjmJy Twa8y3hACCRLTm7ePSOm9oWLQwogNhZdCyuu/D7V0LeYq/sKTRI4hqpvkYoaJ5bXsFLp INm2Gw5FEti9G0w2BTUI3+yz8KoNTTNHvHtkZFGyrIXSVhRI7yihqEtF2GEDgOvJ+h7t DBgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767793758; x=1768398558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Bw6fgNtZmBe2W56ugS12P5lnC0TRTn4SZrhJOxug+wQ=; b=ipo1v/0eHzRS1EN71XmCxsFA3QVk0gJry4B9RItzEA8Ld8+8X1wdDNYlY8KMqOb5l/ 7DdijBjfqP5xHb9NWrPUs63OP61aSqlMD9xF1Pc47AS0+p1ijvhnvm8HeZ8qmxeWx7Iq qGuPJT0cUG20F6HDtIdI0cp7DaBBLqp94S/DeU01EMnn15m3p5mg7z9hOtqdB8f1wJxd cNVqyXv0jx/JyhFdE6SODTGqgY62s3BheAFPLLIO5UUvAKqXAB86rV8u0ABmF8fBJrSK rCiSlTndLglaGpJrkqIrQEDlY5QiLUlMzl5Cq2Fqjblc2QG1zWx9BXh0lzFUR1XT9lnD UcGg== X-Forwarded-Encrypted: i=1; AJvYcCUOz4ROv5hibr+wAeVrkgvBg5ICr/PGDDifntFWgjOIyVOoLjnxxGRb6SANj5i6dS5Gf4TH+LP3VQHqERc=@vger.kernel.org X-Gm-Message-State: AOJu0YzyQWaz0GzRQwZWUOZGbHYufdYXqvY8w03AHWpjLU+mEPNLIvNM 6t8RD2AjnH2vY+gPhVTxG/+kxc90x6s/5si5+3BC1KI6prsuHmaxKgJF X-Gm-Gg: AY/fxX64z30C+RDJvSAPUbkhO6uAkfV0x7t8Oinuvin4qV0X9g+aLtLF4PC4BXVl3dQ G5EZVHqyDWrWmse7xbDTWaweUp8eGTgNi9b0cDir3/ywpNsWxL2OeEKsYwkEamMe4Zx3FC+p3Lc hzl1Pt1NDwV7TjNXUYF7g9AcdJlCYeWrs3jPVvfID4HtydJYJq/+7XCmDs9vL+Njt1g8ciXP6Zc sJ74FXgnfX8EPxdxrhByIwobESpbtu8ie2NEMjHcYMTsz5t5qJimnmu4z7vM4Hmolv/pNqY6uUP HKtUEvnDhrkQ0aVu+N4D7TtMOmrDBGu16X8VqLcPu/cWXTxshH0GtvdBlSi7HOZoLZ+bCfv6pIC talF2PpQubMfNzRzXhBzL5YAe2UFqmNlb6k2CSJTTMhWGfD0d+VElkiCrW7bkEdxoxlmm1FZAs/ jU96eDtE4qOCc= X-Google-Smtp-Source: AGHT+IFj4SFEIp18Y5M2C38LwZUCcGWQNMHaApWC/2wyk9IyQIwapqJnVP0bVg04ZV9jnPoyGDdrDA== X-Received: by 2002:a05:6a20:6a26:b0:35d:cad7:cd63 with SMTP id adf61e73a8af0-3898f91d20fmr2344473637.30.1767793758490; Wed, 07 Jan 2026 05:49:18 -0800 (PST) Received: from karthik.. ([43.247.159.43]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c5302c61sm5109577b3a.42.2026.01.07.05.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 05:49:18 -0800 (PST) From: Karthikey D Kadati To: Hans de Goede , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Karthikey D Kadati Subject: [PATCH v2 RESEND v2 3/3] media: atomisp: propagate errors from ISP xnr and IRQ enable Date: Wed, 7 Jan 2026 19:18:44 +0530 Message-ID: <20260107134844.68074-4-karthikey3608@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107134844.68074-1-karthikey3608@gmail.com> References: <81e2d12c-342b-4b88-88a0-3e24115541aa@kernel.org> <20260107134844.68074-1-karthikey3608@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate the return value of atomisp_css_capture_enable_xnr() in atomisp_xnr(). Also check the return value of atomisp_css_irq_enable() and log an error once using dev_err_once() to avoid flooding dmesg. Signed-off-by: Karthikey D Kadati --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/stag= ing/media/atomisp/pci/atomisp_cmd.c index 4ed6b8aea..da2481af2 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -874,7 +874,8 @@ void atomisp_assert_recovery_work(struct work_struct *w= ork) if (!isp->asd.streaming) goto out_unlock; =20 - atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, false); + if (atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, false)) + dev_err_once(isp->dev, "atomisp_css_irq_enable failed\n"); =20 spin_lock_irqsave(&isp->lock, flags); isp->asd.streaming =3D false; @@ -925,8 +926,9 @@ void atomisp_assert_recovery_work(struct work_struct *w= ork) =20 atomisp_csi2_configure(&isp->asd); =20 - atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, - atomisp_css_valid_sof(isp)); + if (atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, + atomisp_css_valid_sof(isp))) + dev_err_once(isp->dev, "atomisp_css_irq_enable failed\n"); =20 if (atomisp_freq_scaling(isp, ATOMISP_DFS_MODE_AUTO, true) < 0) dev_dbg(isp->dev, "DFS auto failed while recovering!\n"); @@ -1196,9 +1198,7 @@ int atomisp_xnr(struct atomisp_sub_device *asd, int f= lag, return 0; } =20 - atomisp_css_capture_enable_xnr(asd, !!*xnr_enable); - - return 0; + return atomisp_css_capture_enable_xnr(asd, !!*xnr_enable); } =20 /* --=20 2.43.0