From nobody Wed Feb 11 06:30:17 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF732C08D0 for ; Wed, 7 Jan 2026 11:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784806; cv=none; b=oO+lYN8ffT7rP1lZVNupVC8joqtnbJ8gNWO7jq7RKNYKptQaaA0YKndL4TjkYrk/95qGtiFHfpoV3aBhSRi+E4BQcoIpPGiqQlN+e/eJs/sOYxLLv7tiivnCxvLLx6TJL+XnkeYZMEafaF4/L0rtQGtimdsOjfsGAM6Z8d1args= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784806; c=relaxed/simple; bh=4UpJyomXhJKAJBk8kEwQdBLU/Z1VqDledzUt+c8zgJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o+YnlHH70QpuLO70kUuswvaKoDTglBHeAkGKjnXtpQxpIoog7Sid5/T5c3aaKwghKSSEC/XUzPIBg8Yivt39Vzkgb8rGMeDUwBgwdPebYRPyqI+esJYCm4YYPI7vEXQ0A9+6BFxmi3VnVLXpKqcReNhHgN0zuFIGhnqh6qw0fGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VKVaRgQ/; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VKVaRgQ/" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42e2d02a3c9so1408757f8f.3 for ; Wed, 07 Jan 2026 03:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767784803; x=1768389603; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T0Xzx90O227/P+k1Zvoh68FlipQTABA5u9PpS6l4LP0=; b=VKVaRgQ/jWZnl/Mrd1aZqQ1417WYdnKTAaLSt3EatYZDmWsX2LK2FMCuDyl01sm4a5 wky1ITBwTmyDrGRmNp54sMhOsTMMPL7dP4wbnNs17opeamKTlcGE8ogKx4rYcwyzjBay 10N24xUcV23B2WMwfzXyyhnCGSl8D2/sN/d+yU+cqSD6fU6DAJvj91dAsT4He3B0tT3l AvLzrjMoP2/Rd3oKSpwrOi8yse4udvxfnMhR6SmeMLVWrsy086FLpBzVrsR2EcOzU0L1 FL1Ss+DL5maLOmqabD3dmWJAkZSxJcIbldBLjmezq/vctQhyXiIpUI7Kz3k8jmhr8yOM IlUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767784803; x=1768389603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T0Xzx90O227/P+k1Zvoh68FlipQTABA5u9PpS6l4LP0=; b=OajkEk+1coDhrF+pi0SOUN5jp6KE9C573SYGqF6TdlDvZNT/0We+SBaCR1gnO7fzMn VRP+RRwooEdMUOcjYiO10gcbPZN01nGWDUOohdqS66lRvi3HNGeQcquTK2leK6hXRkYe Dcd7h1OjpDBoEHIS0mCpkcL97KZlOk7ioT4zgkcsgHemFC7Geafhe3dDXNyh/gS9vBG+ seP2rCMKP3Huo7a+lT5rDxz/YjuTZEmMFrGQ3GTBftYlgW3hu1APBiOfiEWog3bO8he5 3FsWrayEeYjZfljvUxahONUVd+tAIebsFJEeZvyRDjDVv+OEnk3v0rCD1V2b6RkGaoHN TCBQ== X-Forwarded-Encrypted: i=1; AJvYcCXASrwYOPDoksIX3KzzwyH1V8Iodq4SAH/5E+gvGVXVaDBT/PiXBjufnAwwP6CO2kZPSKQ12ZGBax/CR7I=@vger.kernel.org X-Gm-Message-State: AOJu0YxzFpRLm9GPkDEjNVDwCplxeJ7VhSMffWlZmrrTwl0E05744KIB keWQefZlLtRWk8j70QZFi/O1oyvhHiFSChzEPe0Ut2cLFl5BGSjwgC/Y X-Gm-Gg: AY/fxX5VXHc/KqgeWYNk2bAvrmb7gjLWu7OlD7Ax2kkP4MoOt3uDnuHwVJhC5r9Cg2P nPPWIkLMLGnzillsJ3x7SP2lhFIYjbPqAn9NCpgngRQ29tNDRAgzTvBRLaPFV8ib3GrvxKPh9ef /Ioa4p5CuHHSvuEC9/ctImtiIVMqVH2bDIBcra85va8q1S0BHWJ86bKQ7QULa8LpSJ8DmjTopki WsIGX63DrRSnaKPMQlmk7vLWePTHXFqaEpYtXmzfSFEKOz6HF49cV8BRyhpBNIJQV0IAiVgunBG UzRkKFm2MLDqDVZ7zAmejpSO2Pel6pvzvhwd82NQz2l50zfLPrZCUVzaGlHKcCt6NiFydqBYzdI N3VqH171aTDwarc5iuXZLpYkq4pIJyi6OlOiNoY8fxKHtlAUf/fhKU85ItfzXg2Wr0bj2PZ1/Fx OnRyDQFe+E+UzeqG0uz1YhsQzlU9rjSvQXnOFB8dc= X-Google-Smtp-Source: AGHT+IFhPXwNn3HSieuU4dTTZKAT+KsFT5sgVhaInEQNM4WnZlAkY6p6XdjzDvxN/HQNvAZcd+OMJg== X-Received: by 2002:a05:6000:2084:b0:42b:2ee0:569f with SMTP id ffacd0b85a97d-432c37c87c6mr2902184f8f.33.1767784803406; Wed, 07 Jan 2026 03:20:03 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ede7esm9733210f8f.32.2026.01.07.03.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 03:20:03 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: jikos@kernel.org, bentiss@kernel.org Cc: superm1@kernel.org, benato.denis96@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ionut_n2001@yahoo.com, sunlightlinux@gmail.com Subject: [PATCH 1/4] HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant Date: Wed, 7 Jan 2026 13:19:44 +0200 Message-ID: <20260107111945.48018-4-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107111945.48018-2-sunlightlinux@gmail.com> References: <10abfaa7-9f5b-494c-8bb5-5da53c087fc4@kernel.org> <20260107111945.48018-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita Use the existing HID_UP_ASUSVENDOR constant instead of the magic number 0xff310000 for better code clarity and maintainability. Change-Id: I65cf58cd0cd47acc39b755fa9a5fb7f2ad271046 Signed-off-by: Ionut Nechita Reviewed-by: Denis Benato Reviewed-by: Mario Limonciello (AMD) --- drivers/hid/hid-asus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 472bca54642b9..eb14b9d13823b 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -317,7 +317,7 @@ static int asus_e1239t_event(struct asus_drvdata *drvda= t, u8 *data, int size) static int asus_event(struct hid_device *hdev, struct hid_field *field, struct hid_usage *usage, __s32 value) { - if ((usage->hid & HID_USAGE_PAGE) =3D=3D 0xff310000 && + if ((usage->hid & HID_USAGE_PAGE) =3D=3D HID_UP_ASUSVENDOR && (usage->hid & HID_USAGE) !=3D 0x00 && (usage->hid & HID_USAGE) !=3D 0xff && !usage->type) { hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n", --=20 2.52.0