From nobody Wed Feb 11 03:42:02 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF732C08D0 for ; Wed, 7 Jan 2026 11:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784806; cv=none; b=oO+lYN8ffT7rP1lZVNupVC8joqtnbJ8gNWO7jq7RKNYKptQaaA0YKndL4TjkYrk/95qGtiFHfpoV3aBhSRi+E4BQcoIpPGiqQlN+e/eJs/sOYxLLv7tiivnCxvLLx6TJL+XnkeYZMEafaF4/L0rtQGtimdsOjfsGAM6Z8d1args= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784806; c=relaxed/simple; bh=4UpJyomXhJKAJBk8kEwQdBLU/Z1VqDledzUt+c8zgJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o+YnlHH70QpuLO70kUuswvaKoDTglBHeAkGKjnXtpQxpIoog7Sid5/T5c3aaKwghKSSEC/XUzPIBg8Yivt39Vzkgb8rGMeDUwBgwdPebYRPyqI+esJYCm4YYPI7vEXQ0A9+6BFxmi3VnVLXpKqcReNhHgN0zuFIGhnqh6qw0fGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VKVaRgQ/; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VKVaRgQ/" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42e2d02a3c9so1408757f8f.3 for ; Wed, 07 Jan 2026 03:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767784803; x=1768389603; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T0Xzx90O227/P+k1Zvoh68FlipQTABA5u9PpS6l4LP0=; b=VKVaRgQ/jWZnl/Mrd1aZqQ1417WYdnKTAaLSt3EatYZDmWsX2LK2FMCuDyl01sm4a5 wky1ITBwTmyDrGRmNp54sMhOsTMMPL7dP4wbnNs17opeamKTlcGE8ogKx4rYcwyzjBay 10N24xUcV23B2WMwfzXyyhnCGSl8D2/sN/d+yU+cqSD6fU6DAJvj91dAsT4He3B0tT3l AvLzrjMoP2/Rd3oKSpwrOi8yse4udvxfnMhR6SmeMLVWrsy086FLpBzVrsR2EcOzU0L1 FL1Ss+DL5maLOmqabD3dmWJAkZSxJcIbldBLjmezq/vctQhyXiIpUI7Kz3k8jmhr8yOM IlUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767784803; x=1768389603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T0Xzx90O227/P+k1Zvoh68FlipQTABA5u9PpS6l4LP0=; b=OajkEk+1coDhrF+pi0SOUN5jp6KE9C573SYGqF6TdlDvZNT/0We+SBaCR1gnO7fzMn VRP+RRwooEdMUOcjYiO10gcbPZN01nGWDUOohdqS66lRvi3HNGeQcquTK2leK6hXRkYe Dcd7h1OjpDBoEHIS0mCpkcL97KZlOk7ioT4zgkcsgHemFC7Geafhe3dDXNyh/gS9vBG+ seP2rCMKP3Huo7a+lT5rDxz/YjuTZEmMFrGQ3GTBftYlgW3hu1APBiOfiEWog3bO8he5 3FsWrayEeYjZfljvUxahONUVd+tAIebsFJEeZvyRDjDVv+OEnk3v0rCD1V2b6RkGaoHN TCBQ== X-Forwarded-Encrypted: i=1; AJvYcCXASrwYOPDoksIX3KzzwyH1V8Iodq4SAH/5E+gvGVXVaDBT/PiXBjufnAwwP6CO2kZPSKQ12ZGBax/CR7I=@vger.kernel.org X-Gm-Message-State: AOJu0YxzFpRLm9GPkDEjNVDwCplxeJ7VhSMffWlZmrrTwl0E05744KIB keWQefZlLtRWk8j70QZFi/O1oyvhHiFSChzEPe0Ut2cLFl5BGSjwgC/Y X-Gm-Gg: AY/fxX5VXHc/KqgeWYNk2bAvrmb7gjLWu7OlD7Ax2kkP4MoOt3uDnuHwVJhC5r9Cg2P nPPWIkLMLGnzillsJ3x7SP2lhFIYjbPqAn9NCpgngRQ29tNDRAgzTvBRLaPFV8ib3GrvxKPh9ef /Ioa4p5CuHHSvuEC9/ctImtiIVMqVH2bDIBcra85va8q1S0BHWJ86bKQ7QULa8LpSJ8DmjTopki WsIGX63DrRSnaKPMQlmk7vLWePTHXFqaEpYtXmzfSFEKOz6HF49cV8BRyhpBNIJQV0IAiVgunBG UzRkKFm2MLDqDVZ7zAmejpSO2Pel6pvzvhwd82NQz2l50zfLPrZCUVzaGlHKcCt6NiFydqBYzdI N3VqH171aTDwarc5iuXZLpYkq4pIJyi6OlOiNoY8fxKHtlAUf/fhKU85ItfzXg2Wr0bj2PZ1/Fx OnRyDQFe+E+UzeqG0uz1YhsQzlU9rjSvQXnOFB8dc= X-Google-Smtp-Source: AGHT+IFhPXwNn3HSieuU4dTTZKAT+KsFT5sgVhaInEQNM4WnZlAkY6p6XdjzDvxN/HQNvAZcd+OMJg== X-Received: by 2002:a05:6000:2084:b0:42b:2ee0:569f with SMTP id ffacd0b85a97d-432c37c87c6mr2902184f8f.33.1767784803406; Wed, 07 Jan 2026 03:20:03 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ede7esm9733210f8f.32.2026.01.07.03.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 03:20:03 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: jikos@kernel.org, bentiss@kernel.org Cc: superm1@kernel.org, benato.denis96@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ionut_n2001@yahoo.com, sunlightlinux@gmail.com Subject: [PATCH 1/4] HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant Date: Wed, 7 Jan 2026 13:19:44 +0200 Message-ID: <20260107111945.48018-4-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107111945.48018-2-sunlightlinux@gmail.com> References: <10abfaa7-9f5b-494c-8bb5-5da53c087fc4@kernel.org> <20260107111945.48018-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita Use the existing HID_UP_ASUSVENDOR constant instead of the magic number 0xff310000 for better code clarity and maintainability. Change-Id: I65cf58cd0cd47acc39b755fa9a5fb7f2ad271046 Signed-off-by: Ionut Nechita Reviewed-by: Denis Benato Reviewed-by: Mario Limonciello (AMD) --- drivers/hid/hid-asus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 472bca54642b9..eb14b9d13823b 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -317,7 +317,7 @@ static int asus_e1239t_event(struct asus_drvdata *drvda= t, u8 *data, int size) static int asus_event(struct hid_device *hdev, struct hid_field *field, struct hid_usage *usage, __s32 value) { - if ((usage->hid & HID_USAGE_PAGE) =3D=3D 0xff310000 && + if ((usage->hid & HID_USAGE_PAGE) =3D=3D HID_UP_ASUSVENDOR && (usage->hid & HID_USAGE) !=3D 0x00 && (usage->hid & HID_USAGE) !=3D 0xff && !usage->type) { hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n", --=20 2.52.0 From nobody Wed Feb 11 03:42:02 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42422302773 for ; Wed, 7 Jan 2026 11:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784813; cv=none; b=PTc4CSIfIbLD3Xm9eJ95mGTzKTj5XOw4xxMABBdQtC92qP/rO2gqyXi4tvOwSsO4AQF3lWqEhmRYJ2yruEW9GtOfgG+Q4LwzxsiggktBTpJqx+o5xdUrKAFAywGR/721tjUTzgr2N3+GIMVYxhXUs3VFCgsGERMsrwMdwurGbg0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784813; c=relaxed/simple; bh=MdSkU08owBo+a95hnnnKrbOzVo7xNbKsMBkF4gz8lqQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hkG1ZPr3JyReWXreH0I45TldsPwXAHUD1O+tLP91mo2KXGt2Kvrp0nbts3b+IzbGJBnG3WcDOD5hvawajCRZB2jHGS5bTeO/5sdEui6OwBNZSSA1W2OloDmHJ8WO6FUpVjkTtz0k+GLymYYuuVK5WeTd4lzbCp42FeagLcoOgTs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=elV/LS1v; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="elV/LS1v" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-430fbb6012bso1487228f8f.1 for ; Wed, 07 Jan 2026 03:20:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767784810; x=1768389610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IIY9LcZC/3MW3IhoKNUi0t3qNOcnbLHxODIY1fPzFxo=; b=elV/LS1vEa4mmd3lbYqyIM+XXYumwF3w5Cgx6n+D4XIeGgHd8gq8pTC3VyDkTdB8AE 2Fm4qm+QQdKwPLO/wi41uCRz4W0nb6VjDiE6gqmrazOlnHtl2UQyCxnvc5hv59GERL2u zEU4YE9jLfEbKN40bHJhWcDeX20xcQL3W9woTF0KYu6h1RJw7vy7QMGMcZyLvfu2Pmjt 5ke52etnvllsZW168hdgMAe6ovjRkYgElKFI/VXGZsQOsvWSkeDRmBggU/CRDw/fZH7g jCDyP9KFCIRnQ7pfoecT0jytRUYWbozInYQiZCWbNf00nojDN7YdTcP3TvPuds6hG6Bj nUJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767784810; x=1768389610; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IIY9LcZC/3MW3IhoKNUi0t3qNOcnbLHxODIY1fPzFxo=; b=WJUnA9fbe1pFZQ2cwgjjYitaLfvgJcCwflJBwgygKo4O9Pj8JCJUdloMvgdVdJz4Yn gm5eG/VFxPM4sPvJEbTBtM0qbKetxPgDFVgdavGgS3lOvPatM/wZK+ha1+LqywPQ0GWD 3oObi1AvnOipbDaSjdn32Lj7gcrcoUnX8pupZhQ7OJpP9xgVM7kW//rgypLDNI8hrATN sh/iIi/yzWiVn/AOY32bgwQ1pyqpseE6XOqOIx4zo9lEY/mYQ2Q8lUZ9i2O5Foj7a7vQ CjnbwYIrnFJwy16I4nTvDkSR/u6AHK23XWMh/OP5XQFtcO7+4JbN657ADg6qCnjcR3cf y1Nw== X-Forwarded-Encrypted: i=1; AJvYcCU6eaThCzRJwIWpYgGKC5V9DVihLn5DLITxYZPciihUyPvI++9Ig1fDuXCNKixr/gGyzod3XygsdnX/1WI=@vger.kernel.org X-Gm-Message-State: AOJu0YzCYtWb+92nQw+FNEv7iNTa4Drz0itSjD94d25/0t1KKhhkSfOL X/VYd10CCwNFm8BTQmdmYCvqtfYvUJkrwl262DgwlIA+Q1Qq5Brjch9K X-Gm-Gg: AY/fxX54t8ZS8WY0N5Q5FAOJQvLQvOYdLn8Ar2sJsdvgEOYBmq436jvQBuq4gkJteis 1YuZp3NDk35naI/w90V/o3Oc3+DeGcz52VtcXBaBmCpbqj/M9pQBSCzeSciKwpVgQjwV/1wN7Eb OFQRTlOyq3Lx/V8rr1dlRB5P3UMwUxU8xDO1z0DGMvWo4OPlHJ3lsMosWT42Jk18d+qAa1ivWCU 2h++VtJy907RFMNGY8DJVFkdSffqbkGIT4EdFScK5rKOHWyD7aL42B0gkAFAw/F4H4rgCiyLJbC A388J1O+kDGBLGw9mq8FA+CQ9MSJj4F9HgVo98MIa7TlasU9386TfjYw0JdjnCx1V8VRZGgoz3I W9GsyPni6zEwip76RDwo0XKRZiuuE64UiN2+noQVdp/giPAZct/7DPxK7ua2X8Crui9tc8z+UUm a/b2cFTqcVpYZqov9kWjGAY3GLNr1WBWC+tTA+otk= X-Google-Smtp-Source: AGHT+IG8c5/9U26VVN69DFrjFV6YFAVD6G2plU+f2nvraUccKVULl5b0Zg0Gs/iWMJrxyuSFTIoboA== X-Received: by 2002:a05:6000:2584:b0:432:5bf9:cf22 with SMTP id ffacd0b85a97d-432c3760f0amr2438901f8f.3.1767784810410; Wed, 07 Jan 2026 03:20:10 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ede7esm9733210f8f.32.2026.01.07.03.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 03:20:10 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: jikos@kernel.org, bentiss@kernel.org Cc: superm1@kernel.org, benato.denis96@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ionut_n2001@yahoo.com, sunlightlinux@gmail.com Subject: [PATCH 2/4] HID: asus: Filter spurious HID vendor codes on ROG laptops Date: Wed, 7 Jan 2026 13:19:46 +0200 Message-ID: <20260107111945.48018-6-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107111945.48018-2-sunlightlinux@gmail.com> References: <10abfaa7-9f5b-494c-8bb5-5da53c087fc4@kernel.org> <20260107111945.48018-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita On Asus ROG G14 and G15 laptops, several HID vendor usage codes (0xea, 0xec, 0x02, 0x8a, 0x9e) are sent during normal operation without a clear purpose, generating unwanted "Unmapped Asus vendor usagepage code" warnings in dmesg. Add definitions for these codes and filter them out in asus_raw_event() to prevent kernel log spam. Tested on Asus ROG G14/G15 series laptops. Change-Id: I3f3b3a1e1698c8689e4c57582635435bfeda5990 Signed-off-by: Ionut Nechita Reviewed-by: Denis Benato Reviewed-by: Mario Limonciello (AMD) --- drivers/hid/hid-asus.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index eb14b9d13823b..06cd3d3b74af7 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -57,6 +57,13 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad"); #define ROG_ALLY_X_MIN_MCU 313 #define ROG_ALLY_MIN_MCU 319 =20 +/* Spurious HID codes sent by QUIRK_ROG_NKEY_KEYBOARD devices */ +#define ASUS_SPURIOUS_CODE_0XEA 0xea +#define ASUS_SPURIOUS_CODE_0XEC 0xec +#define ASUS_SPURIOUS_CODE_0X02 0x02 +#define ASUS_SPURIOUS_CODE_0X8A 0x8a +#define ASUS_SPURIOUS_CODE_0X9E 0x9e + #define SUPPORT_KBD_BACKLIGHT BIT(0) =20 #define MAX_TOUCH_MAJOR 8 @@ -348,6 +355,21 @@ static int asus_raw_event(struct hid_device *hdev, if (report->id =3D=3D FEATURE_KBD_LED_REPORT_ID1 || report->id =3D=3D FEA= TURE_KBD_LED_REPORT_ID2) return -1; if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) { + /* + * G14 and G15 send these codes on some keypresses with no + * discernable reason for doing so. Filter them out to avoid + * unmapped warning messages. + */ + if (report->id =3D=3D FEATURE_KBD_REPORT_ID) { + if (data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEA || + data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEC || + data[1] =3D=3D ASUS_SPURIOUS_CODE_0X02 || + data[1] =3D=3D ASUS_SPURIOUS_CODE_0X8A || + data[1] =3D=3D ASUS_SPURIOUS_CODE_0X9E) { + return -1; + } + } + /* * G713 and G733 send these codes on some keypresses, depending on * the key pressed it can trigger a shutdown event if not caught. --=20 2.52.0 From nobody Wed Feb 11 03:42:02 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56B22302773 for ; Wed, 7 Jan 2026 11:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784828; cv=none; b=Bn7cwpn32atFxjIKewdaSrrdnD16N5QuN+hx0jki0fnQLnEGOAXlbJwszdpZcXqVh2gPHfGa44UWqD0nyzAaX6eTt0YbEoYZTTLicFyzAHO/yPavCU0JvPFzetpPKcpV+MeFHNONajvwMOpQok7wSbEcT0XSgYXAOxR2bFF6o7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784828; c=relaxed/simple; bh=bhXL/qlVaZjV6U7YXLUhezHX6YWbXxyg7ca561Xl6C8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AlklGTKVhRTOKS2uiVnebI1YM0hLmNfe9DRxfjtbehYhr8AvpM3IO+3QY9aMQsPwcKmk+68vSEV3gvWyAuR6EJFN8kkfMMYIMljEZ2p/j9B2sqCsayXcQKwwjeQqd4aZLgOPQWr8C/oTM5yU5R++hi2GwM5c0XyWWgACZ2rXjNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=huaroCwj; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="huaroCwj" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47d3ffa6720so19390905e9.0 for ; Wed, 07 Jan 2026 03:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767784826; x=1768389626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IwyToufcall8PMuGttvxAFGI24D+w7zA2Duyq4+CB8g=; b=huaroCwjexR61nlSikRPeCSX8n4NxPbcfwRGluREiVZ0iRBgZdg2NwQG1B32tIBHEM vL7/VANIUgc44/UvjNLXr05SWM8HqWq5Y7+sYsa4yR+XluW1WPF4yEIDxB4fNNGh/75s lPhMCn8CQ35uXQnucw+R1xwFSx9lcZrK2QihT1win7XcjcHBCyR0z5qYn8v4lJ0GcpSW /SdTUfWGPPQZvMhLkHPj78iLjeM/bukH52LHswQuaYnElO9McWlBEeC4/ml4pXP/vdvQ IypsQjY3aslqZGESY5jLLMo6VEeM9pIVziz+u2DKF/l87f2UQ9A6IPFv+JSX5HpEgKAp AcPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767784826; x=1768389626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IwyToufcall8PMuGttvxAFGI24D+w7zA2Duyq4+CB8g=; b=XaFMahZnhkKnheEByCKZM8oS2I5rpAc0mmkzGl0qhNeimcRwqutmBW1R+2wl+uZ7DR MVvqQ+y3nAGHD+mtHHKgu6gWxCnSBNeh/Xnyj8NYM7LsNhXUNOOO2W8WUGT1myblgSlE G6gx9A/z40m1VvHQLvBwKjHkTxABMyCbmtNGJHgxpoyuo/+0tOP4vKkD7zDP3AZUHq/f yvIsAqh1+n1/pd9L8A0ORkVuEy3/0EQpn+6nXIun9+NzIhR53EbsVipMBy4DIwbf2v+B NhGEqx4xhv8SMK1ZlneaDGX/qnFAhiQvGRxjdqt5GrY/KDg7SFBRfzzPIz4+Kab5tnw/ Lbpg== X-Forwarded-Encrypted: i=1; AJvYcCV3vgIJh+0oOfM+A8NUdTpVvPkzGzN/MuKFKvAoJXzbzYMqGAEWyK/IqxJMZYvAT+v60Vxktb7QUv5O7Po=@vger.kernel.org X-Gm-Message-State: AOJu0YyihSrKCGDC4CvdUsUyTDFQ5LDwp3UjpMDRYwjW9FmdLCmuAvIr Ir5fU2/Zo1XZT8GiyPC76k1WBmVxY0YSs74M/5mmcRz38gwDibFfVO5I X-Gm-Gg: AY/fxX51GCW2GYjuxZ1d7kTl45XFifeGKcaoQRj1qBbHGoOduh5kowssFZG9sWotFUy gFb2wXYwNf3eOgcF0HViSocRC28MhgIg4pSZrQAXPxdGs6urB+31l7r7bEExGk52zoEO7vLuNw8 73WjFP7g4MAdM4s12STsNvFuzNgeRELB2YKZPf0sctIfWXZ3oUMy/BY6uhJZ7bBqZ68JH09/8Jl V5R83dNUTAGYl7+mPe/EqcmG2NHrrk7Vj4RVbjXfKSAKCcX9NNNlfu4yShSneWGVt/6qf9XJP3M DI9IXQh7vA5qY+7eCEmj+SvkruI6PzirZ+vlwDFeiL7o7Zoy9tuM0ltD2jBUEqQjSPNTlWTCldZ RIEt2XtUs+arw98qwYONSHWccbXK/avo/DuHbElv0RtGMIcQOuFi/uIUT+PMkmkK4UOdaWDcaGz YZ6WId5wBItHxNp9CAG/CVnFcXsbvPqgvRIxwRgzk= X-Google-Smtp-Source: AGHT+IEw4zMO2eVkiMUB64U3zeUyxLPKAlLXswDPB5Ecg4K3mY3LtUSZzDU0OLKBOw5QXAMn+ZKT1Q== X-Received: by 2002:a05:600c:3110:b0:479:3a86:dc1a with SMTP id 5b1f17b1804b1-47d84b41176mr22561975e9.36.1767784825629; Wed, 07 Jan 2026 03:20:25 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ede7esm9733210f8f.32.2026.01.07.03.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 03:20:24 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: jikos@kernel.org, bentiss@kernel.org Cc: superm1@kernel.org, benato.denis96@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ionut_n2001@yahoo.com, sunlightlinux@gmail.com Subject: [PATCH 3/4] HID: asus: Add WMI communication infrastructure Date: Wed, 7 Jan 2026 13:19:48 +0200 Message-ID: <20260107111945.48018-8-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107111945.48018-2-sunlightlinux@gmail.com> References: <10abfaa7-9f5b-494c-8bb5-5da53c087fc4@kernel.org> <20260107111945.48018-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita Add the infrastructure needed for the HID driver to communicate with the asus-wmi driver: - Add linux/acpi.h include (in alphabetical order) - Define ASUS_WMI_METHODID_NOTIF method ID in asus-wmi.h - Implement asus_wmi_send_event() function to send events to asus-wmi This infrastructure will be used to handle special keys that require WMI communication. Change-Id: Ic4d9b35f8b1f2b48c7c26e7259b4d05951021b58 Signed-off-by: Ionut Nechita Reviewed-by: Denis Benato --- drivers/hid/hid-asus.c | 24 ++++++++++++++++++++++ include/linux/platform_data/x86/asus-wmi.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 06cd3d3b74af7..05fa35489258d 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -23,6 +23,7 @@ /* */ =20 +#include #include #include #include @@ -321,6 +322,29 @@ static int asus_e1239t_event(struct asus_drvdata *drvd= at, u8 *data, int size) return 0; } =20 +/* + * Send events to asus-wmi driver for handling special keys + */ +static int asus_wmi_send_event(struct asus_drvdata *drvdata, u8 code) +{ + int err; + u32 retval; + + err =3D asus_wmi_evaluate_method(ASUS_WMI_METHODID_DEVS, + ASUS_WMI_METHODID_NOTIF, code, &retval); + if (err) { + pr_warn("Failed to notify asus-wmi: %d\n", err); + return err; + } + + if (retval !=3D 0) { + pr_warn("Failed to notify asus-wmi (retval): 0x%x\n", retval); + return -EIO; + } + + return 0; +} + static int asus_event(struct hid_device *hdev, struct hid_field *field, struct hid_usage *usage, __s32 value) { diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/pla= tform_data/x86/asus-wmi.h index 419491d4abca1..516538b5a527e 100644 --- a/include/linux/platform_data/x86/asus-wmi.h +++ b/include/linux/platform_data/x86/asus-wmi.h @@ -29,6 +29,7 @@ #define ASUS_WMI_METHODID_KBFT 0x5446424B /* KeyBoard FilTer */ #define ASUS_WMI_METHODID_INIT 0x54494E49 /* INITialize */ #define ASUS_WMI_METHODID_HKEY 0x59454B48 /* Hot KEY ?? */ +#define ASUS_WMI_METHODID_NOTIF 0x00100021 /* Notify method */ =20 #define ASUS_WMI_UNSUPPORTED_METHOD 0xFFFFFFFE =20 --=20 2.52.0 From nobody Wed Feb 11 03:42:02 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 247AF30ACE8 for ; Wed, 7 Jan 2026 11:20:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784845; cv=none; b=jMpZfuuGc8TzGrwNyWUNCi/AL7q8fcVyzr7Ph4jvQl85gSrBjekCWcN7m5kaYm84kZgsik0qBfUnQW45E13D7jlIdrYIO9MJFPcoJ6TjOh8TeASsYMIoprtRyx1Q9+B6Nkjji+6X6AcUWR9KjTZtOgMeLTCnK29qBdqBH9ujqtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767784845; c=relaxed/simple; bh=75OT4VBTXhb4+iZyrygf3VNRp5IxOj3TrpfZYW0VvUw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gR10ck3blVoPJG99lQ2HbCndeoSvTCGyUQmRcpMks29AKLLezZZYyKqFyxuJM4j1ob5ASeTSdCB9H/LB2dp87o45j3P2y/dAbB8sZaUWHWj/E/CcZjg1UN7bYlpdxpQ7C8vwI1hu3bK+icyGPQKz8mhY7s8O+mSk/2N7Z7lDhTk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C7XxdatI; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C7XxdatI" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso9138225e9.1 for ; Wed, 07 Jan 2026 03:20:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767784842; x=1768389642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4AiH+3Np39EevPYd1cmAw7r/LCFkel4dQzhGFB22cXo=; b=C7XxdatIDOuV6pa2O6sDkxj+GU+UWHLjz81vRifU6jD8u+bHFPYjx/VO4d5W7OKepq pMb80RuqZfVz6lahegH+SCsAJFOeacwXDBFieVz6WKpi+TcmYnPmDrs4TJaW+lw21snX PQT9xgneTlI0r8ogO6iZbtvUVeLFtkKjFX/c/hgFEXL3y+wZN+nKRV0Cjf5kUm151Xc5 hTGjJrDV4JrBDubYxo/DTwgez/IvuPGHGKaTlRWEvmfdPDS6vhf0YuVcMQ1UMqDUeZ2b fNtxd8Z6jMo3iQPb8MKnWLXVcoVGwcBPn/dvsLqIQ20fsBAkaLqqm9xIASjgcCAxVTvB f4TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767784842; x=1768389642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4AiH+3Np39EevPYd1cmAw7r/LCFkel4dQzhGFB22cXo=; b=alv10lTRWRaUVp+2vjF6IRv44wTmKCN6I7NRIkpXrLCPme5hZJqhA6aKZVRr5GOose tvw6eVkjxU10c3TPrIKsTCVmdkRQFfYP4X8wmp7WndlldDw/nIPz2zO8QpITivTo2lfB fr63vFK8OE+HPO24W/pZTq+g7biECTdG9QVU59d8eVXNeyAuhW0E4Smr4zZzoqpuUCFd TIJQrhIAc6stnUErsq6HovR2lXUz3oxEeUfy/LowQYQyX2x8uxVuBa1fcpfoZUhS+sf5 nu6D9sVO8xLeJM3I3k7G/E/zl0rERb4JKST+2XU/kmPDOJXdlJD8dqOvmBxf0X/o4HRN z08g== X-Forwarded-Encrypted: i=1; AJvYcCVthupeDrjZxMPH9kcSrIQYxKh8t92MM2fGHV+iamaQpkK6m+q4mmW8EjO9JaEaHoqwFEA1JIdMz9MXKHI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh93IZ/mlByttqn18RFNct0E/N73bSU1BiwYoaQ6ioUmw++UyS j22887FePNv+WcYwa1lbxPPntOYFNUJDoXpIm8TAgraHoKyhqDWyCacR X-Gm-Gg: AY/fxX46T5FIzJR7HWuMUQmsXRt59hsGQDakRrmF3NrMONLHSGZSJ136+M83iBsXFo5 zEvgwAn46aWq/vWURMqQl5g+qlsEbe5L3IqYJvIKlgBibIHEH97dnoftOY5Y2NOao+IMEveYhAH esI84F0AjL828nEGck2wuCjsRS2ZafPGx/GHvNvZ/HGLKBchpQygwadqjnuK99/1/VmlUHLMcew 7q/NuX5fAngLgPRk3XmXGHA7XkKJF9OW/RsIHWKJI4wtKuV9pCWEmThjonvs4HpVJas8bqFkG3s o2a7hx1uItiJijNMOyL4YwGSPNFhCwNZi0LRvChkSEOQdfmzrnalTfj9H4L9r82mRiH9kvXn7+A 6F9NLnFyJ9bcEw5CQNDffjVTo40jRgmKZNIlZGm/1hOvDY7ds9ju0jPzEZi0bH2YdvX7Gn8f1/+ TvHjusex8wheT02bQ4RYJPUlR26wsERV+KUXjJAuc= X-Google-Smtp-Source: AGHT+IHStTre6RcNVG2fgEwYMM9+sR9sGgPpfvxCsnoCn60JW7GI+cQYpyrknTEVIKGw6Or+Txim1w== X-Received: by 2002:a05:6000:310b:b0:431:7a0:dbbb with SMTP id ffacd0b85a97d-432c374ff56mr2883888f8f.33.1767784842231; Wed, 07 Jan 2026 03:20:42 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ede7esm9733210f8f.32.2026.01.07.03.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 03:20:41 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: jikos@kernel.org, bentiss@kernel.org Cc: superm1@kernel.org, benato.denis96@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ionut_n2001@yahoo.com, sunlightlinux@gmail.com Subject: [PATCH 4/4] HID: asus: Implement Fn+F5 fan control key handler Date: Wed, 7 Jan 2026 13:19:50 +0200 Message-ID: <20260107111945.48018-10-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107111945.48018-2-sunlightlinux@gmail.com> References: <10abfaa7-9f5b-494c-8bb5-5da53c087fc4@kernel.org> <20260107111945.48018-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita On Asus ROG laptops, the Fn+F5 key (HID code 0xae) is used to cycle through fan modes. This key press needs to be forwarded to the asus-wmi driver to actually change the fan mode. Add ASUS_FAN_CTRL_KEY_CODE define and implement the handler in asus_raw_event() to send WMI events when this key is pressed. Tested on Asus ROG G14/G15 series laptops. Change-Id: Ic03df877b71e34c421e992a06e5e706d954e7dbf Signed-off-by: Ionut Nechita --- drivers/hid/hid-asus.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 05fa35489258d..d93c8f030b239 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -65,6 +65,9 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad"); #define ASUS_SPURIOUS_CODE_0X8A 0x8a #define ASUS_SPURIOUS_CODE_0X9E 0x9e =20 +/* Special key codes */ +#define ASUS_FAN_CTRL_KEY_CODE 0xae + #define SUPPORT_KBD_BACKLIGHT BIT(0) =20 #define MAX_TOUCH_MAJOR 8 @@ -379,12 +382,21 @@ static int asus_raw_event(struct hid_device *hdev, if (report->id =3D=3D FEATURE_KBD_LED_REPORT_ID1 || report->id =3D=3D FEA= TURE_KBD_LED_REPORT_ID2) return -1; if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) { - /* - * G14 and G15 send these codes on some keypresses with no - * discernable reason for doing so. Filter them out to avoid - * unmapped warning messages. - */ if (report->id =3D=3D FEATURE_KBD_REPORT_ID) { + /* Fn+F5 fan control key, send WMI event to toggle fan mode */ + if (data[1] =3D=3D ASUS_FAN_CTRL_KEY_CODE) { + int ret =3D asus_wmi_send_event(drvdata, ASUS_FAN_CTRL_KEY_CODE); + + if (ret < 0) + hid_warn(hdev, "Failed to trigger fan control event\n"); + return -1; + } + + /* + * G14 and G15 send these codes on some keypresses with no + * discernable reason for doing so. Filter them out to avoid + * unmapped warning messages. + */ if (data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEA || data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEC || data[1] =3D=3D ASUS_SPURIOUS_CODE_0X02 || --=20 2.52.0