From nobody Sun Feb 8 00:49:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A627B2E6CB8 for ; Wed, 7 Jan 2026 08:58:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767776323; cv=none; b=WipBvDzCbCbI0kGH2VpEAS4ifJvRjoP87Ksy0GX69e6wGGzQjfpPiJMhGy3sxuzfarLw4/WofIg6MFvxs+He32R6+iNeTejWuUiiDD1gVTVv1dM8zqt3au4Tszu/QtWGaUBXmNM+LIF0LoUd/FeUxLUCwxbr8Mav2IYU5vrjVa0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767776323; c=relaxed/simple; bh=sjlN4pR9R9fEnwmcTRS4xZJHRowWfmiEakxeNh9KN1o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FfMWEa2Vsy9CQmcXZf0lfDsdEfCykeUKA5K4JwoOe8wugMD3Eg/5umRJvpZW6kXiC6N2b7lgmKD2YFA8LU3OvU2U4MldhGqGTakBccWyhhvShCaLz5rtpi+bx5/r+y5mnk8DVrtpQXKj/lD7NTiMGzzFlRSRGcQwDhfpdc2D9Yc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cGPo3Ny2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Bj2SBxsI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cGPo3Ny2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Bj2SBxsI" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6076tNqd2379157 for ; Wed, 7 Jan 2026 08:58:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=cqkCNcY4K3V+l8wWDpRmocDU4wuSqzLH/Pv 8p+vDVrk=; b=cGPo3Ny2LmHSDLkDwzZ2xkMEe1cSrII1+pJTmMSfIAzmtOKIzNV O4gXpdChMulxUalo3KasBYVwSO9XiAx2k0V1F6LNTEI51NCpAFFCo5C/AP9RRpdX bex0q6WQXUz+kIm8hKt4YdsQgUxs/CitE7fZ4cNmuXt8hOQ5gVjxSVrXKK/sjJOy KN36G8EddNGpSiF05kam47+72zE3nEjl9uDIdell7BsSYMJW53umVWdAbwHWMK/7 mDQZszUY/4p19gB8+dWTJGT5HOy/Z6N23PsLTverWrJqYEjoXCl/gBfn4IAtq2h+ gSx93M/cL8Q0kwGLx88w2W1g98QDY2j10wg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhjn4rcjg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 07 Jan 2026 08:58:40 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee3dfe072dso45632591cf.2 for ; Wed, 07 Jan 2026 00:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767776320; x=1768381120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cqkCNcY4K3V+l8wWDpRmocDU4wuSqzLH/Pv8p+vDVrk=; b=Bj2SBxsIe7xi6AQBoQsDsdrmsY+jeqs1D17Z4Eb+OvSoZklcnGCpmY1cbmXPKQEsI+ uNtZHngxPCoPtvc1vj7ovt0Ms3AQRyQIjSNRvUZ7/G0+BMGyxVW30+sM0bpOfqTZ30pR 1bubEZsYnTcj77/Os7+MCNDzX85bxh9/tipdtC1jVopBqhw2DbFwh/TE+eiVYmwfF4+C oYf7z8ooDDiBJr26jsDGH+CMxclZj8NHDi3D9Exkx8p4GOXTJB70FEGCS3vsKcDDI9cx PmJLDteC5TRo6mIX+fYTFJGjIhGv727QiCpZeU/k7iKQerM8spw+rwrIWjWgi1ZVfnUt gk5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767776320; x=1768381120; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cqkCNcY4K3V+l8wWDpRmocDU4wuSqzLH/Pv8p+vDVrk=; b=lIr/grQ7t4xBWgcan8uL8UnP2rUJ3cVne8cCK663NLXZoYzO1uUnWMPhiu1q57wR6i nqslyOywABc1SHNU7nUY4iAU3uY3K0VVPWM56aD9SCmMxrwYN1lBingIs6lfXxtOcTWF Fh48cozZnCBKyUZzgTQdUszBoCahPz5DPpzAQI1wYIhJoe+wlOYjZP5Tro0jlRV7gbBi G7VhHEtMOCYSuZ3H5Q9GJ/P3vkIFMjMMdOHQpW0aeDTwCOYy1tJqIPNCzqDm2JUaNy/f NpRgHk90o7MCcRbJxWtOihVAomML3q1yw9wqtc8xeLGPvUMTMriRGr5UkHeMAc7rEagN taEw== X-Forwarded-Encrypted: i=1; AJvYcCUvFFWG9R6pNatr2PmHc6TP8fW6b2a3lH1f8ii/plcAdAfxQyvOeqFYYJAh7N3BsW6Si6sBkmz2+xnVX3c=@vger.kernel.org X-Gm-Message-State: AOJu0YwjfzjQGg3Nk1+D/yuJ+d8kRs+46S7PUXqPjRnSCFIblenWMPGi rnChoQ22mshu0VWohuXSt4qxAoK+QwH2aIjeMQa+uzcaeQH+CrvzScyQRbrakwiiA4aqJRQ5V/L xQ2uv/TxEGja0OC3bxUZxxZWZWTmvIgueyMsB3TEct+7gicCQh21O+l+ZPz1UPPyGPv8= X-Gm-Gg: AY/fxX5TfY8jRlwDwyoAD2uZnl3/H0Z2qNI+N/P+ozQ1bTtFGe9ptfVHpuc4KLAjrdG vuZ9Bmg9jLMfsBWXW0byLsrM0ddWodgxRUf/TKvHxS8QnnSjkAnt3AIUe76DGH7FABgmoyPhhBY /FYsrH1VIsljx2t+FfEF0ia9JeZh8z78FO2RmAcRJ6Q15tYXF3OAHPQebAT2U2CHVJE7ELz9qRA ExLoOqwIdYFLsF5KhtJMl+5xirYZcrgIBrxgAvwD2I7k1s1LKLybb8/myCUQzcEdbKF68cWJ+JP 6JDSMWZvRO6XYcqLC0DtP67xS68IdnELxf3lGPSlc4if1J8twr7wOJtrpKwHR4T55VIIRcvF8D8 13wMrvLFlRUqQnreNYWPequv7KdPVuKCiU+is6A== X-Received: by 2002:a05:622a:15d0:b0:4ee:1c81:b1d5 with SMTP id d75a77b69052e-4ffb4a3e880mr21245211cf.46.1767776319770; Wed, 07 Jan 2026 00:58:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IF96OGcUtEOM4Psc8sgo9R3lRhIlXlER2V5kmLltVS+fsOjqHZzhW6w2qIoFsaCy9urNg/bvg== X-Received: by 2002:a05:622a:15d0:b0:4ee:1c81:b1d5 with SMTP id d75a77b69052e-4ffb4a3e880mr21245071cf.46.1767776319269; Wed, 07 Jan 2026 00:58:39 -0800 (PST) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:b90b:ec1:e402:4249]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e19bfsm9145792f8f.18.2026.01.07.00.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 00:58:38 -0800 (PST) From: Bartosz Golaszewski To: Jonas Jelonek , Linus Walleij , Bartosz Golaszewski , Thomas Richard Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Dan Carpenter Subject: [PATCH] gpio: line-mux: remove bits already handled by GPIO core Date: Wed, 7 Jan 2026 09:58:33 +0100 Message-ID: <20260107085833.17338-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=LJhrgZW9 c=1 sm=1 tr=0 ts=695e2040 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=VzeXDgSa-F83hufpAqsA:9 a=uxP6HrT_eTzRwkO_Te1X:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA3MDA3MiBTYWx0ZWRfXzdHl7kKZgmeu ouXjQ7GTvzc4iTOvpADRRCLm6U1cITL1fGOsJ+yoR/Vsnio+y/WGjwls7U8J2ulTgv9BfCskYIA 6o0BU7FBcX5oh6nzxlHz3qcwsdBjw1SXsgxR0efZZgISU3jkDM0xjJ21esWoVscXcqz+tDfxIgi Bfl90t674lNlzJw5kgK3oFCjmvHgVSThtUpGlwd/DWqZSQcZmrjcR9qkeG3KW9sfOKIJbCuM0Ru cKdecNGTaDJbk23W9EibBdNuyYX5fWQ3NmhTaPRm7D0l+dvSva++kRCVDa3aBNUmVwtpYwPwe5X 9zC42+Pqkd91l+Atoam3tI6XZoaDYAAL7CTuwN3Xrqp6ERAtMe4RJqVK6b+7Iochy4qS5WWwQIL GSSCYzyp9z9atRTczjdxyZF+9Gjtcie2P2khMr+T/dGEY1R+xOy/j6iY6W914+FJKK76y01DydZ dTTlx069kIHAhOPRTDQ== X-Proofpoint-GUID: qHtO5xaBMfggeLomkJHGy9X7VbbP3Z-N X-Proofpoint-ORIG-GUID: qHtO5xaBMfggeLomkJHGy9X7VbbP3Z-N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_03,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601070072 Content-Type: text/plain; charset="utf-8" GPIO core already handles checking the offset against the number of GPIOs as well as missing any of the GPIO chip callbacks. Remove the unnecessary bits. Also, the offset check was off-by-one as reported by Dan. Fixes: 2b03d9a40cd1 ("gpio: add gpio-line-mux driver") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aV4b6GAGz1zyf8Xy@stanley.mountain/ Signed-off-by: Bartosz Golaszewski Reviewed-by: Jonas Jelonek Tested-by: Jonas Jelonek --- drivers/gpio/gpio-line-mux.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpio/gpio-line-mux.c b/drivers/gpio/gpio-line-mux.c index a4f384306218..62548fbd3ca0 100644 --- a/drivers/gpio/gpio-line-mux.c +++ b/drivers/gpio/gpio-line-mux.c @@ -29,9 +29,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsig= ned int offset) struct gpio_lmux *glm =3D gpiochip_get_data(gc); int ret; =20 - if (offset > gc->ngpio) - return -EINVAL; - ret =3D mux_control_select_delay(glm->mux, glm->gpio_mux_states[offset], MUX_SELECT_DELAY_US); if (ret < 0) @@ -42,12 +39,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsi= gned int offset) return ret; } =20 -static int gpio_lmux_gpio_set(struct gpio_chip *gc, unsigned int offset, - int value) -{ - return -EOPNOTSUPP; -} - static int gpio_lmux_gpio_get_direction(struct gpio_chip *gc, unsigned int offset) { @@ -80,7 +71,6 @@ static int gpio_lmux_probe(struct platform_device *pdev) glm->gc.parent =3D dev; =20 glm->gc.get =3D gpio_lmux_gpio_get; - glm->gc.set =3D gpio_lmux_gpio_set; glm->gc.get_direction =3D gpio_lmux_gpio_get_direction; =20 glm->mux =3D devm_mux_control_get(dev, NULL); --=20 2.47.3