From nobody Sat Feb 7 23:23:34 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7019427C866 for ; Wed, 7 Jan 2026 08:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767775339; cv=none; b=K/Le0uWi80xYbnQGNO0Gsqs5cKv5dkc2D43AFCPgsZcgnOAN9BwPlpWEQ99QYijCw3+K0hwF/q30OD253p2nZuK5z/Udrrvd/iG5Cp5XXcMJDm9NwnrlEWykjY7ezjyxXlb1n36RsoFkknHxZlrIrinWMmitjuWgZxttJQJqKnQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767775339; c=relaxed/simple; bh=klJtv0skWj5s1KSDKEqNzbwBl5YvfN22u23GjjY4QUo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=k/j/wVJe9+x1cpImATDKeecDEFGI169cI9i5JmSJVsEGF6xtj7KS0GQrHa25CkOe0xichSu4dmzHowlm3Dg4gAsRzvW8j0/TfheXAcAm/aUQB6RjqSd7JzKxAZtwAjgP9/weXdkGliXV40JjY8Ma03oC4ceN3r1I61LQ/FyC2sU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ImVVA0wv; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ImVVA0wv" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-34c213f7690so1306609a91.2 for ; Wed, 07 Jan 2026 00:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767775338; x=1768380138; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kq4DgEEPcGBcWcgZluwbIC/FOn5tUqMqd4zV497dWo8=; b=ImVVA0wv+uou42SVoQeFbLPXABQEOeVtCgQNjizvAcI4hObfYoPrpVaKwU2eOSLdjF BoYIxJsNjkepoknbfp77FmnOGseqiZF1rpJJ8AB7WcxgaIYu+ZriCb2oDyz8ae0qJYZe bVTXbM8dtHIGROi8GLIdSW+gfpI/gj2Uuo8Wq6wPDUxEWUuHvT/1xOD2ObE3j5wZh595 br/U6TuFnza5k3Uj8mB/uPLg2GjaC5om8vxjez7DnGjDmry+1xoAEPIpKeR6+9uY5wQJ m5fKqg/+Q9ewwd0O6rjReIqP8n8hpOl2siSSLlRxIahHi19QT/QLd7wuLxparfMTeOiX bjOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767775338; x=1768380138; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kq4DgEEPcGBcWcgZluwbIC/FOn5tUqMqd4zV497dWo8=; b=uYqP7CRpWydBvuGS/waNu32bNjHtxyBCC5gOvmH3JOzX0AXmplbtiY3mVzKLloWeTQ oqK3txsOufvcJl3vl7kzrt68nIq8dEMqRKJU0IIGrLPVtr/4hdlXHnFpg/slVDdvej39 hFjzEKfhntVbynoiph5NYl19XBSe9rEHcL3d6RIh3ux8qY33kYW8cblLfPdUroyMnNW8 Cth2hO2PG/j0X9kXYau16Lw2gIBTTzWJ4ImznPVVYbJQZ+3j6LeIKIlnjAUvSsbQzKcD NfL/4TxlXzbyNYspAXhF9UJ0eFrufIIAbX/yNxOkpOxDejz1JDBnZYGcfToOcSpvc9hP tfmw== X-Forwarded-Encrypted: i=1; AJvYcCV8VfncJzv4F6M0EyGNztO4lYJVJsTINTLXAKafJnXEJ4OUpFshONFDlDJNdgdlxS3w11V9aLqMqb1mgD0=@vger.kernel.org X-Gm-Message-State: AOJu0YzN1BGzUfuee0UjQKzU7s/2nwS19EzPlsJMHepDv7524IzUY9gN ByUotLxb9ldvnqxLHJSD6qb3Er/Npm8yzovSQ+oVgsqtLw83fUEWcpHN X-Gm-Gg: AY/fxX77m4H/wM7+3ftyP5aj5H5nTh6OSt882YJE+ePabyvX7DhkBwM0fotc00Hkudc nYKmaDJ5Ir3SySQRIApgUrI/xuU6A9tbnhWa/jLVFfRT9ZRXU44Ha67mS4odduavsEgWIfBHFNa 458WB34+NB5tZdMjoFsdHEL9uIgSCJ/4TeqyIVix/qzoZT1/+kjLUYa+jn7DBohXvJHRtADDBhi mM7vSB+jkBRJpKs+fIXeKG5mhyYAzUhPaNDpFcmMRnYlwXvEGmknMJlqF6cN6pmC9md1FoOT3rf qZ46eUAEwYbatf3o2w/LwOsSSwiUABh68e81CZnxepkmaIV3FXBQOd5op3bEvOxIPzL51AL8qpn 8LMXjV8SyYm8yzVaVRnCO+j5DxygqWFrZ2ouunpT8yHJdSL4n5EyMue5rh5IXnxcJztMak50= X-Google-Smtp-Source: AGHT+IHliq9/BKbXKFS8jUH9l0mp8MZOWjAiCglIwf0kezPhz5HU7s7XfPwPafxi8/Ixh313yiC2fQ== X-Received: by 2002:a17:90b:3149:b0:340:d511:e164 with SMTP id 98e67ed59e1d1-34f68c0228amr1591307a91.19.1767775337710; Wed, 07 Jan 2026 00:42:17 -0800 (PST) Received: from oslab.. ([2402:f000:4:1006:809:0:a77:18ea]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5f8afba8sm4323876a91.13.2026.01.07.00.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 00:42:17 -0800 (PST) From: Tuo Li To: stf_xl@wp.pl Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tuo Li Subject: [PATCH v2] wifi: iwlegacy: 3945-rs: fix possible null-pointer dereferences in il3945_rs_get_rate() Date: Wed, 7 Jan 2026 16:41:49 +0800 Message-ID: <20260107084149.173289-1-islituo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In this function, il_sta is assigned to rs_sta, and rs_sta is dereferenced at several points. If il_sta is NULL, this can lead to null-pointer dereferences. To fix this issue, add an early check for il_sta and return if it is NULL, consistent with the handling in il3945_rs_tx_status(). Besides, if the STA il data is uninitialized, return early instead of setting il_sta to NULL, consistent with the handling in il3945_rs_tx_status(). Signed-off-by: Tuo Li Acked-by: Stanislaw Gruszka --- v2: * Return early for uninitialized STA il data and align D_RATE messages with il3945_rs_tx_status(). Add a wifi: prefix to the patch title. Thanks to Stanislaw Gruszka for the helpful advice. --- drivers/net/wireless/intel/iwlegacy/3945-rs.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/3945-rs.c b/drivers/net/wi= reless/intel/iwlegacy/3945-rs.c index 1826c37c090c..c509c89bba00 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-rs.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-rs.c @@ -626,10 +626,15 @@ il3945_rs_get_rate(void *il_r, struct ieee80211_sta *= sta, void *il_sta, =20 D_RATE("enter\n"); =20 + if (!il_sta) { + D_RATE("leave: No STA il data to update!\n"); + return; + } + /* Treat uninitialized rate scaling data same as non-existing. */ - if (rs_sta && !rs_sta->il) { - D_RATE("Rate scaling information not initialized yet.\n"); - il_sta =3D NULL; + if (!rs_sta->il) { + D_RATE("leave: STA il data uninitialized!\n"); + return; } =20 rate_mask =3D sta->deflink.supp_rates[sband->band]; --=20 2.43.0