From nobody Sat Feb 7 23:23:28 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8F56202C5C for ; Wed, 7 Jan 2026 07:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767769821; cv=none; b=hWFJ+a0xOnuRs3gNiWsUkOiz+WH4vOo4Io1ITpre3GDKR3y7HcFPaDV4ig9kFgepT/15a2zc7PG4b+WQiFojakiagbBP4s/RGQT7xkaip5HpJ6ztDCn4y9hKErceHFYKkR5FZxHOJC4kaxJlZGKZ6y6IJEFwQVsKe0ThquYRISg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767769821; c=relaxed/simple; bh=LU2Voa03VkzUwZX9vOFZxVmW18w/dzJM2emLQZVtjvk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Bez8YjRP/l0U1tt4Eow3QB+e27N7cr+D39JmCwKFvMD2Gv5EkiDGDod9zFEqILEkc1aRKhlVKAlmYzkZSQkIyqGon9oZqZKde/BkFeI2yXbgF7Wv8PFFme65a2Jarn7T1DL4Xtcj7+HondhTTff1Wye1+rTAw7/0IRRjOoictJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AJZnQrn9; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AJZnQrn9" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7bc248dc16aso1287448b3a.0 for ; Tue, 06 Jan 2026 23:10:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767769819; x=1768374619; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UY8e66H6OsSyRkR5Mv0ekoBF1txUXmREvLtVHZOR7r8=; b=AJZnQrn9pbfTOiJPNPMz238oPoDaoF21fTfDknpc7dH5cdlbxXISxQhtX9Ux4Czz8I X3VSAQGQEU1jKNIoyhlwqAGEuoNWqRQmKLvMkgGsoebFcK/oiglnk1X/+AiAMONK78X8 D9gAXvUifYe9RNxsHSoKO1Nlz8BrOrPVpcDjAXs6+mteVT9FtxYEyjfzXQstKTWVsfN6 IZpQCZYvBwRJf65iPR1aInTJyBY/eVZ32avRg3HZFDMUqTLBm1g+RXb4w/RpZIWAnw5t jCFkz4xR8hW3h1lxjBXW94ysmnjJf/FT1azVRolKoN5L5/HBlP6Oa1osMUzY6hR1OWk+ ESxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767769819; x=1768374619; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UY8e66H6OsSyRkR5Mv0ekoBF1txUXmREvLtVHZOR7r8=; b=YEnfF4+pJnhKDD048v2zLeXig6uL1T5Y6Z7y3IsrttU10xcdZAmzajixRFZ6+cKEv7 PVVYXriWMXA7tfAdWCwAVnXR8kmJsZtDRKMecRce41hLkrVDK1ghPqL+KIOlw97rkg88 vbTCGLiuXjsIpiDO92k7Ly+eowMaL8Vl2P4WaLgoHV3QDpwKHlhtseGor4yiSHX/1+cI XT3W4qtlnTgWkgbzXx6+ERL7PYwpBApHTijw1pT2t8Srppv9zHyU0fpevTHm+SJt1FyO BfBWXwjREaCPP0OdXOum46ubIHm7EWCsry8CwXc1nyQiB9tRzFtlpxbRhpXRYu7Yzim9 AuPA== X-Forwarded-Encrypted: i=1; AJvYcCU/uY7nlwcLRjDzr8k5rnBGlXTX2cH3hOjgNt0bFlq61zvVkRjO1hPLhXMH8CkMWMeBTEqjt7/1aGP+sfE=@vger.kernel.org X-Gm-Message-State: AOJu0YzQag2JN3LUlW0JbLkXimnN3AYeQi3QKI0GPt6bwI9hwnqsUKtT hOpq9Z8jqArWa1ym+tmnZ0qDRSwLWtP0ZN5avABHYxZUk7rIKCW1WABk X-Gm-Gg: AY/fxX4Xfv6pslvQgw3zAfrEdo4KeyVQySM4vB0hdKJjVfJ3rLtqCxHLWKcQDC3qmZj HVMttAZ/KzUxa1h5nK4SJ4jW4iR4C6zDweuWxRfP9571xuQRsrU7x9r18JvE/h8RY6kBD58COlV QJLkihx8ESXmngpwdyrfd8dSt84wxs/qSiYkSv3VENT59+vsVyGnLt9boi93/9OA8LNaWBqQnOG yjf985Op8ozeG5uA0JCSxxDqPStFENN5YjFnaSXieVrk0dsiz+Rk/mK9iAoU7f/T6EOxwYIel6r WtXn13qWADLAYhT943Q+1K53u9cIbv30GHy7hhpPw4UWqhu/930vFH8Kqjlnn5H5uglutFhN+kg gmcLooLKALLIlkuAfMtrgs1DqhsNq91xAelgV5ZawTgZBDVDp1sdwUZxko6hoE1gSMPZ9fvc= X-Google-Smtp-Source: AGHT+IG5ItTnNq4tILfoyom2Ei5YIEcdCIqNrLivJ5YAUKkolU35Bm2FigETroRO01as2j1PQQKrEw== X-Received: by 2002:a05:6300:210c:b0:342:1265:158f with SMTP id adf61e73a8af0-3898f99b23bmr1376081637.51.1767769819069; Tue, 06 Jan 2026 23:10:19 -0800 (PST) Received: from oslab.. ([2402:f000:4:1006:809:0:a77:18ea]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c52f8952sm3973858b3a.39.2026.01.06.23.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 23:10:18 -0800 (PST) From: Tuo Li To: stf_xl@wp.pl Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tuo Li Subject: [PATCH] iwlegacy: 3945-rs: fix possible null-pointer dereferences in il3945_rs_get_rate() Date: Wed, 7 Jan 2026 15:10:01 +0800 Message-ID: <20260107071001.172132-1-islituo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In this function, il_sta is assigned to rs_sta, and rs_sta is dereferenced at several points. If il_sta is NULL, this can lead to null-pointer dereferences. To fix this issue, add an early check for il_sta and return if it is NULL, consistent with the handling in il3945_rs_tx_status(). Signed-off-by: Tuo Li --- drivers/net/wireless/intel/iwlegacy/3945-rs.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlegacy/3945-rs.c b/drivers/net/wi= reless/intel/iwlegacy/3945-rs.c index 1826c37c090c..c13268093a6e 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-rs.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-rs.c @@ -626,8 +626,13 @@ il3945_rs_get_rate(void *il_r, struct ieee80211_sta *s= ta, void *il_sta, =20 D_RATE("enter\n"); =20 + if (!il_sta) { + D_RATE("leave: No STA il data available!\n"); + return; + } + /* Treat uninitialized rate scaling data same as non-existing. */ - if (rs_sta && !rs_sta->il) { + if (!rs_sta->il) { D_RATE("Rate scaling information not initialized yet.\n"); il_sta =3D NULL; } --=20 2.43.0