From nobody Sun Feb 8 04:11:26 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1A4625D53C for ; Wed, 7 Jan 2026 04:43:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767760997; cv=none; b=KpH2MfnicPpJKoBvxbPWA0GqU+9by+UgZvNzmz4jP1zmtqBbObnAYHXNTn2xAekahN02RE0LH7IwF7bDPWAjXWaiDrc8Zh7RFD9n6hJJVlZ4s2hE9eBU3H9fj6nFSInZSoj85CpTbPoe5nc1EcKhcXcQGZkLo5foN62nvZzyxBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767760997; c=relaxed/simple; bh=MkQ4XoQfjzxb5Bd22BM0zqSZxNNCZ/iSlC3xOfhPAgw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uuI4/uBRXxuN9kDFMHV2Vom/Bw+6a+pms2jdZNWk1KtYVfXb9A2FFzisKSvDmWS3ZWO7FhY6itPlniTK5qmUxtPt8O28jkQm/Fv5oUJNSmpKsS5wUYXrksFSv8I5Ze1XQ2UTt057dzhGcXtUBwPfcbK+6CqzyneAv3f6nxJtsh4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JG7zYWX/; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JG7zYWX/" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a0834769f0so15699625ad.2 for ; Tue, 06 Jan 2026 20:43:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767760995; x=1768365795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=thb/F5AmFMs9ckn4s6Vf7Io+bFyVo1RiT6S4i8FpYAM=; b=JG7zYWX/FjhL7HpVb4rFz2BAlgK+eaKtkHRlqawbqC7OpGnRCJY8rohzUlw0ld4bfS c7nnNYT/XygubUATnfbuEHozZrXIoqn/mWygovd/72udEh78xrlp3PQN79a1X+BbeC25 4ySGRZw8TjVq7InWZhEKZef6fBFlQQnwj0tMsXFlww/VnoQR8bkJwCpynAQqaf+oLL1a ua3z7H4IEfcyb/gq2vccH7/RlI4+q8ZMqVED1dH/afSH5BmdALHq1n1LTMIuI/hjtP7D fFycLaHbnvVWJIOSgc0LY/t+3Dnb8EMkL16AnQCTQ2WAGNEG8U7Vhh/2iiMI7Xy+tjTR xlSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767760995; x=1768365795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=thb/F5AmFMs9ckn4s6Vf7Io+bFyVo1RiT6S4i8FpYAM=; b=St4i3afKpLBfb8N1dPh2i1hDqu53UW+laQtnACGeVIoAMCtrLuW7bSjS7fThX16QSZ 6vEYpxJ8XcDY+TMqWEkN9DDsRXc9zhaIa26YhBDdIjZBp9TdrC+oJLqg+c1/msK/KED2 6WfbqqVgg0ixUjZuhJyGZbeFuM+G+d1675no0p+lwjRJzSdfKOHatBaQ4CWmlSaLKMYH B2xtt1CMHjNFiGD9KGjf2zvlVy3k7/stVVjaA3RayiCHzr9JnJtkM+qIvl5nLTb58AUh aDO+ZQOKC43QWZF/AE6wJkF/ssqB/5ogFL1fWuWhjNnENyINiksMUtXuZURKRxFQTxtZ fUrA== X-Gm-Message-State: AOJu0YwpjwJNdEInslGaPAVj5cYkqWjPxgAWocUrMksgdN6wbkyRAABS sLtKdN6nGkpfgLZZ8nA70YYICEi+xALJ+hk+RGVPNzErNs/+FZvQWs6c X-Gm-Gg: AY/fxX7iyndLlKs0Q21aNP7riYIPdYrgS0KWW8HBJnrcuVIEaGeE8aJncAqPqfiJke/ PzG30fsRgjVwfFsdHHQeA5d3yoBJblqTiMEHcHGXumUj2cy8syQ0pYt582MgTE+Q5XyPJic1L4q 0ysr/j7fbbLFmYNd4ChXArD4Qu/Gy/sBybY7xeg4NnVj90oXEipAtIkp0gZ4pSKFOAfdctAp3oW 6kF8/02xpuwQs9O5hBmCqLnmmLAGqLWXrhaQaCWt3w5qfq05MCiQ3ETzsGFLsktU84f8hwVBOs3 2W45mxKdb2e8YeVLSHxGCy3uVcDGxAwvB/TClVUJAzAE7oz+kwGxqp8VWhBDkrKGpV4WBjvNU4Y oRzmVt1PKBORFWkVG3DzgEZKoXMPx0iXpqQEFb98dLctytkL0lzavdS4s2+DqGSbit5ujYCpo2c JFWuv1BwuN60xYVefEVZI8vjif5x1y8RVX2P60X61eUwE= X-Google-Smtp-Source: AGHT+IHEaO2WdOiPYRPaVMlPLug2wHz5JWNqR4SeeEsDG6lB5tEtYaBOclypPoot3PX+4+bsXooZ1w== X-Received: by 2002:a17:902:ce92:b0:2a0:d63c:784d with SMTP id d9443c01a7336-2a3ee4a7dccmr11794585ad.40.1767760995098; Tue, 06 Jan 2026 20:43:15 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:d1c8:9d76:637a:6957]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c39ef2sm36866225ad.14.2026.01.06.20.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 20:43:14 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v4 1/4] fb: Add dev_of_fbinfo() helper for optional sysfs support Date: Tue, 6 Jan 2026 20:42:54 -0800 Message-ID: <20260107044258.528624-2-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107044258.528624-1-chintanlike@gmail.com> References: <20260107044258.528624-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add dev_of_fbinfo() to return the framebuffer struct device when CONFIG_FB_DEVICE is enabled, or NULL otherwise. This allows fbdev drivers to use sysfs interfaces via runtime checks instead of CONFIG_FB_DEVICE ifdefs, keeping the code clean while remaining fully buildable. Suggested-by: Helge Deller Reviewed-by: Helge Deller Reviewed-by: Andy Shevchenko Signed-off-by: Chintan Patel Reviewed-by: Thomas Zimmermann --- include/linux/fb.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/linux/fb.h b/include/linux/fb.h index 05cc251035da..dad3fb61a06a 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -628,6 +628,15 @@ static inline void unlock_fb_info(struct fb_info *info) mutex_unlock(&info->lock); } =20 +static inline struct device *dev_of_fbinfo(const struct fb_info *info) +{ +#ifdef CONFIG_FB_DEVICE + return info->dev; +#else + return NULL; +#endif +} + static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 s_pitch, u32 height) { --=20 2.43.0 From nobody Sun Feb 8 04:11:26 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2DC26E6E8 for ; Wed, 7 Jan 2026 04:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767760999; cv=none; b=a4YeVkrNYk11Ck+wOIvAULVd1UkXbu+lubSpjsjbY3bhj/cB1NVIEavULLa1ofdZmE/Knlg5UPbA3NCcX7BoUnP+CzWSxGEypyaUIe6m2jTNpeh/qQGDTZG2XZEU+U9kehGO/uo1bpQpt2Bi891MBhLdy0ysyMWQXzUpXFdW084= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767760999; c=relaxed/simple; bh=FnV0IJmLlwk0Yk8Amd2W/sf6pDwZoG+c8cE9oXjsy6E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GNdKyef+j1jlmq6Bcv9++I8v5X6d/HgjfsbmN+NN5SaegEcnmzL/9yDBCNXQDtAo1Wok0fm9yswiJA3gIJOIT80YwEh0IrFcDlFArfpppvqTunhUatDnCqgELXBNB92yt8mLEAVrurkVD+Uo0YOrNK1XmS32HdplhCffUC94sNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OsRk2Atz; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OsRk2Atz" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c2dc870e194so1017326a12.2 for ; Tue, 06 Jan 2026 20:43:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767760997; x=1768365797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NLWOELcEjrI2iHJxLfRXTvBZahch6VAgebKRz7irVnw=; b=OsRk2AtzqxcSndp5aSNLRXCQSAd33VenZRHISibKT3i2mt1kRTM6JYnUq2/X0zamm+ SpCL5X5koCLvjjK9WFwvWxmqVJQ9Ct26MLdS1A+OYWm3gT1bECSAflMZjhhIkRvKQ0fx q1r6DSkPyY6/c0xflLi2chwaIwJzxnDwo+v3WyIZ1oc/E77Tp1vY9zEbXoEfbQ1SEX49 i27/VdIfdSD0j1ohtrQN9UhcuSWTW0HS0qKXjc8VBM7KLOLYV1uHoxzGYs8Dm3dsGXDW 6Jmeppl6rQT+veyHQvH76rLXmZCNfXA16KwpnmPkcwItFyjsVW7J9UOC9CDm8aixNuN9 mEOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767760997; x=1768365797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NLWOELcEjrI2iHJxLfRXTvBZahch6VAgebKRz7irVnw=; b=jeVbm1togExMMLWeN0oWHgzvLEHGvOrABwzY+ZZvfqoWbrVCYkPRWHWhi4T/ZKcAmc Ofc/ZEDE0o1TrNvcs3S00APSs6ZbNBIiaf6xh0QC68vRIg1Nz+mUYxFJSn7oF0PV+HhY b1JK0dc3bygFPS5PAxj7hFzYZpMOcpyXfW/sTwrvZrD4wpsPdA3//nBdIS1SycqAJchC BfZUqAu7clbPJRdVJmxB1OICHrwYz9rhdiBQ7eV4JoKkzXwP3kpc8Rsr1luMcdliN3VV NaVAZLgSGgJ9qa4wl88ZGcQbaU4GlDb7OG5QC1PpYnEE/WvLNMOWTIpTJkm7aGSBfLmU 697A== X-Gm-Message-State: AOJu0YxsZGm8GNx0KB63S8sH5yri4XwZmrsjs7wxzNT2kmIldrCpfWFH Y9XNjcvi9FKBBy1Q43u+sAoXnJI2z5b0W0/IZhuZFqK9CKml+9c8ItnJ X-Gm-Gg: AY/fxX4IoaHB0R8T3ZPIrNQ4xgDEWnsbqYAtiuiliHtcmHo4vah3ig41CtBft9bzw9O Gu6+bBjP4AUFcAvxHYDG/dq8riO85jMythXirzyh3c+vq0No+cKljNLmBhCLgCknsgAWKaRnuD4 M8/fXjeO+cxovn8hoEV4zbebS85BaGbt6bYsfEzC1U0Eg+UcQNPRHMz1zSTnBMpijvfgWPl8vGG w725bldiQjbIf+R22ZSsi7sKUKm8DdBG4dwBFnTfEEYWdx/gdign3sxDhL5VcMIsgrOKIyxiBbG 4Oa1LagmOXabfOkLeurhEMKGuG5qlhzEPb+JA7WezN2tnYoBIiOw43X9CEDgAAf1uWI8A0CBMhd /OAIhNG8EIzYFRZ5kSh4ItKC/D8ngieNNt9ZZ7sizUOTipxHr6phPE7Uw+7UZTtZJw4Z8jie9wQ kw8hD5MHr2cJBh52XjDN3IGihoc35EHvS+Ks9xW4kg/p0thJTfSUu2Mg== X-Google-Smtp-Source: AGHT+IEF2tiwIdEjUKJoleA4BSAnBVhOgZtlhWyisn+mWM00+oMK/a966pLLKiRVpDOA/U4Wkrlj0A== X-Received: by 2002:a05:6a21:32a0:b0:366:2677:4b38 with SMTP id adf61e73a8af0-3898f8f5458mr1134448637.8.1767760997324; Tue, 06 Jan 2026 20:43:17 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:d1c8:9d76:637a:6957]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c39ef2sm36866225ad.14.2026.01.06.20.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 20:43:17 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v4 2/4] staging: fbtft: Make FB_DEVICE dependency optional Date: Tue, 6 Jan 2026 20:42:55 -0800 Message-ID: <20260107044258.528624-3-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107044258.528624-1-chintanlike@gmail.com> References: <20260107044258.528624-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fbtft provides sysfs interfaces for debugging and gamma configuration, but these are not required for the core driver. Drop the hard dependency on CONFIG_FB_DEVICE and make sysfs support optional by using dev_of_fbinfo() at runtime. When FB_DEVICE is disabled, sysfs operations are skipped while the code remains buildable and type-checked. Suggested-by: Thomas Zimmermann Suggested-by: Helge Deller Reviewed-by: Helge Deller Signed-off-by: Chintan Patel Reviewed-by: Andy Shevchenko Reviewed-by: Thomas Zimmermann --- drivers/staging/fbtft/Kconfig | 5 ++++- drivers/staging/fbtft/fbtft-sysfs.c | 20 ++++++++++++++++---- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconfig index c2655768209a..578412a2f379 100644 --- a/drivers/staging/fbtft/Kconfig +++ b/drivers/staging/fbtft/Kconfig @@ -2,11 +2,14 @@ menuconfig FB_TFT tristate "Support for small TFT LCD display modules" depends on FB && SPI - depends on FB_DEVICE depends on BACKLIGHT_CLASS_DEVICE depends on GPIOLIB || COMPILE_TEST select FB_BACKLIGHT select FB_SYSMEM_HELPERS_DEFERRED + help + Support for small TFT LCD display modules over SPI bus. FB_DEVICE + is not required, but if enabled, provides sysfs interface for debugging + and gamma curve configuration. =20 if FB_TFT =20 diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fb= tft-sysfs.c index e45c90a03a90..d05599d80011 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -203,14 +203,26 @@ static struct device_attribute debug_device_attr =3D =20 void fbtft_sysfs_init(struct fbtft_par *par) { - device_create_file(par->info->dev, &debug_device_attr); + struct device *dev; + + dev =3D dev_of_fbinfo(par->info); + if (!dev) + return; + + device_create_file(dev, &debug_device_attr); if (par->gamma.curves && par->fbtftops.set_gamma) - device_create_file(par->info->dev, &gamma_device_attrs[0]); + device_create_file(dev, &gamma_device_attrs[0]); } =20 void fbtft_sysfs_exit(struct fbtft_par *par) { - device_remove_file(par->info->dev, &debug_device_attr); + struct device *dev; + + dev =3D dev_of_fbinfo(par->info); + if (!dev) + return; + + device_remove_file(dev, &debug_device_attr); if (par->gamma.curves && par->fbtftops.set_gamma) - device_remove_file(par->info->dev, &gamma_device_attrs[0]); + device_remove_file(dev, &gamma_device_attrs[0]); } --=20 2.43.0 From nobody Sun Feb 8 04:11:26 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 970C125A2CF for ; Wed, 7 Jan 2026 04:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767761001; cv=none; b=us8GOTqeHDqxMaO3YVqItTNL7e4cFgTCgotZDryQ1NB/pvjzcdodM5fYbSy+sbPg0gdsGSNF7vvRAkKE1CjTGP19cr1LMln4EsclYGuU0KVBRigyrIz69kIA5kGcSeJHs8zyYQTC9d0fkpI4p2J9Chh6IzuMKKmvsjQnT3iF4fc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767761001; c=relaxed/simple; bh=+Fzr6kEopBOBGruOQNRZeskEAAtW+K4Nv+xnTvdpk0Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lkuff7PP8DDJSvLI/8kLzC4adGcN37RKLffH7bHW0yFBZrst+UlkBqZ0/rNcmfCoqtSg0X86vUDJHty7WM4MtBKZuLKIRbcXWWbedbL/2iSn2w1oPMpD1nMlep6k3bZtlweY3kWChJazSFAitCH/bmKXjXgA27Epe7wTumhOxLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d91zWun3; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d91zWun3" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c0224fd2a92so1051599a12.2 for ; Tue, 06 Jan 2026 20:43:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767760999; x=1768365799; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CmNZiMiLRz7C+tpqpi8aiFEIQgPCT214fV1yD6bvzyk=; b=d91zWun33bl4mNjzP495EmDnaUPUtEJAvMFui/KnC02a5zjaqup1O8FFjsb6u4FBkJ PKIo412pF/BZpfTtie5PUq6p0PHNvRR5GD9SkDPy86oEsTa9t/qiscwrUnl22BandhKQ vfbBfxmsYyDLUB5GDJ16lf/4CStn89aL399DO4jX11Bv0wUhatwz3xSPKQi+kiD7LB1+ Jop825fHoOOcIVGbTlEmWt1C1h5A7m1CPfpFFey8zUExmG6++CKm3lHJpm5sTGHQzK39 oVCPAuclW6z/JF6cCznyVBujOXjuQTa+YQH5kAH7h/uRx6OtOti5zFUadxMEi20o1Ojm /T0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767760999; x=1768365799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CmNZiMiLRz7C+tpqpi8aiFEIQgPCT214fV1yD6bvzyk=; b=BLbITT+rv+WtS2Jv+eJ/9uxvcl4uAb8xPeYEUXxavmLtYA+xW7+PXnlF0ApMsT4gam Fymy4dOXEDBni0LqtkjLHXyeGHlBJuN9sSgszyuN8FXLRYQslxrlj9Gg6fbuVovNZ1mT 5w8LBvVpQny6jrUFAUEauoGL0Z48QAPTq3fZgATV68vjRfxgIYvn4Op3QfFHCGdmmo64 Exi4NZu8zg/UHcFIjQica3XnzfVBz42dnmQTmlTkb6/Q0/Wk35wmTgwXlkk92bH8hYhM wzvJM9ur1WQuGcIbTtoGRyZl7XzDPEPyzdFOq/WanG3v9O6vj+ZZ5AawkXXr7smLF5E1 qZXw== X-Gm-Message-State: AOJu0Yw6+2Fuier2XkLYojPM8uQ4X7m5t973atjngPDVWAKivfzN9IdM 7Ic0yQkm40Alc6AlJK8gIO2lu6P1ZldY0SmP2ANRoCR885JVWQM0ZECV X-Gm-Gg: AY/fxX6/KfD4zfWRGvWgUudk6+ugir8ElyjU13iHYtFkfxUCYR2PJ29ezST9s9xbUGY LIFNWWHuIzFfXBozCpKrCF7JYPk1t+x9jPlyyk0t6ejJ0GZcUeOR1qUwhPBWCoPk1F7Py13G9g2 aDOsTBNAJnA0V2lImrvQOychH/2uuFvmePA4xWGkCydHfeafNJmtLtCKrDTJQ0JiQnsHlsNdNhm EnshcnM3HpyyQhHkOJsKSfjzJw/R6QlauMdeufa31lWlAv/U5psA+Eg4OpqdHE0cZ/XgytN58II 26ToZjtP02yrX2nRYI+xHtoF5lTJDdux6P7q3qTNIpedaedJMo1J2tOmYbOBYLDY4UkPXr+Yr/D 6/2GcApzzPa2i24k67xmjPj5uyS+6r591z+d8G6aDqn3rO+mk2Yyz0ZDngq0JDhC+1t5QNv2Lfa nIN4bhJQB6sBIP19qvsAXfYKsuybrIei5VdVYhvlDLq+XWnDMCfdZtGg== X-Google-Smtp-Source: AGHT+IGyLXpHnLdUccdHLbJKV2U55q9FpnJ0qEZouF7Rk2ZDPQCEjkM51aika9hOgCehETQQWJIYhQ== X-Received: by 2002:a05:6a20:918e:b0:34f:b660:770d with SMTP id adf61e73a8af0-3898f9dd14cmr1103698637.55.1767760998777; Tue, 06 Jan 2026 20:43:18 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:d1c8:9d76:637a:6957]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c39ef2sm36866225ad.14.2026.01.06.20.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 20:43:18 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v4 3/4] fbdev: omapfb: Make FB_DEVICE dependency optional Date: Tue, 6 Jan 2026 20:42:56 -0800 Message-ID: <20260107044258.528624-4-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107044258.528624-1-chintanlike@gmail.com> References: <20260107044258.528624-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" omapfb provides several sysfs interfaces for framebuffer configuration and debugging, but these are not required for the core driver. Remove the hard dependency on CONFIG_FB_DEVICE and make sysfs support optional by using dev_of_fbinfo() to obtain the backing device at runtime. When FB_DEVICE is disabled, sysfs operations are skipped while the code still builds and is type-checked. Suggested-by: Helge Deller Signed-off-by: Chintan Patel Reviewed-by: Thomas Zimmermann --- drivers/video/fbdev/omap2/omapfb/Kconfig | 3 ++- .../video/fbdev/omap2/omapfb/omapfb-sysfs.c | 18 ++++++++++++++---- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev= /omap2/omapfb/Kconfig index f4cdf999a080..2d20e79adefc 100644 --- a/drivers/video/fbdev/omap2/omapfb/Kconfig +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig @@ -5,7 +5,6 @@ config OMAP2_VRFB menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB - depends on FB_DEVICE depends on DRM_OMAP =3D n depends on GPIOLIB select FB_OMAP2_DSS @@ -13,6 +12,8 @@ menuconfig FB_OMAP2 select FB_IOMEM_HELPERS help Frame buffer driver for OMAP2+ based boards. + FB_DEVICE is not required, but if enabled, provides sysfs interface + for framebuffer configuration and debugging. =20 if FB_OMAP2 =20 diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c b/drivers/vide= o/fbdev/omap2/omapfb/omapfb-sysfs.c index 831b2c2fbdf9..38a635d38d58 100644 --- a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c @@ -558,10 +558,15 @@ int omapfb_create_sysfs(struct omapfb2_device *fbdev) =20 DBG("create sysfs for fbs\n"); for (i =3D 0; i < fbdev->num_fbs; i++) { + struct device *dev; int t; + + dev =3D dev_of_fbinfo(fbdev->fbs[i]); + if (!dev) + continue; + for (t =3D 0; t < ARRAY_SIZE(omapfb_attrs); t++) { - r =3D device_create_file(fbdev->fbs[i]->dev, - &omapfb_attrs[t]); + r =3D device_create_file(dev, &omapfb_attrs[t]); =20 if (r) { dev_err(fbdev->dev, "failed to create sysfs " @@ -580,9 +585,14 @@ void omapfb_remove_sysfs(struct omapfb2_device *fbdev) =20 DBG("remove sysfs for fbs\n"); for (i =3D 0; i < fbdev->num_fbs; i++) { + struct device *dev; + + dev =3D dev_of_fbinfo(fbdev->fbs[i]); + if (!dev) + continue; + for (t =3D 0; t < ARRAY_SIZE(omapfb_attrs); t++) - device_remove_file(fbdev->fbs[i]->dev, - &omapfb_attrs[t]); + device_remove_file(dev, &omapfb_attrs[t]); } } =20 --=20 2.43.0 From nobody Sun Feb 8 04:11:26 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D2B26F28D for ; Wed, 7 Jan 2026 04:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767761002; cv=none; b=agHsMRXV6fknFHini2rh426aeFujjEQIZ6f53/OGMksYYBOIm3CHxPjHnsV/n97qnqCSL5l20/RE/jtah3IbEdgDucbUCMEeQdPot01NZybel7MkmL2U5FsZ8bn614YWXzxgFEiwHg/s9ZXB1KyTPIGEQXab3dwiRaz8jDQY5EY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767761002; c=relaxed/simple; bh=tRNeZwnYBDiJ5gpYRj3YNtC9pI+I0JQn8tmEq71PS0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g/8x+pFcHl3e78gk5fuCIf6iIJN2oN+R0BBOPHJ242uMGeUzn8FxfMOc3wrpahtm48mhCZiurjpa/mloUt3fyqI+aBtlR5spZTdOjE6BGzkuF+JVUW5DJnpo9na3rGQMBPf8v7Mhv1UnDRXT5DN9RLQFPYL5wMHp+JZWUt8gePk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jvG32x9V; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jvG32x9V" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a09757004cso18195085ad.3 for ; Tue, 06 Jan 2026 20:43:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767761000; x=1768365800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5rLU7DAV9qpUwuBQAOxfbjMQs4IqSMkv9fgfYLMr0Ww=; b=jvG32x9VHN8R+LNmGb8I5yrXn8sT4yGVC6XgnwQifJodOgrbV7CuVUylqWIazH8I/S Qd8WaqzWgUlklP5mDt5vMzGdCBozmCqRF1pjT+IwDWftfMoiKUSyLESGzN0PbyDO1GgG sYtlTac3LeWeTrXXHlSbyS0q2TiKJ4UW/3td1UzaWtfBg3oKmbL1Tsg+/z2Da2EoamDF dX9Wjqz7cdOaktw56xY63un67XyoTjoJfY/c729WjYBJu6VFG5oe3VVDqCWR3QCkDoHS ijCdh8jT2XH3IcRj7XMvLv+wvWz8OcFb6W5PpscLBpHoP14cTfCfb7FIUIU2VBERajeM yymw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767761000; x=1768365800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5rLU7DAV9qpUwuBQAOxfbjMQs4IqSMkv9fgfYLMr0Ww=; b=EXSraK6B0gvvzJ9selZ9EF+ko5vN1evkdJW91kPcIQ/SDNu3y96GsU6RLUyeAaRqsh 2M5NxnJzhlYx7ArtgXw4nMJoykblcW7t8MrC0xHnmOVdDyzrIRhrtsPLXHG9a5RGaNdZ h5DoJ492Mr22u9hT9r8mji0Sib8SPbNDYLHHcF5Rop+GHCkXgTYxP3B8SvSwGmZhdmYK z+u4OAfJvHkt1WlKBjKLubcbbJ+NRAj+QrevAhBOLWHNTeU1K1hkY6ZAc3K1CpbbCLnD m/PHNDC9Bl9w3oCU3dl11ZVdg5PEOPzH1H8Tw44uCR+mguY8+7d79NZQs9mleUJNl3JN /A8w== X-Gm-Message-State: AOJu0YzvIsWFy05oOHf9HihYEMPVIH0MfQOxPC//ti/SpIB07BM6ovvg aFc9ATHm0vUS6L3k3hE2XE8S7s62IxLKv1gRaQ1ksC6iIvIPcxQCZ0Id X-Gm-Gg: AY/fxX5IwVjhq7dDwRQIa3OwawNcZLoZ2Q6dLhz3Jb/lfBSB5efK/ZMDSZh68Jx0Ex9 lNC+PrVxzIldlLBa/gtHujmptbYuT5VPBtHE596gZGY5TL+jdjAfG3/xB78xGSDAGXqysHeW9oT Ws13gjgaTK81OTtK0jaQUAlJvMljk2jOTvGIawNrsm2LktGQ776zNy1FDlIQURlx6d5h37sfx25 kAvTzH5v52U+drOrAMaUKam0PcrpfLN8X4NHTT8l07duaUGWMguQNXxXqePfXCXqZhNRqsISy30 vNB6u5Qs82mtnN8emaOEBwn5TwlhOtfKPWQ/yAMR54sIIpOm7oRzJ29688YtTVJeQojvfPOYTuY Ad3NnO8XxouBL5w2VUDmiEdrIRAeIzssljk7aT18ug785RUAEyJgjLcvXTALJ51BPBn94RdQV4i eILC5u1cIk7+iencrCUWcR/risGxxZtMTiN4BkJc8muyY= X-Google-Smtp-Source: AGHT+IEc8TO2toWTGIaoXuv5rNAydXLamcJRscYf8Qm/aRVC4j2jXnovQzTTCfCrrqFWoia694nIZA== X-Received: by 2002:a17:902:e952:b0:29f:2f40:76c4 with SMTP id d9443c01a7336-2a3ee48ace2mr10688365ad.34.1767761000170; Tue, 06 Jan 2026 20:43:20 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:d1c8:9d76:637a:6957]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c39ef2sm36866225ad.14.2026.01.06.20.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 20:43:19 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v4 4/4] fbdev: sh_mobile_lcdc: Make FB_DEVICE dependency optional Date: Tue, 6 Jan 2026 20:42:57 -0800 Message-ID: <20260107044258.528624-5-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107044258.528624-1-chintanlike@gmail.com> References: <20260107044258.528624-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sh_mobile_lcdc driver exposes overlay configuration via sysfs, but the core driver does not require CONFIG_FB_DEVICE. Make overlay sysfs optional so that the driver can build and operate even when FB_DEVICE is disabled. The kernel naturally ignores the missing attribute group, preserving buildability and type safety. Suggested-by: Helge Deller Signed-off-by: Chintan Patel Reviewed-by: Thomas Zimmermann --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/s= h_mobile_lcdcfb.c index dd950e4ab5ce..5f3a0cd27db3 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -1343,14 +1343,17 @@ static DEVICE_ATTR_RW(overlay_mode); static DEVICE_ATTR_RW(overlay_position); static DEVICE_ATTR_RW(overlay_rop3); =20 -static struct attribute *overlay_sysfs_attrs[] =3D { +static struct attribute *overlay_sysfs_attrs[] __maybe_unused =3D { &dev_attr_overlay_alpha.attr, &dev_attr_overlay_mode.attr, &dev_attr_overlay_position.attr, &dev_attr_overlay_rop3.attr, NULL, }; + +#ifdef CONFIG_FB_DEVICE ATTRIBUTE_GROUPS(overlay_sysfs); +#endif =20 static const struct fb_fix_screeninfo sh_mobile_lcdc_overlay_fix =3D { .id =3D "SH Mobile LCDC", --=20 2.43.0