From nobody Sat Feb 7 17:04:33 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30E83236A73 for ; Wed, 7 Jan 2026 02:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767751850; cv=none; b=rYiZFlDG++nylrsLqqxraqR1o7Y1QojCpwM9do+7agX3OKyqbCXPkat+LSmF8sbQ2e5Gia/g8msS0otQprESphFXixcxZvkE5LNapbcbQ1xagyBC2sG4VItlO7/OjH9R+KHBfNjWa1/Jo9vd8EtHd9dFnwkSCYZ0ZIBQKIJWIGw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767751850; c=relaxed/simple; bh=fMDCKlg9zba/zZb9oTcA9DVRWMpTEuuWrq7zJgxZmAw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lk/e2qmI1bstqgB2eOv3cjzXeoNq/u0dJoJiEOfJ4bkNHdcOEVG35yzdj6jvy8xwSkztPq575WzzR3cA51gtYz/K5e2L/YIiF2t/zKeWllCIFvVLw9IBECnbuEvT7pzARt1YdK1PUXVdKb6GrdeDc+6DUaqtjfgPGqEay5mhYf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SjKmdgdw; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SjKmdgdw" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2a0f3f74587so16518025ad.2 for ; Tue, 06 Jan 2026 18:10:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767751848; x=1768356648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WynyOCb+C0xrwJyO/eUwFrGXGMsmrA2cIlbHyTfpriw=; b=SjKmdgdw7yYe9swIqy/6kWMukMveCz9PfhXTsH0Y3Vagxjmyx7B4KnM8Ju1w0e0076 NO2BGxlvchHZzIz5YqdI+TaMLVJb/VjBRBnUq3paweWGDpr8iiPoQRV6QZSi9d79IftQ WAyIJxkzBakAfNbGSGP3racqPM/DJEz/QfcplJmGuoeTwWKdL/yDOsiM8GIHPI3mYX3+ j7NCkghEU36SVlLWH2NhrAOhmwLiVD7RIIT8eKwRJC0ttAWxPrmEiv6f8UK9jeIZKEzU h/+f3jd9gdDHnuWy+J7ydUL3TzHd0vkm+CkUlRdDXQLj/21di0dXdmlRA8ViSCdz0WFd BV0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767751848; x=1768356648; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WynyOCb+C0xrwJyO/eUwFrGXGMsmrA2cIlbHyTfpriw=; b=gKhzQ4gRhcPriCN1kXWEwnWHctzceNmgcc3A/V07TpoZSiBQCwptJbpWryUc+Id1Wd 6x8sUaWknU+ybok8HEjybL3NnhvVSsp+kVW61NG1lt/p2IdikrFmwakkIMONt7wwc7Rx qdPWe5RYN/6Nf93kbYupu+Aq92XZx9nXXhni+daOQJO/QcxDQh7MdHkYO2eko4Gfgxf6 i9Ln9X/UREI2ybFZI9F4nHg2gZQTgCk8D2QFEt2IxPUM8aGDpRi04nENoxRqTmrYn1O5 LfQ09Em+yP5wVYF27HV9UwpycGlKaRWIicl14wR6K2fzo+XedwzZaTfVRLyiE6DrEFgF LsDw== X-Forwarded-Encrypted: i=1; AJvYcCUSo0+I+zVIiii8Nd4DW3L7doOI48Y6TZC1UBuUO8UFQljNQQb9ZYYFNh6QwkBpWEvoBxhA9kZ6yQdeODo=@vger.kernel.org X-Gm-Message-State: AOJu0YxLuSLFUg9WjACXPwJrlsGn0IDuAUdm7dZWnN+X0wnxOkpJlYhT uD9hWNlvWLteqwXM4lbaWjmh4LJ1m/d7NO0/IhuLP+Ol/TWG5URD87cs X-Gm-Gg: AY/fxX7PVlv8JXbJUSuBvsmNixzm5cG90/s2OX8FgPpbdmw/95R4WXmz2n9NG1NcLf5 KFCsnE0dNGE5FfDh1vVSd0xaNVsBJImc1QKh5cw6RoSmJfnMY+XEvbxMRWD3gcxHskcWX79jJ2y iAMh4FszOq/5cdfc+YcYheLfMmSKWgy5Tyhb4v897c9iPP2eOHMBTUetMCaAR2MylqUilrkRSca hwRpYDZldHdAKry+xU+RABEqNAayM3mHzfFo6DI9AEL2JcqH50eMw85c3XOZmzndfbjD/eHgMwD Ur1l/YwY5tR2tOu2g+JD9HiOJEhbGd73QPQU5TskzwCqBpbiBEXcjpKi6sGSWRy4X6VXh5Uw49G P1heV3zMMbK6tYef1bAnnxaXVAIA/IILegPt/6JBOno0ZfWtAc0jYYPFZyawbJ26g3nQ2fsrCh/ laXAZL3TQdXTlDFKP+aBzwSdOtTuKEWppxyhqD+IgtKjOQkrcadvcjOXazkGKGMHg= X-Google-Smtp-Source: AGHT+IGuqoSFCj02JSWOaDgM8bCQgS+XVd2xgdWjjeB9ZIL1CfWG2thjcMprL4VJkqMCpEF3K/RBKg== X-Received: by 2002:a17:903:3c2d:b0:29d:73cc:c9e8 with SMTP id d9443c01a7336-2a3ee43896bmr9388235ad.2.1767751848468; Tue, 06 Jan 2026 18:10:48 -0800 (PST) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:389d:941b:5f:cbd3:6ba]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc8d81sm33297085ad.81.2026.01.06.18.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 18:10:47 -0800 (PST) From: Deepanshu Kartikey To: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, a.s.protopopov@gmail.com Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+2c29addf92581b410079@syzkaller.appspotmail.com Subject: [PATCH] bpf: Reject BPF_MAP_TYPE_INSN_ARRAY in check_reg_const_str() Date: Wed, 7 Jan 2026 07:40:37 +0530 Message-ID: <20260107021037.289644-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BPF_MAP_TYPE_INSN_ARRAY maps store instruction pointers in their ips array, not string data. The map_direct_value_addr callback for this map type returns the address of the ips array, which is not suitable for use as a constant string argument. When a BPF program passes a pointer to an insn_array map value as ARG_PTR_TO_CONST_STR (e.g., to bpf_snprintf), the verifier's null-termination check in check_reg_const_str() operates on the wrong memory region, and at runtime bpf_bprintf_prepare() can read out of bounds searching for a null terminator. Reject BPF_MAP_TYPE_INSN_ARRAY in check_reg_const_str() since this map type is not designed to hold string data. Reported-by: syzbot+2c29addf92581b410079@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D2c29addf92581b410079 Tested-by: syzbot+2c29addf92581b410079@syzkaller.appspotmail.com Fixes: 493d9e0d6083 ("bpf, x86: add support for indirect jumps") Signed-off-by: Deepanshu Kartikey Acked-by: Anton Protopopov --- kernel/bpf/verifier.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index f0ca69f888fa..3135643d5695 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -9609,6 +9609,11 @@ static int check_reg_const_str(struct bpf_verifier_e= nv *env, if (reg->type !=3D PTR_TO_MAP_VALUE) return -EINVAL; =20 + if (map->map_type =3D=3D BPF_MAP_TYPE_INSN_ARRAY) { + verbose(env, "R%d points to insn_array map which cannot be used as const= string\n", regno); + return -EACCES; + } + if (!bpf_map_is_rdonly(map)) { verbose(env, "R%d does not point to a readonly map'\n", regno); return -EACCES; --=20 2.43.0