From nobody Sat Feb 7 17:54:59 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62DC61D47B4; Wed, 7 Jan 2026 00:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767745336; cv=none; b=BSQCVerZHpWJk815WL9R6rDPtOlUeOhlV6PAapsJnoh+GPK652zkVXqhmZIVWXA+Kqj8tOnC9NQNNhy9E3vBIHoqqxgBFL6ky1T7f5Plsi4JH/ym7iNgexfKTXfpKhdrIkDmUis2KHm0GAjzkdzryZ/5AEHbSamuBA8ZqCBCa9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767745336; c=relaxed/simple; bh=ODz8vQM06hZpoUx5eKexuLW904bBK0VE0zDOrwdA9y8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QL0XMbWyXqcONqVEzwYrSmveRawcsB26K8pfi2iKB0vzixgoqpRaFUiJFP9/TpMlvi0glfinlLzdKeDwCfiIhkT0EzwS1n86ncOPzQSDHAyTF3pSpRxUR9UmSqLuoUuNODQGOx0A2xIuIfYFekcFA52S7OBfJ3UwVuHXQW/mniE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KaIpjcxi; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KaIpjcxi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767745335; x=1799281335; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ODz8vQM06hZpoUx5eKexuLW904bBK0VE0zDOrwdA9y8=; b=KaIpjcxi5Xasgx3L0Q3bRSsrSCit0E/19kgHdEJidg9tR2CcDkJHfv3f dAHioFwLEG/xBfeg2VNwt9Wab4T3wvbMwxUDA+dZarQvuo4v5R4vBO4iP E8uJ7PsBLTM/UTKpIc3j4F4YachuoNoyZqaPB2tMkGG1uAmCz6PbvepdE QSRudQ8n9V3/3yAY4v3iLebiy4KFUHcYyt2tiNabj/+D5NLrUYhR+xBa+ h3HG0HAFFtJ7Ro0n5bQiYxJgwrr8yb9I301BjDHjtUmZOoXvEscR6KqqL vh4Mj3Crdngqmvy4sCz9YvdA/IcpK39TFMb7BOS7Yyx2sD7fdyynXJb2K w==; X-CSE-ConnectionGUID: q2m76mzYSgGqYmw4fo+2wQ== X-CSE-MsgGUID: r8riHyhVTZO4MLofWoYhLQ== X-IronPort-AV: E=McAfee;i="6800,10657,11663"; a="69164111" X-IronPort-AV: E=Sophos;i="6.21,206,1763452800"; d="scan'208";a="69164111" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 16:22:09 -0800 X-CSE-ConnectionGUID: oBG1V4ZQTdGsPP/XPPj7pg== X-CSE-MsgGUID: QdFPWMbtRxOYVL8C6Jajcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,206,1763452800"; d="scan'208";a="206931519" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 16:22:08 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.comn Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH 1/4] platform/x86/intel/vsec: Decouple add/link helpers from PCI Date: Tue, 6 Jan 2026 16:21:48 -0800 Message-ID: <20260107002153.63830-2-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107002153.63830-1-david.e.box@linux.intel.com> References: <20260107002153.63830-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This refactor is preparatory for ACPI-enumerated PMT endpoints. While intel_vsec is bound to PCI today, some helpers are used by code that will also register PMT endpoints from non-PCI (ACPI) paths. Clean up PCI-specific plumbing where it isn=E2=80=99t strictly required and rely on generic struct device where possible. Signed-off-by: David E. Box Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/platform/x86/intel/vsec.c | 13 +++++++++---- drivers/platform/x86/intel/vsec_tpmi.c | 2 +- include/linux/intel_vsec.h | 2 +- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index ecfc7703f201..130577061a51 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -158,18 +158,23 @@ static bool vsec_driver_present(int cap_id) */ static const struct pci_device_id intel_vsec_pci_ids[]; =20 -static int intel_vsec_link_devices(struct pci_dev *pdev, struct device *de= v, +static int intel_vsec_link_devices(struct device *parent, struct device *d= ev, int consumer_id) { const struct vsec_feature_dependency *deps; enum vsec_device_state *state; struct device **suppliers; struct vsec_priv *priv; + struct pci_dev *pdev; int supplier_id; =20 if (!consumer_id) return 0; =20 + if (!dev_is_pci(parent)) + return 0; + + pdev =3D to_pci_dev(parent); if (!pci_match_id(intel_vsec_pci_ids, pdev)) return 0; =20 @@ -204,7 +209,7 @@ static int intel_vsec_link_devices(struct pci_dev *pdev= , struct device *dev, return 0; } =20 -int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent, +int intel_vsec_add_aux(struct device *parent, struct intel_vsec_device *intel_vsec_dev, const char *name) { @@ -252,7 +257,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct dev= ice *parent, if (ret) goto cleanup_aux; =20 - ret =3D intel_vsec_link_devices(pdev, &auxdev->dev, intel_vsec_dev->cap_i= d); + ret =3D intel_vsec_link_devices(parent, &auxdev->dev, intel_vsec_dev->cap= _id); if (ret) goto cleanup_aux; =20 @@ -349,7 +354,7 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, str= uct intel_vsec_header *he * Pass the ownership of intel_vsec_dev and resource within it to * intel_vsec_add_aux() */ - return intel_vsec_add_aux(pdev, parent, no_free_ptr(intel_vsec_dev), + return intel_vsec_add_aux(parent, no_free_ptr(intel_vsec_dev), intel_vsec_name(header->id)); } =20 diff --git a/drivers/platform/x86/intel/vsec_tpmi.c b/drivers/platform/x86/= intel/vsec_tpmi.c index 7748b5557a18..2ccde86c529f 100644 --- a/drivers/platform/x86/intel/vsec_tpmi.c +++ b/drivers/platform/x86/intel/vsec_tpmi.c @@ -655,7 +655,7 @@ static int tpmi_create_device(struct intel_tpmi_info *t= pmi_info, * feature_vsec_dev and res memory are also freed as part of * device deletion. */ - return intel_vsec_add_aux(vsec_dev->pcidev, &vsec_dev->auxdev.dev, + return intel_vsec_add_aux(&vsec_dev->auxdev.dev, feature_vsec_dev, feature_id_name); } =20 diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h index 53f6fe88e369..28c2f5855a11 100644 --- a/include/linux/intel_vsec.h +++ b/include/linux/intel_vsec.h @@ -183,7 +183,7 @@ struct pmt_feature_group { struct telemetry_region regions[]; }; =20 -int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent, +int intel_vsec_add_aux(struct device *parent, struct intel_vsec_device *intel_vsec_dev, const char *name); =20 --=20 2.43.0 From nobody Sat Feb 7 17:54:59 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0932017A31C; Wed, 7 Jan 2026 00:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767745335; cv=none; b=lFHq4LGLDTB+gpaGDhAMx848hkIbbtAiwwO+NKwaoRBp9BQ6Vk9AD9/GpChuo/b4aMNyZAJeL5F5w674/6UTIH/yNKHjc//ECP2/oIDardDkMPEVW1EFQSBDaqytbSwkJQtIkzuoxdB2NzG9zl1OgrIDOlfxmPSHpYLkiQzirJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767745335; c=relaxed/simple; bh=7S7c3pZN/iTzPROnYIDCYdk2TAauovgGMY7LtD8OslI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PRmOyJPvRom2XsgCexFV4HlXzg1HIm0zW+HPG6WnEZabfQMJHqVfWnaMwbQJwBp815xxanJYYZZzww9aGq9vODSHSOT8RxvF+cs+9Bllqq13dBz6pJuM0nSGM5Iwy9Pd19cELaqcMQmm5KHVbnDziFrT6GH2daMC0CiDeE5JGxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=d16CuyQu; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="d16CuyQu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767745334; x=1799281334; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7S7c3pZN/iTzPROnYIDCYdk2TAauovgGMY7LtD8OslI=; b=d16CuyQuxhstJ4Bf4Tf4KtAfM4t0rl6+QviZOufmINMgG+HNJzR3m60W UafGVuPshrXgIJMiAcp4arZCyuQsrwi3j2QlZ+iWG518qm7+i1ljEnyID N4CfQ/wwvd4iWE3kYEF1EJChLeYrRufFpiRizIM9sQyRnraDg1TZyRsVn a01um7c0y8jWzRVSi1R2FvD/+AQlpO3gdvHYKvwQyBqTdW4wdSj0eDv3R xKRRgrOlkv7wwtpTdlgob+CfIb1yaWGCWrCDOJiljF5923Yzo/k6p2oQA CrwydiqQSMRb1UdmDNlqg8B/ZWd8SoUA5kxE/4co/HypbxvQ35vrKnQ94 A==; X-CSE-ConnectionGUID: 4X9tZXJjRAu3KQ6gEtCh7A== X-CSE-MsgGUID: W8g8FEZXR/Wo2ORNRXr0qw== X-IronPort-AV: E=McAfee;i="6800,10657,11663"; a="69164104" X-IronPort-AV: E=Sophos;i="6.21,206,1763452800"; d="scan'208";a="69164104" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 16:22:09 -0800 X-CSE-ConnectionGUID: eIEwkaKwRhCotaqLkXwtfA== X-CSE-MsgGUID: jpn5RhaLS/i2kPgyQcTbHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,206,1763452800"; d="scan'208";a="206931522" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 16:22:08 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.comn Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH 2/4] platform/x86/intel/vsec: Switch exported helpers from pci_dev to device Date: Tue, 6 Jan 2026 16:21:49 -0800 Message-ID: <20260107002153.63830-3-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107002153.63830-1-david.e.box@linux.intel.com> References: <20260107002153.63830-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Preparatory refactor for ACPI-enumerated PMT endpoints. Several exported PMT/VSEC interfaces and structs carried struct pci_dev * even though callers only need a generic struct device. Move those to struct device * so the same APIs work for PCI and ACPI parents. Signed-off-by: David E. Box Acked-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_debugfs.c | 2 +- drivers/gpu/drm/xe/xe_hwmon.c | 2 +- drivers/gpu/drm/xe/xe_vsec.c | 7 +- drivers/gpu/drm/xe/xe_vsec.h | 2 +- drivers/platform/x86/intel/pmc/core.c | 4 +- .../platform/x86/intel/pmc/ssram_telemetry.c | 2 +- drivers/platform/x86/intel/pmt/class.c | 8 +- drivers/platform/x86/intel/pmt/class.h | 4 +- drivers/platform/x86/intel/pmt/discovery.c | 4 +- drivers/platform/x86/intel/pmt/telemetry.c | 13 ++-- drivers/platform/x86/intel/pmt/telemetry.h | 11 ++- drivers/platform/x86/intel/sdsi.c | 5 +- drivers/platform/x86/intel/vsec.c | 74 +++++++++++-------- drivers/platform/x86/intel/vsec_tpmi.c | 6 +- include/linux/intel_vsec.h | 18 ++--- 15 files changed, 86 insertions(+), 76 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugf= s.c index e91da9589c5f..d07b2aad300f 100644 --- a/drivers/gpu/drm/xe/xe_debugfs.c +++ b/drivers/gpu/drm/xe/xe_debugfs.c @@ -45,7 +45,7 @@ static void read_residency_counter(struct xe_device *xe, = struct xe_mmio *mmio, u64 residency =3D 0; int ret; =20 - ret =3D xe_pmt_telem_read(to_pci_dev(xe->drm.dev), + ret =3D xe_pmt_telem_read(xe->drm.dev, xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID), &residency, offset, sizeof(residency)); if (ret !=3D sizeof(residency)) { diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c index 97879daeefc1..556072a0ac10 100644 --- a/drivers/gpu/drm/xe/xe_hwmon.c +++ b/drivers/gpu/drm/xe/xe_hwmon.c @@ -464,7 +464,7 @@ xe_hwmon_energy_get(struct xe_hwmon *hwmon, int channel= , long *energy) if (hwmon->xe->info.platform =3D=3D XE_BATTLEMAGE) { u64 pmt_val; =20 - ret =3D xe_pmt_telem_read(to_pci_dev(hwmon->xe->drm.dev), + ret =3D xe_pmt_telem_read(hwmon->xe->drm.dev, xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID), &pmt_val, BMG_ENERGY_STATUS_PMT_OFFSET, sizeof(pmt_val)); if (ret !=3D sizeof(pmt_val)) { diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c index 8f23a27871b6..997fe0c8858e 100644 --- a/drivers/gpu/drm/xe/xe_vsec.c +++ b/drivers/gpu/drm/xe/xe_vsec.c @@ -141,10 +141,10 @@ static int xe_guid_decode(u32 guid, int *index, u32 *= offset) return 0; } =20 -int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t us= er_offset, +int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user= _offset, u32 count) { - struct xe_device *xe =3D pdev_to_xe_device(pdev); + struct xe_device *xe =3D kdev_to_xe_device(dev); void __iomem *telem_addr =3D xe->mmio.regs + BMG_TELEMETRY_OFFSET; u32 mem_region; u32 offset; @@ -197,7 +197,6 @@ void xe_vsec_init(struct xe_device *xe) { struct intel_vsec_platform_info *info; struct device *dev =3D xe->drm.dev; - struct pci_dev *pdev =3D to_pci_dev(dev); enum xe_vsec platform; =20 platform =3D get_platform_info(xe); @@ -220,6 +219,6 @@ void xe_vsec_init(struct xe_device *xe) * Register a VSEC. Cleanup is handled using device managed * resources. */ - intel_vsec_register(pdev, info); + intel_vsec_register(dev, info); } MODULE_IMPORT_NS("INTEL_VSEC"); diff --git a/drivers/gpu/drm/xe/xe_vsec.h b/drivers/gpu/drm/xe/xe_vsec.h index dabfb4e02d70..74ac575cd68c 100644 --- a/drivers/gpu/drm/xe/xe_vsec.h +++ b/drivers/gpu/drm/xe/xe_vsec.h @@ -10,6 +10,6 @@ struct pci_dev; struct xe_device; =20 void xe_vsec_init(struct xe_device *xe); -int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t us= er_offset, u32 count); +int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user= _offset, u32 count); =20 #endif diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/i= ntel/pmc/core.c index 7d7ae8a40b0e..4abe5e1f574d 100644 --- a/drivers/platform/x86/intel/pmc/core.c +++ b/drivers/platform/x86/intel/pmc/core.c @@ -1288,7 +1288,7 @@ static struct telem_endpoint *pmc_core_register_endpo= int(struct pci_dev *pcidev, unsigned int i; =20 for (i =3D 0; guids[i]; i++) { - ep =3D pmt_telem_find_and_register_endpoint(pcidev, guids[i], 0); + ep =3D pmt_telem_find_and_register_endpoint(&pcidev->dev, guids[i], 0); if (!IS_ERR(ep)) return ep; } @@ -1573,7 +1573,7 @@ static int pmc_core_get_telem_info(struct pmc_dev *pm= cdev, struct pmc_dev_info * if (!pmc->map->lpm_req_guid) return -ENXIO; =20 - ep =3D pmt_telem_find_and_register_endpoint(pcidev, pmc->map->lpm_req_gu= id, 0); + ep =3D pmt_telem_find_and_register_endpoint(&pcidev->dev, pmc->map->lpm_= req_guid, 0); if (IS_ERR(ep)) { dev_dbg(&pmcdev->pdev->dev, "couldn't get telem endpoint %pe", ep); return -EPROBE_DEFER; diff --git a/drivers/platform/x86/intel/pmc/ssram_telemetry.c b/drivers/pla= tform/x86/intel/pmc/ssram_telemetry.c index 03fad9331fc0..6f6e83e70fc5 100644 --- a/drivers/platform/x86/intel/pmc/ssram_telemetry.c +++ b/drivers/platform/x86/intel/pmc/ssram_telemetry.c @@ -60,7 +60,7 @@ pmc_ssram_telemetry_add_pmt(struct pci_dev *pcidev, u64 s= sram_base, void __iomem info.base_addr =3D ssram_base; info.parent =3D &pcidev->dev; =20 - return intel_vsec_register(pcidev, &info); + return intel_vsec_register(&pcidev->dev, &info); } =20 static inline u64 get_base(void __iomem *addr, u32 offset) diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/= intel/pmt/class.c index 7c3023d5d91d..8077274726b5 100644 --- a/drivers/platform/x86/intel/pmt/class.c +++ b/drivers/platform/x86/intel/pmt/class.c @@ -60,11 +60,11 @@ pmt_memcpy64_fromio(void *to, const u64 __iomem *from, = size_t count) return count; } =20 -int pmt_telem_read_mmio(struct pci_dev *pdev, struct pmt_callbacks *cb, u3= 2 guid, void *buf, +int pmt_telem_read_mmio(struct device *dev, struct pmt_callbacks *cb, u32 = guid, void *buf, void __iomem *addr, loff_t off, u32 count) { if (cb && cb->read_telem) - return cb->read_telem(pdev, guid, buf, off, count); + return cb->read_telem(dev, guid, buf, off, count); =20 addr +=3D off; =20 @@ -99,7 +99,7 @@ intel_pmt_read(struct file *filp, struct kobject *kobj, if (count > entry->size - off) count =3D entry->size - off; =20 - count =3D pmt_telem_read_mmio(entry->pcidev, entry->cb, entry->header.gui= d, buf, + count =3D pmt_telem_read_mmio(entry->ep->dev, entry->cb, entry->header.gu= id, buf, entry->base, off, count); =20 return count; @@ -208,7 +208,7 @@ static int intel_pmt_populate_entry(struct intel_pmt_en= try *entry, struct intel_vsec_device *ivdev, struct resource *disc_res) { - struct pci_dev *pci_dev =3D ivdev->pcidev; + struct pci_dev *pci_dev =3D to_pci_dev(ivdev->dev); struct device *dev =3D &ivdev->auxdev.dev; struct intel_pmt_header *header =3D &entry->header; u8 bir; diff --git a/drivers/platform/x86/intel/pmt/class.h b/drivers/platform/x86/= intel/pmt/class.h index 3c5ad5f52bca..3eb8ab97dd87 100644 --- a/drivers/platform/x86/intel/pmt/class.h +++ b/drivers/platform/x86/intel/pmt/class.h @@ -23,7 +23,7 @@ struct pci_dev; extern struct class intel_pmt_class; =20 struct telem_endpoint { - struct pci_dev *pcidev; + struct device *dev; struct telem_header header; struct pmt_callbacks *cb; void __iomem *base; @@ -65,7 +65,7 @@ struct intel_pmt_namespace { struct intel_pmt_entry *entry); }; =20 -int pmt_telem_read_mmio(struct pci_dev *pdev, struct pmt_callbacks *cb, u3= 2 guid, void *buf, +int pmt_telem_read_mmio(struct device *dev, struct pmt_callbacks *cb, u32 = guid, void *buf, void __iomem *addr, loff_t off, u32 count); bool intel_pmt_is_early_client_hw(struct device *dev); int intel_pmt_dev_create(struct intel_pmt_entry *entry, diff --git a/drivers/platform/x86/intel/pmt/discovery.c b/drivers/platform/= x86/intel/pmt/discovery.c index 32713a194a55..66f1ae931e05 100644 --- a/drivers/platform/x86/intel/pmt/discovery.c +++ b/drivers/platform/x86/intel/pmt/discovery.c @@ -540,7 +540,7 @@ static int pmt_features_probe(struct auxiliary_device *= auxdev, const struct auxi if (!priv) return -ENOMEM; =20 - priv->parent =3D &ivdev->pcidev->dev; + priv->parent =3D ivdev->dev; auxiliary_set_drvdata(auxdev, priv); =20 priv->dev =3D device_create(&intel_pmt_class, &auxdev->dev, MKDEV(0, 0), = priv, @@ -607,7 +607,7 @@ void intel_pmt_get_features(struct intel_pmt_entry *ent= ry) =20 mutex_lock(&feature_list_lock); list_for_each_entry(feature, &pmt_feature_list, list) { - if (feature->priv->parent !=3D &entry->ep->pcidev->dev) + if (feature->priv->parent !=3D entry->ep->dev) continue; =20 pmt_get_features(entry, feature); diff --git a/drivers/platform/x86/intel/pmt/telemetry.c b/drivers/platform/= x86/intel/pmt/telemetry.c index a4dfca6cac19..e11f7bde41b2 100644 --- a/drivers/platform/x86/intel/pmt/telemetry.c +++ b/drivers/platform/x86/intel/pmt/telemetry.c @@ -112,7 +112,7 @@ static int pmt_telem_add_endpoint(struct intel_vsec_dev= ice *ivdev, return -ENOMEM; =20 ep =3D entry->ep; - ep->pcidev =3D ivdev->pcidev; + ep->dev =3D ivdev->dev; ep->header.access_type =3D entry->header.access_type; ep->header.guid =3D entry->header.guid; ep->header.base_offset =3D entry->header.base_offset; @@ -204,7 +204,7 @@ int pmt_telem_get_endpoint_info(int devid, struct telem= _endpoint_info *info) goto unlock; } =20 - info->pdev =3D entry->ep->pcidev; + info->dev =3D entry->ep->dev; info->header =3D entry->ep->header; =20 unlock: @@ -218,9 +218,10 @@ static int pmt_copy_region(struct telemetry_region *re= gion, struct intel_pmt_entry *entry) { =20 + struct pci_dev *pdev =3D to_pci_dev(entry->ep->dev); struct oobmsm_plat_info *plat_info; =20 - plat_info =3D intel_vsec_get_mapping(entry->ep->pcidev); + plat_info =3D intel_vsec_get_mapping(pdev); if (IS_ERR(plat_info)) return PTR_ERR(plat_info); =20 @@ -308,7 +309,7 @@ int pmt_telem_read(struct telem_endpoint *ep, u32 id, u= 64 *data, u32 count) if (offset + NUM_BYTES_QWORD(count) > size) return -EINVAL; =20 - pmt_telem_read_mmio(ep->pcidev, ep->cb, ep->header.guid, data, ep->base, = offset, + pmt_telem_read_mmio(ep->dev, ep->cb, ep->header.guid, data, ep->base, off= set, NUM_BYTES_QWORD(count)); =20 return ep->present ? 0 : -EPIPE; @@ -335,7 +336,7 @@ int pmt_telem_read32(struct telem_endpoint *ep, u32 id,= u32 *data, u32 count) EXPORT_SYMBOL_NS_GPL(pmt_telem_read32, "INTEL_PMT_TELEMETRY"); =20 struct telem_endpoint * -pmt_telem_find_and_register_endpoint(struct pci_dev *pcidev, u32 guid, u16= pos) +pmt_telem_find_and_register_endpoint(struct device *dev, u32 guid, u16 pos) { int devid =3D 0; int inst =3D 0; @@ -348,7 +349,7 @@ pmt_telem_find_and_register_endpoint(struct pci_dev *pc= idev, u32 guid, u16 pos) if (err) return ERR_PTR(err); =20 - if (ep_info.header.guid =3D=3D guid && ep_info.pdev =3D=3D pcidev) { + if (ep_info.header.guid =3D=3D guid && ep_info.dev =3D=3D dev) { if (inst =3D=3D pos) return pmt_telem_register_endpoint(devid); ++inst; diff --git a/drivers/platform/x86/intel/pmt/telemetry.h b/drivers/platform/= x86/intel/pmt/telemetry.h index d45af5512b4e..a4fa2178adef 100644 --- a/drivers/platform/x86/intel/pmt/telemetry.h +++ b/drivers/platform/x86/intel/pmt/telemetry.h @@ -7,7 +7,6 @@ #define PMT_TELEM_CRASHLOG 1 =20 struct telem_endpoint; -struct pci_dev; =20 struct telem_header { u8 access_type; @@ -17,7 +16,7 @@ struct telem_header { }; =20 struct telem_endpoint_info { - struct pci_dev *pdev; + struct device *dev; struct telem_header header; }; =20 @@ -71,8 +70,8 @@ int pmt_telem_get_endpoint_info(int devid, struct telem_e= ndpoint_info *info); =20 /** * pmt_telem_find_and_register_endpoint() - Get a telemetry endpoint from - * pci_dev device, guid and pos - * @pdev: PCI device inside the Intel vsec + * device, guid and pos + * @dev: device inside the Intel vsec * @guid: GUID of the telemetry space * @pos: Instance of the guid * @@ -80,8 +79,8 @@ int pmt_telem_get_endpoint_info(int devid, struct telem_e= ndpoint_info *info); * * endpoint - On success returns pointer to the telemetry endpoint * * -ENXIO - telemetry endpoint not found */ -struct telem_endpoint *pmt_telem_find_and_register_endpoint(struct pci_dev= *pcidev, - u32 guid, u16 pos); +struct telem_endpoint * +pmt_telem_find_and_register_endpoint(struct device *dev, u32 guid, u16 pos= ); =20 /** * pmt_telem_read() - Read qwords from counter sram using sample id diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel= /sdsi.c index da75f53d0bcc..d7e37d4ace23 100644 --- a/drivers/platform/x86/intel/sdsi.c +++ b/drivers/platform/x86/intel/sdsi.c @@ -599,13 +599,14 @@ static int sdsi_get_layout(struct sdsi_priv *priv, st= ruct disc_table *table) return 0; } =20 -static int sdsi_map_mbox_registers(struct sdsi_priv *priv, struct pci_dev = *parent, +static int sdsi_map_mbox_registers(struct sdsi_priv *priv, struct device *= dev, struct disc_table *disc_table, struct resource *disc_res) { u32 access_type =3D FIELD_GET(DT_ACCESS_TYPE, disc_table->access_info); u32 size =3D FIELD_GET(DT_SIZE, disc_table->access_info); u32 tbir =3D FIELD_GET(DT_TBIR, disc_table->offset); u32 offset =3D DT_OFFSET(disc_table->offset); + struct pci_dev *parent =3D to_pci_dev(dev); struct resource res =3D {}; =20 /* Starting location of SDSi MMIO region based on access type */ @@ -681,7 +682,7 @@ static int sdsi_probe(struct auxiliary_device *auxdev, = const struct auxiliary_de return ret; =20 /* Map the SDSi mailbox registers */ - ret =3D sdsi_map_mbox_registers(priv, intel_cap_dev->pcidev, &disc_table,= disc_res); + ret =3D sdsi_map_mbox_registers(priv, intel_cap_dev->dev, &disc_table, di= sc_res); if (ret) return ret; =20 diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index 130577061a51..b84bb92624ef 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -274,7 +274,7 @@ int intel_vsec_add_aux(struct device *parent, } EXPORT_SYMBOL_NS_GPL(intel_vsec_add_aux, "INTEL_VSEC"); =20 -static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_head= er *header, +static int intel_vsec_add_dev(struct device *dev, struct intel_vsec_header= *header, struct intel_vsec_platform_info *info, unsigned long cap_id) { @@ -283,24 +283,24 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, s= truct intel_vsec_header *he struct resource *tmp; struct device *parent; unsigned long quirks =3D info->quirks; - u64 base_addr; + u64 base_addr =3D info->base_addr; int i; =20 if (info->parent) parent =3D info->parent; else - parent =3D &pdev->dev; + parent =3D dev; =20 if (!intel_vsec_supported(header->id, info->caps)) return -EINVAL; =20 if (!header->num_entries) { - dev_dbg(&pdev->dev, "Invalid 0 entry count for header id %d\n", header->= id); + dev_dbg(dev, "Invalid 0 entry count for header id %d\n", header->id); return -EINVAL; } =20 if (!header->entry_size) { - dev_dbg(&pdev->dev, "Invalid 0 entry size for header id %d\n", header->i= d); + dev_dbg(dev, "Invalid 0 entry size for header id %d\n", header->id); return -EINVAL; } =20 @@ -315,11 +315,6 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, st= ruct intel_vsec_header *he if (quirks & VSEC_QUIRK_TABLE_SHIFT) header->offset >>=3D TABLE_OFFSET_SHIFT; =20 - if (info->base_addr) - base_addr =3D info->base_addr; - else - base_addr =3D pdev->resource[header->tbir].start; - /* * The DVSEC/VSEC contains the starting offset and count for a block of * discovery tables. Create a resource array of these tables to the @@ -337,7 +332,7 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, str= uct intel_vsec_header *he release_mem_region(tmp->start, resource_size(tmp)); } =20 - intel_vsec_dev->pcidev =3D pdev; + intel_vsec_dev->dev =3D dev; intel_vsec_dev->resource =3D no_free_ptr(res); intel_vsec_dev->num_resources =3D header->num_entries; intel_vsec_dev->quirks =3D info->quirks; @@ -415,12 +410,13 @@ static int get_cap_id(u32 header_id, unsigned long *c= ap_id) return 0; } =20 -static int intel_vsec_register_device(struct pci_dev *pdev, +static int intel_vsec_register_device(struct device *dev, struct intel_vsec_header *header, struct intel_vsec_platform_info *info) { const struct vsec_feature_dependency *consumer_deps; struct vsec_priv *priv; + struct pci_dev *pdev; unsigned long cap_id; int ret; =20 @@ -432,8 +428,12 @@ static int intel_vsec_register_device(struct pci_dev *= pdev, * Only track dependencies for devices probed by the VSEC driver. * For others using the exported APIs, add the device directly. */ + if (!dev_is_pci(dev)) + return intel_vsec_add_dev(dev, header, info, cap_id); + + pdev =3D to_pci_dev(dev); if (!pci_match_id(intel_vsec_pci_ids, pdev)) - return intel_vsec_add_dev(pdev, header, info, cap_id); + return intel_vsec_add_dev(dev, header, info, cap_id); =20 priv =3D pci_get_drvdata(pdev); if (priv->state[cap_id] =3D=3D STATE_REGISTERED || @@ -449,7 +449,7 @@ static int intel_vsec_register_device(struct pci_dev *p= dev, =20 consumer_deps =3D get_consumer_dependencies(priv, cap_id); if (!consumer_deps || suppliers_ready(priv, consumer_deps, cap_id)) { - ret =3D intel_vsec_add_dev(pdev, header, info, cap_id); + ret =3D intel_vsec_add_dev(dev, header, info, cap_id); if (ret) priv->state[cap_id] =3D STATE_SKIP; else @@ -461,7 +461,7 @@ static int intel_vsec_register_device(struct pci_dev *p= dev, return -EAGAIN; } =20 -static bool intel_vsec_walk_header(struct pci_dev *pdev, +static bool intel_vsec_walk_header(struct device *dev, struct intel_vsec_platform_info *info) { struct intel_vsec_header **header =3D info->headers; @@ -469,7 +469,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev, int ret; =20 for ( ; *header; header++) { - ret =3D intel_vsec_register_device(pdev, *header, info); + ret =3D intel_vsec_register_device(dev, *header, info); if (!ret) have_devices =3D true; } @@ -517,7 +517,9 @@ static bool intel_vsec_walk_dvsec(struct pci_dev *pdev, pci_read_config_dword(pdev, pos + PCI_DVSEC_HEADER2, &hdr); header.id =3D PCI_DVSEC_HEADER2_ID(hdr); =20 - ret =3D intel_vsec_register_device(pdev, &header, info); + info->base_addr =3D pdev->resource[header.tbir].start; + + ret =3D intel_vsec_register_device(&pdev->dev, &header, info); if (ret) continue; =20 @@ -562,7 +564,9 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev, header.tbir =3D INTEL_DVSEC_TABLE_BAR(table); header.offset =3D INTEL_DVSEC_TABLE_OFFSET(table); =20 - ret =3D intel_vsec_register_device(pdev, &header, info); + info->base_addr =3D pdev->resource[header.tbir].start; + + ret =3D intel_vsec_register_device(&pdev->dev, &header, info); if (ret) continue; =20 @@ -572,13 +576,13 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev, return have_devices; } =20 -int intel_vsec_register(struct pci_dev *pdev, - struct intel_vsec_platform_info *info) +int intel_vsec_register(struct device *dev, + struct intel_vsec_platform_info *info) { - if (!pdev || !info || !info->headers) + if (!dev || !info || !info->headers) return -EINVAL; =20 - if (!intel_vsec_walk_header(pdev, info)) + if (!intel_vsec_walk_header(dev, info)) return -ENODEV; else return 0; @@ -604,7 +608,7 @@ static bool intel_vsec_get_features(struct pci_dev *pde= v, found =3D true; =20 if (info && (info->quirks & VSEC_QUIRK_NO_DVSEC) && - intel_vsec_walk_header(pdev, info)) + intel_vsec_walk_header(&pdev->dev, info)) found =3D true; =20 return found; @@ -630,7 +634,7 @@ static void intel_vsec_skip_missing_dependencies(struct= pci_dev *pdev) =20 static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_dev= ice_id *id) { - struct intel_vsec_platform_info *info; + struct intel_vsec_platform_info info, *info_temp; struct vsec_priv *priv; int num_caps, ret; int run_once =3D 0; @@ -641,22 +645,25 @@ static int intel_vsec_pci_probe(struct pci_dev *pdev,= const struct pci_device_id return ret; =20 pci_save_state(pdev); - info =3D (struct intel_vsec_platform_info *)id->driver_data; - if (!info) + info_temp =3D (struct intel_vsec_platform_info *)id->driver_data; + if (!info_temp) return -EINVAL; =20 + /* XXX: Needs better fix */ + info =3D *info_temp; + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; =20 - priv->info =3D info; + priv->info =3D &info; pci_set_drvdata(pdev, priv); =20 - num_caps =3D hweight_long(info->caps); + num_caps =3D hweight_long(info.caps); while (num_caps--) { - found_any |=3D intel_vsec_get_features(pdev, info); + found_any |=3D intel_vsec_get_features(pdev, &info); =20 - if (priv->found_caps =3D=3D info->caps) + if (priv->found_caps =3D=3D info.caps) break; =20 if (!run_once) { @@ -676,7 +683,10 @@ int intel_vsec_set_mapping(struct oobmsm_plat_info *pl= at_info, { struct vsec_priv *priv; =20 - priv =3D pci_get_drvdata(vsec_dev->pcidev); + if (!dev_is_pci(vsec_dev->dev)) + return -ENODEV; + + priv =3D pci_get_drvdata(to_pci_dev(vsec_dev->dev)); if (!priv) return -EINVAL; =20 @@ -822,7 +832,7 @@ static pci_ers_result_t intel_vsec_pci_slot_reset(struc= t pci_dev *pdev) =20 xa_for_each(&auxdev_array, index, intel_vsec_dev) { /* check if pdev doesn't match */ - if (pdev !=3D intel_vsec_dev->pcidev) + if (&pdev->dev !=3D intel_vsec_dev->dev) continue; devm_release_action(&pdev->dev, intel_vsec_remove_aux, &intel_vsec_dev->auxdev); diff --git a/drivers/platform/x86/intel/vsec_tpmi.c b/drivers/platform/x86/= intel/vsec_tpmi.c index 2ccde86c529f..254273392639 100644 --- a/drivers/platform/x86/intel/vsec_tpmi.c +++ b/drivers/platform/x86/intel/vsec_tpmi.c @@ -530,7 +530,7 @@ static const struct file_operations mem_write_ops =3D { .release =3D single_release, }; =20 -#define tpmi_to_dev(info) (&info->vsec_dev->pcidev->dev) +#define tpmi_to_dev(info) ((info)->vsec_dev->dev) =20 static void tpmi_dbgfs_register(struct intel_tpmi_info *tpmi_info) { @@ -642,7 +642,7 @@ static int tpmi_create_device(struct intel_tpmi_info *t= pmi_info, tmp->flags =3D IORESOURCE_MEM; } =20 - feature_vsec_dev->pcidev =3D vsec_dev->pcidev; + feature_vsec_dev->dev =3D vsec_dev->dev; feature_vsec_dev->resource =3D res; feature_vsec_dev->num_resources =3D pfs->pfs_header.num_entries; feature_vsec_dev->priv_data =3D &tpmi_info->plat_info; @@ -742,7 +742,7 @@ static int tpmi_fetch_pfs_header(struct intel_tpmi_pm_f= eature *pfs, u64 start, i static int intel_vsec_tpmi_init(struct auxiliary_device *auxdev) { struct intel_vsec_device *vsec_dev =3D auxdev_to_ivdev(auxdev); - struct pci_dev *pci_dev =3D vsec_dev->pcidev; + struct pci_dev *pci_dev =3D to_pci_dev(vsec_dev->dev); struct intel_tpmi_info *tpmi_info; u64 pfs_start =3D 0; int ret, i; diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h index 28c2f5855a11..931ff42361a9 100644 --- a/include/linux/intel_vsec.h +++ b/include/linux/intel_vsec.h @@ -29,8 +29,8 @@ #define INTEL_DVSEC_TABLE_OFFSET(x) ((x) & GENMASK(31, 3)) #define TABLE_OFFSET_SHIFT 3 =20 -struct pci_dev; struct resource; +struct pci_dev; =20 enum intel_vsec_id { VSEC_ID_TELEMETRY =3D 2, @@ -82,14 +82,14 @@ enum intel_vsec_quirks { * struct pmt_callbacks - Callback infrastructure for PMT devices * ->read_telem() when specified, called by client driver to access PMT da= ta (instead * of direct copy). - * @pdev: PCI device reference for the callback's use + * @dev: device reference for the callback's use * @guid: ID of data to acccss * @data: buffer for the data to be copied * @off: offset into the requested buffer * @count: size of buffer */ struct pmt_callbacks { - int (*read_telem)(struct pci_dev *pdev, u32 guid, u64 *data, loff_t off, = u32 count); + int (*read_telem)(struct device *dev, u32 guid, u64 *data, loff_t off, u3= 2 count); }; =20 struct vsec_feature_dependency { @@ -122,7 +122,7 @@ struct intel_vsec_platform_info { /** * struct intel_sec_device - Auxbus specific device information * @auxdev: auxbus device struct for auxbus access - * @pcidev: pci device associated with the device + * @dev: struct device associated with the device * @resource: any resources shared by the parent * @ida: id reference * @num_resources: number of resources @@ -134,7 +134,7 @@ struct intel_vsec_platform_info { */ struct intel_vsec_device { struct auxiliary_device auxdev; - struct pci_dev *pcidev; + struct device *dev; struct resource *resource; struct ida *ida; int num_resources; @@ -198,14 +198,14 @@ static inline struct intel_vsec_device *auxdev_to_ivd= ev(struct auxiliary_device } =20 #if IS_ENABLED(CONFIG_INTEL_VSEC) -int intel_vsec_register(struct pci_dev *pdev, - struct intel_vsec_platform_info *info); +int intel_vsec_register(struct device *dev, + struct intel_vsec_platform_info *info); int intel_vsec_set_mapping(struct oobmsm_plat_info *plat_info, struct intel_vsec_device *vsec_dev); struct oobmsm_plat_info *intel_vsec_get_mapping(struct pci_dev *pdev); #else -static inline int intel_vsec_register(struct pci_dev *pdev, - struct intel_vsec_platform_info *info) +static inline int intel_vsec_register(struct device *dev, + struct intel_vsec_platform_info *info) { return -ENODEV; } --=20 2.43.0 From nobody Sat Feb 7 17:54:59 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 863851DED42; Wed, 7 Jan 2026 00:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767745337; cv=none; b=HvVPAsjipI7bA+pDUAA9Is2LNO1itAQ4n97nSMar3AiS64JTW/6uYGpO0dU2fq9QcKEwXdXyAlZXPwXjz8iMOvwcoK49BYXfyuB9wcsQuvRFjEEv7wvBMA/lUNBqDdFnC0HzX4VJ4Q6FEFEt3IXRa7eR9GjHZeIl7mfGlkpRytw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767745337; c=relaxed/simple; bh=PqjVYCDUKkqMaY/J6kWsbzjBfCex8qasIuQ9PbHpHV8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KgjU+TP6S2wt3aDfyrdmHMgqrqqNWr9Vw5x6F9vtlb6tDo2yEiqMCa09qPvKE9CtT79Ct4QsgT5TcujG7fe/jr58F4+0IdS99X0zF8gHsXbLnvs/Z31XmDbHsuTMPPC1wZVzBJETV5OEtpnMyQhp1KS8he6/ol1kBmLAEd4wJGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AUq5VP8k; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AUq5VP8k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767745336; x=1799281336; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PqjVYCDUKkqMaY/J6kWsbzjBfCex8qasIuQ9PbHpHV8=; b=AUq5VP8kI17rRBKvDdUTvP06Up3Ofzp5X9QCYtWrPo74+voYp8MIr91t 1IbhIx5+7Sp+dQUFkxXNIK16Im53jRKUwunUZWNqNY/fhx8Y/Z+a+1Nqr QB1XXYEWQr+HHo93GDtOefMCbdvX602wdls8osBpjSs0s5u/nVd/i8FGX fSEdWlPF5oa9twfDoJ+/9grdxBSUVkWn9G5fKQviLlCwlmNVM5+FUJzyn Zsipa0UTKAL35RkrxNBcHw0ASKv87VMND4dKExvjf8O2lgRar8fc3tnFF DuQxm7HngI7QsDefyQacCfxjHuCJ4RSWF0Pu3qAtK1C7Qtg7uwkXBM7TQ g==; X-CSE-ConnectionGUID: MGzK4MmLTh67i33SrwsJsQ== X-CSE-MsgGUID: wiIUfLQMTdiUhChq5unF8w== X-IronPort-AV: E=McAfee;i="6800,10657,11663"; a="69164122" X-IronPort-AV: E=Sophos;i="6.21,206,1763452800"; d="scan'208";a="69164122" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 16:22:09 -0800 X-CSE-ConnectionGUID: LStnZQhNSjqFXnmNQgn5Xw== X-CSE-MsgGUID: eWEp3f3VSEuc64fUKPyPVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,206,1763452800"; d="scan'208";a="206931525" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 16:22:08 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.comn Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH 3/4] platform/x86/intel/vsec: Return real error codes from registration path Date: Tue, 6 Jan 2026 16:21:50 -0800 Message-ID: <20260107002153.63830-4-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107002153.63830-1-david.e.box@linux.intel.com> References: <20260107002153.63830-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Stop collapsing registration results into booleans. Make intel_vsec_walk_header() return int and propagate the first non-zero error from intel_vsec_register_device(). intel_vsec_register() now returns that error directly and 0 on success. This preserves success behavior while surfacing meaningful errors instead of hiding them behind a bool/-ENODEV, which makes debugging and probe ordering issues clearer. Signed-off-by: David E. Box Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/platform/x86/intel/vsec.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index b84bb92624ef..42471fd609b1 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -461,20 +461,19 @@ static int intel_vsec_register_device(struct device *= dev, return -EAGAIN; } =20 -static bool intel_vsec_walk_header(struct device *dev, - struct intel_vsec_platform_info *info) +static int intel_vsec_walk_header(struct device *dev, + struct intel_vsec_platform_info *info) { struct intel_vsec_header **header =3D info->headers; - bool have_devices =3D false; int ret; =20 for ( ; *header; header++) { ret =3D intel_vsec_register_device(dev, *header, info); - if (!ret) - have_devices =3D true; + if (ret) + return ret; } =20 - return have_devices; + return 0; } =20 static bool intel_vsec_walk_dvsec(struct pci_dev *pdev, @@ -582,10 +581,7 @@ int intel_vsec_register(struct device *dev, if (!dev || !info || !info->headers) return -EINVAL; =20 - if (!intel_vsec_walk_header(dev, info)) - return -ENODEV; - else - return 0; + return intel_vsec_walk_header(dev, info); } EXPORT_SYMBOL_NS_GPL(intel_vsec_register, "INTEL_VSEC"); =20 --=20 2.43.0 From nobody Sat Feb 7 17:54:59 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA9AF1DFD96; Wed, 7 Jan 2026 00:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767745337; cv=none; b=kabslLbhubRmMGbSQpPBTBHsGiLvNIdFTrVRl1RCCFGbLkj5mQ4sP8JZl+jUQKBldNCwyuvmt7yiEqJYEundvivbty3n3sHpVAvK+8nYlHn5cclFnRkQxmFQJ4Z0gVIl7pEnJGq9xBwzOces3TYoflvNmxR42yQ/qRJ4oT80X4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767745337; c=relaxed/simple; bh=+zZsnqtWYOKWf13j3NIfJKTb3vuYMFSj5yf8TzgjSFk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nHKGyJ7xt6MOwAQXhc0FRcJ7YgB3+08X4GyF8Xv0X82+qTGErBNsN0l7n5NZesRpAQX8JUnrFlH1drXc8UAtj9lh4UfvELz+HgOZ+veixOHIiwaCGTLqQ+XnmrtGmIBniXm5CA7UleixGzwW9ucUuXxPF8LPzC2+nu4CiqaHPdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cvCt44X2; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cvCt44X2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767745337; x=1799281337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+zZsnqtWYOKWf13j3NIfJKTb3vuYMFSj5yf8TzgjSFk=; b=cvCt44X2pvSDNiFmsE7ztooxDqLO8TB1ZO3fJUiujVMjMciq7vfJRfFR mOzm2X96/waPhfaIJeExGCtkPQqnC80BZjqK5LfdLHnBVeusWKNR8oP3c EiTcYALrN1+tyUe/sXiPNzrgJ2CyRPGljMODHWrWcUBVDplUgWBWA3Y6D EipTp4Gw6JgU1HhE90myItjhAMXs8yUBrd7w9wrZZjQYsIRHboAlKK3Tx lcTFWYOAW3l7FlujfwLOfEtqs2ywa/lblKoILX6fjdevXL7d6EKH1QFtq mbWhcla3dXTYDvFG1B2oaKeFrzt32w6Q5wXl1DrC5Ra6MU9wFWsXyZmwr w==; X-CSE-ConnectionGUID: JLLcJwR8RKCLw3xeF8LfpQ== X-CSE-MsgGUID: FFcLLK66QUOO1N0zurecAw== X-IronPort-AV: E=McAfee;i="6800,10657,11663"; a="69164125" X-IronPort-AV: E=Sophos;i="6.21,206,1763452800"; d="scan'208";a="69164125" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 16:22:09 -0800 X-CSE-ConnectionGUID: NlP7E6iCQCSO3py5EQNrdA== X-CSE-MsgGUID: 4dDWmAo8TMCrCWrgSi0KDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,206,1763452800"; d="scan'208";a="206931528" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 16:22:08 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.comn Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH 4/4] platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec Date: Tue, 6 Jan 2026 16:21:51 -0800 Message-ID: <20260107002153.63830-5-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260107002153.63830-1-david.e.box@linux.intel.com> References: <20260107002153.63830-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Newer platform will optionally expose PMT discovery via ACPI instead of PCI BARs. Add a generic discovery source flag and carry ACPI discovery entries alongside the existing PCI resource path so PMT clients can consume either. Changes: - Add enum intel_vsec_disc_source { _PCI, _ACPI }. - Extend intel_vsec_platform_info and intel_vsec_device with source enum and ACPI discovery table pointer/ - When src=3D=3DACPI, skip BAR resource setup and copy the ACPI discovery entries into the aux device. No user-visible behavior change yet; this only wires ACPI data through vsec in preparation for ACPI-enumerated PMT clients. Signed-off-by: David E. Box --- drivers/platform/x86/intel/vsec.c | 16 ++++++++++++++++ include/linux/intel_vsec.h | 20 +++++++++++++++++++- 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index 42471fd609b1..705672dcdd11 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -109,6 +109,7 @@ static void intel_vsec_dev_release(struct device *dev) =20 ida_free(intel_vsec_dev->ida, intel_vsec_dev->auxdev.id); =20 + kfree(intel_vsec_dev->acpi_disc); kfree(intel_vsec_dev->resource); kfree(intel_vsec_dev); } @@ -321,6 +322,10 @@ static int intel_vsec_add_dev(struct device *dev, stru= ct intel_vsec_header *head * auxiliary device driver. */ for (i =3D 0, tmp =3D res; i < header->num_entries; i++, tmp++) { + /* This check doesn't apply to ACPI based discovery */ + if (info->src =3D=3D INTEL_VSEC_DISC_ACPI) + break; + tmp->start =3D base_addr + header->offset + i * (header->entry_size * si= zeof(u32)); tmp->end =3D tmp->start + (header->entry_size * sizeof(u32)) - 1; tmp->flags =3D IORESOURCE_MEM; @@ -339,6 +344,17 @@ static int intel_vsec_add_dev(struct device *dev, stru= ct intel_vsec_header *head intel_vsec_dev->base_addr =3D info->base_addr; intel_vsec_dev->priv_data =3D info->priv_data; intel_vsec_dev->cap_id =3D cap_id; + intel_vsec_dev->src =3D info->src; + + if (info->src =3D=3D INTEL_VSEC_DISC_ACPI) { + size_t bytes; + + bytes =3D intel_vsec_dev->num_resources * sizeof(info->acpi_disc[0]); + + intel_vsec_dev->acpi_disc =3D kmemdup(info->acpi_disc, bytes, GFP_KERNEL= ); + if (!intel_vsec_dev->acpi_disc) + return -ENOMEM; + } =20 if (header->id =3D=3D VSEC_ID_SDSI) intel_vsec_dev->ida =3D &intel_vsec_sdsi_ida; diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h index 931ff42361a9..9d7795480c49 100644 --- a/include/linux/intel_vsec.h +++ b/include/linux/intel_vsec.h @@ -32,6 +32,11 @@ struct resource; struct pci_dev; =20 +enum intel_vsec_disc_source { + INTEL_VSEC_DISC_PCI, /* PCI, default */ + INTEL_VSEC_DISC_ACPI, /* ACPI */ +}; + enum intel_vsec_id { VSEC_ID_TELEMETRY =3D 2, VSEC_ID_WATCHER =3D 3, @@ -102,6 +107,10 @@ struct vsec_feature_dependency { * @parent: parent device in the auxbus chain * @headers: list of headers to define the PMT client devices to create * @deps: array of feature dependencies + * @acpi_disc: ACPI discovery tables, each entry is two QWORDs + * in little-endian format as defined by the PMT ACPI spec. + * Valid only when @provider =3D=3D INTEL_VSEC_PROV_ACPI. + * @src: source of discovery table data * @priv_data: private data, usable by parent devices, currently a callback * @caps: bitmask of PMT capabilities for the given headers * @quirks: bitmask of VSEC device quirks @@ -112,6 +121,8 @@ struct intel_vsec_platform_info { struct device *parent; struct intel_vsec_header **headers; const struct vsec_feature_dependency *deps; + u32 (*acpi_disc)[4]; + enum intel_vsec_disc_source src; void *priv_data; unsigned long caps; unsigned long quirks; @@ -123,7 +134,12 @@ struct intel_vsec_platform_info { * struct intel_sec_device - Auxbus specific device information * @auxdev: auxbus device struct for auxbus access * @dev: struct device associated with the device - * @resource: any resources shared by the parent + * @resource: PCI discovery resources (BAR windows), one per discovery + * instance. Valid only when @src =3D=3D INTEL_VSEC_PROV_P= CI + * @acpi_disc: ACPI discovery tables, each entry is two QWORDs + * in little-endian format as defined by the PMT ACPI spec. + * Valid only when @src =3D=3D INTEL_VSEC_PROV_ACPI. + * @src: source of discovery table data * @ida: id reference * @num_resources: number of resources * @id: xarray id @@ -136,6 +152,8 @@ struct intel_vsec_device { struct auxiliary_device auxdev; struct device *dev; struct resource *resource; + u32 (*acpi_disc)[4]; + enum intel_vsec_disc_source src; struct ida *ida; int num_resources; int id; /* xa */ --=20 2.43.0