From nobody Sun Feb 8 02:56:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B5231A56D; Wed, 7 Jan 2026 14:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795635; cv=none; b=XzmFrpfqRlBCYk0ebf9GaI0A98ufgTZtlgqcJZwMgh/8wb+AigHwzhZNhzmypXPIYxhhieLFoJYbvFUQMvsD9ZmGhgyMPAkINDS8GrmAWc++7fBzuVFL8GqU/9XhRu93e9hsVcjJvk3Rad45NTb+IiUET7563YLJERbVM+iOEcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795635; c=relaxed/simple; bh=tkUtMumKw36UQhHrH7n1l5r+Vth05W6Tk5DQRZclMos=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h1u5fgXQistrKqRJy06xNWrE5sPqXJl4dsDoUVJQi7XwTET4auN46wEV8Tlp71bI4CBZCW/hsZZkS8klIczv3noNGonZ55pDHNzMqJ0rI3VuN/xldUXL2sqPqv1/9ryeY23H+DRuOMveGNikxJec5l1wMkqvYHaUU9Atfr37x/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gJRc65Eh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gJRc65Eh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83829C19421; Wed, 7 Jan 2026 14:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767795635; bh=tkUtMumKw36UQhHrH7n1l5r+Vth05W6Tk5DQRZclMos=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gJRc65EhM+CoGdgtUcCCHQUHquGON7WfOakpDPhwU7kZoT6NgRkQLTzebiOgNPsih Z3XFJQFUJCyOg9EB7GnFXh9keS0S5W5slW/P0fC4lrOtPk86MjEXUPhsXB8CATttmX GURU0FARiG2XeRc28/+2CU8MsaGtz1J5c63hPGKUG41JCTD2fB3PrMUFUadwsC4hnk lia/iyFdJXYYxfkCtORWwxPCP0bmYZauJkF6rztYEvHJAQlZTRBCdDCC3fX5v5ke0F E9Hq3Dw0dyahHxZZJk/J5ZPnWSNJeWpt7hOsy5Ckx6IyY08RsTsdpYnNq4LrkHeqln Rce8v60llcPJQ== From: Jeff Layton Date: Wed, 07 Jan 2026 09:20:09 -0500 Subject: [PATCH 1/6] nfs: properly disallow delegation requests on directories Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260107-setlease-6-19-v1-1-85f034abcc57@kernel.org> References: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> In-Reply-To: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> To: Christian Brauner , Al Viro , Jan Kara , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Trond Myklebust , Anna Schumaker , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Andreas Gruenbacher , Xiubo Li , Ilya Dryomov , Hans de Goede , NeilBrown Cc: Christoph Hellwig , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, v9fs@lists.linux.dev, gfs2@lists.linux.dev, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1561; i=jlayton@kernel.org; h=from:subject:message-id; bh=tkUtMumKw36UQhHrH7n1l5r+Vth05W6Tk5DQRZclMos=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBpXmurGkP7toxFY3jKAO4v32OcZyFMTRKEDvXQd JpSxp4vRDWJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaV5rqwAKCRAADmhBGVaC FTJSEACmkBB7G9y/f0LVHuGDnP+jDnSPBvak4kEVurnaE4ki+rPuNqZGlb1a+7g8Af8qaX8ACA7 sqgMNm5XxSfVFllZlRnfavXfkL6BoLncqs/nuMOBdwElX5nDGgDAIg8A7npclylIY/WhLN+cRMH 7wqNux4Id5LrlkRSG/EyakGtWyYh3U9kjyS7YhMY/6fQ0FohvSl0jNexT3tJ7hLRa/SEKaGK/TR jmrSPP54QdLwrdYNl5UMc0X3ovBaL1rerOLecg0e+NgsHzcht7KitusEW27w6zNNeqn8Nwk2ZjD 0rz8AXXPouQiJYD/6uZaVsNU2Dsp5uOab7Bej/STcGp0+kd5+0cZoeGG000asDvqCam/rzMVBWk RLtIAOA5uTm8FrMbnXmpL2nbms3rr3fKuM+k4KyylXlePhkn9USlvvL6vZxJncFIF+yTGth7kZR eeBqe4ME9WtvuGu483hUgIJ2Ec0uFhI2brGjxZ7AtNvckuh2KNaWplOk9wCQmcs8pPHYgH644q6 9r9q5Vnn3j4mEqrgQ6yIUz1+VX/JC54vtU+T/xkUbWKjbLfXhRsYjqHwLJzCTQ3bbLIBtHNg45j BMqUWzcsgr+gw7a6bxSVsPSTsU1bJRbeKCAiBjPQA+4w0euocCsWD1xkrvUz6sV1SyVb0q5C2jZ ppEXuUmMIS4hNHQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Checking for S_ISREG() in nfs4_setlease() is incorrect, since that op is never called for directories. The right way to deny lease requests on directories is to set the ->setlease() operation to simple_nosetlease() in the directory file_operations. Fixes: e6d28ebc17eb ("filelock: push the S_ISREG check down to ->setlease h= andlers") Reported-by: Christoph Hellwig Closes: https://lore.kernel.org/linux-fsdevel/aV316LhsVSl0n9-E@infradead.or= g/ Signed-off-by: Jeff Layton Tested-by: Christoph Hellwig --- fs/nfs/dir.c | 1 + fs/nfs/nfs4file.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 23a78a742b619dea8b76ddf28f4f59a1c8a015e2..71df279febf797880ded19e4552= 8c3df4cea2dde 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -66,6 +66,7 @@ const struct file_operations nfs_dir_operations =3D { .open =3D nfs_opendir, .release =3D nfs_closedir, .fsync =3D nfs_fsync_dir, + .setlease =3D simple_nosetlease, }; =20 const struct address_space_operations nfs_dir_aops =3D { diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c index 7317f26892c5782a39660cae87ec1afea24e36c0..7f43e890d3564a000dab9365048= a3e17dc96395c 100644 --- a/fs/nfs/nfs4file.c +++ b/fs/nfs/nfs4file.c @@ -431,8 +431,6 @@ void nfs42_ssc_unregister_ops(void) static int nfs4_setlease(struct file *file, int arg, struct file_lease **l= ease, void **priv) { - if (!S_ISREG(file_inode(file)->i_mode)) - return -EINVAL; return nfs4_proc_setlease(file, arg, lease, priv); } =20 --=20 2.52.0 From nobody Sun Feb 8 02:56:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 122F431B81C; Wed, 7 Jan 2026 14:20:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795638; cv=none; b=FSL3RwrFtnC2SFHGc52Y4DrWvmYPXXaBpC8IuN2jskFSlMPnnYeL8OiL/seuuhRt2x7eQ6LVhPOkGu7bioR4JjiUmKEZsZyd2nMAg/WdjpXYehip5XKCWiNculmpvolBsy2+36jU1n7HZyqoflxespLQIZhsWm25a7h/c0Kb8k8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795638; c=relaxed/simple; bh=pS9yyXCuYMf7+KI6SO4u/vUJdTQQPT4ls4okttVSWaE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QaFu1UG/J9tFNiVNDcTd1plssb0b21I/2M3erSMHGWXviFjzEUTpisP5StuvAqcahhrLBnmlIvvcECchdG2PqwoGNO1WdjhdF2nPA1rReD5sUYZnxVmTNHmdm+0XkfcD6PUgxNzMjGa767edwdXwXj7odCV+fHtlpruqX2C36jI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cA+jkYKy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cA+jkYKy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39E71C4CEF1; Wed, 7 Jan 2026 14:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767795637; bh=pS9yyXCuYMf7+KI6SO4u/vUJdTQQPT4ls4okttVSWaE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=cA+jkYKyIk9GTNT/RIbyJ9+oKweiiJOPVQCV7mks0aWjroSOLgyr8NLfelO+dq/eT tGcBFxnITdlA3YUwDbY02hxwKrWVId2eHezILAMkPjIrQ7TQDYEyhGgR3LYdRG7KBj my+DRpKBaHOOqBrZSB9du2hQPSCpR3iuL+pnPeS5KmJFKSAFfnMvlstBnNCyr0/uol RaLURmzRTHfr/7jKY0wRcFvR6Zlw0/AQV+IfhkzSJph2a6+2424ezAWL+djjqJRu0V Nkc/d4zOjIgbTfqQtGXE7hAEctSbGVMbuu5+P1ZG7HPzP6zqMoyZDLUT8OEDZ4lfZt 3zCQr7PD6PLww== From: Jeff Layton Date: Wed, 07 Jan 2026 09:20:10 -0500 Subject: [PATCH 2/6] smb/client: properly disallow delegations on directories Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260107-setlease-6-19-v1-2-85f034abcc57@kernel.org> References: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> In-Reply-To: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> To: Christian Brauner , Al Viro , Jan Kara , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Trond Myklebust , Anna Schumaker , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Andreas Gruenbacher , Xiubo Li , Ilya Dryomov , Hans de Goede , NeilBrown Cc: Christoph Hellwig , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, v9fs@lists.linux.dev, gfs2@lists.linux.dev, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1365; i=jlayton@kernel.org; h=from:subject:message-id; bh=pS9yyXCuYMf7+KI6SO4u/vUJdTQQPT4ls4okttVSWaE=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBpXmusiT+Zo4rGBFj36gZGzZezqsdQ5jMDN7570 +X3LnovMQ6JAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaV5rrAAKCRAADmhBGVaC FQyMD/9Yn2ldQZofv33ljyPfw1HKZHxfV9g/4IXvDS0coXZV6btn300rZiiHijlDiQL22qszkfB /O5PtQ1peH2IuYCsNFIVCGWPjk6v1RJQ5Laeekscv207sRvr5nppbivyGjDLQ26gBSxZ08hmyMR Nl6WavAO7n/mTPxDgtfZNRjQur9yv2xVTZsN/nnO3ZCH7hL9kakZEpaXpgXLr7y00ToeMt6EU9l Sdo2kgGbG/83S7eNy8Lr+F8aYFgbPE72ftaxhTcOMfWt9tGgtefRlXQORqlppSRKBKb1T0l8wmJ 0dWUV6cweW4Cg1/ITOkHrp79vgFzL1km9I1yH092pUxCz5gzTkpy4Zl3rkzUnlLziVOfXrpuqrd w/OPxT8+Dw+ALUDRs7NvJdESsYzb6njiUWrO93vRdPNf9FNXxThSdRQFbqCidSfhKUyvStDYFQi lcgBKOXwxRmHVzOBjQ/axpCrQy5KVBprSIuXFBzXqkIzd5siyyiJT+0wQwfSACU537xUx43faEK lDnmDlcpCWS8WgyESuaIKTIOd2Y7oZc7qT2kSV/NtUb5f2Tuc2DzqggxrSdFWsd97LL4Aus78WE bIyQGskKVTfRSBzNzO1nbaXG6wVlTBLAa3WUVnRuaK2XtH3poGnHCEf33B9r8ujY2TOo0asLeub OnlAv+OtROjS4Nw== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 The check for S_ISREG() in cifs_setlease() is incorrect since that operation doesn't get called for directories. The correct way to prevent delegations on directories is to set the ->setlease() method in directory file_operations to simple_nosetlease(). Fixes: e6d28ebc17eb ("filelock: push the S_ISREG check down to ->setlease h= andlers") Signed-off-by: Jeff Layton --- fs/smb/client/cifsfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c index d9664634144d3ebba5cdd659f651d6e6e8f975fa..a3dc7cb1ab541d35c2e43eefb7a= 2d2d23ad88bb3 100644 --- a/fs/smb/client/cifsfs.c +++ b/fs/smb/client/cifsfs.c @@ -1149,9 +1149,6 @@ cifs_setlease(struct file *file, int arg, struct file= _lease **lease, void **priv struct inode *inode =3D file_inode(file); struct cifsFileInfo *cfile =3D file->private_data; =20 - if (!S_ISREG(inode->i_mode)) - return -EINVAL; - /* Check if file is oplocked if this is request for new lease */ if (arg =3D=3D F_UNLCK || ((arg =3D=3D F_RDLCK) && CIFS_CACHE_READ(CIFS_I(inode))) || @@ -1712,6 +1709,7 @@ const struct file_operations cifs_dir_ops =3D { .remap_file_range =3D cifs_remap_file_range, .llseek =3D generic_file_llseek, .fsync =3D cifs_dir_fsync, + .setlease =3D simple_nosetlease, }; =20 static void --=20 2.52.0 From nobody Sun Feb 8 02:56:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1291337686; Wed, 7 Jan 2026 14:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795640; cv=none; b=aFSnDuFCG32ptQvX9ly945G0HZl7h9TsnwMZvrMiuKXkLiPlu8aR8+x1gQLnoZA5Shvx70oNZzo8+0O69UnL/+xv89WC/ZqxwXmmJsPSeC/6TvJotzfWc6tzbVfU9rRd4WfOX4lOzEOiYiu/snRcwDXKFLMsQdfsCsnu4b4gl4w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795640; c=relaxed/simple; bh=kEkvQ9NQX8PYeQ1rYCmj8d2YBAwnJXpHvKctygKYYLE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RlKZHnTKjHDQ3k8wjwphXY+zubDxqADSjAN7UzTl2wFC139KSX/HzQleaoOvGbXp0nv/U6KhJLs2hyl3LAtMw++WwD5geaxaQR0alDMNPG60Gmk/G9+8PuIED8mfmPI3uSVSp9m8evQe/KLcpip8NRLZCgSOpbkTM9jshQY0GzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tMaMO7WG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tMaMO7WG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4211C19421; Wed, 7 Jan 2026 14:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767795640; bh=kEkvQ9NQX8PYeQ1rYCmj8d2YBAwnJXpHvKctygKYYLE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=tMaMO7WG6JQhtw/hjE2heFOQVqZg8m9u5mOJk8GHSYuYqtLXGFT+QUckJbHV9GTXF l1+IH9jE2kxotMlq1CFMLvL2S25sDzp3RZt+YMmAXgRz4TcNIKLlJBXPQoVjUwJHtq dfdr8JNozaLjMuivAvuKpg4DY14hkbMXeB88vuHJB1RiJqGCCfnWy2u9D6Gc7NYj21 2Pf2No971PU+wx5L4w1tPzsWIx9TS0cZRGxFcdIxPakokvkm5+I5PGCqDoaaq1bFW9 XuVxHaNAqOkASACOpIW7FDhKCIjqatsbuzvfse+v6YsX4Qp8Ixx9gfrQyPxG34gewd 63LbQMsYkLMTQ== From: Jeff Layton Date: Wed, 07 Jan 2026 09:20:11 -0500 Subject: [PATCH 3/6] 9p: don't allow delegations to be set on directories Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260107-setlease-6-19-v1-3-85f034abcc57@kernel.org> References: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> In-Reply-To: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> To: Christian Brauner , Al Viro , Jan Kara , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Trond Myklebust , Anna Schumaker , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Andreas Gruenbacher , Xiubo Li , Ilya Dryomov , Hans de Goede , NeilBrown Cc: Christoph Hellwig , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, v9fs@lists.linux.dev, gfs2@lists.linux.dev, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1032; i=jlayton@kernel.org; h=from:subject:message-id; bh=kEkvQ9NQX8PYeQ1rYCmj8d2YBAwnJXpHvKctygKYYLE=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBpXmusFABXCuzBzy1mQmp7JWrenTQAfrgA1JQp8 OqxhqtVIYKJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaV5rrAAKCRAADmhBGVaC FTfjD/wNogu8cq8DRl9tjq+zSkAMYAM++zEaDaPvKxwfExuQJ4iUCAvP+ZMG14K799qKk6rnzyD GGcpO7zJtgg5d3Ae2B/4I8tXitDrgsiiBUsisxdmWzkG3QT344FwzDRaLCpAndlEjvew4rc6jwg 5hog3xLPo+RJv9f9D9Q+YiHP6G0hkn3uI1P+Kh2MAErNM1w2F0EjOGKoFbW+WWCkGVTYo6hiE6Y VWXWVY359KrHGq9TYZAPJO3kBWGxwqtvTkV8OA3nAiP2a4trCbFxgi/Cn1lsfF2vrl7HuEGXvlI J9JEOD2ZUy3l9xajY89qg6Us3nS/E6S/9BL3AR6YTslqBc3g4TWd7u8E4OXDajuyZNS5WPfbtES cGl76WgXitBQ6ScvKAz7I3/op6aeqZnwl+vWGPGkku5BEMP/9u/Pns/4BW38JGmd9rJv6fgpw75 l4noDgGaBUZjPbvhtpCNu266GcIuZjREGxHbT42mbJcQCf9BhH4QjebrGYFc4XiTLtiL12sG2Lb wiH2A/Fkb2GgRXQnVd2oTcEpx0aPAu09Mqn0E3yNJzghCU3QTKYyFy/ILBaVyuvOujsdc39z/Pl UGcD39cVDUmjcL4fYoti+ZQL6IKnhUk7iTWzkzSor+aGy7ihb0B4sAOhHlGDXXsqeJuePcbfp/v ACInyCk/xwIXBGA== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 With the advent of directory leases, it's necessary to set the ->setlease() handler in directory file_operations to properly deny them. Fixes: e6d28ebc17eb ("filelock: push the S_ISREG check down to ->setlease h= andlers") Signed-off-by: Jeff Layton --- fs/9p/vfs_dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/9p/vfs_dir.c b/fs/9p/vfs_dir.c index e0d34e4e9076e3b1a6c5ed07a3e009a50c9fa2a9..af7f72abbb76aaff934b80d4002= f32e3b0d17b6d 100644 --- a/fs/9p/vfs_dir.c +++ b/fs/9p/vfs_dir.c @@ -242,6 +242,7 @@ const struct file_operations v9fs_dir_operations =3D { .iterate_shared =3D v9fs_dir_readdir, .open =3D v9fs_file_open, .release =3D v9fs_dir_release, + .setlease =3D simple_nosetlease, }; =20 const struct file_operations v9fs_dir_operations_dotl =3D { @@ -251,4 +252,5 @@ const struct file_operations v9fs_dir_operations_dotl = =3D { .open =3D v9fs_file_open, .release =3D v9fs_dir_release, .fsync =3D v9fs_file_fsync_dotl, + .setlease =3D simple_nosetlease, }; --=20 2.52.0 From nobody Sun Feb 8 02:56:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7639F33893D; Wed, 7 Jan 2026 14:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795643; cv=none; b=D6NtyiJOVK6wWVAJO9zdGZbqX8sbaBiMknNWAFF0Hval2e33aWApJFokXpobSLhZ0A0mBFpJMgI70sOV4jm1AR7redKWVI7SnE260tyM+X8PoZ0nZQOODeJYnm54k7iiYrXz4SulsFD2/hBZOmo0b6QM4j2CljZ166ZIIz8h/0I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795643; c=relaxed/simple; bh=WOObDB36kX8/qufFSII94oHmtu/aTYmL2lv+jov+ZmA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VniDj6Nctzy2wUzf6JpVpBzCcr6QnemOF3Qkv6A/zesGj3B1jDV4Hy2oOEoHMdjqQLx5ulaz78Ru+CPn+cUGdZRDNOjDVfidFYRdM69KgYkrFWWpiHPKsNWrvbClLZeMVMg2XpJ2NgdmR1RBf78CZnYmdp3qzNgojGiMCRgdCPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hW1hwBJ6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hW1hwBJ6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B210C19425; Wed, 7 Jan 2026 14:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767795643; bh=WOObDB36kX8/qufFSII94oHmtu/aTYmL2lv+jov+ZmA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hW1hwBJ6L2Sc82JMpAHppzOF/u4ORRMdsFEbffGaAz3eHHfJ/pKGliS1vbuNkRbzA CDG0x276T1iZUPAx/ygrRIZH4Z4ongqtKKs5I30tX9ZBoKHaU0UN60IWpPiQFwH1Yx YnD4xds5h9wih4LxizeNZQX0+udKbN5sQ+kL24T4cOnATEi2u/MPILScUOU7iM5uq3 Ag6oqPji7MyCVy5Iy3bcch7Vg8AMNjtN3LkANWa2Qvch1j9kRAj7VaqPIzPZMM2FlI 78QF41BB4zQMokBB9HkvcZv4dZAiGaXJH3maeYsyWZ1PZxBpRnKrJv8RdbfjTDuRyF fbLNJ2HT02c2A== From: Jeff Layton Date: Wed, 07 Jan 2026 09:20:12 -0500 Subject: [PATCH 4/6] gfs2: don't allow delegations to be set on directories Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260107-setlease-6-19-v1-4-85f034abcc57@kernel.org> References: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> In-Reply-To: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> To: Christian Brauner , Al Viro , Jan Kara , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Trond Myklebust , Anna Schumaker , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Andreas Gruenbacher , Xiubo Li , Ilya Dryomov , Hans de Goede , NeilBrown Cc: Christoph Hellwig , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, v9fs@lists.linux.dev, gfs2@lists.linux.dev, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=826; i=jlayton@kernel.org; h=from:subject:message-id; bh=WOObDB36kX8/qufFSII94oHmtu/aTYmL2lv+jov+ZmA=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBpXmusNiNlSlsI6aV6lp0Xi1SIcHsWJueGpuTVl eQ6zJd8vWmJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaV5rrAAKCRAADmhBGVaC FahPEACuMe99DApaXMxkgM0GK98+vE+ljpvVbIEq2apnJZzzAfT0hyf/6gvBJNqqPgdcwGOIL1N Ialp+dOG1L5LZ4z/T8xu2lCmwQ5ZFZwiqyomq1SJ61zt2xGJiYKufOA6M/fn1EPifLmJM28gijH 6U3tRVcffCpJDF0GGCvwkO1sVnIQzZDweIyiyXOv3bMIzYTidH7JgRtLOk9novnILuULmVNUmtl xu49xC/PrkkR9B2wto7SK2OWt4OPpTgJmpn002UwSOejzpH9MfAam6VxMQR1Jk56TID7BJZA4nJ EKEblKGq11SauGkJQB5Fm9inIwMzdw2Pmvj+0/z/VJhQQpjxY3UZTmNfF4ELGsHcEz9325r8ZSk nEUKDTf4v7IeupzNaRUmDsHgJi+mKJsc+w/PG7cR5P6NKXyG6VCmt+U4IeWPbJqzZRVBa43k8xu kVfYM2xu1j2OaO8ggJtf/u/50S72NZ4RW/RyFvFCxG0NMZ41hRm2BfcPeZXmL82aMXY4EyCxs9f J9GOEHg9Xia1+QtaJM8khb0pHiQKzSEDPiKm5F8UIZre9gbramIUQ3euPrvJugtOCf2lF4cWkSG MS+xHOVEAkdxuUKGpeKArHhvvJnOTHcqF0MdPMdJ4D/jaTHUsz6JO1SGGr4fxk84qJlU1KxCiFL /515RZqlOwF+x1w== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 With the advent of directory leases, it's necessary to set the ->setlease() handler in directory file_operations to properly deny them. In the "nolock" case however, there is no need to deny them. Fixes: e6d28ebc17eb ("filelock: push the S_ISREG check down to ->setlease h= andlers") Signed-off-by: Jeff Layton --- fs/gfs2/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index b2d23c98c996553ee14f1969638e709a3d7ede1c..86376f0dbf3a553375b0064c9a1= eff3bfa9651f5 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@ -1608,6 +1608,7 @@ const struct file_operations gfs2_dir_fops =3D { .lock =3D gfs2_lock, .flock =3D gfs2_flock, .llseek =3D default_llseek, + .setlease =3D simple_nosetlease, .fop_flags =3D FOP_ASYNC_LOCK, }; =20 --=20 2.52.0 From nobody Sun Feb 8 02:56:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E08FE335083; Wed, 7 Jan 2026 14:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795646; cv=none; b=k+bEaLvuSuPq7suJZn8l2FelzLxbUwU+v6uPHwP6Eoo9hDaYxyo6gO7Sq+Gh2qgdegQvck7It+VjFfyzvwVr+gTzmsdWLR3hn+UGYBf/g3zI/9aPw4AAxmgR/4AaQ3O1yp1Pj4FUe8wTN9UDgoAC4iBuNf0Tt4pa12BiJNJuAN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795646; c=relaxed/simple; bh=ds534lCWLHpMcwlbbHzQlr9A4OTNCTKxUOGRXEYJFsk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YYCtGYxB95KP4eVynLt1JBPUyC+Eq1ZBSUp+vZYV0B0dzNJD+kR6vHpJXhrTsmlKQeE0LZM6UfGxf6ninB4ErpZt4UBncwW8chs+Dbnk5lMXtDsg7qt8F6rF9T8/ZsXbNPLtGhddBq16qTDtK1QB33a1sCd4urhGHuzLN16Jed4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Om1avZwO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Om1avZwO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5187CC4CEF1; Wed, 7 Jan 2026 14:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767795645; bh=ds534lCWLHpMcwlbbHzQlr9A4OTNCTKxUOGRXEYJFsk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Om1avZwOyGZK1QoUdSEsiJgpPi472rFu0IAN0zkdiPMzJ4BvbGzfley1DhAWnG2C3 G8ixMQtZRot+v/5m1M65/j82ZHMJot75PhBjzpDgvuAxf34mTGPXUspjL+4GKB0kIr kGEmh5XKQtAt1CVCb6658nXe/efMrySPCMPVTWkfu0WXjz1MLfO6Lzo8gvwfT9SGOx urOznDaYtVu7VGDAoU76p+ThuRL6yCjktUyRTao58HrG3PGY2X2fPOM470qZix2muR EXaQwkL8xl2xUfJp+ugLsF2p2yeBLmyWCa4upLWY00jZy9e8T0kHiX9Wu2HLCLsx82 vLlA4XLdE9u7A== From: Jeff Layton Date: Wed, 07 Jan 2026 09:20:13 -0500 Subject: [PATCH 5/6] ceph: don't allow delegations to be set on directories Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260107-setlease-6-19-v1-5-85f034abcc57@kernel.org> References: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> In-Reply-To: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> To: Christian Brauner , Al Viro , Jan Kara , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Trond Myklebust , Anna Schumaker , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Andreas Gruenbacher , Xiubo Li , Ilya Dryomov , Hans de Goede , NeilBrown Cc: Christoph Hellwig , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, v9fs@lists.linux.dev, gfs2@lists.linux.dev, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1018; i=jlayton@kernel.org; h=from:subject:message-id; bh=ds534lCWLHpMcwlbbHzQlr9A4OTNCTKxUOGRXEYJFsk=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBpXmus9It2N5iLf/AgDcoMLsotEuVTaIoiBt4fz bKZ8HLxxsyJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaV5rrAAKCRAADmhBGVaC FQHeD/9txKErTu2VqtOJBvCZywuVpA7nlv7Mc+Nh5b9kO1zC+TXiaR/2dUGLqVEaj5MYbwfn+Ht 5yRd1VcJi2i1rHid8YpNOv7RZCrVcO/Mz+FnYuA0gVewTmN8agXMeAFtqt7QCaybU+0udZN/RkR snXrcKefpJ9N/qAVoDX/DZMuYWcJG144xBsX+/sVJMmOa+mhr7+WRfvBbObi3eQ0VymOUbEqe0r QYi12klOvTv6W3Q/Gwk5Ruo6SiMs3zeLsFAJAmv8scWkFdDe9ljZOdL/+BSYnRKjp21sENFkOps AbvtKNI5KgysVvY3+p+k+JiXsX9O+5UyVkhRjMdtcD9NLpdtfXX4OMDZ75jcujoNEPu9UH8/gxN GgxxZzuA9y/K60cSjgq7CohOuIeScQa224rO9fGpfo1A3gtqrz+erRgSivICligUaMi5zdoBQJ5 Ne6fzCv6W6LwubIif9qUZv/oNtoxsw2qlSRqTtYCpHyk9R4fgxAlLIfTahfapFrvAO8POJqEjCI Hp9SrkxNjYgq2yxzB+/sGct0LAfr4WhzE7Su6G6fmJFeZpHP9nnmE/f2j8KPBZ6crxn6CrPrvSf 5MXQXnMGDUZZViMBxOhhFiTo97cq8JZzdhhMjK8QaAT22o2AxgCelf/OABrLVSCy6H/FANcDjqk iYN6ErEMQ+lshww== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 With the advent of directory leases, it's necessary to set the ->setlease() handler in directory file_operations to properly deny them. Fixes: e6d28ebc17eb ("filelock: push the S_ISREG check down to ->setlease h= andlers") Signed-off-by: Jeff Layton Reviewed-by: Viacheslav Dubeyko --- fs/ceph/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index 86d7aa594ea99335af3e91a95c0a418fdc1b8a8a..804588524cd570078ba59bf38d2= 460950ca67daf 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c @@ -2214,6 +2214,7 @@ const struct file_operations ceph_dir_fops =3D { .fsync =3D ceph_fsync, .lock =3D ceph_lock, .flock =3D ceph_flock, + .setlease =3D simple_nosetlease, }; =20 const struct file_operations ceph_snapdir_fops =3D { @@ -2221,6 +2222,7 @@ const struct file_operations ceph_snapdir_fops =3D { .llseek =3D ceph_dir_llseek, .open =3D ceph_open, .release =3D ceph_release, + .setlease =3D simple_nosetlease, }; =20 const struct inode_operations ceph_dir_iops =3D { --=20 2.52.0 From nobody Sun Feb 8 02:56:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C50F0330337; Wed, 7 Jan 2026 14:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795649; cv=none; b=lDrAvATduEH2Dmo5BqYxe6FlZIg++2QkzJkyWkq8UODfB2xxtKU0cMe7BY7GO3lJh5SGmuavCvQpUnef7Uh8ZBV4Ub23eb6ooQswWsH+2RAzTEQSmiJYjZDW2PRCeCcQSLKg8QZLH/olTEfnsUkqyRe3MwokKwbuL9nT9WCfZuY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767795649; c=relaxed/simple; bh=swYePiPcFodsDh/67E0j7LPYSSE9pk5yCYXqd+3XH2Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tIOvyb6T9JkIWnK2R9YPqo8Pg2TiYxzVUn3yrJ2voEPeI4DRk8xlsFVifZhwDAZeduACyFjyB4lmzl2mLG5o0xTGL084Y1niZ0dHSNX13Ls4oPj+GQkZdCM3Wjlizfb8Jyk+EKtdbdiSnZlzOp2rFYLmh9i71fpIQGSa9hgByMk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AYpAl51z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AYpAl51z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07BB6C4CEF7; Wed, 7 Jan 2026 14:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767795648; bh=swYePiPcFodsDh/67E0j7LPYSSE9pk5yCYXqd+3XH2Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=AYpAl51zYcKM5SOyIjkH+SRS+s1SgwbK+zEYQJ3vsaYluDtz4qEDKpTsvxJhEXyYG UTSnn8T72uZwqIsFSSzWJpg7dyR9Ud+wjulGfX/BNnsSyQN5VqxkjvEzhOPn3xBvdS LCMFm8wgeJZkQ0wLlBejx6ZpSrSAlxbbusu4Shito0wZh5nQNt/BK383ps9t+ivcoy L8kbTGLPioQrGce25s9TlBD5CG9ZzO6VdZc7ulMRWtDD+/YBXOwhshvwLOZ28qOt0H BruLv4TMRys0iitPAaeXQMTLHu+22xZ12Cobm2cGS5HYrIfGgDLaMRR01oocXXlv2H gwgtatvghwDAg== From: Jeff Layton Date: Wed, 07 Jan 2026 09:20:14 -0500 Subject: [PATCH 6/6] vboxsf: don't allow delegations to be set on directories Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260107-setlease-6-19-v1-6-85f034abcc57@kernel.org> References: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> In-Reply-To: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> To: Christian Brauner , Al Viro , Jan Kara , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Trond Myklebust , Anna Schumaker , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Andreas Gruenbacher , Xiubo Li , Ilya Dryomov , Hans de Goede , NeilBrown Cc: Christoph Hellwig , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, v9fs@lists.linux.dev, gfs2@lists.linux.dev, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=759; i=jlayton@kernel.org; h=from:subject:message-id; bh=swYePiPcFodsDh/67E0j7LPYSSE9pk5yCYXqd+3XH2Y=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBpXmut4DdA0I/BS+hpNDcLM7DVrBk7ZZAAPZ+Zf eiWHvcBVXqJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaV5rrQAKCRAADmhBGVaC FQvRD/sHAd32Qf+FYYgxkOBSMrFu4x01VAu/CLJP7DaLx3Xn+Dv7QzwmKIVmYCMtXyFOxudfC8d 0/BRqz6PP8PrWIBv5t3/l82lbaOo2STYUwHroFqZyapkFfE3L91jt84YXiW59+896fVi+QUgKwK 25palCrATUG2xnKiUZZplJU9lXM62SDdqGM5DTVVvdEY0lwIi9fnv5eLDWr1NXBqFhJoxX4oh57 m6wxwDen/kPliwyNVHTNAT7djbqx4ldSz3C+CUaFplPlbh3L6KChKePwFXIo+4VC2UUv5Sdt1FP XBg16+mvp1o4LBlXH/CBTXcQz6/9KV0KouDjeMx2TXaqyawt+0Y5jYrH54EaZxIaEJGCn+EjbtO UajPiRYeCzAbSdZrtPa5ZRlFAl9Xq7Q/8hyB9+kHKcxF1xRt0uD32QQd0Vw/vx73njrWMml//qB ysVrjW5ZuhjRPbMmrqv/MNoPVZlRtCshC8RRTAD/adxKsAEIN4x2dQX0Ffcb8r4MVxzF1XcZeeu wW7pqzU7lgPfsaapcTDth0br9AAubLK1XZkgzhivEL0lxl+lzHEkyIcpOuqns+SO8FtTVyJpUoY IHKx4DSCl2GAL2qiCalTXVkr7WyaOgB5itY2mwVEBaKxnHyV/MvdPFoVxkqxeAWKLL+HKSJVNYS hxfwPgeRb504faQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 With the advent of directory leases, it's necessary to set the ->setlease() handler in directory file_operations to properly deny them. Fixes: e6d28ebc17eb ("filelock: push the S_ISREG check down to ->setlease h= andlers") Signed-off-by: Jeff Layton --- fs/vboxsf/dir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c index 42bedc4ec7af7709c564a7174805d185ce86f854..230d7589d15cc98f6bc7e930ba4= 0ca5f7dbf7e18 100644 --- a/fs/vboxsf/dir.c +++ b/fs/vboxsf/dir.c @@ -186,6 +186,7 @@ const struct file_operations vboxsf_dir_fops =3D { .release =3D vboxsf_dir_release, .read =3D generic_read_dir, .llseek =3D generic_file_llseek, + .setlease =3D simple_nosetlease, }; =20 /* --=20 2.52.0