From nobody Mon Feb 9 02:23:48 2026 Received: from mx0a-00015a02.pphosted.com (mx0a-00015a02.pphosted.com [205.220.166.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC50345749 for ; Tue, 6 Jan 2026 15:26:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.166.249 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767713184; cv=none; b=r/TABE+BnavCBlJvML36YQlKFKmqxmWE2nhpAKS0KzPHqsDn4gbqxPdg1l5CdiGzMIiNjEfEyZewa03LJJL7Mu9A+4T85m+5qISCZ19KsuS7XvbAtXdQBcTRSRLQes2mTciryCD9LAabr1bQ3Q0dur7bARW6iJnzdThJFrnE7vE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767713184; c=relaxed/simple; bh=QiOTvUPpuVa6Mguw0HLAgiHskC6kVX5FUsDm2wL5MAQ=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=rZY6eFH9anrTnlhtr5GhnGAgAUkbNmkffj59UMp6l/auKkn9ZCYn309mM87m1AT0l37XHtYDGTGzR5rM/iI2clmtlpPHbA0lle1Lsv7jJ8DpKS8wE2/lxoNR5P2EVvLHXP7YrsJeOE/9kzAsolY2snL5sUogEJYiGMvut1a2Kmc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=belden.com; spf=pass smtp.mailfrom=belden.com; dkim=pass (2048-bit key) header.d=belden.com header.i=@belden.com header.b=ssL0n1gP; arc=none smtp.client-ip=205.220.166.249 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=belden.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=belden.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=belden.com header.i=@belden.com header.b="ssL0n1gP" Received: from pps.filterd (m0264209.ppops.net [127.0.0.1]) by mx0a-00015a02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60681M2Y2776675; Tue, 6 Jan 2026 10:07:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=belden.com; h= content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=podpps1; bh=LltnVltnu8FNStGaEjXz0dSImeM9qSHjzea5M 2YlO98=; b=ssL0n1gPUZ02FdwJzyQkgphLYPoelsr6KokCi9I2QOz4HR7ZWNvt7 JDqu3zAHYRx6l4YM3S1bw1Af6GHNZete9wzXyngWdUEO6TELfHJcfu/CzJws29+P mxSX9iCXoNbsxGEwQV5uA6G6jPKvvF2bJcYH3FvmrMKh36lp/+9MJ0QR9ASk0KYG 4eWd4S5n+uloi7x++q9gOFDi5Htz+Kn3EOqZHOW93f5+AWUmgzjJ7Xkt5IZ5Lt3P HrPuBV9kCB9kA1IWqsAOc/AM+DJ/zWHzvDTYkwNBOmaEXZU6obgUbd4PmmxQT/eq Hs5I+899AxsGShN7xqxW4XgkerN1Bl5Kg== Received: from relay1.belden.com ([12.161.118.81]) by mx0a-00015a02.pphosted.com (PPS) with ESMTPS id 4bf0acnpa5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 06 Jan 2026 10:07:07 -0500 (EST) Received: from pps.filterd (dcric1ppa01pb.mcp.local [127.0.0.1]) by dcric1ppa01pb.mcp.local (8.18.1.2/8.18.1.2) with ESMTP id 6061qh1C030660; Tue, 6 Jan 2026 10:07:06 -0500 Received: from chbrn1rnd0001 ([10.1.2.194]) by dcric1ppa01pb.mcp.local (PPS) with ESMTPS id 4beyawu7sq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Jan 2026 10:07:06 -0500 (EST) Received: from chbrn1rnd0001.netmodule.intranet (chbrn1lab0001.netmodule.intranet [10.121.114.100]) by chbrn1rnd0001 (Postfix) with ESMTP id DA76F3A01D7; Tue, 6 Jan 2026 15:07:04 +0000 (UTC) From: Aleksandar Gerasimovski To: linux-kernel@vger.kernel.org, vkoul@kernel.org, kishon@kernel.org, aleksandar.gerasimovski@belden.com Subject: [PATCH] phy/marvell/phy-mvebu-cp110-utmi: fix dr_mode property read from dts Date: Tue, 6 Jan 2026 15:06:43 +0000 Message-Id: <20260106150643.922110-1-aleksandar.gerasimovski@belden.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601060131 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDEzMSBTYWx0ZWRfX4S9IN86MsO/c G8eTbnQ0KQy/KoZEW9lYi9eUqIihBa+WcTpOUNcRIO3iJL3Xhxolf72Ef/l1JwkTsSfGutOK72L hKhDgSp3pHkDDpED8x5x7fyUgjoVmRcWcuaWnAnV/kZV663elDtwqDBDA/KmDkeN1wJ8i0znJgE L1Waap0qQWQ3ezLOf0qQ+Bk2qH4fb8ZZeNw1RnDczThuiXW+CAcMaRiOKwUQIbNAweVBMn7X+Ya qMn9mfUC9yGhBj2Hc7ag+AW8tNSk7hL0BFHUb9AWm9bKiGRZH4c8uqdyutXHUTxwJj492VB3jIU 2F5iBBD01oge4iTKaYR7+b8CO0PA0Stq9TzssMwL4lKJYC/ffPR67jaD2M3+Wo4eaVHsJaUlZA/ 4hn51ZzRUI3TWAXGbjttWSzOuMCm3pjXTHgOS9hGVbEp0TWnWMjEiD4TGn0u8NE9VNaeUm1ZCFp 9WzAN4x3BPyRCFN8Whw== X-Authority-Analysis: v=2.4 cv=balmkePB c=1 sm=1 tr=0 ts=695d251c cx=c_pps a=cuOCxa8MntS3/AsasmU/aA==:117 a=cuOCxa8MntS3/AsasmU/aA==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=WDlp8lUfAAAA:8 a=lEBi6yjrif_4z9IrltkA:9 X-Proofpoint-ORIG-GUID: Sx0ywp3Hp8H5DY31qlQS1hkyPgxU9xtP X-Proofpoint-GUID: _IAmQ42Z_WGRxdWLO8ZamVHVT5MJ4yFa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 spamscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060131 X-Proofpoint-TriggeredRule: module.spam.rule.outbound_notspam Content-Type: text/plain; charset="utf-8" The problem with the current implementation is that it does not consider that the USB controller can have multiple PHY handles with different arguments count, as for example we have in our cn9131 based platform: "phys =3D <&cp0_comphy1 0>, <&cp0_utmi0>;". In such case calling "of_usb_get_dr_mode_by_phy" with -1 (no phy-cells) leads to not proper phy detection, taking the "marvell,cp110-utmi-phy" dts definition we can call the "of_usb_get_dr_mode_by_phy" with 0 (#phy-cells =3D <0>) and safely look for that phy. Signed-off-by: Aleksandar Gerasimovski --- drivers/phy/marvell/phy-mvebu-cp110-utmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/marvell/phy-mvebu-cp110-utmi.c b/drivers/phy/marve= ll/phy-mvebu-cp110-utmi.c index 59903f86b13f..dd3e515a8e86 100644 --- a/drivers/phy/marvell/phy-mvebu-cp110-utmi.c +++ b/drivers/phy/marvell/phy-mvebu-cp110-utmi.c @@ -338,7 +338,7 @@ static int mvebu_cp110_utmi_phy_probe(struct platform_d= evice *pdev) return -ENOMEM; } =20 - port->dr_mode =3D of_usb_get_dr_mode_by_phy(child, -1); + port->dr_mode =3D of_usb_get_dr_mode_by_phy(child, 0); if ((port->dr_mode !=3D USB_DR_MODE_HOST) && (port->dr_mode !=3D USB_DR_MODE_PERIPHERAL)) { dev_err(&pdev->dev, --=20 2.34.1 ********************************************************************** DISCLAIMER: Privileged and/or Confidential information may be contained in this message= . If you are not the addressee of this message, you may not copy, use or de= liver this message to anyone. In such event, you should destroy the message= and kindly notify the sender by reply e-mail. It is understood that opinio= ns or conclusions that do not relate to the official business of the compan= y are neither given nor endorsed by the company. Thank You.