From nobody Mon Feb 9 10:47:57 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C9E73346A5 for ; Tue, 6 Jan 2026 13:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767706850; cv=none; b=KehfzT4wZnkgAe2vLdBYHlqxWJVzNaN4pQPr5ee9I7V66ASAU2UVXedwDjtXTsPwiM3+8s+5VGsIzoH/pTvvGnBgggnLUn5whuy91cz5rX5IiYxcyqdB7EdtbL7B14UKkR/oGDJ19k3R+zFrX6r9YUQdiu0NYQlcmU7vlzU4ApQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767706850; c=relaxed/simple; bh=D1O+si2Yt1LHRX9ttPtLSW9kr0/xClDgoku245+GvJk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ixN/cqE6oOlVBK8aIkiE8ahBChdoARPCoMWcHXi2zw22kjjffBC6JGtD5cAmIpzMiYaEDMCoJCF/4kBAcmttcxEtr9AWUh0hl3q/wejb1RTVMtMePaC7zNelnVMdM2HIlk8gjCHKfS2nJV1nXe/mG5iVVtli/SOGFrG9dmI63bE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j3YtAs9g; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I4w8eqmW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j3YtAs9g"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I4w8eqmW" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 606BUxaW2253808 for ; Tue, 6 Jan 2026 13:40:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=09GkqJKtIHi QNekPzoYMiNgzGedCPpCvBabWAf+0JyA=; b=j3YtAs9g6P//wjdLTCBI+S0LuTf 3xUGxV6doPL/RJ4Mgt/thSTknnVQnsiZz5i0+Sht+U68PtMZxbKpv6dVmDBmOLCK +ns7n0RHlFXdQdJr2wk9Gye8sdRkA5xqdo99djDfvef+RvAUN1Ys41pWT4TIG1NA TBW3m4f3Pbjj+rQhiVLQhiIRWUplghJ6SoKsHZTSCISywTFr0dxPpUQY/dKmd9fG z0qyelCRbjBHC/pYj2kHrWbZTA1cEyR1wvXt8SsZtiYU50QcrSJo0gXYjwhaCj1z pvpntR127gTOg+x/c9JApkfbun3F5qaR02zNHKm7xyjEu0QoyUoKfFXCmWA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bgu421j3w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 13:40:40 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c904a1168so2321751a91.1 for ; Tue, 06 Jan 2026 05:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767706839; x=1768311639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=09GkqJKtIHiQNekPzoYMiNgzGedCPpCvBabWAf+0JyA=; b=I4w8eqmWjnKmUh8V0jmFpv5dvOs+duP0lA3eK0w8ZjyDhUWgGh8PytxMX/qxJjqcDB bObtb+3rx9JTjUov2xop+9Ad7gO/6/TluEzmVqGz22Fa8thIqEfHemXpNSZo5m5bFQ88 MB6QKMUuYV9xRfP5Sq85HVgeyUWaEbP3/+0u2vj2XXOjDAxTHa0VQp3vdEFJcqY+f91L p4CjQ1EuwcEQ1aa8ZOGCBlcjFGGWoAhsavNcuQU00uOJ/Fxoa+f2B9hxrAzyn4+BxjY5 j+F6G3UlX69gd9+RL+BhOD0Ant7JL68nzU7oUTw7E8RL2jbHjnm3T5OwWGrGb7nppGUs cVvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767706839; x=1768311639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=09GkqJKtIHiQNekPzoYMiNgzGedCPpCvBabWAf+0JyA=; b=fXK4rDXc2l5MzuMFGfDfFapigxJHsucjfoEUfwmu1XOGkyctQLJgVxBxshwe9Conno eZQ0l9Seerek5TWRbGJ87q0SQOODq6uqvSXmU75velM7I4F9dqVPR/l5v8tnrhckdhir U5M8uB1rrmUEx9OnwfgHwp8FbTyVajo7EeiECHgGYZW/w6MBRIEa/AjJpmu/gqmtm4LB lDsOdV3d5RHXqr4aoJY31mICWPFLabkYRsQbyPQbQJVPCpG298Jzd0783lGmE9iwgaPb Gwe0otQ+JsQzSnIaOI13U06fnOl3lBApmzNg8mFKfop8M7UqLIt91BdJIow17IS10Ukx 4r4w== X-Forwarded-Encrypted: i=1; AJvYcCWwuQHnwzO+4w0+L3o1pAlTrc37YykrQpzpvEGWyQWzRUy6SxrIpE1MPKBBel+0SkzUYTYSs6q5eYFHNhk=@vger.kernel.org X-Gm-Message-State: AOJu0YyAkXM+tIuMlrPwgIpOLKqUzc6aN5rQxXzatygOiqOjdkQsjigh CxKasNMCXFl36jJsc7qache4tuhOl4jHkSreEkkjXUhMMLAUtB+/EWGLfqPAQuHVDhL1/bfcVHe erzbhh7MUHnu/kdTOFNeWcSfc9GrAumRLMPikoPgUcavivs+VHMhnudryR/GViLvtgH4= X-Gm-Gg: AY/fxX6e7mFGLvaOX+RRChnqVFLEXzJApzXxMuIXjC8PRC1v6PzoCJFsYRIYNXg/aJH yTFBkvjlMfnSxyyiFL4SWfgfMSQUKbWjIUf7UcIyLgGHuT2FnimMIoPlzZInBsDqqIjSZovHdn1 cqPET8AKu37gUhS8i9fKej91iaC8O0pN7qeDqFbOxOjLaFFPolQ6DKSduZNeIIzXiER+3SW1dtS m0UzyHtI13r/NuFrin4aCG7xmNL4lH5rfPcJdmdyJYMav1uX1QmYR7Ox2r4AOWuPG2B0dA1R3p/ 85nwaukIKcRU9cS+9gj53kz4bOYGdUpOo6zxtBgHRsMU4k8D5Ep4z6WX0E1ik5MpgLtkcFGc2Mr TVeuseBltjBbEFXSI0zQZWyAvWdFkbAJfQsmwZP19 X-Received: by 2002:a17:903:3806:b0:2a0:afeb:fbb2 with SMTP id d9443c01a7336-2a3e2d5a034mr25572245ad.60.1767706838966; Tue, 06 Jan 2026 05:40:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0NLjFs+ONROrujGP8cMw4GV8fRDz387ZfduPT0onKmM4tZUyrM+9Z3Zo9EvL7UQbHurbRyw== X-Received: by 2002:a17:903:3806:b0:2a0:afeb:fbb2 with SMTP id d9443c01a7336-2a3e2d5a034mr25571965ad.60.1767706838430; Tue, 06 Jan 2026 05:40:38 -0800 (PST) Received: from hu-rdwivedi-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc7856sm24112515ad.68.2026.01.06.05.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 05:40:38 -0800 (PST) From: Ram Kumar Dwivedi To: mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, ram.dwivedi@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Anjana Hari , Shazad Hussain Subject: [PATCH V4 4/4] ufs: ufs-qcom: Add support for firmware-managed resource abstraction Date: Tue, 6 Jan 2026 19:10:08 +0530 Message-Id: <20260106134008.1969090-5-ram.dwivedi@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260106134008.1969090-1-ram.dwivedi@oss.qualcomm.com> References: <20260106134008.1969090-1-ram.dwivedi@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=dYuNHHXe c=1 sm=1 tr=0 ts=695d10d8 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=YNeBtJC1tzGph8_Y4V8A:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: S_HF10t5CUF5C86YwDK0dOSaLzxuSueJ X-Proofpoint-ORIG-GUID: S_HF10t5CUF5C86YwDK0dOSaLzxuSueJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDExOSBTYWx0ZWRfX8iq1W+ziA9dy 3XjNhHsb3Eot1GJvpfLIt5ZcvSegxGzfVPrqbXKcRQ80hbZZ8WlD6PKU3vdVF68Ha6igAQaLjVK qAvH93ofXkeOmqaEIDSpuGwplHiSuivHfRgGfQ9s6eOF8y5HcBAa6kYo5BoNG4bb+FDXXSrc1xn z8arGqGFad47OD61BvFipfsDrYw+aNZv5pV1HheaDuDYggfLNcGFVTbhWbaBLcA2zISZlegZISl mdF55Z3SIzv9i5m9QaqCqnqrrD4TBfpGVDRIrpJf1qgmrqgdzMMs8tICZDB19glvPUFt0UoWyqo 2ANkLbwn/AdqbZW7IYV7uuhIaE6nTLsY2ux6cOxJwOX2h06MRvOgASUD3LATmVQmUa36nENkSCR +MSrcC8z3Lo92RUJXl+RZgG1jKN4GN2CeIXTgPA6+zEQgBxyTNQykiu2QeUbzWVum88fRfQOVGF 8di7FyqyUbpmiF4oMDQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060119 Content-Type: text/plain; charset="utf-8" Add a compatible string for SA8255p platforms where resources such as PHY, clocks, regulators, and resets are managed by firmware through an SCMI server. Use the SCMI power protocol to abstract these resources and invoke power operations via runtime PM APIs (pm_runtime_get/put_sync). Introduce vendor operations (vops) for SA8255p targets to enable SCMI- based resource control. In this model, capabilities like clock scaling and gating are not yet supported; these will be added incrementally. Co-developed-by: Anjana Hari Signed-off-by: Anjana Hari Co-developed-by: Shazad Hussain Signed-off-by: Shazad Hussain Signed-off-by: Ram Kumar Dwivedi --- drivers/ufs/host/ufs-qcom.c | 164 +++++++++++++++++++++++++++++++++++- drivers/ufs/host/ufs-qcom.h | 1 + 2 files changed, 164 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 8ebee0cc5313..ddca7b344642 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -619,6 +620,27 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *= hba, return err; } =20 +static int ufs_qcom_fw_managed_hce_enable_notify(struct ufs_hba *hba, + enum ufs_notify_change_status status) +{ + struct ufs_qcom_host *host =3D ufshcd_get_variant(hba); + + switch (status) { + case PRE_CHANGE: + ufs_qcom_select_unipro_mode(host); + break; + case POST_CHANGE: + ufs_qcom_enable_hw_clk_gating(hba); + ufs_qcom_ice_enable(host); + break; + default: + dev_err(hba->dev, "Invalid status %d\n", status); + return -EINVAL; + } + + return 0; +} + /** * ufs_qcom_cfg_timers - Configure ufs qcom cfg timers * @@ -789,6 +811,38 @@ static int ufs_qcom_resume(struct ufs_hba *hba, enum u= fs_pm_op pm_op) return ufs_qcom_ice_resume(host); } =20 +static int ufs_qcom_fw_managed_suspend(struct ufs_hba *hba, enum ufs_pm_op= pm_op, + enum ufs_notify_change_status status) +{ + struct ufs_qcom_host *host =3D ufshcd_get_variant(hba); + + if (status =3D=3D PRE_CHANGE) + return 0; + + if (hba->spm_lvl !=3D UFS_PM_LVL_5) { + dev_err(hba->dev, "Unsupported spm level %d\n", hba->spm_lvl); + return -EINVAL; + } + + pm_runtime_put_sync(hba->dev); + + return ufs_qcom_ice_suspend(host); +} + +static int ufs_qcom_fw_managed_resume(struct ufs_hba *hba, enum ufs_pm_op = pm_op) +{ + struct ufs_qcom_host *host =3D ufshcd_get_variant(hba); + int err; + + err =3D pm_runtime_resume_and_get(hba->dev); + if (err) { + dev_err(hba->dev, "PM runtime resume failed: %d\n", err); + return err; + } + + return ufs_qcom_ice_resume(host); +} + static void ufs_qcom_dev_ref_clk_ctrl(struct ufs_qcom_host *host, bool ena= ble) { if (host->dev_ref_clk_ctrl_mmio && @@ -1421,6 +1475,55 @@ static void ufs_qcom_exit(struct ufs_hba *hba) phy_exit(host->generic_phy); } =20 +static int ufs_qcom_fw_managed_init(struct ufs_hba *hba) +{ + struct device *dev =3D hba->dev; + struct ufs_qcom_host *host; + int err; + + host =3D devm_kzalloc(dev, sizeof(*host), GFP_KERNEL); + if (!host) + return -ENOMEM; + + host->hba =3D hba; + ufshcd_set_variant(hba, host); + + ufs_qcom_get_controller_revision(hba, &host->hw_ver.major, + &host->hw_ver.minor, &host->hw_ver.step); + + err =3D ufs_qcom_ice_init(host); + if (err) + goto out_variant_clear; + + ufs_qcom_get_default_testbus_cfg(host); + err =3D ufs_qcom_testbus_config(host); + if (err) + /* Failure is non-fatal */ + dev_warn(dev, "Failed to configure the testbus %d\n", err); + + hba->caps |=3D UFSHCD_CAP_WB_EN; + + ufs_qcom_advertise_quirks(hba); + host->hba->quirks &=3D ~UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH; + + hba->pm_lvl_min =3D UFS_PM_LVL_5; + hba->spm_lvl =3D hba->rpm_lvl =3D hba->pm_lvl_min; + + ufs_qcom_set_host_params(hba); + ufs_qcom_parse_gear_limits(hba); + + return 0; + +out_variant_clear: + ufshcd_set_variant(hba, NULL); + return err; +} + +static void ufs_qcom_fw_managed_exit(struct ufs_hba *hba) +{ + pm_runtime_put_sync(hba->dev); +} + /** * ufs_qcom_set_clk_40ns_cycles - Configure 40ns clk cycles * @@ -1950,6 +2053,39 @@ static int ufs_qcom_device_reset(struct ufs_hba *hba) return 0; } =20 +/** + * ufs_qcom_fw_managed_device_reset - Reset UFS device under FW-managed de= sign + * @hba: pointer to UFS host bus adapter + * + * In the firmware-managed reset model, cold boot power-on is handled + * automatically by the PM domain framework during SCMI protocol init, + * before ufshcd_device_reset() is reached. For subsequent resets + * (such as suspend/resume or recovery), the UFS driver must explicitly + * invoke PM runtime operations to reset the subsystem. + * + * Return: 0 on success or a negative error code on failure. + */ +static int ufs_qcom_fw_managed_device_reset(struct ufs_hba *hba) +{ + static bool is_boot =3D true; + int err; + + /* Skip reset on cold boot; perform it on subsequent calls */ + if (is_boot) { + is_boot =3D false; + return 0; + } + + pm_runtime_put_sync(hba->dev); + err =3D pm_runtime_resume_and_get(hba->dev); + if (err < 0) { + dev_err(hba->dev, "PM runtime resume failed: %d\n", err); + return err; + } + + return 0; +} + static void ufs_qcom_config_scaling_param(struct ufs_hba *hba, struct devfreq_dev_profile *p, struct devfreq_simple_ondemand_data *d) @@ -2229,6 +2365,20 @@ static const struct ufs_hba_variant_ops ufs_hba_qcom= _vops =3D { .freq_to_gear_speed =3D ufs_qcom_freq_to_gear_speed, }; =20 +static const struct ufs_hba_variant_ops ufs_hba_qcom_sa8255p_vops =3D { + .name =3D "qcom-sa8255p", + .init =3D ufs_qcom_fw_managed_init, + .exit =3D ufs_qcom_fw_managed_exit, + .hce_enable_notify =3D ufs_qcom_fw_managed_hce_enable_notify, + .pwr_change_notify =3D ufs_qcom_pwr_change_notify, + .apply_dev_quirks =3D ufs_qcom_apply_dev_quirks, + .fixup_dev_quirks =3D ufs_qcom_fixup_dev_quirks, + .suspend =3D ufs_qcom_fw_managed_suspend, + .resume =3D ufs_qcom_fw_managed_resume, + .dbg_register_dump =3D ufs_qcom_dump_dbg_regs, + .device_reset =3D ufs_qcom_fw_managed_device_reset, +}; + /** * ufs_qcom_probe - probe routine of the driver * @pdev: pointer to Platform device handle @@ -2239,9 +2389,16 @@ static int ufs_qcom_probe(struct platform_device *pd= ev) { int err; struct device *dev =3D &pdev->dev; + const struct ufs_hba_variant_ops *vops; + const struct ufs_qcom_drvdata *drvdata =3D device_get_match_data(dev); + + if (drvdata && drvdata->vops) + vops =3D drvdata->vops; + else + vops =3D &ufs_hba_qcom_vops; =20 /* Perform generic probe */ - err =3D ufshcd_pltfrm_init(pdev, &ufs_hba_qcom_vops); + err =3D ufshcd_pltfrm_init(pdev, vops); if (err) return dev_err_probe(dev, err, "ufshcd_pltfrm_init() failed\n"); =20 @@ -2269,10 +2426,15 @@ static const struct ufs_qcom_drvdata ufs_qcom_sm855= 0_drvdata =3D { .no_phy_retention =3D true, }; =20 +static const struct ufs_qcom_drvdata ufs_qcom_sa8255p_drvdata =3D { + .vops =3D &ufs_hba_qcom_sa8255p_vops +}; + static const struct of_device_id ufs_qcom_of_match[] __maybe_unused =3D { { .compatible =3D "qcom,ufshc" }, { .compatible =3D "qcom,sm8550-ufshc", .data =3D &ufs_qcom_sm8550_drvdata= }, { .compatible =3D "qcom,sm8650-ufshc", .data =3D &ufs_qcom_sm8550_drvdata= }, + { .compatible =3D "qcom,sa8255p-ufshc", .data =3D &ufs_qcom_sa8255p_drvda= ta }, {}, }; MODULE_DEVICE_TABLE(of, ufs_qcom_of_match); diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h index 380d02333d38..1111ab34da01 100644 --- a/drivers/ufs/host/ufs-qcom.h +++ b/drivers/ufs/host/ufs-qcom.h @@ -313,6 +313,7 @@ struct ufs_qcom_host { struct ufs_qcom_drvdata { enum ufshcd_quirks quirks; bool no_phy_retention; + const struct ufs_hba_variant_ops *vops; }; =20 static inline u32 --=20 2.34.1