From nobody Sat Feb 7 17:56:00 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 214F529B8E6 for ; Tue, 6 Jan 2026 09:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767692946; cv=none; b=YvXgO24oIR4dcJHZV4qwIoStunSF8IQUo+GoQfcx04nuD9m1HrOQUkRvmRAhvMKL28AvvYrcqQenHrV1t1zkV9FVA8mub4pn9t2IYGSxgoiCTMj1kb4U+hm6JYv+ZhN0vb2bsi6LnBkzbuMd7zDZSAggeuKReOBvA8e75V6U40k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767692946; c=relaxed/simple; bh=93sInUW9zEA86TJ92/hM/OPNM3sAV6MsWLI7AyWVdm0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V63CC6mikVYOJ9EFO8P1k8soDLok6+es7xKEdpcubROMF3XRJGh05KPNlSJiWtzbaSi2A2Re1ysTYu2kXz+cvUA/qmIJq0h6J/lYyRwZsmI2GAX7SbSlZ+p9/KuaYw1sLoee1swEh4zdj7Ob1sznIdaRcquKMYPDJL1HWgS0vSA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bGhsONEx; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bGhsONEx" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4779b49d724so1189875e9.0 for ; Tue, 06 Jan 2026 01:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767692943; x=1768297743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZdSCrn+/q0mZzBSTq1BS80pekWEZnQx2RMu8OndDeLE=; b=bGhsONExMOpFHhfHnDMLcWiwayhtQNSdJy4aiS0mU0IdC2lwyz4oLSeALwwYqQD6/v 2byTyN6a0YyQ+6LhNRzi0XA82d2qVgUf5gPlVXjC4oQu6WzRqDZ6mD2+PKMbFm7p8fRb U+qbnjJB7Dc/W9uAbHukmnzp1sWDlrHyeug9PMUDQEsPhHXPoLKTwfVscZmH6PlEaMaV ayp8O3P//GMPSjWjjTCaaPJG0whykLwnLit0pXd3Fbct6WHjWAndXnFyA6wSyCxRF0vQ f+iEbphTz6Ofarb4+3UPImOENEl1F5PnlRjlJX3iJI5zv5Zw/DJn0MZlSkUtnbqes0GX +D2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767692943; x=1768297743; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZdSCrn+/q0mZzBSTq1BS80pekWEZnQx2RMu8OndDeLE=; b=GR6hE3n8gOSXuSBwYxIA6FWSJJ1fxIJ8ax6cypboi2HXjxDNBgFzaRSbgZryJ+s9IK O1cpprTlWLokq3i5ds8wKxfZNE/sW7nIVkor5Goy5bWVWU5l+AGRccZIVS6j203Z6Ewu lO7TGT8cEuG/dNloadpLpK8nKqFkseuER64dgHupEYjijic07oojeEuf+mty9EeJ586S AufSqXKauFGdgJcXSSr9lESyKLHN1rnX+BnFL38dZmoxaKVnDaSRXIqz8jiSpRPhg5n7 zC6fkJfrDYEBsUBVUUA0bPk/c4JF7hfjHBFpB8/YS2YNIKObAFCRMDxjAx6bHWJTAKcF lCGA== X-Forwarded-Encrypted: i=1; AJvYcCWoAqRhj0oHeqZhanIzvoO3RrnhLQHr9m0sc9G+eUgTvFPe0vWygvWdIv0rt81DSoekxWI3D0oi1G99Mxs=@vger.kernel.org X-Gm-Message-State: AOJu0YwgBZePLHKBokF1qXUrVH83OiTb3BA71KBm47a5FJTrhW+gTcx3 EghZEWk7H4oaUBbxx+2oDkmrNCT6LGfkBIJl2sr3yHrTkhfr1hCAWsOg X-Gm-Gg: AY/fxX6CHXftbTGjns4hrQntPX/vmDLZEuVQygEk5vuqe19DwLXdLm+x2ClKXaQcwia qE4XMJlqpyhnD/ifYOxd24GxZ1akc+XN3dy6jS1SAfvHse5oj82jCnjd0nupxwH2tHH5vUqJoLU NzBRMzhnntCJhitNVxTVMzp8vu8tkwSz93MC64FI8N4cIzcUNkM/B+n4TwIISBQF8AvTKXeUk+1 +jq8RVNi7cdfDIaU5SyuDQNIby8eCWWolvXaygdiB76P4lpuCaAeEQjuOjyj/CA+36fHivQSfo2 L9Myl5nNAZaKvHX7wiQwMdcmKbbN1s8Ee/b1CgdizMVgv98AhFCT20ZyzcL+gUfy7Ue3WQg8CAK hbyHxdILyiJ6cwk1bFqAiJIBgwHrfTFRi2lgafNJFu5ZZjPN+5FNixr+38WeurdUiCQn7+M8Qgf aOcfyIrSy17PQ9uFOOkPAuY0E7b+O1IvfdQUUOtnus1kKR5tMbJxs7zGG6oPXrBtPIY3NAhdimK T3IqkE= X-Google-Smtp-Source: AGHT+IEx2UdQuxi7Q30O0PMFfygpPYTxnIeUBD5iNPkUORydOgAHKzsNi0xUzYgshQ1Av83QPmgZtw== X-Received: by 2002:a05:6000:2883:b0:429:d084:d210 with SMTP id ffacd0b85a97d-432bc97d535mr2100593f8f.0.1767692943323; Tue, 06 Jan 2026 01:49:03 -0800 (PST) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-83-215.paris.inria.fr. [128.93.83.215]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-432bd5edd51sm3330081f8f.29.2026.01.06.01.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 01:49:03 -0800 (PST) From: Thomas Fourier To: Cc: Thomas Fourier , stable@vger.kernel.org, Steffen Klassert , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ingo Molnar , Thomas Gleixner , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] net: 3com: 3c59x: fix possible null dereference in vortex_probe1() Date: Tue, 6 Jan 2026 10:47:21 +0100 Message-ID: <20260106094731.25819-2-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pdev can be null and free_ring: can be called in 1297 with a null pdev. Fixes: 55c82617c3e8 ("3c59x: convert to generic DMA API") Cc: Signed-off-by: Thomas Fourier --- drivers/net/ethernet/3com/3c59x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/= 3c59x.c index 8c9cc97efd4e..4fe4efdb3737 100644 --- a/drivers/net/ethernet/3com/3c59x.c +++ b/drivers/net/ethernet/3com/3c59x.c @@ -1473,7 +1473,7 @@ static int vortex_probe1(struct device *gendev, void = __iomem *ioaddr, int irq, return 0; =20 free_ring: - dma_free_coherent(&pdev->dev, + dma_free_coherent(gendev, sizeof(struct boom_rx_desc) * RX_RING_SIZE + sizeof(struct boom_tx_desc) * TX_RING_SIZE, vp->rx_ring, vp->rx_ring_dma); --=20 2.43.0