From nobody Sun Feb 8 04:13:21 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C586530B536 for ; Tue, 6 Jan 2026 09:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767690022; cv=none; b=YiQIVAhA5b7y57/LaoCJvFGcnwoe/w+R9yzBXHZDkV4ZS8KnOwj3RPEMd7dNaau85Q8a1gZPYvOCFii0U4Bhk1pyp2FnHqnrQQnd3YrOon0OGr1xkym8hx43u8yT4aJebTwSajx81vKE2aFAZT425ObsxYtB/V/IPq5V8OxW0f4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767690022; c=relaxed/simple; bh=w/A977JRSXpQfJbkXr/2XYvk5k4zy1OWbRcWorwj+Ew=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CPHhtN8kPleCXlZJEG11xH5+RGvhwH1fHeNKVQHjXyt8zBQFq1ZU2LIGHzdnJPYfFeNR7ayp7u9bcBLs1wtVeMbZdvs4V1HEKtsivHxepm6orGxLyHFR5CCVV4WvKT1H8S4P04BwaJ1f8GRLfsOkMiz5zSnD5sZIFGj/NXDTRhI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dJnxGMIA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VY8qFCPz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dJnxGMIA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VY8qFCPz" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6063Q1eY2429743 for ; Tue, 6 Jan 2026 09:00:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=zUmJx583wbIqbI/LnTq2qTUX5b+XpJNoiwx n1/rffoo=; b=dJnxGMIAyzB4PbZ6MmAJk5BnLsOhqj3GNT0QhtWZwCRCaqKJRyo 6gq39vnXnOoszTprusZdSQL7N/GxoWO5RS9W5SnB2Z9bxmRCpjhCoC9moTOqLTr6 Fe2SeWLCLC4YJ02HHKQZAmM1d3akRT4yENG52WyILRPHnGuOwmnTbyiMAmNiUD7j ieO4CHSTVkN358A4ndSushtRNHzpfeV2LqwAvWZQB1/6ejtK+iUYwPu6UCD7CNyQ br1CenYNR/qi9jiaduj5bezt5X6D66XZmWNnEbWiKkciWL7JMa82Li/zAFek3qMV BEIbxe3e8DaH/hDao5i2C070EB0MFnYmgyQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bgr73984c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 09:00:20 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88a3356a310so17849186d6.3 for ; Tue, 06 Jan 2026 01:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767690019; x=1768294819; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zUmJx583wbIqbI/LnTq2qTUX5b+XpJNoiwxn1/rffoo=; b=VY8qFCPzXV05Qp9awzLoe9CBveVbC+k9qPLuAEv+qk0mlCoDwlzVR0PpawRnkh2MOk i52X36gzJ1jM8AtxgXUGvzJGlKvegl9B7+4ewOQp2Joq5arFQxoGciezyJF3Eh+Ib1L1 2rGuDz4c6W1IUR8rT4EaRYprSDQAGm/9GOUez9Yrr6/fnxB095dgvT6ng84euwvPwogU 0WKQKPF8Ch/z1/YQDrpCXieX/AhYgc5TprYV1/57oAmPIAkUZBYiGzOyBEpvK36UURVP TtQuQiYn1CMqudJhkbDsW+AJgyNTFvHW2/szp2yxUbc6ur/eTCmjcQeleCHfKTLKvjUW oKUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767690019; x=1768294819; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zUmJx583wbIqbI/LnTq2qTUX5b+XpJNoiwxn1/rffoo=; b=g9Tq6zeOKT1Sg5TLvG2Y8zGKu4Lwxmg5U8QpLyQ6SXT4eka2GM1IEkkP6Uo2SB5zWD k8iqehx81DdwnHsT0NMleXfWwp/cFJqSsV46HJeZ4QWSoHvoV2Ua3eHoHDnzGfXEbabc 9/lhnrqquLo3iOTlERTnZs4rVniiLfL44oaCbiG54UaYu/CkS7auJcaR257lXEb5OkvY V9Hpi4R2BEHAr/nCAlNj/CgmP6nzq/eRBV7dhtfUsniKFAGQ9OJ1H0eGoWvxaz5K0fgs bjL30RRTAfA/lOUpBrOALkHpYYaUUwiYfZv49JY5bELiUahiInN2OVjcxSx0mBYPHGzM SjAw== X-Forwarded-Encrypted: i=1; AJvYcCV6bR7fJJx2TlluprFaQHdhioXN3I/AtWYdpvSJKiIsMV8U2B2E7MsLMH1Hyh0RvJH/A2qpImjP8Y/5VnY=@vger.kernel.org X-Gm-Message-State: AOJu0YzpSZDufjoCl7BhJg908ON4GnE1cHcj3kX9NidBJn04AjHeExrM HlOqsXpTvv2jIrC7WjjTZfGz1xXFK+MUa5XCv/vE4sLiCqQy5IAB3JStxmkHFVG7u482l0rD0jR vXbuMXhNcpGZvGXgNjUxACh+qutQ0cTuwR9cF5pe/Bqav7JG+c7WvkR0jKqBNIWk8atc= X-Gm-Gg: AY/fxX4RZi6VbXPIuBnCE6oQU5BBxplrGIe7XIrTw+1h1ZLE8WuIpiS2R+aGWcY1jiJ 40XFZbPZ62BnXG4azcAQJ8TcxUOKFMPPPXlIxYzuurTNg1PT5WwPI4ltMyNAHZXUX1saSVMMQbA 71afmZal3bTbOEhaCzeFfIgohSznDejiMAZPH/GP0gDM+5cnJ+2AGwBKk3c4jxTpf6/yqRrV5gr u7tW1LhJE+U3FVM7GaN4zEZlsi5ztQi+AzbkoFyMS/Gt3muoo9PDwNT9fTWGYXZ/n8ST8TdiItw uwvISdMbABd2OFqle3NC5/esJ1S1SnL0HbkLxCKq8WSQPpQS8yVxHj0sPWdN5Ie1b6dZwKcLWwa S26fVYuHrEMGClxQEHtYp9dhGNZ0fE3KGQ7mo+mw= X-Received: by 2002:a05:622a:4d98:b0:4f1:b398:551f with SMTP id d75a77b69052e-4ffa77f6136mr26639901cf.68.1767690018490; Tue, 06 Jan 2026 01:00:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiDIRIh0uRsi01LsmTGYlRfJRiytQ0H19Dw+EIaGym4rEAY4QFPoKpFGj+0y75JD3JHMf/gg== X-Received: by 2002:a05:622a:4d98:b0:4f1:b398:551f with SMTP id d75a77b69052e-4ffa77f6136mr26639491cf.68.1767690018029; Tue, 06 Jan 2026 01:00:18 -0800 (PST) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:a1e5:bc32:d004:3d67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ff319sm3196825f8f.43.2026.01.06.01.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 01:00:17 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Bartosz Golaszewski , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org, Marek Szyprowski Subject: [PATCH] gpio: rockchip: mark the GPIO controller as sleeping Date: Tue, 6 Jan 2026 10:00:11 +0100 Message-ID: <20260106090011.21603-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=QrxTHFyd c=1 sm=1 tr=0 ts=695ccf24 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=hD80L64hAAAA:8 a=EUspDBNiAAAA:8 a=-jpIsuwBRm6Qzzl2v0IA:9 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-ORIG-GUID: QBgW2yOL-vM7YG0ZR-Vzl8cAgf9sCIbk X-Proofpoint-GUID: QBgW2yOL-vM7YG0ZR-Vzl8cAgf9sCIbk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDA3NSBTYWx0ZWRfX/AbFeF3YKfYF 8mWlCAVuUglrE46ihfHYyJM2veNn2pWiUL9MwHZ1WH5c7fPzzzXK0wOsMDpZPKr3GNYjc0Rob23 e80Z25Hlnr3T9RpLd27zmiMP4ydf6IhyZpdK+3sBWaR4YyB/Su+lLwD43UjLdDQdqsdkcMhg2fd fNusxSLCEuk+z+nuY1WyLIDxIc/keqwBh3sJUOTawbJML85UU9DL1druNR/U5ia7dQC0ybyosM3 MAO5UtyrzU3X/gC0qbYGu45J/d+MpSBT37rRWPnOLTF13Ii7pk7a9b349GRHYDy6DXhSk5pHru7 HBclXDF7O4I+9kAyYq5JwKGsxT7lehYR6veD/gGp0jb4mbIG4UAxMy0bhpDS6cJnRgSgHccEWVB YgSTDrqBQzUgX4YMKtcXM5D4azR5fGFDbwvXBOB1Ii7YyBHoryzwqUUxMEhT3ZuQuKoqo6TDfw5 ZMu7txFDsYfBFxTakOQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_02,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060075 Content-Type: text/plain; charset="utf-8" The GPIO controller is configured as non-sleeping but it uses generic pinctrl helpers which use a mutex for synchronization. This can cause the following lockdep splat with shared GPIOs enabled on boards which have multiple devices using the same GPIO: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:591 in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 12, name: kworker/u16:0 preempt_count: 1, expected: 0 RCU nest depth: 0, expected: 0 6 locks held by kworker/u16:0/12: #0: ffff0001f0018d48 ((wq_completion)events_unbound#2){+.+.}-{0:0}, at: process_one_work+0x18c/0x604 #1: ffff8000842dbdf0 (deferred_probe_work){+.+.}-{0:0}, at: process_one_work+0x1b4/0x604 #2: ffff0001f18498f8 (&dev->mutex){....}-{4:4}, at: __device_attach+0x38/0x1b0 #3: ffff0001f75f1e90 (&gdev->srcu){.+.?}-{0:0}, at: gpiod_direction_output_raw_commit+0x0/0x360 #4: ffff0001f46e3db8 (&shared_desc->spinlock){....}-{3:3}, at: gpio_shared_proxy_direction_output+0xd0/0x144 [gpio_shared_proxy] #5: ffff0001f180ee90 (&gdev->srcu){.+.?}-{0:0}, at: gpiod_direction_output_raw_commit+0x0/0x360 irq event stamp: 81450 hardirqs last enabled at (81449): [] _raw_spin_unlock_irqrestore+0x74/0x78 hardirqs last disabled at (81450): [] _raw_spin_lock_irqsave+0x84/0x88 softirqs last enabled at (79616): [] __alloc_skb+0x17c/0x1e8 softirqs last disabled at (79614): [] __alloc_skb+0x17c/0x1e8 CPU: 2 UID: 0 PID: 12 Comm: kworker/u16:0 Not tainted 6.19.0-rc4-next-20260105+ #11975 PREEMPT Hardware name: Hardkernel ODROID-M1 (DT) Workqueue: events_unbound deferred_probe_work_func Call trace: show_stack+0x18/0x24 (C) dump_stack_lvl+0x90/0xd0 dump_stack+0x18/0x24 __might_resched+0x144/0x248 __might_sleep+0x48/0x98 __mutex_lock+0x5c/0x894 mutex_lock_nested+0x24/0x30 pinctrl_get_device_gpio_range+0x44/0x128 pinctrl_gpio_direction+0x3c/0xe0 pinctrl_gpio_direction_output+0x14/0x20 rockchip_gpio_direction_output+0xb8/0x19c gpiochip_direction_output+0x38/0x94 gpiod_direction_output_raw_commit+0x1d8/0x360 gpiod_direction_output_nonotify+0x7c/0x230 gpiod_direction_output+0x34/0xf8 gpio_shared_proxy_direction_output+0xec/0x144 [gpio_shared_proxy] gpiochip_direction_output+0x38/0x94 gpiod_direction_output_raw_commit+0x1d8/0x360 gpiod_direction_output_nonotify+0x7c/0x230 gpiod_configure_flags+0xbc/0x480 gpiod_find_and_request+0x1a0/0x574 gpiod_get_index+0x58/0x84 devm_gpiod_get_index+0x20/0xb4 devm_gpiod_get_optional+0x18/0x30 rockchip_pcie_probe+0x98/0x380 platform_probe+0x5c/0xac really_probe+0xbc/0x298 Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio") Cc: stable@vger.kernel.org Reported-by: Marek Szyprowski Closes: https://lore.kernel.org/all/d035fc29-3b03-4cd6-b8ec-001f93540bc6@sa= msung.com/ Signed-off-by: Bartosz Golaszewski Acked-by: Heiko Stuebner --- drivers/gpio/gpio-rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 47174eb3ba76..bae2061f15fc 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -593,6 +593,7 @@ static int rockchip_gpiolib_register(struct rockchip_pi= n_bank *bank) gc->ngpio =3D bank->nr_pins; gc->label =3D bank->name; gc->parent =3D bank->dev; + gc->can_sleep =3D true; =20 ret =3D gpiochip_add_data(gc, bank); if (ret) { --=20 2.47.3