From nobody Sat Feb 7 09:59:10 2026 Received: from mail-qv1-f100.google.com (mail-qv1-f100.google.com [209.85.219.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9E6E21C16A for ; Tue, 6 Jan 2026 00:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767661099; cv=none; b=INKlto5fVt+bws962ILWHgvaaEETBG+ltxiqR6AQ+xt5YtfsJPu+9D1yoql2pUMy1Zwsu/XVwtmxQb3jIG7A82BR/S53fTCn1dVXtb926ndFDP3VcEwzjYSUK411IT7Jvm9EvvmUBzZv5TydhcJ+hssY1WU/unAY69/SriieiDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767661099; c=relaxed/simple; bh=FpSk9SBO7a8fTola1zwsU8+516cI+0H9/8WbLKjGV0Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BHVQyL5LCFNSVTvV2Xc1HNY0iEii98NUmt9K5KKS/toE1BpZvUsY3qQHd/LMU0/xfKpsq1j0slzBVFpJ2tzIsLpwN4SjZMQoD7WHe3qzRkM8HheRZlzX/3y037A4iphan36jrx2oM0duFV3yupJSl0QWKcWw7r3bNfJz4+RcPY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=LGcaG0XY; arc=none smtp.client-ip=209.85.219.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="LGcaG0XY" Received: by mail-qv1-f100.google.com with SMTP id 6a1803df08f44-88a43bfacb2so561746d6.0 for ; Mon, 05 Jan 2026 16:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1767661092; x=1768265892; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zdwpGAzUowZ3h68lzOUG2hhVHWdUBrDTU/ZZOy1LyBQ=; b=LGcaG0XYIdxQstnTwYEDXzPqNmcfkhEnx32a1N9Az6x/y/Muv2t7Kx8x9Ft79tsKum PzEXKqt9yLndcefuHKJt1gJ/XT3dAkPbPcz8P+ryWa1Y011R+8A25m8CkZst+WZWpmPw YtEAX4zfoO9LZE7DNO1+JbaD0QqiHbFYVSKj2+oXVId9+zsFDyQrdMsLRwrRDzr+XeA4 ZBbmKcIfP+Y3kutivmL4OqI1REp6vxdYbZFH+DX5wrzs09jwpCnrnacjjy7PljZjDHGn +3WgV5D8mvrx/isuyhLoApQrsc0gqLf4Z7OTGSgSiYuRtfIs97Oequed8xNAUxeyZ9FE c6rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767661092; x=1768265892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zdwpGAzUowZ3h68lzOUG2hhVHWdUBrDTU/ZZOy1LyBQ=; b=ExXbH6TS9Kz4kEOZpYVC2Wjx5sp9UH8r0NZWB7LANuM4sScKXr7c3EiOABfKeeSWiH wtdW6+Tn+hzhzT4Sinnymdd1tugvV56yTDCQ6ueu+DSczpq+NL+6zYwUW5sTWxxkFVgx zA0UwCsyNMqNr/+DGk+okKNk4IVNjeesEInsZ8vnecJ2e8FeaeD1nfsB4se6EfVihV3k FxJOh5B+SriTzZgCQn7nq4gu0Ga+K3gJCz+heigoSv8IYx37KO88nQmAm9zuEbCnqwsh djhNTtO6ZV35UlWy7+Qqv6yrzEitRInNdNqQXdLQBlojYt2RrI3cNNbFbWyPZvzjrvOC vykw== X-Forwarded-Encrypted: i=1; AJvYcCW4YfIVWHCHKl4c4XmaF9nQ/1zZG+f8TDVjhRG+lRbQ0aXEwXiZMofVvr8oAAwWen5+/fgMQlnUQaEzjN4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/jkJMQYgCZwlKO1dl8/KSaSb9pYbFmMCM+iz8+wm6DUMAIxf6 bXs7w2/f7RnjVvKwkQjQBgtfHuAykvj2Ti+pvxQzNjlgORL3btSGJGBEkNNWCyFRHOdjRmdJDG8 pMp5bhPC6XhB6oDsqQ7OCaFnsAWbSNsbc0XWeyxFyYDQY2+KMcnst X-Gm-Gg: AY/fxX6ozLJbCIKBJLNKZBB+OWB9T2izl/d9X6SVah2zgX7RVkHxV+PAgA3gDTSLr4G gtZ+Bx4FMqv9Zfj7agl6TUlrr0zHqAIDVWxPmyHzsvsyRZXSAkcZMF6iWeKmGgjlybo8cffAfE5 5lGqank9JH6uO7NZHZejGA0Vt4HjvgxPZDGzUjW/VcWYlcgdNfr+QfYhXo5aTCNM81PtaTJEY/7 pS+u3absqjcUZBTtG1KCKgdV8kcdZjny9NQuHdbmj8cp2NCtpRT/DeTWLROQ4NfToEMw8cP45qx phEF5BU6Pya9RgSypc1c/qjlGJ7/TPSy2CtH+JbFBvQNe1MnfZdGReYkpUo1aWmTBV+TCf0LzI2 YzeDi79HzOrokcIdscKHZbvEgcAM= X-Google-Smtp-Source: AGHT+IFwU/pBJWR2dwidv8JAygHGSrQWnV5pCYktkIbCd+APT962DRxhuMqf8abnSh/I/kA4ymWysHLBGQ+5 X-Received: by 2002:a05:622a:198d:b0:4e8:a54d:cce8 with SMTP id d75a77b69052e-4ffa76dc314mr16457471cf.4.1767661092015; Mon, 05 Jan 2026 16:58:12 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-89077179352sm796626d6.32.2026.01.05.16.58.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 16:58:12 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.49.34.222]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 0A5523401CC; Mon, 5 Jan 2026 17:58:11 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id EFEB7E44554; Mon, 5 Jan 2026 17:58:10 -0700 (MST) From: Caleb Sander Mateos To: Ming Lei , Jens Axboe , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Stanley Zhang , Uday Shankar , "Martin K . Petersen" , Caleb Sander Mateos Subject: [PATCH v3 16/19] selftests: ublk: support non-O_DIRECT backing files Date: Mon, 5 Jan 2026 17:57:48 -0700 Message-ID: <20260106005752.3784925-17-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260106005752.3784925-1-csander@purestorage.com> References: <20260106005752.3784925-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A subsequent commit will add support for using a backing file to store integrity data. Since integrity data is accessed in intervals of metadata_size, which may be much smaller than a logical block on the backing device, direct I/O cannot be used. Add an argument to backing_file_tgt_init() to specify the number of files to open for direct I/O. The remaining files will use buffered I/O. For now, continue to request direct I/O for all the files. Signed-off-by: Caleb Sander Mateos --- tools/testing/selftests/ublk/common.c | 4 ++-- tools/testing/selftests/ublk/file_backed.c | 2 +- tools/testing/selftests/ublk/kublk.h | 2 +- tools/testing/selftests/ublk/stripe.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/ublk/common.c b/tools/testing/selftest= s/ublk/common.c index 01580a6f8519..d9873d4d50d0 100644 --- a/tools/testing/selftests/ublk/common.c +++ b/tools/testing/selftests/ublk/common.c @@ -10,11 +10,11 @@ void backing_file_tgt_deinit(struct ublk_dev *dev) fsync(dev->fds[i]); close(dev->fds[i]); } } =20 -int backing_file_tgt_init(struct ublk_dev *dev) +int backing_file_tgt_init(struct ublk_dev *dev, unsigned int nr_direct) { int fd, i; =20 assert(dev->nr_fds =3D=3D 1); =20 @@ -23,11 +23,11 @@ int backing_file_tgt_init(struct ublk_dev *dev) unsigned long bytes; struct stat st; =20 ublk_dbg(UBLK_DBG_DEV, "%s: file %d: %s\n", __func__, i, file); =20 - fd =3D open(file, O_RDWR | O_DIRECT); + fd =3D open(file, O_RDWR | (i < nr_direct ? O_DIRECT : 0)); if (fd < 0) { ublk_err("%s: backing file %s can't be opened: %s\n", __func__, file, strerror(errno)); return -EBADF; } diff --git a/tools/testing/selftests/ublk/file_backed.c b/tools/testing/sel= ftests/ublk/file_backed.c index c14ce6608696..db4c176a4f28 100644 --- a/tools/testing/selftests/ublk/file_backed.c +++ b/tools/testing/selftests/ublk/file_backed.c @@ -161,11 +161,11 @@ static int ublk_loop_tgt_init(const struct dev_ctx *c= tx, struct ublk_dev *dev) if (ctx->metadata_size) { ublk_err("%s: integrity not supported\n", __func__); return -EINVAL; } =20 - ret =3D backing_file_tgt_init(dev); + ret =3D backing_file_tgt_init(dev, 1); if (ret) return ret; =20 if (dev->tgt.nr_backing_files !=3D 1) return -EINVAL; diff --git a/tools/testing/selftests/ublk/kublk.h b/tools/testing/selftests= /ublk/kublk.h index 830b49a7716a..96c66b337bc0 100644 --- a/tools/testing/selftests/ublk/kublk.h +++ b/tools/testing/selftests/ublk/kublk.h @@ -460,8 +460,8 @@ extern const struct ublk_tgt_ops null_tgt_ops; extern const struct ublk_tgt_ops loop_tgt_ops; extern const struct ublk_tgt_ops stripe_tgt_ops; extern const struct ublk_tgt_ops fault_inject_tgt_ops; =20 void backing_file_tgt_deinit(struct ublk_dev *dev); -int backing_file_tgt_init(struct ublk_dev *dev); +int backing_file_tgt_init(struct ublk_dev *dev, unsigned int nr_direct); =20 #endif diff --git a/tools/testing/selftests/ublk/stripe.c b/tools/testing/selftest= s/ublk/stripe.c index d4aaf3351d71..2be1c36438e7 100644 --- a/tools/testing/selftests/ublk/stripe.c +++ b/tools/testing/selftests/ublk/stripe.c @@ -313,11 +313,11 @@ static int ublk_stripe_tgt_init(const struct dev_ctx = *ctx, struct ublk_dev *dev) return -EINVAL; } =20 chunk_shift =3D ilog2(chunk_size); =20 - ret =3D backing_file_tgt_init(dev); + ret =3D backing_file_tgt_init(dev, dev->tgt.nr_backing_files); if (ret) return ret; =20 if (!dev->tgt.nr_backing_files || dev->tgt.nr_backing_files > NR_STRIPE) return -EINVAL; --=20 2.45.2