From nobody Mon Feb 9 12:24:41 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B39534DB5C; Tue, 6 Jan 2026 17:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767721452; cv=none; b=lBemFH3oM2N7EIAuwk23L0V+mh4I8oG2hfXHcRKZiItDFvqvq7CVPKsQvbMlY+NDRBW4rDl2SJq07nfxB5vsZCgecpJsZDw/bQKS+Ngfrpcv1u1MxTamiX6vrZiI+s6Qm5WyDguCnlw6Ncv/UnpNQr5tuQ0Zs6yhf2cFMRIRQDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767721452; c=relaxed/simple; bh=k4dIiayHY+3fQFoVlD/gTbiIPus9xFdi2n1KjW+WW0g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IaejZEIhjx1XXjBj2g6Q7qHyJx3zeQgJ26Cl/cYZ+//HUYtDUwZU8zeZtLOJh/G6TsRYVI/Gq6B51fu/1UAJlxz1b0jKQEaaocp6y7EqTZfRzQmpdzBH1TS2DZ500PL/qGAxDjMjNoap7NteJA5bwPn9nH0pLOC0D2Pa611u+RQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=218m2JFA; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="218m2JFA" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 683031A26A6; Tue, 6 Jan 2026 17:44:09 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 3231460739; Tue, 6 Jan 2026 17:44:09 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B1AFE103C81A7; Tue, 6 Jan 2026 18:44:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1767721447; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=RSAb30vPwta0L6j5mRlEyTeFIJd6lPuoibY+qgqO0Dk=; b=218m2JFAFbKKWUlQUsn2Wm6w3yVK4viodOWXVZp2fFlwZ445/2JYDQ82c4nchEP1Wc7BEj KOwFsCAfbuLy3cfxgnPZWsaeGn5iU6kuZuZdSZzFqmbHUazQ/Jjb0faP+8EA2XXy54s5Lc aEQr0KVGF+jGmWVwWL3n61fKG5LyfTA/iOzDLdrYO6mmNQAbokLYsPopsmeHJ2UeOer3hx t5NnU4ggEPcb6O8N8a/p1s+sdfIvJ+2CG3BbFah4qebfqmxw30jOhbYJgI3mhtG2VFqa7y OZe6t4UTq383p1fVjwr9S80ZQlSHlfg104GcSYOlJ/da8CDiGeLs+zyhHNotuw== From: "Kory Maincent (TI.com)" Date: Tue, 06 Jan 2026 18:42:29 +0100 Subject: [PATCH v3 13/22] drm/tilcdc: Remove the useless module list support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260106-feature_tilcdc-v3-13-9bad0f742164@bootlin.com> References: <20260106-feature_tilcdc-v3-0-9bad0f742164@bootlin.com> In-Reply-To: <20260106-feature_tilcdc-v3-0-9bad0f742164@bootlin.com> To: Jyri Sarha , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Bartosz Golaszewski , Tony Lindgren , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Markus Schneider-Pargmann , Bajjuri Praneeth , Luca Ceresoli , Louis Chauvet , Thomas Petazzoni , Miguel Gazquez , Herve Codina , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, "Kory Maincent (TI.com)" X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 The tilcdc driver previously supported a sub-module system where external display drivers (panels, encoders) could register themselves through tilcdc_module_init() and be automatically initialized through a module list. This infrastructure became unused after the component framework support and panel driver was removed. Reviewed-by: Luca Ceresoli Signed-off-by: Kory Maincent (TI.com) --- Change in v3: - Move the removal of module_init/exit in a following patch. --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 29 ----------------------------- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 27 --------------------------- 2 files changed, 56 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/t= ilcdc_drv.c index 6a08f50762af9..34d0e81552912 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -7,7 +7,6 @@ /* LCDC DRM driver, based on da8xx-fb */ =20 #include -#include #include #include #include @@ -34,8 +33,6 @@ enum { DA850_TILCDC, }; =20 -static LIST_HEAD(module_list); - static const u32 tilcdc_rev1_formats[] =3D { DRM_FORMAT_RGB565 }; =20 static const u32 tilcdc_straight_formats[] =3D { DRM_FORMAT_RGB565, @@ -50,20 +47,6 @@ static const u32 tilcdc_legacy_formats[] =3D { DRM_FORMA= T_RGB565, DRM_FORMAT_RGB888, DRM_FORMAT_XRGB8888 }; =20 -void tilcdc_module_init(struct tilcdc_module *mod, const char *name, - const struct tilcdc_module_ops *funcs) -{ - mod->name =3D name; - mod->funcs =3D funcs; - INIT_LIST_HEAD(&mod->list); - list_add(&mod->list, &module_list); -} - -void tilcdc_module_cleanup(struct tilcdc_module *mod) -{ - list_del(&mod->list); -} - static int tilcdc_atomic_check(struct drm_device *dev, struct drm_atomic_state *state) { @@ -97,12 +80,6 @@ static const struct drm_mode_config_funcs mode_config_fu= ncs =3D { static void modeset_init(struct drm_device *dev) { struct tilcdc_drm_private *priv =3D dev->dev_private; - struct tilcdc_module *mod; - - list_for_each_entry(mod, &module_list, list) { - DBG("loading module: %s", mod->name); - mod->funcs->modeset_init(mod, dev); - } =20 dev->mode_config.min_width =3D 0; dev->mode_config.min_height =3D 0; @@ -474,15 +451,9 @@ static struct drm_info_list tilcdc_debugfs_list[] =3D { =20 static void tilcdc_debugfs_init(struct drm_minor *minor) { - struct tilcdc_module *mod; - drm_debugfs_create_files(tilcdc_debugfs_list, ARRAY_SIZE(tilcdc_debugfs_list), minor->debugfs_root, minor); - - list_for_each_entry(mod, &module_list, list) - if (mod->funcs->debugfs_init) - mod->funcs->debugfs_init(mod, minor); } #endif =20 diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/t= ilcdc_drv.h index dafb00908d1d4..60e85e29b1063 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h @@ -81,33 +81,6 @@ struct tilcdc_drm_private { bool irq_enabled; }; =20 -/* Sub-module for display. Since we don't know at compile time what panels - * or display adapter(s) might be present (for ex, off chip dvi/tfp410, - * hdmi encoder, various lcd panels), the connector/encoder(s) are split i= nto - * separate drivers. If they are probed and found to be present, they - * register themselves with tilcdc_register_module(). - */ -struct tilcdc_module; - -struct tilcdc_module_ops { - /* create appropriate encoders/connectors: */ - int (*modeset_init)(struct tilcdc_module *mod, struct drm_device *dev); -#ifdef CONFIG_DEBUG_FS - /* create debugfs nodes (can be NULL): */ - int (*debugfs_init)(struct tilcdc_module *mod, struct drm_minor *minor); -#endif -}; - -struct tilcdc_module { - const char *name; - struct list_head list; - const struct tilcdc_module_ops *funcs; -}; - -void tilcdc_module_init(struct tilcdc_module *mod, const char *name, - const struct tilcdc_module_ops *funcs); -void tilcdc_module_cleanup(struct tilcdc_module *mod); - #define DBG(fmt, ...) DRM_DEBUG(fmt"\n", ##__VA_ARGS__) =20 int tilcdc_crtc_create(struct drm_device *dev); --=20 2.43.0