From nobody Sat Feb 7 05:01:02 2026 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC31310764 for ; Mon, 5 Jan 2026 21:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767648696; cv=none; b=tPU09ggV0cBdLUH8LvcbgMp+Gva/Xoy3hVJSF55kMuFCIg3y59+k1QUY8P05KSRW7YKUnI3DxQKvJDipftWGQmcMt+tccXOnWqfEvHsbn/W03N/LhlK66reO6kCtYmwu/uki+JuvLeDfdsQDPBOz1VxUxtJqUuogxANWXM4GKVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767648696; c=relaxed/simple; bh=yEYBuvLd/BthcXjgBviK2z+dPWoq/XyaCHn4ndnWrcg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=hws1iv7PEYQAkfIaFvNHdNPr8l9rBMkufLeCEFAwcExWgXL7Z0FMv5uaqAhP+9wXV+Q+YzfBgtF19isKY8E2HG8XGOaQPwL8KBbsX+l0KGQxfVJZIEWNBfT1Nw1+KbEdmuhIrUpByTCr8zMnw+VsneQ85gkCP5PytdnNrUl4V+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g8LWrMD9; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g8LWrMD9" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-8be92e393f8so38183085a.1 for ; Mon, 05 Jan 2026 13:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767648694; x=1768253494; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XhBC7rXz1pRImrcbPp+woVkaMumJ5RxzSRmSj0UEHEQ=; b=g8LWrMD9FP27Styy1hoX7+OrA2RJACC88AxL5jwQPdBew+p1iycMOxfuJzPtYjO0wq kmTaQIMzpw6K9JSNLjJGxJfDjvWV+UlaaRyHstAdJ78zPaS5LVusrewPeroJYqo98R3A 03MCOkbDsCzbldGPU2biIpvG0/p6e1D2y94sNeTteMJCTgl8AnTY93l7j4zGUpPJPeZg LBWlQexw40QjQPnKGa/SwaFWVaPJeNAgGdyI6OjcSYInZsO7en4nszpdDwyVABbDwqgh CbBFdm1N/GVNw7X19ZpTFH+A5m9efpTi56aPHytdpLlir6hUq2KnB0kL7dCLhPf1n/uA 7Kqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767648694; x=1768253494; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XhBC7rXz1pRImrcbPp+woVkaMumJ5RxzSRmSj0UEHEQ=; b=fGPwmUrz0YQcUqntNLZPphJhevQFKaY4tT2Jjb/Rl8/dyya65npUxkOzsNquCE0Of/ 5S/hm/576v+QxL+X7V9oCH/ps7tJ5mypt+Bcc1lsyB7VzqBnh42FWYZYxak5jdfTKyeP tBVM4XnDCB3GtMz8a/VYwOlNUBDF1yP2JASqlen+/wri6bmOMOdB2LWgoVMyqvCdPhQE mLiwy7bUZIFAUusthGy2ioVQRs7iPGVjJSsKwNkUa/pRugf4Nr7kL/CcxQwydhiAr7QU 07besZRrjbjnDb6itS02J2VqzwjzsQ4KSor/1s3ajFqxTEgNjEz70j1l4liteYAEmRn7 znBw== X-Forwarded-Encrypted: i=1; AJvYcCU0B9HWamt+CCmKgIX4New4yUXUn+ecJySg8y7bqcYPC1qYl7bqc7rTyylC+UT9MnULVrpm6BxHJoJPaC8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4kXYuDowHwglGpm2LUECHT7GreGXAURB+zedHw4ArdUriFPLO ObwJZhApHeMqguccwXpmfHQa4o+USmIS4KfBwfs3iuh1rEL3li0qD+NS X-Gm-Gg: AY/fxX59DfwY8JJyK/gffmoXHnx5S2E+B3jPIssK5svAQIZQvsAMBYlJGixZYOpQhQg KexysIqXf/CVnZLOysPHBKZ7lRLUnF9jsOHs5adjY54n/9PD777qCXrI3nu8jEQ2SST5kk1fr3p lDKkfnx3vCQ1x5ryECILShsw0+Z5BzJuKHjV6tGU2xGloGbZN2klO7ylgKvKGpv/td2mM0OHlcO COirytcMJfxqujY3g68OvZH2as6UTa2YzxFb6oAO6W8dbCkKFDBP5tUiAdOl1vaimlQwykLkpIk newncrdVlht0ZC+a3VyJ+WYG0wI+oj0FLeAve5tDKzjGZRhTQoRz4fck44ssTfAh3L8080/mAQ/ MI0gTxCkD9lyi/1H5rS5DyNgY13eWw1667z3pE61sMAC//dyhUKsQOu+2yeRb2GQuSruGhdRrFP PEBe92bOycR/6Q3P1B4l2o4CPN9yyt66TS X-Google-Smtp-Source: AGHT+IGjGuVVtc4a9gZlmcnbYKV3HMs0PzUAQZ58Z3IxzCp1ryp/OyBq+hta8t2JtYK0yjLVBi/v5Q== X-Received: by 2002:a05:620a:4508:b0:8b2:e3c1:24b7 with SMTP id af79cd13be357-8c37f535f19mr90357985a.29.1767648693845; Mon, 05 Jan 2026 13:31:33 -0800 (PST) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f51d06fsm33450785a.32.2026.01.05.13.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 13:31:32 -0800 (PST) From: Jiasheng Jiang To: Nilesh Javali , "James E . J . Bottomley" , "Martin K . Petersen" Cc: GR-QLogic-Storage-Upstream@marvell.com, Saurav Kashyap , Quinn Tran , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] scsi: qla2xxx: Remove redundant and conflicting initialization in qlt_alloc_qfull_cmd Date: Mon, 5 Jan 2026 21:31:29 +0000 Message-Id: <20260105213129.46096-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Remove the unconditional initialization of cmd->q_full =3D 1 at the beginning of qlt_alloc_qfull_cmd(). Perform initialization of the q_full and term_exchg flags exclusively within the conditional branches based on the qfull input parameter. This change eliminates the redundant assignment when qfull is true and avoids the unnecessary overwrite of the flag when qfull is false. Ensure that the command state accurately and explicitly reflects its intended purpose=E2=80=94either a "Queue Full" event or an "Exchange Termin= ation" =E2=80=94without relying on a conflicting default value. Fixes: 33e799775593 ("qla2xxx: Add support for QFull throttling and Term Ex= change retry") Signed-off-by: Jiasheng Jiang --- drivers/scsi/qla2xxx/qla_target.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_t= arget.c index d772136984c9..560ff42ce3c7 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -6682,7 +6682,6 @@ qlt_alloc_qfull_cmd(struct scsi_qla_host *vha, cmd->tgt =3D vha->vha_tgt.qla_tgt; cmd->vha =3D vha; cmd->reset_count =3D ha->base_qpair->chip_reset; - cmd->q_full =3D 1; cmd->qpair =3D ha->base_qpair; cmd->cdb =3D &cmd->atio.u.isp24.fcp_cmnd.cdb[0]; cmd->cdb_len =3D 16; @@ -6691,8 +6690,10 @@ qlt_alloc_qfull_cmd(struct scsi_qla_host *vha, cmd->q_full =3D 1; /* NOTE: borrowing the state field to carry the status */ cmd->state =3D status; - } else + } else { + cmd->q_full =3D 0; cmd->term_exchg =3D 1; + } =20 spin_lock_irqsave(&vha->hw->tgt.q_full_lock, flags); list_add_tail(&cmd->cmd_list, &vha->hw->tgt.q_full_list); --=20 2.25.1