From nobody Mon Feb 9 09:32:38 2026 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9638326F2AF for ; Mon, 5 Jan 2026 20:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767646058; cv=none; b=HaPLr7EWVAW89pE5tP3t3LpKxTczMaNf4fQqKv7uEvCBSrPhpx4+Lrch8ixht3qXJ34mhjWcRkXxp7Qkau+Rm4IzOmCsyyMzMZGVU2BgfpzHS+YzzBvKURiiDDCoY4h3/a1cIMQJX5SyRYBNZgOd/7b2vkkeD7OCAYhJZSR3fr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767646058; c=relaxed/simple; bh=7nReUWnIK+5M7ZN5i+O5JzR7QSNdfOBwiVz/I8wLhmo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QcSyT4ykbmucdaRCUO8VkSTnejtJfbdNWvn7nx0KzaqOsa66NSPr1A2DVLoAO7zO6VeH0SbhNMxMF17M9dxdTHt9I84Q5bVI8SzjrIEAQR+5x6fpTBy4WqfvQCx/SnMeNz/yiUxvrKFStcKXs7zS5boyzwj4ygUpo87zyUpWLdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com; spf=pass smtp.mailfrom=googlemail.com; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b=Ou+qtwh3; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=googlemail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="Ou+qtwh3" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6505d3adc3aso421173a12.1 for ; Mon, 05 Jan 2026 12:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1767646055; x=1768250855; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6P8LBmvGnTOHrkGqJNJYNGnVf7vFIplFOGVmqZklygM=; b=Ou+qtwh3TYFXodD4h9yJWXFsZWaCxMRwMI3axRft4ZCOXHryjNzwGCZ6L34L+nHnNR /qIYKcwejzREqIfH64Gn2q3mXennUY7S+r9rT5c0BHCmqR10fQvC4sZHfhaD3wU6Maly Fws2g3HVty9dNfrhceKsTmxJf9S1uf1LCRK+vIKeIgOPTJyP5Y62bgXTT0xIDPfyaj/q T7KBxkMUf1IegmwRE6BXkJNPy1xwJYSGnxkId0gr4wLZDgEvEtxA0G0yk7BsEAvj+6qS PHb5ZYwoXmehOHUttybPRWiJ2O4FPTGMPEF+A9i5Fir+DbWkf+rzAckZmo4u8DabhvXD vZDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767646055; x=1768250855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6P8LBmvGnTOHrkGqJNJYNGnVf7vFIplFOGVmqZklygM=; b=ZA5l4warEdvpBvGqtmWvn+rsYn9eRJ/I2IQpJ0WvzW9psFqkVPLtC8YXqsW4TkHEXm tXnbl3G+2GrJmC/jGVNxBaI+qECgaKfaczopwFyaQJrHG2zeHSbQJxnlQFX9G3v+l62U cRUdsE8CRNOz1OpC7zAULjPMtwx3ctIk31Bvhj6AQF08kA4mCQXa5M4ZL6d20rHF6hzc Kp8iIknA10vKvR+X1axqOnazWYVVZ+JMHFJQwhjF0R8zVcPkF6FbILqvtB0k1yWoGPDw f2E33JH/EoPYlNMQ+hudsFHnCBgWQJK8P4yiUhdYp3NSEES/iSw39OZEIzvpsC1iniJu rZXA== X-Forwarded-Encrypted: i=1; AJvYcCXEEC1wBpgySlmo+evIWGQTqsz3YbZWwKAUCPg/O/oY0D+NyjFqn+xOPn2fmQouzsWB3Fz6gf3+EtPFNTA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8tHyHfeO8wgbQVgpgZ+OLQjUnBO2DLGiCmggCk27GeR5J/jhP gakxEWSrDJwf+oE0uA4DjbtEpKmML1RaW1zbFVkLWoA2+iq8nkbiovvr X-Gm-Gg: AY/fxX7+M/WeWnbB5rCYmpH9XgBubH6Oc2h+0YIbnzH3iHoqnbo6AX1BMGBGqxb9LhQ 9UQhovove5IvUjbabK1LcFpm6N2k7JpUuEXRPJoQKIOYeDm8WNtEGZMPO6ZEq5qoFEMg/G+/S7S s3bYtKELYglgaeTeqjaNVmxXIqGPS+DEmLM0az6rfuF6RTADWbq7moBtuSKedRivMtl4s3blPng 00VEMwKI4wWsi4pNga17TLJl2gnKI8FASKPdQ29JPaQiaJ0bcZCEmsdaB2Eydb4/2SEN1v+/pMR 9W4rNsCzAYZ/lm3swmXLyW4n11qN0EPULaDyQchY1AKgpxkslUPlzcAq5HhEhk7yuAkETRn3dD+ U2XdkTPqYzJkhJXCImlgaioUQbKB36aD3AxCe7qh6NZumjy8KK5vazGkJGQVIUGmwgQblXgONDC tE3/rbPKinQ3Z9v6rp5TCIMdXfIMarAlW0K9z0MR0394SawjJEV03ITPim6YlOyPEFd1oNGPbsk GmIdbBiLBYNJb0zmRCzG8m8KwjQAEyYA4crxe8Tjg== X-Google-Smtp-Source: AGHT+IGG1LQBfEPmFlrxpYd8DB9+gcGLWD908SEefSfmMK/DBGdhRfme546/4V60Eq3pmIsZOVk88A== X-Received: by 2002:a17:907:944f:b0:b83:13c3:d495 with SMTP id a640c23a62f3a-b8426bb91abmr96266166b.37.1767646054735; Mon, 05 Jan 2026 12:47:34 -0800 (PST) Received: from blackbox (dynamic-2a02-3100-a8ad-5500-1e86-0bff-fe2f-57b7.310.pool.telefonica.de. [2a02:3100:a8ad:5500:1e86:bff:fe2f:57b7]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b842a233ef3sm26240566b.1.2026.01.05.12.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 12:47:33 -0800 (PST) From: Martin Blumenstingl To: linux-amlogic@lists.infradead.org Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jian.hu@amlogic.com, jbrunet@baylibre.com, Martin Blumenstingl Subject: [PATCH v1 1/3] clk: meson: gxbb: Limit the HDMI PLL OD to /4 on GXL/GXM SoCs Date: Mon, 5 Jan 2026 21:47:08 +0100 Message-ID: <20260105204710.447779-2-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260105204710.447779-1-martin.blumenstingl@googlemail.com> References: <20260105204710.447779-1-martin.blumenstingl@googlemail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GXBB has the HDMI PLL OD in the HHI_HDMI_PLL_CNTL2 register while for GXL/GXM the OD has moved to HHI_HDMI_PLL_CNTL3. At first glance the rest of the OD setup seems identical. However, looking at the downstream kernel sources as well as testing shows that GXL only supports three OD values: - register value 0 means: divide by 1 - register value 1 means: divide by 2 - register value 2 means: divide by 4 Using register value 3 (which on GXBB means: divide by 8) still divides by 4 as verified using meson-clk-measure. Downstream sources are also only using OD register values 0, 1 and 2 for GXL (while for GXBB the downstream kernel sources are also using value 3). Add clk_div_table and have it replace the CLK_DIVIDER_POWER_OF_TWO flag to make the kernel's view of this register match with how the hardware actually works. Fixes: 69d92293274b ("clk: meson: add the gxl hdmi pll") Signed-off-by: Martin Blumenstingl --- drivers/clk/meson/gxbb.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index 5a229c4ffae1..0788b9b1ed21 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -349,12 +349,19 @@ static struct clk_regmap gxbb_hdmi_pll =3D { }, }; =20 +static const struct clk_div_table gxl_hdmi_pll_od_div_table[] =3D { + { .val =3D 0, .div =3D 1 }, + { .val =3D 1, .div =3D 2 }, + { .val =3D 2, .div =3D 4 }, + { /* sentinel */ } +}; + static struct clk_regmap gxl_hdmi_pll_od =3D { .data =3D &(struct clk_regmap_div_data){ .offset =3D HHI_HDMI_PLL_CNTL + 8, .shift =3D 21, .width =3D 2, - .flags =3D CLK_DIVIDER_POWER_OF_TWO, + .table =3D gxl_hdmi_pll_od_div_table, }, .hw.init =3D &(struct clk_init_data){ .name =3D "hdmi_pll_od", @@ -372,7 +379,7 @@ static struct clk_regmap gxl_hdmi_pll_od2 =3D { .offset =3D HHI_HDMI_PLL_CNTL + 8, .shift =3D 23, .width =3D 2, - .flags =3D CLK_DIVIDER_POWER_OF_TWO, + .table =3D gxl_hdmi_pll_od_div_table, }, .hw.init =3D &(struct clk_init_data){ .name =3D "hdmi_pll_od2", @@ -390,7 +397,7 @@ static struct clk_regmap gxl_hdmi_pll =3D { .offset =3D HHI_HDMI_PLL_CNTL + 8, .shift =3D 19, .width =3D 2, - .flags =3D CLK_DIVIDER_POWER_OF_TWO, + .table =3D gxl_hdmi_pll_od_div_table, }, .hw.init =3D &(struct clk_init_data){ .name =3D "hdmi_pll", --=20 2.52.0