From nobody Mon Feb 9 13:58:32 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71DC831326A for ; Mon, 5 Jan 2026 14:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767625111; cv=none; b=i5LEJKkt+wzUqdQGDcDOYOdiIioqA+Zx1KpS5SHst9VuPntyU8VGcCf2SDApjh0r0GsX3Siyvco3KEMXcwxS/SyHDaUcwhK9fibHNn06MG94+jVrESKrIgp/yWLek3k+7v3/NPknVtkg71EYY43xgTh5v+Fi/86siJT77p8oawo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767625111; c=relaxed/simple; bh=VcJC7sCWJodERaoTS9t7XlGBxL7hprZHiIDPn09Ne7s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jgoM1Ni5FD2bmXJOl2NBV4dQXKjQEodhMcZ+meF9QbgaQHvDKqKAYRBpgccvqVr2heNTsL9kYLE8QwzB5c8BJjDToYFaFB+WdsTMO9vAePhag6d9LcNzIHRFZ+9RgJWzs3gbqZuffELcebjnmw2t3QAkohkO7fkn5cz6KzhLzmA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aLZ7nyLI; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aLZ7nyLI" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-81345800791so34114b3a.0 for ; Mon, 05 Jan 2026 06:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767625110; x=1768229910; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bw6fgNtZmBe2W56ugS12P5lnC0TRTn4SZrhJOxug+wQ=; b=aLZ7nyLI5ISY1e8Lnq3V3hGK4/90QvWT0qYWnZb1+PYdO7fy7UZ7vi43XwCYtOclpc QLBJUZZNwX/paQs+dk8MPLJWjCNtsVBDQpGIZnhXX+ZnWd4zNkmx1O/YvZ8nOotQpjtn 94PZ9IO52oTJEtSuattxoZnHbPMFnoGhb+TUCM6T527NkvE+hGVzi+UAhB8cMOKXnVpb rvtl6RMdBSQKtLznImarXMPZgFCUxkPrSiZONvHLuptKsIz3bCFg+I/SglobSpxhTR39 EllzMR2Y0giGpBzyf82CSo/Myx9uP7weM+c6YbtcwNGsVK21nxwUd/n9fZJ2ebiD1781 Qpsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767625110; x=1768229910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Bw6fgNtZmBe2W56ugS12P5lnC0TRTn4SZrhJOxug+wQ=; b=jRAmimzG2nLptyPxn8nsoOoX1CFi9i7iA5AJqDlebNVsUYu0dCVLCjxoYxwOiqDkBI o+XNI2Rfr6rou9EwmyePJf1CRoD0gGJU4prfsW36FTUDBADkkSb+orMcFcgPr/CLFe+t +rCX7B9HU+twFeCb7rVrtF1UCkbsNs9SpyaNPXGvAQEKDZEKv+eeSycUgep37V/WL13H Hi04w0uAjG3nsBnDo+d/tSP9K18CEXr35QRG4+JOMuZkdNcyhrLmfqJ6LLqmQQ0nkmEY XHO2Tf1ycPTvZh+Uv1W/dyGCInKY5LkBe3HllzMOc1k4AZh8HUT/4BbIwhBShhyb4chH DGZA== X-Forwarded-Encrypted: i=1; AJvYcCVrRvAV2fv77xVmLU/GIKPH+GqHDHQWGf9bOwTjX/jWott0akpV5VJX/eStwBurBHU+mJCNkFW00oy+lQg=@vger.kernel.org X-Gm-Message-State: AOJu0YwF1R0mIzKPMxR5kVdx46aoYIi2X3f8foybCZUIW5IMW8hQ4yCq mk4AQtJKnfkQiw6clN32t0jvNOoODZaQafX5HNvsBOwA8hLfDbL8upnl X-Gm-Gg: AY/fxX6KHhnNTJhOgyDv8949HHGJ+IcuEzmfRUXZY42qpgfhFmlAovuYlvvOnrX7mHb FuV+O1o35gJtg7CiY0yGUcroVs7blMnPPp8/uLuOzkkmYmJkXIGZ/j1yG/VdVJH2jW4wvHTha7Y xOntbFg+JlwDGL6/tjeXDnj8FCW7na2+tdtPHirsVcMVJBehJ9EuCRiXFYZrJFZ4aTOGWVpokT4 HgAJ1+VklNm9WHKAhY4FbJyI5WewJ73qeItwho1xstDvV5wRTdnBe9/v0v6LujqQUP8jQeIpfzx QFe93ianhKVKzwZWcl6WnFod+Jq925CWZI6N8R6QXPZ64ie+fiq1nmvIdUO0W0wQhT63/BMXTOP 5FtFBgeewwFlwD2dklq12GDeuOSC0AM9rjnBZ0kobGAUtyyifJusmxhwWoIAeio7oBj+RTLIuV7 ERP7fsw3NWcz8= X-Google-Smtp-Source: AGHT+IHd0J7CYDZvoLfOcn3yuW4Bcd7pC34RjnYz8x8yPWpwNDXN3La7THKi3GPsSVNRoAdXAZJ7RQ== X-Received: by 2002:a05:6a20:6a08:b0:342:1f0:9af3 with SMTP id adf61e73a8af0-376a81dcc3dmr42857702637.29.1767625109526; Mon, 05 Jan 2026 06:58:29 -0800 (PST) Received: from karthik.. ([43.247.159.43]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e2b81484sm715955ad.78.2026.01.05.06.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 06:58:29 -0800 (PST) From: Karthikey D Kadati To: Hans de Goede , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Karthikey D Kadati Subject: [PATCH v2 3/3] media: atomisp: propagate errors from ISP xnr and IRQ enable Date: Mon, 5 Jan 2026 20:27:24 +0530 Message-ID: <20260105145724.37305-4-karthikey3608@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260105145724.37305-1-karthikey3608@gmail.com> References: <81e2d12c-342b-4b88-88a0-3e24115541aa@kernel.org> <20260105145724.37305-1-karthikey3608@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate the return value of atomisp_css_capture_enable_xnr() in atomisp_xnr(). Also check the return value of atomisp_css_irq_enable() and log an error once using dev_err_once() to avoid flooding dmesg. Signed-off-by: Karthikey D Kadati --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/stag= ing/media/atomisp/pci/atomisp_cmd.c index 4ed6b8aea..da2481af2 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -874,7 +874,8 @@ void atomisp_assert_recovery_work(struct work_struct *w= ork) if (!isp->asd.streaming) goto out_unlock; =20 - atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, false); + if (atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, false)) + dev_err_once(isp->dev, "atomisp_css_irq_enable failed\n"); =20 spin_lock_irqsave(&isp->lock, flags); isp->asd.streaming =3D false; @@ -925,8 +926,9 @@ void atomisp_assert_recovery_work(struct work_struct *w= ork) =20 atomisp_csi2_configure(&isp->asd); =20 - atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, - atomisp_css_valid_sof(isp)); + if (atomisp_css_irq_enable(isp, IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF, + atomisp_css_valid_sof(isp))) + dev_err_once(isp->dev, "atomisp_css_irq_enable failed\n"); =20 if (atomisp_freq_scaling(isp, ATOMISP_DFS_MODE_AUTO, true) < 0) dev_dbg(isp->dev, "DFS auto failed while recovering!\n"); @@ -1196,9 +1198,7 @@ int atomisp_xnr(struct atomisp_sub_device *asd, int f= lag, return 0; } =20 - atomisp_css_capture_enable_xnr(asd, !!*xnr_enable); - - return 0; + return atomisp_css_capture_enable_xnr(asd, !!*xnr_enable); } =20 /* --=20 2.43.0