From nobody Mon Feb 9 14:23:35 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD2D02638BA for ; Mon, 5 Jan 2026 14:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767621992; cv=none; b=K0m3xWqUb/BJ9WHjTvtOiQssaMrCb5dJAgR6WNpTO9Li3JvBEXPv+nJEQff6c5ook9/w6m2tbTw6CoW3+eI8e5T7nEfcPlhfyMktS+xvUsRDt875jPjZZijOz+CkEus+3Yn+oVGmo6uNNTY3xJDmHXbaq2pVcU94vgseft72TQQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767621992; c=relaxed/simple; bh=YDm68YWhw+GEjf0gozJmWl/ojKKZcva9ZQA+L2+6sjg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=myZEI8HEu1o6VHyGd0CBL796v0E6pPIFMVHsJoYRCezu67QhZcAYk3t+WIaw920FiP3hkFY0OXeFNyrstNWpA+YShSlJ8m55gaGKSy1e6TyqPTMjJ+OfQJhIenLexYYBvSHHprW5KBxDBtHaofMyHl6Uer1MrAx48jFVjFfIDVE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bfY0BrIT; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bfY0BrIT" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42fbc305882so6747905f8f.0 for ; Mon, 05 Jan 2026 06:06:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767621989; x=1768226789; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hOJglpam6Y6tV/ZKx1vMYagmOMEwuqgdfcTZ8FECwao=; b=bfY0BrITyJmlzAuK4dl2gKORFURQMa5qUWtsIk1z7hdhyxnaSoukrin8kyedcEBDog DwjWDOeXM8bTDQGKrCfKT6PLUidxANICUHqOiOnaCXgUBaPmh/Kqh5BZ2xdsmFB3MvFi DFR3MQwICb4rdWiCEbwODtRrocGF7TN9uNhsIliRaWDftwzg4bQFq10RHI2kRgJVcsYg 2x2IATe/ERh9rTpMULI01HwuMhm/NEE6gKQbjMvDvgrbrJ2sj50d/Ie5Zkfmrsc4qo2m G7cbyoc/RtlHehdp+G8Kg9Xq8GFdCI1Br6sB5gUCfXgaPcsVW0OU4q4s4v7YLVMTgiuC jelw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767621989; x=1768226789; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hOJglpam6Y6tV/ZKx1vMYagmOMEwuqgdfcTZ8FECwao=; b=MfQnAsbi9bjMQeytZ92PeDYubRzNBL7jUvPDwq/4FYl1RhdJPuGW5b1JC8NsKYzSII /ITOiKg46qoioC21LfeYipwtrpZiuo59Wt2W8IFRurpEPm7bEKUf/MqqTLoO/02dAe/w wW7ijq55dzTyJ1qM/wKWQmiPC1u9xgRQvcnYB+dA+TGGII7STNxmAcMP+9LNGvTjgMPf cnSOh5JlV5da4xS4uBcRIScv9H60RSUs5NPon1PvPtvFXdHiU9MAjRcf4OUc5yS2kYYx pY0DswUhTQdrn/AtC3SLASjVUbKINrcLl1rnk3BsEW3Cfo19N4El4LH1oFJrze8xwC01 zshQ== X-Forwarded-Encrypted: i=1; AJvYcCVe+8bZjJ8BFj2h0s4TtFOXzWfjx//Jtd4O9if/+eD3E70Se/9NRKFANJ1w3g803C/XS2JBewyeOfv+i10=@vger.kernel.org X-Gm-Message-State: AOJu0YzUxWs8Cu16X9KMEV67gJJAOeqXYTSXe3vIQCEjDZ1wPfTWH6MN WvwFai+UG4QtaAaBtSsQqxYlvIPBk7FDC+fwcOqO2hGzemA3xslZ/MbEGb8M9PFCEBg= X-Gm-Gg: AY/fxX5kxAXBX9ojMII+boAxKHITQRVlZ0z1pquMkPFGfji+s65C/b71gc6xMooLUGK qC5buZr8JNrLkWbvQ7PpEs5wtIWs6BxqYYs41GZgObcY0sBk7jsTmXOIHzeZ2Nv3SZt3hICJ/qN MfZVK5OAF3Cpbo002MxIU1v1SX+kKzPtbzAEgG3jNnNOqsDR7K2z6G7j/UvWUIs1S8estJ/W3Ec T4pPzwMyLdTmCHrGh3TPkVoQ6nO7xMgSyVg+tPnsIKgBN4Ba8BTTU72zEPUVa/6uLDOKhWlVQKS SwKrmzV0HxNQt987V9WB8v2CcJk/4CzLEcFDwiRolSy+Q8V8KgpDLSGVDrdlns99BhbPI7o8d9h empbp55+px/NgzOBM+pkHVvUvuNk0elIbW1stXGmog+grWm0Zl4QmzGOxeS1z5+jMRxW7iUt8oZ LqBMHHYyw5ZEI3W1UXNdEvDil7zAXvTcwH4+CrHyJd6rAxKIC7HiaR68ZSyRGoqFFAsjnCnExbj LMYnoi+v1A+tOEp3FVoEnqPfS9Bq16jm5UQx525KZNj X-Google-Smtp-Source: AGHT+IHYjz/XhcS6cgCdmHSfRfjnK952JHLNhqtvsHW++gGz2atIPw5gFfbGYXmxHJxJ2yyaYDBXJA== X-Received: by 2002:adf:f18c:0:b0:432:8036:4a0e with SMTP id ffacd0b85a97d-43280364b6dmr31538076f8f.35.1767621988981; Mon, 05 Jan 2026 06:06:28 -0800 (PST) Received: from iku.example.org ([2a06:5906:61b:2d00:b8c0:9e58:2df0:631f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1aee5sm102452753f8f.4.2026.01.05.06.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 06:06:28 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Pavel Machek Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH] clk: renesas: cpg-mssr: Unlock before reset verification Date: Mon, 5 Jan 2026 14:06:25 +0000 Message-ID: <20260105140625.2590685-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Move spin_unlock_irqrestore() before verifying the reset result and printing errors. The verification condition only uses local variables and does not require locking. Reported-by: Pavel Machek Closes: https://lore.kernel.org/all/aVujAQJSDn6WyORK@duo.ucw.cz/ Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven --- drivers/clk/renesas/renesas-cpg-mssr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/r= enesas-cpg-mssr.c index 35cb49763014..a6df0d2538c7 100644 --- a/drivers/clk/renesas/renesas-cpg-mssr.c +++ b/drivers/clk/renesas/renesas-cpg-mssr.c @@ -806,14 +806,12 @@ static int cpg_mrcr_set_reset_state(struct reset_cont= roller_dev *rcdev, =20 /* Verify the operation */ val =3D readl(reg_addr); + spin_unlock_irqrestore(&priv->pub.rmw_lock, flags); if (set =3D=3D !(bitmask & val)) { dev_err(priv->dev, "Reset register %u%02u operation failed\n", reg, bit); - spin_unlock_irqrestore(&priv->pub.rmw_lock, flags); return -EIO; } =20 - spin_unlock_irqrestore(&priv->pub.rmw_lock, flags); - return 0; } =20 --=20 2.52.0