From nobody Sat Feb 7 11:31:37 2026 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A6A033ADB5; Mon, 5 Jan 2026 12:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767615957; cv=none; b=VCJaYxMuDuVr2guA4T2SAFA5Hf24txGm2Vq/f8NcC8STTcjHj6QHyLuwFhXdJIfSP3HRl9g11R4U+2VZmrfTasOn5FN7fdAq3LJCQ3HaSBJBP+nGF7JVE5sYyBXJS2/XUbBJh+PU5Sr77aOXo+2jWWN+62bBBaETf9w8b32eNlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767615957; c=relaxed/simple; bh=qh8jtoMFPEHHepmGnuAMEkyqmpW4B9KCVYzHVFqxwhQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=sUoMPqawnoVWaJSfnJ0o+lpK/2pIkhpzT5/lfDdLgUyr0YzDmf/c3oVFLP3R8QL97/E0FgfgTWQdb2Xk0YjDqFtNKFcATDdUwS2HT+mhLGZp5/UWxrmXyP1dYzNWSR5W3FlsFgsvAuAliUqBfLvWAWy2n7dI58BOCr4MKomjoJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QiR84lM3; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QiR84lM3" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1767615952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HAJ50QDzcNGq8LvMiguZDX4QYKgW6XNq4PfpmpJ7fsI=; b=QiR84lM3TZB4l+3xFAitFbeO9zeHAOpLNHAtziktyk5eD/4piimyWCNMsgcWzw1q2r5yg5 EqMXve8AXKAI+q/VAaonszFQzyYB4DeuJ7ay2oNGuM1ZHfEFON1jJEsD5yOP4u1zCVj3dF XetPVVHB25SXhFSHkH8LPmg2k50XLH0= From: sunliming@linux.dev To: maddy@linux.ibm.com, mpe@ellerman.id.au Cc: npiggin@gmail.com, chleroy@kernel.org, bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, sunliming , kernel test robot , Dan Carpenter Subject: [PATCH] PCI: pnv_php: Fix smatch warnings about "address of NULL pointer" Date: Mon, 5 Jan 2026 20:23:45 +0800 Message-Id: <20260105122345.157991-1-sunliming@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: sunliming Fix below smatch warnings: drivers/pci/hotplug/pnv_php.c:710 pnv_php_alloc_slot() warn: address of NUL= L pointer 'php_slot->bus' Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202601050123.5JEZ4Znh-lkp@intel.com/ Signed-off-by: sunliming --- drivers/pci/hotplug/pnv_php.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c index c5345bff9a55..a22b8d69a479 100644 --- a/drivers/pci/hotplug/pnv_php.c +++ b/drivers/pci/hotplug/pnv_php.c @@ -801,6 +801,9 @@ static struct pnv_php_slot *pnv_php_alloc_slot(struct d= evice_node *dn) return NULL; } =20 + php_slot->bus =3D bus; + php_slot->pdev =3D bus->self; + /* Allocate workqueue for this slot's interrupt handling */ php_slot->wq =3D alloc_workqueue("pciehp-%s", 0, 0, php_slot->name); if (!php_slot->wq) { @@ -818,8 +821,6 @@ static struct pnv_php_slot *pnv_php_alloc_slot(struct d= evice_node *dn) kref_init(&php_slot->kref); php_slot->state =3D PNV_PHP_STATE_INITIALIZED; php_slot->dn =3D dn; - php_slot->pdev =3D bus->self; - php_slot->bus =3D bus; php_slot->id =3D id; php_slot->power_state_check =3D false; php_slot->slot.ops =3D &php_slot_ops; --=20 2.25.1