From nobody Sat Feb 7 08:45:32 2026 Received: from mail-qv1-f100.google.com (mail-qv1-f100.google.com [209.85.219.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD7B0288C26 for ; Mon, 5 Jan 2026 10:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767608274; cv=none; b=a3/ovap9kE0dNostcX7rhh1pK1b5tH1EH/BqLJ/pw/Rqm2XB3Eei4Pl6JNiWwW2hB7iyj13h+2XYVpNRiVPpve+YFmT0e7NLH0UEn2VPniOogWEv2kJXn9S16mXujjgK2a3vfxGGT9wMfqu5Fl9KarTpNMBvajDBhSF5RTSExdY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767608274; c=relaxed/simple; bh=QY3HTEVaHPlfhfn0LQXxca+zyPZhcAwhzUarq0fwl9Q=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=I+6zxD1arlQODn4ptzQ4bn0ORigdGN2JzXLM+oTN5GgtaNZvURdauVHr96mTA2TvH8m0zpKzE42F+OB+Qh5XvmDOa3uZbAs5q7IbhU+mY+plDwAUzJzbtFBIuZwK6iNZFBm8xynvaSHPHpoGWgcwcV08n0bERK66h3Brx4HI0u0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=XVT72kka; arc=none smtp.client-ip=209.85.219.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="XVT72kka" Received: by mail-qv1-f100.google.com with SMTP id 6a1803df08f44-88a2d21427dso150645026d6.3 for ; Mon, 05 Jan 2026 02:17:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767608272; x=1768213072; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZDEZfxXGKUHqnD6uzu3JESKT0vdq+bi9ssWL2yPlp2w=; b=J6iED38dLFqRmGtklbcXTzx6FjzKp+Rd+PNuYQoQ3kXNMLAOBCYXWZdik7p638Pkl6 nfniErl+cfqC6yUz28wq2jFf8KuPT0jHEoeBsQBjtFhY096ktTpOazRcnvGYAu+65Vdh QdNWvFup3b0Tjt0EN7UtK/AZqem1OlFX9N2cQF36AmGYU7q9ItlFHl5RUVwkjJSPRq7w IUW1EZ49Y85bIqfPTcIZppTbF53X2dRi0Oewom/dJgAio2pwaHogJVkIUCWUfStMgYPj 8XHKHjoBxQL+upcv5Ev2IYlo9g8JX5ryl/2bm/LvEBGsu1zW97wTEqWBI/BYNT4ZGiUa BI8w== X-Forwarded-Encrypted: i=1; AJvYcCVv4/YpcobIPlnVWkLLaIVwYybhNVlQryQnrOj4ImrXThtAkxf4fNeJIbztHBQosEZklpz+4P0Kccu91+g=@vger.kernel.org X-Gm-Message-State: AOJu0Yw72+CVO9lM9GZ28Iwe2Io4BFZ86HSPM4aSmHzxlixO/+LPaSVf 0QXXQBLq9SVG2Iz3kbTKo+lkQfTw2AaDvND9R8Gcps13vbiJFICM25XN7WfI+grT9uUKGjFSOjY 8TNV8535dZdTFqZbW29K3d9lZoGBhPByRCVV2kI5CKRuB/Iv4Uv7c0P1lwXcy5wjgSa98neJ8wu 8b8kZL7diX3zkVgyJuuKRcv22+pF0f52Au9cU2fo7Q+Pguc1bl/LAScaPDY19m060JB1cUCxGJK MQoOiUfL/Q3ZNY7lTyh9BRRRA== X-Gm-Gg: AY/fxX53RQyXUrTj2BF0Zl4x5Nw3lu3n6oMCccIaSTZZWN4/mlGYimX84ofh5gDg2i5 heusd+fBbIJ4pFI0QwgrPnY1gad9gTbBdcsJ1lHrRdmUuc+Q7h/VtLvcJs/3mu7GcVKy07/UkcH K4rtBBX1dauXCtVY6LQFnoFuIouGtrHh0Np6hq9zdoxTsM324q97/lMAU5QpE2hbPwxXqf2sdLa FrpuU2WP54hLEcZRciYiyGwnYgcr05DJ42yd8QF4qBeJOSoyQzgQ59X3cgWdl/TOr5y/DFxobmw 7mjyLe3NOTFYryHk71xLqu8w4+jA3m2dOXp1rJH9JqgnUb3gTQnsdcAnVF2j1uXPsFYrCd6Hyic oABt1jFnA/FbotOTftyzI6UkOO7rC1dscbwm8gs446MzpJ23QRnwt9NfSyUIZJfCSVIFRrCsU66 kKiiZAb8lCtpJbAtlTqD9rT5JiiK/rVbykmP6ZwjEvnJJS5oJ8s1Q= X-Google-Smtp-Source: AGHT+IHVGTEXdRsxPQaZECGIdiwOwJzMW5K3ckIhGJV0MwQZdE8CaN/3kR6UhB3kjROjJtmXqWendqjFfWBT X-Received: by 2002:a05:6214:da7:b0:888:8096:a09c with SMTP id 6a1803df08f44-88d86e43f78mr753710496d6.62.1767608271597; Mon, 05 Jan 2026 02:17:51 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-120.dlp.protect.broadcom.com. [144.49.247.120]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-88d98055ca8sm67655216d6.28.2026.01.05.02.17.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jan 2026 02:17:51 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b9ceccbd7e8so31293421a12.0 for ; Mon, 05 Jan 2026 02:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1767608270; x=1768213070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZDEZfxXGKUHqnD6uzu3JESKT0vdq+bi9ssWL2yPlp2w=; b=XVT72kkahmHtaf719+HMdZO37C3gfnmLQw4FyrAMadM2CYk3a4lhAJOeKTrdwNfv5W gzNHLCfteYMe/qZhuUZ/gG7ZnauTI9+wYtcgITdjvpX1JtUGeTwoxK7sfJZlfrrbTj5Q 5s5EbShd9BYjVHhQvn7CNcjg4S6XdoIvJ11cY= X-Forwarded-Encrypted: i=1; AJvYcCXkNADGNsoIv5DXYGwmzuO+fgAyWALYUHOiiHUmt/fA1ttyLxEu2X+qXdUKbo6OilWczQAto6RxD5QGz7M=@vger.kernel.org X-Received: by 2002:a05:7023:905:b0:11d:fd26:234e with SMTP id a92af1059eb24-121722b821amr43934361c88.16.1767608269931; Mon, 05 Jan 2026 02:17:49 -0800 (PST) X-Received: by 2002:a05:7023:905:b0:11d:fd26:234e with SMTP id a92af1059eb24-121722b821amr43934337c88.16.1767608269346; Mon, 05 Jan 2026 02:17:49 -0800 (PST) Received: from shivania.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1217254d369sm170077924c88.16.2026.01.05.02.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 02:17:49 -0800 (PST) From: Shivani Agarwal To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Henry Martin , Sasha Levin , Shivani Agarwal Subject: [PATCH v5.10] cpufreq: scmi: Fix null-ptr-deref in scmi_cpufreq_get_rate() Date: Mon, 5 Jan 2026 01:57:01 -0800 Message-Id: <20260105095701.659420-1-shivani.agarwal@broadcom.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Henry Martin [ Upstream commit 484d3f15cc6cbaa52541d6259778e715b2c83c54 ] cpufreq_cpu_get_raw() can return NULL when the target CPU is not present in the policy->cpus mask. scmi_cpufreq_get_rate() does not check for this case, which results in a NULL pointer dereference. Add NULL check after cpufreq_cpu_get_raw() to prevent this issue. Fixes: 99d6bdf33877 ("cpufreq: add support for CPU DVFS based on SCMI messa= ge protocol") Signed-off-by: Henry Martin Acked-by: Sudeep Holla Signed-off-by: Viresh Kumar Signed-off-by: Sasha Levin [Shivani: Modified to apply on 5.10.y] Signed-off-by: Shivani Agarwal --- drivers/cpufreq/scmi-cpufreq.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index bb1389f27..6b65d537c 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -29,12 +29,18 @@ static const struct scmi_handle *handle; =20 static unsigned int scmi_cpufreq_get_rate(unsigned int cpu) { - struct cpufreq_policy *policy =3D cpufreq_cpu_get_raw(cpu); + struct cpufreq_policy *policy; + struct scmi_data *priv; const struct scmi_perf_ops *perf_ops =3D handle->perf_ops; - struct scmi_data *priv =3D policy->driver_data; unsigned long rate; int ret; =20 + policy =3D cpufreq_cpu_get_raw(cpu); + if (unlikely(!policy)) + return 0; + + priv =3D policy->driver_data; + ret =3D perf_ops->freq_get(handle, priv->domain_id, &rate, false); if (ret) return 0; --=20 2.40.4