From nobody Mon Feb 9 23:15:34 2026 Received: from mail-qv1-f98.google.com (mail-qv1-f98.google.com [209.85.219.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 914DE248F6F for ; Mon, 5 Jan 2026 07:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.98 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767597765; cv=none; b=D0a8/YNCTsscYWpagU5k51WnBAxR0KOg+ttnk+SBmUs3nMXsfPMQAVwPoIlT1dFjj1nyLkA8U0MSS3TQiccwX1QUizJprdn9j78JiiTLwk2R6zP6eKZ2QAtVN9oxPJHUwnhWrDnzj1fiJDWKnDOJ4XhindOCl+/jlc+aNk49w80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767597765; c=relaxed/simple; bh=/wME24CEwrWAEU21ThjVbixPTVFQSGmJJfmADqMDWp4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q/D49q/IQA2fCNGifNYh7PdwEszeP/Xes7wmjrp3dYtaEW4zarQ8z+k8iI7gnibaTGeX/i/gCLb8pcXXZv5SpP3LbaOzozbkpxwGnH7oMADtW9RqzAJrcUgCC8yiLbtA/fvYTjLkZDPGPCcSROtAfG5YrIrQjR5zLPt5epEsD2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=LF4fU+1d; arc=none smtp.client-ip=209.85.219.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="LF4fU+1d" Received: by mail-qv1-f98.google.com with SMTP id 6a1803df08f44-88ffcb14e11so108836326d6.0 for ; Sun, 04 Jan 2026 23:22:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767597761; x=1768202561; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x9hftn4favyaNi5RDxua41GjYksofMa+nNP6S0BT7ZM=; b=QAlGJNu9/zKlr8nNbmqWeAq8nFuzUtR/n/AoTlKgy9xP2A4DDSpISW0kJ1ax/CgvLs ezz+WWCJfK8waIBUGfzw9VQY02RA+wRZCBdFbE1T1qmQBzZlFz0Eznnt1Om5fqONHXmq iX4h6iA17kOTi6JqMP/bHj3+8XGWcIYXoMxBwpqVSJOAKjcxLu61GDvx/lWkTJRGt7mT S2/tQP5l8NRqVLm9vtfAPDpHJpZVinp9vvDnT0zrXAHYXpHpdbndCzxIch1bMUwsSMA2 /uDUpOSU3mPspxkST6S6QxvG0syJBDwlT0ptKo6cMQQgYK/5mIORWk7oEkyU5GG/Kv8k H/eA== X-Forwarded-Encrypted: i=1; AJvYcCUVaJqETHMEc6PRwPK2BiEastFSb2Fr9gDpcXfL2fFZdj72Gxm150GoKKnqbO2Kwathpke0fltF2iehHAI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9GoUEaJtcNqAH8D+eq8p0ODN7d1e5QDOO6eqgFeS6FdueFsvb WdpHIilcsatQ6z1Rnsc1WGjZLPoDM3rx6LDAhj4Z0N+7/LKOXwOi5Zo3NqNysHF6KTlZHggi/oQ D4Zv0F6MSsH3+tzeNCnsZ6Dn6w+dZNBx3962UE+AT+SgYPx5NRiwE2uqts/4U7CIIcgRp6FqE6R KCQuyf4p0nRM3T3k+oghljw9vYaJJQJzjPmMc61+dILLVhYfp7PXxOzeW7XTeThTv8wg2GH1Gg7 VdEENSMYObG5Yiv1PCIbfEMa9G5 X-Gm-Gg: AY/fxX7wI2wej8B7ZEm5unN7IVQkFRFwJ9vt64VaUqxPYdNIrrkNTO5KtCRLAedj1jM q8vW8PVi+b74SS+4B/rfoWXxQKTAvlHwrz6RHbzA0XtxSwJEYWquTFTfKvBpTPIJkP5CE9yQSwb yOpFAbXRzCZCQyfu7UatTdbab07zvjOiQAX5QhTpjh3VjNZ6hHGCYwJtsuPnkYEUKY/pf9cyEhI 5rkgVqmIeZNxxptyeq6iWG+mPA4Cta7u3bez4vYZinUUN+xEVlxB274NEGrKfEtOTUIlSr5q/SV ggc8/WzDsQmEFfMR9s/SOxGYwcvzRfeUxyQdze3Ud8gW2/MVK0vzXrIAbvM4b53wFyLne2HU0Rw ij6UV1Hp9xl1cQCJTAYoevwywkaQgZEuRlOrXllVaxiyfAllb0YqzSZE3hjwZS1QL4x+z1w7i6V Uegwa1I8YbDDeEqypbObeZOb3YLEoOIbyVoYtjHdNwB+S5BCdZuwDlZA== X-Google-Smtp-Source: AGHT+IHtEbpSz/yROB1nwNNF82+80kGZeHoXQnu9WnRDitcVi34zDmJlzxDCG9PeNgto/9Gf4q0ry9urucNO X-Received: by 2002:ad4:5609:0:b0:87f:fbe1:2c2a with SMTP id 6a1803df08f44-88d821376c0mr482756186d6.26.1767597761226; Sun, 04 Jan 2026 23:22:41 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-88d95889cbasm66946376d6.13.2026.01.04.23.22.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jan 2026 23:22:41 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7ba92341f38so14802904b3a.0 for ; Sun, 04 Jan 2026 23:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1767597760; x=1768202560; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x9hftn4favyaNi5RDxua41GjYksofMa+nNP6S0BT7ZM=; b=LF4fU+1dfq4+26hkQF0cfxhsKbDHCjvJpWjfzvfJZ4xLqyVAtWxSLqUtr4eI8N2xAJ l6knhSxY/UJM+f9955vOVaF/hyyJqgTQZZXyT4qPhInpBvxVhiSLe72KpW0301zWNuBT pj5iA3thRFSa74l4Jc/LWilnPoZO1MKOVZpaA= X-Forwarded-Encrypted: i=1; AJvYcCXBaTMi0gVbL84LuDifK3rvPJH/rN6gV+EdZDpqJRwkCk4NQ/yhOu1nSchhB01EcDAvs1V3uMwLy5rhGSc=@vger.kernel.org X-Received: by 2002:a05:6a00:430a:b0:7a2:7bdd:cbe8 with SMTP id d2e1a72fcca58-7ff655b041bmr39061218b3a.18.1767597759848; Sun, 04 Jan 2026 23:22:39 -0800 (PST) X-Received: by 2002:a05:6a00:430a:b0:7a2:7bdd:cbe8 with SMTP id d2e1a72fcca58-7ff655b041bmr39061202b3a.18.1767597759470; Sun, 04 Jan 2026 23:22:39 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7dfab836sm47293293b3a.36.2026.01.04.23.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 23:22:39 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v4, net-next 3/7] bng_en: Handle an HWRM completion request Date: Mon, 5 Jan 2026 12:51:39 +0530 Message-ID: <20260105072143.19447-4-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260105072143.19447-1-bhargava.marreddy@broadcom.com> References: <20260105072143.19447-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Since the HWRM completion for a sent request lands on the NQ, add functions to handle the HWRM completion event. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 3 +- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 44 ++++++++++++++++++- 3 files changed, 45 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 7533c382714e..ad29c489cc88 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2299,8 +2299,7 @@ static int bnge_open(struct net_device *dev) =20 static int bnge_shutdown_nic(struct bnge_net *bn) { - /* TODO: close_path =3D 0 until we make NAPI functional */ - bnge_hwrm_resource_free(bn, 0); + bnge_hwrm_resource_free(bn, 1); return 0; } =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 04989908b133..b5c3284ee0b6 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -77,6 +77,7 @@ struct tx_cmp { #define CMPL_BASE_TYPE_HWRM_FWD_REQ 0x22UL #define CMPL_BASE_TYPE_HWRM_FWD_RESP 0x24UL #define CMPL_BASE_TYPE_HWRM_ASYNC_EVENT 0x2eUL + #define CMPL_BA_TY_HWRM_ASY_EVT CMPL_BASE_TYPE_HWRM_ASYNC_EVENT #define TX_CMP_FLAGS_ERROR (1 << 6) #define TX_CMP_FLAGS_PUSH (1 << 7) u32 tx_cmp_opaque; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.c index db49a92542c0..fb29465f3c72 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -390,6 +390,43 @@ static void __bnge_poll_work_done(struct bnge_net *bn,= struct bnge_napi *bnapi, } } =20 +static void +bnge_hwrm_update_token(struct bnge_dev *bd, u16 seq_id, + enum bnge_hwrm_wait_state state) +{ + struct bnge_hwrm_wait_token *token; + + rcu_read_lock(); + hlist_for_each_entry_rcu(token, &bd->hwrm_pending_list, node) { + if (token->seq_id =3D=3D seq_id) { + WRITE_ONCE(token->state, state); + rcu_read_unlock(); + return; + } + } + rcu_read_unlock(); + dev_err(bd->dev, "Invalid hwrm seq id %d\n", seq_id); +} + +static int bnge_hwrm_handler(struct bnge_dev *bd, struct tx_cmp *txcmp) +{ + struct hwrm_cmpl *h_cmpl =3D (struct hwrm_cmpl *)txcmp; + u16 cmpl_type =3D TX_CMP_TYPE(txcmp), seq_id; + + switch (cmpl_type) { + case CMPL_BASE_TYPE_HWRM_DONE: + seq_id =3D le16_to_cpu(h_cmpl->sequence_id); + bnge_hwrm_update_token(bd, seq_id, BNGE_HWRM_COMPLETE); + break; + + case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT: + default: + break; + } + + return 0; +} + static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info = *cpr, int budget) { @@ -440,8 +477,11 @@ static int __bnge_poll_work(struct bnge_net *bn, struc= t bnge_cp_ring_info *cpr, rx_pkts++; else if (rc =3D=3D -EBUSY) /* partial completion */ break; + } else if (unlikely(cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_DONE || + cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_FWD_REQ || + cmp_type =3D=3D CMPL_BA_TY_HWRM_ASY_EVT)) { + bnge_hwrm_handler(bn->bd, txcmp); } - raw_cons =3D NEXT_RAW_CMP(raw_cons); =20 if (rx_pkts && rx_pkts =3D=3D budget) { @@ -559,6 +599,8 @@ int bnge_napi_poll(struct napi_struct *napi, int budget) work_done +=3D __bnge_poll_work(bn, cpr, budget - work_done); nqr->has_more_work |=3D cpr->has_more_work; + } else { + bnge_hwrm_handler(bn->bd, (struct tx_cmp *)nqcmp); } raw_cons =3D NEXT_RAW_CMP(raw_cons); } --=20 2.47.3