From nobody Mon Feb 9 11:05:06 2026 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7390629E116 for ; Mon, 5 Jan 2026 07:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767597755; cv=none; b=ud3V4rbIEUjvR+DwZJteqNDVaFRO4I+7sqwyS6n1z0QurBDkYrc/otcXFSmq+luQEEDUQPfIRtDvSxeEAGT2odnaCM16AEdPgqwseJ7v2xDu7k8TuFXnBVeSyylBUW8lhXKkmVOmFrREqn7mP5bhgxl1we5jCKcfqBWOl/8WDT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767597755; c=relaxed/simple; bh=G42HEdK63RMSkNcCPQGCk4X08ncSFrRURRT8K21yxRE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GZlMsByBlQbnvtE8eMmw0NJy96XKuVZ+aSttxwvKu+JLXx9DGd71pAyyrzPRXkNszVF/l22jl9GdhSSAdC4h6oZBJcv9GQlECqT+XFFvx1M1VZTQ0F+NMPcTVc01d+STG8E5qBYjO/Y7qU25nAEyMiUTKkKzWSSIqP/qUyQxxBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Jaxlceq2; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Jaxlceq2" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-2a0fe77d141so158223255ad.1 for ; Sun, 04 Jan 2026 23:22:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767597753; x=1768202553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P5v6be/rvU1Ddm94jt+LcDTFwMP9w1kpc8KK4AcGhZ4=; b=c2nCdeuYQ01HAUsLQwmOK/cmzqdghO5i962Mv1OQ6aIrJ25jC0z/rVffdsG4w050pU hF3Q33QvThEvvbiy5Aa7743A+gQRLHkeNe2buZmy9ltla6itus9HgD6YNI7YxilcfMs2 m7VaSnx3NiPl87av7fnHI1si0S7JQrDRuZ0lw/i9QO+ocrzrQwU8HFUFzwxK72531ujW IiYrxLxNl+vf/JTlt1cMiDZ5vBqYI613NpxpiZJ4DrGKsprHM/bTAmRURD8moK09Eelf zYqUoIb7pr83CWv+Ao87qdQ9oogQ3JzlgaEPjoHCgfAjdttnYtdUSC4jjpwbwGZkkwBG RsVQ== X-Forwarded-Encrypted: i=1; AJvYcCVEf9pQgG99ToVF1t0JcKxdVsfw4yLtRswd/Ga5RbHL1pYYigzUtyF0bqxYyw/vxeDJy5t3lg4+HhilYNw=@vger.kernel.org X-Gm-Message-State: AOJu0YxfLDsVfOqPH4N72bDhsXAi5ypNi9Fg5YB/ekAys/4UXq1Zlc6/ ACqPus/X1AUgh2YBBwv9C8EJRApskAy0qUibePTfX/AMcW3k5T6i1rZfEdo2tuiYOVCObezv/DV QKyvmy93eqn+Bku5iK7mazQRmbRuKR3OGoCP/qKJyhQEKnDFrIxzz5KVRPp9DlrsppvNnZjMYn7 wrPfRmF4WT411e9nxPKQX0M62B7Cf7XJzHIeEZUn8EWqJQAnYf/xIQvcDJlxHSwp4USy4pdYTaI EY+ptCYKKMWyzugxVE2axqxzZV3 X-Gm-Gg: AY/fxX6nXI+h8Q5diCBNGNK1pICXwf55BSohQuT+WHRsAr1zpEeyoFNC7wuLlq+HXZX NYU9C+SWY1WXWaAPSfVxLerAoT3JH8VHU825CNTGqK/jAYHPUawgEFHcX7sbFzCTJZx1k+SnTfO 9kp7/KeGTGbswXc+Uy00D+TKLrwF0i1KrnngeYlQZasPlvWgd/xKsPKxi/G+zp0tdlsGMfMFFQ+ jkDIgngaks3g8/Vat45fjP3/GrPlxFSpO/dhiouaZIo+gESdjdiNPE3kdBS4tyhUzuRsgiKFboF dv/ifEustiqvac/oqb4+Y5yhwy9M5rdU2FUj8HkaCg2pDCIzmSsj6fjo8j6qdXygInN8j7gDh7F EZBfFQ7y50Qhr7PdwKi71jophNFJpOMXqKUphWmxZl4MXAi+q/rIfbO3BDxHBbStT1L4wCEj9Hp y34JmzQoWO9nWXr5P2IJ87jiFxq0EARNjb/XP29ocIZrN89GcejK4hBw== X-Google-Smtp-Source: AGHT+IGwAirTqDWMzEMCugxMhoEcEpdUhYUHGLgEANyea3A5DO3qbEgk4iqB8qDemvGHf0zVw+otVjCvymK8 X-Received: by 2002:a17:902:c94b:b0:2a0:9084:3aff with SMTP id d9443c01a7336-2a2f2a5aa44mr496965375ad.61.1767597752589; Sun, 04 Jan 2026 23:22:32 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2a3bf5f992bsm9716805ad.11.2026.01.04.23.22.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jan 2026 23:22:32 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7d481452732so26004668b3a.1 for ; Sun, 04 Jan 2026 23:22:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1767597751; x=1768202551; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P5v6be/rvU1Ddm94jt+LcDTFwMP9w1kpc8KK4AcGhZ4=; b=Jaxlceq2dDbx8/1b68bqSeOvV6wto8qfR4KVKunN4LGbe5l8AvxT8Z2o0E/cqIvApi DYaslqnlAQfONEdz8pRe42WG8AVbAg9DvdiuHNZPfsdg6Mh5EYEyg/48JNz9kNxZt9Kj XV3EcdEr9qv9eOpeeXKwGw2IUM+5aiAwX9AVQ= X-Forwarded-Encrypted: i=1; AJvYcCUVuOwVoCjh/mQnjjsJ0up4kOq9wBXIscUmT0k52dPIVV69LijUCw3cWIrcmVTKX5DecqcbVKGpP9KkMq8=@vger.kernel.org X-Received: by 2002:a05:6a00:600e:b0:7fb:cf05:93db with SMTP id d2e1a72fcca58-7ff6667cc4emr44478626b3a.59.1767597751044; Sun, 04 Jan 2026 23:22:31 -0800 (PST) X-Received: by 2002:a05:6a00:600e:b0:7fb:cf05:93db with SMTP id d2e1a72fcca58-7ff6667cc4emr44478614b3a.59.1767597750640; Sun, 04 Jan 2026 23:22:30 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7dfab836sm47293293b3a.36.2026.01.04.23.22.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 23:22:30 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v4, net-next 1/7] bng_en: Extend bnge_set_ring_params() for rx-copybreak Date: Mon, 5 Jan 2026 12:51:37 +0530 Message-ID: <20260105072143.19447-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260105072143.19447-1-bhargava.marreddy@broadcom.com> References: <20260105072143.19447-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add rx-copybreak support in bnge_set_ring_params() Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 19 +++++++++++++++++-- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 5 +++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 832eeb960bd2..8bd019ea55a2 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include =20 @@ -2295,7 +2296,6 @@ void bnge_set_ring_params(struct bnge_dev *bd) rx_space =3D rx_size + ALIGN(NET_SKB_PAD, 8) + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); =20 - bn->rx_copy_thresh =3D BNGE_RX_COPY_THRESH; ring_size =3D bn->rx_ring_size; bn->rx_agg_ring_size =3D 0; bn->rx_agg_nr_pages =3D 0; @@ -2334,7 +2334,10 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->rx_agg_ring_size =3D agg_ring_size; bn->rx_agg_ring_mask =3D (bn->rx_agg_nr_pages * RX_DESC_CNT) - 1; =20 - rx_size =3D SKB_DATA_ALIGN(BNGE_RX_COPY_THRESH + NET_IP_ALIGN); + rx_size =3D max3(BNGE_DEFAULT_RX_COPYBREAK, + bn->rx_copybreak, + bn->netdev->cfg_pending->hds_thresh); + rx_size =3D SKB_DATA_ALIGN(rx_size + NET_IP_ALIGN); rx_space =3D rx_size + NET_SKB_PAD + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); } @@ -2367,6 +2370,17 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->cp_ring_mask =3D bn->cp_bit - 1; } =20 +static void bnge_init_ring_params(struct bnge_net *bn) +{ + u32 rx_size; + + bn->rx_copybreak =3D BNGE_DEFAULT_RX_COPYBREAK; + /* Try to fit 4 chunks into a 4k page */ + rx_size =3D SZ_1K - + NET_SKB_PAD - SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); + bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2456,6 +2470,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bn->rx_dir =3D DMA_FROM_DEVICE; =20 bnge_set_tpa_flags(bd); + bnge_init_ring_params(bn); bnge_set_ring_params(bd); =20 bnge_init_l2_fltr_tbl(bn); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index fb3b961536ba..557cca472db6 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -135,7 +135,8 @@ struct bnge_ring_grp_info { u16 nq_fw_ring_id; }; =20 -#define BNGE_RX_COPY_THRESH 256 +#define BNGE_DEFAULT_RX_COPYBREAK 256 +#define BNGE_MAX_RX_COPYBREAK 1024 =20 #define BNGE_HW_FEATURE_VLAN_ALL_RX \ (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_STAG_RX) @@ -186,7 +187,7 @@ struct bnge_net { u32 rx_buf_size; u32 rx_buf_use_size; /* usable size */ u32 rx_agg_ring_size; - u32 rx_copy_thresh; + u32 rx_copybreak; u32 rx_ring_mask; u32 rx_agg_ring_mask; u16 rx_nr_pages; --=20 2.47.3