From nobody Wed Jan 7 22:50:05 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C26802BE7B4 for ; Mon, 5 Jan 2026 03:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767583271; cv=none; b=AB1d6aygIKQ6CRmLy7/cqUsIEvQducUqtztHCN8WsGy6rjBidHrwzyu86GoZboqcbz8zEMP7D5ylJI8u3wGruLh+txz/qZFi84wUt1LF39JdLq03Ub0RZVwk0TEvefbIOi8mQp4IkWVNEtgLNokjtFBmDo7YHm6l956hrVsVzu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767583271; c=relaxed/simple; bh=Iv+5nblWkO00/r04WS5PXA9MBWrWfOkN2OfiOV3goqI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rk0f8COnQ+KYStdP9Oi7Bi9nFl8eyBl/e8bSeoxd5HymvkUUG7aqvfKmyJRPF87mqPSmhU/lakkxwJEcMgyeCW956aKhd72m611QMyeg+jNCuNNzyHiBVVrNJIn7wOPAGYSbz8a6LE2YsaaC/8sCFHmt4lBSSaicKruWUNYL7q4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QojswVZs; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QojswVZs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767583270; x=1799119270; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Iv+5nblWkO00/r04WS5PXA9MBWrWfOkN2OfiOV3goqI=; b=QojswVZsC3LMS+yc3+yDUIHI9sH/1THzOZO4eR3RIqZf6DsT7CYW4twT ZnBhbbl2IJyQu5rJPboDC5K+5/BxIQ9L6P1nIifzDO8dgjNU3yH6XEAMQ KtK16HP1FQUywIOjV8TzEp9xzS3Puw5umeUbXoW547FKq0Tv566J4c2n/ lDkNaqAekkwNaC6waGwhpKiIwmNnmN0uRZtcON5LWkpvtUGusbCUMCqwK dy75wVTETd/YsURSChnJRG2XJzte0rPj3o4DuJqn1d3boxQUWgZXtPgjd cSx8HDufJ41UCdieMwZzHTiqqWQQnJ+Og19c+28Q12Xw5p6nvAcTaDsfP A==; X-CSE-ConnectionGUID: Vk4UWVLMQ5CTNufJS7Hh0w== X-CSE-MsgGUID: mNU3noEXSnytoL3s0CnRxQ== X-IronPort-AV: E=McAfee;i="6800,10657,11661"; a="56511335" X-IronPort-AV: E=Sophos;i="6.21,202,1763452800"; d="scan'208";a="56511335" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2026 19:21:07 -0800 X-CSE-ConnectionGUID: SfqAlP9TS8CJpnziGVupUQ== X-CSE-MsgGUID: Jmr8lNoMT8GAsC1ur/BfTw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,202,1763452800"; d="scan'208";a="202310153" Received: from baandr0id001.iind.intel.com ([10.66.253.151]) by orviesa007.jf.intel.com with ESMTP; 04 Jan 2026 19:21:05 -0800 From: Kaushlendra Kumar To: broonie@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org Cc: linux-kernel@vger.kernel.org, Kaushlendra Kumar Subject: [PATCH] regmap: maple: free entry on mas_store_gfp() failure Date: Mon, 5 Jan 2026 08:48:20 +0530 Message-Id: <20260105031820.260119-1-kaushlendra.kumar@intel.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" regcache_maple_write() allocates a new block ('entry') to merge adjacent ranges and then stores it with mas_store_gfp(). When mas_store_gfp() fails, the new 'entry' remains allocated and is never freed, leaking memory. Free 'entry' on the failure path; on success continue freeing the replaced neighbor blocks ('lower', 'upper'). Signed-off-by: Kaushlendra Kumar --- drivers/base/regmap/regcache-maple.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/base/regmap/regcache-maple.c b/drivers/base/regmap/reg= cache-maple.c index ca1c72b68f31..4134a77ae1d6 100644 --- a/drivers/base/regmap/regcache-maple.c +++ b/drivers/base/regmap/regcache-maple.c @@ -95,12 +95,13 @@ static int regcache_maple_write(struct regmap *map, uns= igned int reg, =20 mas_unlock(&mas); =20 - if (ret =3D=3D 0) { - kfree(lower); - kfree(upper); + if (ret) { + kfree(entry); + return ret; } -=09 - return ret; + kfree(lower); + kfree(upper); + return 0; } =20 static int regcache_maple_drop(struct regmap *map, unsigned int min, --=20 2.34.1