From nobody Fri Jan 9 01:02:32 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B1A130F526 for ; Mon, 5 Jan 2026 02:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767579010; cv=none; b=meyXzSq531GHBarUfxLvNkkqFE6Mxxr46sycS96T09vghIjQ+UieVV2VoQII3ux7ocOOpOZiffxt2pJqAf6cdpbr+xNbb5KDDsNyM+zaqxZtyPG07YIKyEvw/iWfN7+bzSoJ7/PxM+w3jgznSWezFxcaiiZtdSSuGdGQQELnrnQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767579010; c=relaxed/simple; bh=mHd5/FDiQ86yScP8/xKWBTcg+ow54G9KDtNwccSg1Uk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rO2Jq+FKGK9IN/Km2IK2U/FRMGiEbRbBpQQPODscNDYEganzXh2pT6BJnQn8Aevkkt3EJhk6Xrrx9W5CuBsoh/eoWj3HKCfBI3ff8n59nFUahTBLQXp1ln03mdZFjjC4/iLAJAzjHDW86LwdBaY7CuuL4xZvhpX1L51SGYjH8p0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aHiu6se8; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aHiu6se8" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-34ccdcbe520so705575a91.1 for ; Sun, 04 Jan 2026 18:10:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767579005; x=1768183805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qykhmziqocBs83eOMsCXS+riegj3dQCRKqwsythsgqI=; b=aHiu6se8cpOvOqDc9GHV/ab3HTwsRuYtPOi6sJs0udSrqjXBXddSJ9XTx8qDx8gOz1 JjH8/O8/ORqxIWSl26yArqg+yDm+A0UOI1lRHReNCxE18wtRJ5ONbudC+zPbO0YnZ5mW suGB3VCHhgW0P2dIMO4UVZgzo8jTZPrC6HE6RkRzuDBcCCpE5vmQqI5+mTm6g22pwYN9 Zs3cwx3P9xrcPBIZSb9jPBk3cYGaF/ebv4Oxe2EkZLNFPVFPCMQSb1DadG5HrqZm34+F lcQT0rP7EKrMo2bVAXCkHDsw33uT5qIHbUIRFcLVACpwYPg560dYcsEVBlhXcHedON3G wfCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767579005; x=1768183805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qykhmziqocBs83eOMsCXS+riegj3dQCRKqwsythsgqI=; b=kzX/6tyXSWn5VOgHcdbauNMG1hThViL8wK2MVCjiE1t+nw8rXwMuczQRqSBMUr4LN0 tCGr3TYvcl+JNFv4zOzAlWarBRhsiO0FPPdVEB6SHkU1lguSAsl/zO7Dnb5bDxpVE9Sn PkLuO8uYStwDbPc1omZcXZqRvlO5+VKAHsqbVmR38TFg7LaLmZx9A3aPpYAqlG3FNDJD U0+XdZyHxzDU2LXzyRx6D1JE6oaqcVGVwtuYBY/LqM8SaCQXAhaTR2aObzcccH8sC9oW Y7Pjb1eMct0qqzR9P5MwBtodn5pnTv9GKhcun3GGBBDbuaDy1weYyv2iGfx9SsQMDiK1 MwXA== X-Forwarded-Encrypted: i=1; AJvYcCU9LZTxYdrT5B9X3LJixvC1tBlDQ1M8gUGbv8s3WwPNDOO3oo1sprrV9jjrHaMm/b51TYbXAVmD91dMhHQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzeSCdPLjXRUvei2HwkD4/51mIMSsO7U0a0Oj/e7jMOPo2Za9+4 lbgnUGN5nwlAknnHLdDDWm8QlI7Tfhzb5Kc+DkTAPu8kTbhLIO+RbO1T X-Gm-Gg: AY/fxX43QO5J7bwE/zrhc4cw5Ky3ml95IsB//BPoyWTP9QX8xzOHyPP6i02EsUMOZG8 ajLv0N8Mz2/WL1dG6F3KF9oLzjNoRnq8k+0FGu0b8zAlBa3GCTvN4W6DZirsKig6Wuq2foXl7Ph 78sxhEUly8P5ll1pBtTUvOuCuN7SBL06mhAKKErI+stznMnd9qVg3nprdbRrB/IjDULbg04UZSP Y1eXocblYSuXRf/0xXKFUWdtEuRbw5//zR9nW8hNmcC07Ra91aI57X9zCSY8cat1nhek56gus6s BlEfQVio+Cmw33Eq0qi5X8Xq3YSPrtAwb6iX00onIPIJdJSLZhfAYmtEB/0uOPxGYNa3fktIlZo GV23DMnooTucwsIqJiRPHFW6OQj9ZLO3tJ+DQ36Ui5PPYdFIF2CCpzDc1245Z5q7Nat/kLibRfO q7hK+CDQ4fEa5eqPk9VirnpWPwKugeOlwJJdzJN3v/1R5rg1JQyxFS5g== X-Google-Smtp-Source: AGHT+IGOQour0NkX3syOiO+wHoNuBNONrZarwLKTvm0Dywz1DdFpKhVE2PPkSnu+G8zeuD1+IqheaA== X-Received: by 2002:a17:90a:e7cd:b0:34c:2e8a:ea42 with SMTP id 98e67ed59e1d1-34f4537d9a4mr5221185a91.7.1767579005234; Sun, 04 Jan 2026 18:10:05 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f476fb838sm4427102a91.7.2026.01.04.18.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 18:10:04 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, Dan Carpenter , David Laight Subject: [PATCH net-next v3 1/2] net: dsa: yt921x: Fix MIB overflow wraparound routine Date: Mon, 5 Jan 2026 10:09:00 +0800 Message-ID: <20260105020905.3522484-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260105020905.3522484-1-mmyangfl@gmail.com> References: <20260105020905.3522484-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reported by the following Smatch static checker warning: drivers/net/dsa/yt921x.c:702 yt921x_read_mib() warn: was expecting a 64 bit value instead of '(~0)' Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/netdev/aPsjYKQMzpY0nSXm@stanley.mountain/ Suggested-by: David Laight Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 0b3df732c0d1..5e4e8093ba16 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -682,21 +682,22 @@ static int yt921x_read_mib(struct yt921x_priv *priv, = int port) const struct yt921x_mib_desc *desc =3D &yt921x_mib_descs[i]; u32 reg =3D YT921X_MIBn_DATA0(port) + desc->offset; u64 *valp =3D &((u64 *)mib)[i]; - u64 val =3D *valp; u32 val0; - u32 val1; + u64 val; =20 res =3D yt921x_reg_read(priv, reg, &val0); if (res) break; =20 if (desc->size <=3D 1) { - if (val < (u32)val) - /* overflow */ - val +=3D (u64)U32_MAX + 1; - val &=3D ~U32_MAX; - val |=3D val0; + u64 old_val =3D *valp; + + val =3D (old_val & ~(u64)U32_MAX) | val0; + if (val < old_val) + val +=3D 1ull << 32; } else { + u32 val1; + res =3D yt921x_reg_read(priv, reg + 4, &val1); if (res) break; --=20 2.51.0