From nobody Fri Jan 9 00:43:26 2026 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 823E62561A2 for ; Mon, 5 Jan 2026 00:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767572833; cv=none; b=dy8EiPYtvBEShjTJ/NzgalNuGk5skzKcsR4MtHgLPtVAJzeF7v6buT05imPBU+wpmRx+nXJL7PCpEW5eGzN9vPIOht8LGl7VI89uxTwE5WqpC996BT2cubhYLUkxHThZSED3d2um6DsMC3lA3/50XpSrjef61JypzdA3At9+BqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767572833; c=relaxed/simple; bh=tzBVMM2UuxU44r818zA3Ug+gigrUDnxlT5FMH8AOwj8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TmH9RjqkvicO3HRcUOVkFDZs1Y6ILhBW+Mc9x7NKvUESLN1LNKKwDdpWHMXV7e1VOqu/Kh6XnlR8q3aqB6PJmYkOFTIYYw0B8qz1mPwU5/ynoL+uwpJyxwcMSF5nvive632AjTAXspXbfgZJr2G9mJgeIvyJzY+gf7ED4aZnPjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eiHGmBdY; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eiHGmBdY" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c4464dfeae8so1153691a12.3 for ; Sun, 04 Jan 2026 16:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767572829; x=1768177629; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F9pZM3lVItBOVq5Rc4FqhGypr50RN8XCw42MqeJlzrY=; b=eiHGmBdYZQbLWcdxAIL+LAvvARyL+dYEEudPaJpOAeI0FnAvvCfUWbDUPyOnIiKaDt SCgBE+PxAgitdzKQ4Vu7SBw4bqEScXDVXW8SSGMLE2bW3+8mJYy+KqN4LRLPTpcPysbZ uzJWDhL4vqaNwDE75iYC/3xAzDR58z9Ua2QpNaji9qx3H+s9kFEuhq8N02AkEzSrjiJY 6Y0gzRkq7q8wgMzZYSamjSJzQiaPL4Tk6LdBXjwnHwdn0ssL0rufxRyZYYHPAKmLwfBv FknhusmTSTwxXU9/CfrZCVheIsZZI+fPn/8w2mtG0gZpihUP3KJxkGfZx8I9t4Q2Oimu 6SLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767572829; x=1768177629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F9pZM3lVItBOVq5Rc4FqhGypr50RN8XCw42MqeJlzrY=; b=nAv5M6I9KLNwD3wiCg37vAmRkmk/362sDwxuNOMU8Xe0d9IiO3AExxQu8173f+WI2k o14X5rX58fGRMOnwAvCOm4v3dnuICtEKqioZH8XECKhIlVOSlflMbhdbI9s/Esd6k/hv nX3LY47D7PuoqqI9rVB6ulohnOOtcSWmOoFjGXm73N5K1gSmM3Az1jstudq98LRp4dSK rrojNdQUt844Hsgr+U3nU+C8d82THtBKxzXKVHm03FL5nF1dQ9m1ANniwObqkmdqxzAp lNrMAwID2SfPzodtTFS9Igp63nPLvVTVmVC8cLcQUHVh0Kg0qIb5VldMV5iPBAV2r/+n KcBg== X-Forwarded-Encrypted: i=1; AJvYcCUexRefpBE+xuUvzy1yKfqLQ1IT46h4A2joZhldXw7GTFR6rU8s+3Ec7hfnX0U+3iI4PMVqApJAemNB3a0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6omH+TFX96HL6Rg8kvQbhmT9k6ThY7jF2naZHyR0US+1NDPMz UNfBwLcEKnyi2a5aiubwrAWbzQwV2DUu+ErqowVxqFJgQWLkCzbQhfgM8CgaNTb6 X-Gm-Gg: AY/fxX6/uH7UJBAPam2eGfwQ8aOw2YmQ7fuUNZWtEgVL+6mvyCADw1U4t9/R8lt73VH uv01CQrEvooQ4DpW3kfHodnQnlT1jZJS0auoROwjYQQpeKiUrOBZHkS2U17SzFnkPEiQD8I0wKJ FsM7U53PcplysyA8X++Wi9JjbyRkstN4XLi2mSZ4kk/Pm03ha32MsL6EmFcaPBlEbfA+99eRyp6 K6JdiOCly5Syr8whSp8bkTUyP6UH7NS6bl/KF2OActXiqJn/D/+PIIgSXab4jhfB4EKXQ0mJPOz Vkm7y8CP3CHr716HiSK6gmKXlzhw3P/Cz2nqLT4wBXXQIkBQv8fL7zW1wbleMNUtRrOyqo/h1dB GZRtSx0kaLUB7wMSUdwwsmTYVko8ur7mbaGCYC0tsP73Fws/ViOLFj3aU+zNWc4wim+cc1L1wa8 fFJKaDuGOaGH1zv8c88qL0nzuWGVXZmcI4xb3y75+53BNQXfQCVMyAPG3UUQ+Jupo= X-Google-Smtp-Source: AGHT+IG7x1Ymdyvu9lCiNZWjm0VKOPz4jnCYI4WRlVDYrDXMAI2/7wPYk6ox4CoZIXyf7ZKZ1JhkhQ== X-Received: by 2002:a05:7022:218:b0:119:e56c:18a9 with SMTP id a92af1059eb24-121722b4f87mr46583592c88.17.1767572829297; Sun, 04 Jan 2026 16:27:09 -0800 (PST) Received: from zubuntu.bengal-mercat.ts.net ([2001:5a8:60d:bc9:9ebf:dff:fe00:f8f2]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724de268sm133378109c88.8.2026.01.04.16.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 16:27:08 -0800 (PST) From: Zac Bowling To: zbowling@gmail.com Cc: deren.wu@mediatek.com, kvalo@kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org, lorenzo@kernel.org, nbd@nbd.name, ryder.lee@mediatek.com, sean.wang@mediatek.com Subject: [PATCH 17/17] wifi: mt76: mt7925: add NULL checks in link station and TX queue setup Date: Sun, 4 Jan 2026 16:26:38 -0800 Message-ID: <20260105002638.668723-18-zbowling@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260105002638.668723-1-zbowling@gmail.com> References: <20260102200524.290779-1-zbowling@gmail.com> <20260105002638.668723-1-zbowling@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add NULL pointer checks for mt792x_sta_to_link() and mt792x_vif_to_link() results in critical paths to prevent kernel crashes during MLO operations. Functions fixed: - mt7925_mac_link_sta_add(): Check mlink and mconf before dereferencing - mt7925_conf_tx(): Check mconf before accessing queue_params These can be NULL during MLO link setup/teardown when mac80211 state may not be fully synchronized with driver state. Found through static analysis and pattern matching. Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt= 7925 chips") Signed-off-by: Zac Bowling --- drivers/net/wireless/mediatek/mt76/mt7925/main.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net= /wireless/mediatek/mt76/mt7925/main.c index 7cf6faa1f6f4..81373e479abd 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c @@ -871,12 +871,17 @@ static int mt7925_mac_link_sta_add(struct mt76_dev *m= dev, =20 msta =3D (struct mt792x_sta *)link_sta->sta->drv_priv; mlink =3D mt792x_sta_to_link(msta, link_id); + if (!mlink) + return -EINVAL; =20 idx =3D mt76_wcid_alloc(dev->mt76.wcid_mask, MT792x_WTBL_STA - 1); if (idx < 0) return -ENOSPC; =20 mconf =3D mt792x_vif_to_link(mvif, link_id); + if (!mconf) + return -EINVAL; + mt76_wcid_init(&mlink->wcid, 0); mlink->wcid.sta =3D 1; mlink->wcid.idx =3D idx; @@ -1735,6 +1740,9 @@ mt7925_conf_tx(struct ieee80211_hw *hw, struct ieee80= 211_vif *vif, [IEEE80211_AC_BK] =3D 1, }; =20 + if (!mconf) + return -EINVAL; + /* firmware uses access class index */ mconf->queue_params[mq_to_aci[queue]] =3D *params; =20 --=20 2.51.0