From nobody Fri Jan 9 00:44:14 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B766A19D08F for ; Mon, 5 Jan 2026 00:27:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767572826; cv=none; b=ZMvg+LrjMIc1yDLVGNWNKtyIFOl0S04g9GzZRj0K41sNyXfOx01/UlpjtcjL1al1QTVRlhQ2zympVso7JeFTgql7u8t22yO6ywaOMko3hy9OGVL6ouSX9b+wggl8iARiXxiujFuG/gP8nJgMaTU64AWMHEwJekAEMkt6O3bmbyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767572826; c=relaxed/simple; bh=vz3x+77kdQ8P9steLlJ4yD4DGKBh00DAeJdBPKKnDns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kvucFxGXPytNOARyi3o0t0QIC+aYr8rb4s683iMG2FlnZAAgVVHRGGOinE/M5ONZful02mBoamsixSb50ETNgs4Ug1qkWM+SgUfN4QpLDvqO9XDHQZgU1jtQYfVOv0yZ1VPkWiwfRr49FbSiLUSpeK63yM9xRB1Zh0PN9j8OaDc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VV3N9+zX; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VV3N9+zX" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7b7828bf7bcso15938987b3a.2 for ; Sun, 04 Jan 2026 16:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767572824; x=1768177624; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XH+kUxxNmkYGglYPogPQvwZMB6lkd5MT/5/E1Mc/8s0=; b=VV3N9+zXrWQiKcuwE3S8bnYuenzhfPEwnKUkDk+8Q/a1D4DzVwK1NRRn8MVrfIMofo pRUMz564W88aak5BQ7GuVxQYy1AFxV6CtLWWZU4STX4tbxNLx5VrCgmK/5Xwa98OXEmP 3SdFmsTjsnOQEvfKw9Koy1yt3QP+2PIyt4RFx89SpegFNQqN2sQ9eEAzivzg2iKONfD0 D/4Q+/sthMh2VQ3kOU+Q9y8GecNKLsxQHU9+8MnvGFEU5UqYUcuFeK8gI+5T1JRk+ncz 29ShCQvy2W0RReiQN1cj5bme331XzV6VLHyK/EKjLJjRwNEUeBdTxf70oUDFS6EepQAg 52aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767572824; x=1768177624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XH+kUxxNmkYGglYPogPQvwZMB6lkd5MT/5/E1Mc/8s0=; b=vSDTqtSgumKKe7vtBIclv+gQfsB2V1sffuolZHF5U6B3Hslg7IzLcjP0eLt403D7es q86o62L7h+paMIIVtqas7NxK3C30pc/nbzG53hZzaBedlGsNKKYEHms8BctCQc6Snz+Q nW88GDu1wXkakBRmJ4uIikW1IUwdNaD06F8G3+2kKH8Q8fTmCqnNuhp8iQ12qEhO0nPB lqdZe5YGXIgRHS1NN6mRB3A/MOD80Wnc5eBk/219ul7ia3kFrs9wBn0CAsVh9OFhJW57 lueD1UUtcPpmm9RFBZSXQ4rz3w1e3nlpjSuxYj/qkg/1gwZU5uYnb9cVqrjNGBfJIj81 PFDA== X-Forwarded-Encrypted: i=1; AJvYcCWYUsFn26nZcErgWUcTRJQznYP0gZrHTmT2kUYdHe/SjxzgsdgtMCXpHSjRoQarqToDQPQttvp4YV5Uf9o=@vger.kernel.org X-Gm-Message-State: AOJu0YyPLPSSXw0803ux++nzOoEW2MKrL1FPC0w1NN62D+zQYvAbmp7F wxGp2v5SbF/ObYy17fJlEc3wkhTGK8p2aMbjB3C4oFG0kEluQ9DBIrZK X-Gm-Gg: AY/fxX4/gv8XVhVyAvJojtb1dtPKf1Xjfj9Tbg9JFIyQc4leKzsFJwJ7fUY/T2AWYIc 1ZlhiWBvNvc6Be9Jx874R6voJc0/4Qh8Ysd9N2703TFt5e6QetNEVVe/oiJ6orEioUbp6AHCaN9 QuItlXkEMpOGcHmDERqqYl8OZbrUBgFopYVWCqsxCDSKohleIOiMUFBmHgTodEad6sXg2JsZIKR bEkbmoXqRA1pNWdQxMzrR0d1M7CKI+2cHfbFfrAydqLCBcz2KAOTrlk/engk0g9+D9acANQUgnt JPWgPPwp6yWZA1NBH2eSp/w0yj+9ft2pkXWuvEnE5RhECWqwUiuNLcpquEVdbT4waQoRXFew0vF ztsu1r/ByVOgMsVft7YuoZDDa8/aj2n81139KeGJSGsXuljw/ujCjFcO+EOIxCDxKClp9kQKz5K 6JNLR87LqeJyaPPBh42uFoTH1RsIL7q+Q/exB6y4tRFmVscekoDQyyDhM3iZCBbv/clpuFeRJrg g== X-Google-Smtp-Source: AGHT+IHlVitLt85bPnu8RzuCU7BAPGF8BkeHdJkRJzJ94cVKx159KPw5GrT2Tq1B7JMG8uWETW358Q== X-Received: by 2002:a05:7022:370f:b0:11a:b04b:3c2e with SMTP id a92af1059eb24-121722f3affmr27965097c88.29.1767572823527; Sun, 04 Jan 2026 16:27:03 -0800 (PST) Received: from zubuntu.bengal-mercat.ts.net ([2001:5a8:60d:bc9:9ebf:dff:fe00:f8f2]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724de268sm133378109c88.8.2026.01.04.16.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 16:27:03 -0800 (PST) From: Zac Bowling To: zbowling@gmail.com Cc: deren.wu@mediatek.com, kvalo@kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org, lorenzo@kernel.org, nbd@nbd.name, ryder.lee@mediatek.com, sean.wang@mediatek.com Subject: [PATCH 12/17] wifi: mt76: mt7925: fix key removal failure during MLO roaming Date: Sun, 4 Jan 2026 16:26:33 -0800 Message-ID: <20260105002638.668723-13-zbowling@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260105002638.668723-1-zbowling@gmail.com> References: <20260102200524.290779-1-zbowling@gmail.com> <20260105002638.668723-1-zbowling@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During MLO roaming, mac80211 may request key removal after the link state has already been torn down. The current code returns -EINVAL when link_conf, mconf, or mlink is NULL, causing 'failed to remove key from hardware (-22)' errors in the kernel log. This is a race condition where: 1. MLO link teardown begins, cleaning up driver state 2. mac80211 requests group key removal for the old link 3. mt792x_vif_to_bss_conf() or related functions return NULL 4. Driver returns -EINVAL, confusing upper layers Observed kernel log errors during roaming: wlp192s0: failed to remove key (1, ff:ff:ff:ff:ff:ff) from hardware (-22) wlp192s0: failed to remove key (4, ff:ff:ff:ff:ff:ff) from hardware (-22) And associated wpa_supplicant warnings: nl80211: kernel reports: link ID must for MLO group key The fix: When removing a key (cmd !=3D SET_KEY), if the link state is already gone, return success (0) instead of error. The key is effectively removed when the link was torn down. Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt= 7925 chips") Reported-by: Zac Bowling Tested-by: Zac Bowling Signed-off-by: Zac Bowling --- drivers/net/wireless/mediatek/mt76/mt7925/main.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net= /wireless/mediatek/mt76/mt7925/main.c index 852cf8ff842f..7cf6faa1f6f4 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c @@ -605,8 +605,15 @@ static int mt7925_set_link_key(struct ieee80211_hw *hw= , enum set_key_cmd cmd, mconf =3D mt792x_vif_to_link(mvif, link_id); mlink =3D mt792x_sta_to_link(msta, link_id); =20 - if (!link_conf || !mconf || !mlink) + if (!link_conf || !mconf || !mlink) { + /* During MLO roaming, link state may be torn down before + * mac80211 requests key removal. If removing a key and + * the link is already gone, consider it successfully removed. + */ + if (cmd !=3D SET_KEY) + return 0; return -EINVAL; + } =20 wcid =3D &mlink->wcid; wcid_keyidx =3D &wcid->hw_key_idx; --=20 2.51.0