From nobody Mon Feb 9 02:12:35 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7A0A17AE1D for ; Mon, 5 Jan 2026 14:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767622568; cv=none; b=PWbEBJmD5MlNkSBMqf7lAN8Sx7lQmWB9MJvBLAFlgIuCmsjh7tTKGDgOYKKWLCxV1GC7QSEP5j7wcVAJ6b/joQItboMxFyFNuHik/hexz9nfJZ12VPPbydLvIKFy0ljRPUil97tun8z0UIUGGxUcN3dPBJS7TQ9XnbmX1y0dfCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767622568; c=relaxed/simple; bh=uxegMP4ngfz6YTXW5vsipTEH39YjT5UqWwy6wlSpynw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cuJtxk8acud8K0Yt73MpG9NOfYwKZfYTMdMLVjUNfmWBxnN411qFplZ45G3UYyjhBnGuRYx/80sCIGzAbHRdRP/5A4PqBu/tWzUUpmBgMBkx19qTVSGyDmVDHQuDskpteH4fPbxoBcn1bLPxx7hqFikiGTSoR8fJ4jRx7Hf31I4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j4LGe7Dh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AEtTE2jB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j4LGe7Dh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AEtTE2jB" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 605AJBa8091785 for ; Mon, 5 Jan 2026 14:16:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5XexJX5iQg/6Cc+7RXXC3iY4y41qBJxRKM+icYmx2H4=; b=j4LGe7DhJAi1YeY7 9eecKo00iULICHDEU/xviIdyNpG+Ft+h5TMHSImeYbZHWxdWCgbZXHJkLVWyO3qb swbY+8/d7QEHbSIoB4xgOZ6G4y9dsHRk3oxsZD48phjdzuClPF+QEAC0/Z5YgmO+ aZ1fDyXrpU54qaF9fYwIbbcBL31IlOJ8la7ANpEsQTYFfG6iDwNCaAEU8CTSKjTq 4jagtbZ2GvzQZSwd8aSTF9Xt9N3OG7gyylCEdXj0b1Fv6aG2GasAGuwkUFd69BeO 7p9BNxWIkn0NJ0ocQCJqZo2U3xRMCWaTHB04VzBG+eqCt9W3mmVNpvtTsTttysIO N3C2zQ== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bg4v61r36-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 05 Jan 2026 14:16:04 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-55ad466ae47so31249941e0c.3 for ; Mon, 05 Jan 2026 06:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767622564; x=1768227364; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5XexJX5iQg/6Cc+7RXXC3iY4y41qBJxRKM+icYmx2H4=; b=AEtTE2jBL69LBjwP0OrWn9S+UDkSTVp/hkPGE5PwtWjYt1bAjcB1SPOH+1MZXY7oVG N8UqMkArlGTH5IDpilYODPJfSsymADtzid5XY73p+nmTKbt6evzGSi2due/gGucWR0ys PxKJIGUzm+P4hf3Osgfx6Q/LrZOcncW7atR8fP+YTziC4yDSsnitifQNm16ArRyuG2Y7 YBWa2puwNdso6K9oHZWvAJsmxPjbpvv9vzb2XPZve7AO/w8tT6mMKwq+oxe3gt29N7yS 0SRvUpqOOYgQv4p+unqX7cYtdtibkHL8kpXAxmTH2QPpBLYBDvpT+s6msnTizXWMZrds /wOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767622564; x=1768227364; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5XexJX5iQg/6Cc+7RXXC3iY4y41qBJxRKM+icYmx2H4=; b=QTP37EZ7eaG9MNSHRYo8tUOtcj7PqTzRtI2gxfIdTyzqmGlT5F1JuQ3RB2YjCth+Wo MzO/PFMnYxSf5AMBesUT0RmWY3/L5fb2lYPyWnftfS1mYUrnjukMm/L41vn3L4J+yk5S W2xMTHh8JY7Q31eErIWIFFeQPDF5CIwshCHhLLpvGFbnTI1BDOL/dToU+wspa23GvUMH VXzQEJbC7M2SP+dIYH6spwO84/NUVfbyfjLB2HiOAPmZLfhVDILXxW/2iBiK0EhDpTJS x6meMLOQHjN2LDqZak22ZaAeX2pUQMfQ3ZZtHsiBZl1bbxlLCBx/JnY4FOdjFCe/qzoQ AcVA== X-Gm-Message-State: AOJu0Yz0u6LreNrTWH7obvtjUJBRKmb0n1pz/+Co//N7uhHzMAbZSjzx NsIpdt2rLxCAJo+e7ng157EmtmiKiNpB6/BK/6hqrGtKAfoow9bSCcib5NmtIhfM8Ly1+voVUB7 Tw38MHBxzeMBmROC0sUjwdIW99Ll6WhGLJx2clSImuknEYfUqi9D3jDN5MPbSc+yrAj0= X-Gm-Gg: AY/fxX5QDTNdRIeG/fOOqRG2ivUZ4TO3aukMpGD8th7QHUkmUYliD7oRAzOxK5xRXdf MGk7iXVCcka5cTUlYBUPLzJVAPSpSls8QjS95XEFhfKLw/lw+9xzZ8TqKJUKNw0fMo25RL2KRjC 7mnmwngCHtcn3xwQoZaE7yo/gXqCjpOvhMvCngBp2nXL5hihgwiKSA+wtqH5TnZZaW9lpG54eXb oF3WvuYJO7HKamH7gYWoGBrEqP3PrZ43RF/nBsWRi4FD12WcnLnIsEI06Flhqm9xltJEQuSValL 25qpIqaVx7lqTFDa4o++t7xiMED4Wt54NWsRVk4XrFijvoaNNVG6iA1DpMoxxt/wxX1b0QjzUcC yDAnc4INf+8MG3WkeMb5JIG+wo0pUQ6+uB7mMo3M= X-Received: by 2002:a05:6122:883:b0:55b:305b:4e34 with SMTP id 71dfb90a1353d-5615be902ccmr17456391e0c.20.1767622563893; Mon, 05 Jan 2026 06:16:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwW/2sgUTawIcHlk+zfDnV7xE72J04w6iAMqO0EiH5BcIc2qAlqXPL0fMTBPWQhYxpxkNemA== X-Received: by 2002:a05:6122:883:b0:55b:305b:4e34 with SMTP id 71dfb90a1353d-5615be902ccmr17456353e0c.20.1767622563369; Mon, 05 Jan 2026 06:16:03 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:dd3b:c635:dd06:9574]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1aef7sm100774703f8f.7.2026.01.05.06.16.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 06:16:02 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 05 Jan 2026 15:15:20 +0100 Subject: [PATCH 01/15] reset: gpio: remove unneeded OF-node put Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260105-reset-core-refactor-v1-1-ac443103498d@oss.qualcomm.com> References: <20260105-reset-core-refactor-v1-0-ac443103498d@oss.qualcomm.com> In-Reply-To: <20260105-reset-core-refactor-v1-0-ac443103498d@oss.qualcomm.com> To: Krzysztof Kozlowski , Philipp Zabel Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1633; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=uxegMP4ngfz6YTXW5vsipTEH39YjT5UqWwy6wlSpynw=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpW8eULIfHxTd1csJI9/EglgTdGdj5vX9iELAIU b4fi/r0OQeJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaVvHlAAKCRAFnS7L/zaE w4pvD/91ttTwXG+Aldpz9UzzlMeDwOd0Z5mCflfjCtJbdzT1nf2bDoOvvl7IXjSHbDqyevX4g0J yeCLfvLCp9gvb7DxBmxdN4nCnvFnZYT9J3wWfvqG0VoPccap4Gy45rgXLjZKvlIpwygDRrjM12X ahzwaER3OfVjfCaQMf7xK7oD/Nx77pAYMkS+mFAqktKZNPc5rPNio9PCczuoFYQ/A5EFQOEjX59 pWuh4w6M29z4mSV/PWec181fMFAA3zrrGO6f7QJd86AR3RwSbxldZPJgWJvmMBhX4zHRp0rfRlN ex6IgZ02NQCnR58d8zNNYoKTouD/xcyZNhAnUrY+DPM7r8fzN4Di86SZgTvT/QnAdSrfysV8IdS wSYTeVhfw3H1CCQ4EVNCOAiAokVYkPIfVuTcYo69VITWKK7NVKrAgcuCl2ZIfLJRW4ld1OGW0M9 t62EAg7MYla5KDkXpcj8dqDAJG/l723QpLsQ6AxipEma96LtAG2UnmJ4aa2wQfIJcdUrduXlkNn jmtN5974QD5zPxOGT5PGXn7oq47c55dSA1bAms5UWE59gaXYpnxU5iLSQMjQPB9z0WnG2V74STB z4ySShW8hCiyuvXN4bA1CRpcBBhi/3Z/mn6ej1RJ1fzPK4Xyr3o/I+tjkHUglVnFHLJbL31zQp0 q7ccFaqfbuOdsAg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDEyNSBTYWx0ZWRfX6yepMVhLbNa+ vDcK+CouU/J+Tax0bHG9okF3Fj2Zwcwue0NheOXQkx5uJESdsVjSWjI2/EI95pOPDWWEQlg+HCW SEsYi8EqvChG3+iK4qbY8xQmcPXqnq795ZFhnFUmMb3jh7zouKjajrUzv5aaqQqAm/YOiSLzdVs sgeSL4WSa1fGniPD5sgwaFLuVjUWJIwIfUOUPZpH3pNv3XSCZEHZpKGfTqmct1oZLXsPDZ+ovVs RGRRjWHYm10BI8eG/Z70/2clzFM9xyTKwEOP7lZdLcizFslos8aQTGgcvoFTYG6CYZGYyetRCrH 97oU7i05/QAGZZ2B3YBvHYw6MyQxqtGg/yfPp0enYrrDxB5PtvuH4TAyYb5aQj+cxCbh9el1deU CJN5Q5biT3AGl8/oVuHDh6aaNoKP7nsorrCM0DJwjVWIFuHtcPNyu//bvuN2nqH6zQ4ynxoYLtn achbg/pAs92uzJ1mnHA== X-Proofpoint-ORIG-GUID: sGAJ7Qa6N71B5YbG86DpwjyY7BEV4PH8 X-Authority-Analysis: v=2.4 cv=c4ymgB9l c=1 sm=1 tr=0 ts=695bc7a4 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ygpbbqW4ee5_35vKHe4A:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-GUID: sGAJ7Qa6N71B5YbG86DpwjyY7BEV4PH8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601050125 Tasking the reset-gpio driver with controlling the reference count of an OF node set up in reset core is a weird inversion of responsability. But it's also wrong in that the underlying device never actually gets removed so the node should not be put at all and especially not at driver detach. Remove the devres action. Signed-off-by: Bartosz Golaszewski Reviewed-by: Philipp Zabel --- drivers/reset/reset-gpio.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/reset/reset-gpio.c b/drivers/reset/reset-gpio.c index e5512b3b596b5290af20e5fdd99a38f81e670d2b..003bad361b3d32560f931f6b922= 34de523f97cf7 100644 --- a/drivers/reset/reset-gpio.c +++ b/drivers/reset/reset-gpio.c @@ -56,18 +56,12 @@ static int reset_gpio_of_xlate(struct reset_controller_= dev *rcdev, return reset_spec->args[0]; } =20 -static void reset_gpio_of_node_put(void *data) -{ - of_node_put(data); -} - static int reset_gpio_probe(struct auxiliary_device *adev, const struct auxiliary_device_id *id) { struct device *dev =3D &adev->dev; struct of_phandle_args *platdata =3D dev_get_platdata(dev); struct reset_gpio_priv *priv; - int ret; =20 if (!platdata) return -EINVAL; @@ -87,10 +81,6 @@ static int reset_gpio_probe(struct auxiliary_device *ade= v, priv->rc.owner =3D THIS_MODULE; priv->rc.dev =3D dev; priv->rc.of_args =3D platdata; - ret =3D devm_add_action_or_reset(dev, reset_gpio_of_node_put, - priv->rc.of_node); - if (ret) - return ret; =20 /* Cells to match GPIO specifier, but it's not really used */ priv->rc.of_reset_n_cells =3D 2; --=20 2.47.3