From nobody Mon Feb 9 18:48:17 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FD1A3314DE for ; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; cv=none; b=iihww7Z1zmbPQO0yBWp0mCOXnIA43wTz9QQUGxwFBdozVSJE4u/Thw8scdoovJVodDvxsQgu1wM8lArMwikBmzhBQ9D+LDnSh4gAk9mMMvrucUNmwYO7YyRZIMe1j4hs2b4AjBN5d22rk+tBsvXBUf2xxHxMXxAs28lB8HzbgQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; c=relaxed/simple; bh=O++W+XGALzh8MFUMgZfv9i2Z9xQlbx152lgCqyih+BQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q1b5ZF/3ewlkplUrZAbX7Wy84fTpnJ+yNjKvmUhxl2+fSnIqqIJd2g6D5kKrHYslfxEWc3cecW/ZnA+KJcKU40w/Oefi78Y6H9yenPykEdKcl85vHymxiIU+LNHa5dCQcCz/0/JhcAo5EvMtgnFZJqKdWoR/cD7dZC/cw0DuOjs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cw1Y0U0G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cw1Y0U0G" Received: by smtp.kernel.org (Postfix) with ESMTPS id 11E23C19422; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767644705; bh=O++W+XGALzh8MFUMgZfv9i2Z9xQlbx152lgCqyih+BQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=cw1Y0U0GH0buegMVh+JcBWk2hjLGpNShEgDEU6nQNeJU0bDAwsXL1OeSRWXMgl5CZ 1fhuYXBb6ExrJj6ZvrjDBR41Yv8WZSMScYthfYigaZuVOZPJNeS1ekiwGEPczfAUlX XDsfpY85BBb4O5Wrqzj7gCXTcrUxcBS27X/qNdFcnoZzW5tPbfZ6o760Z9yVKDFCgv qrvftGw69RDzueJvbZ1MDJNADM8oEsTc68SlgNX0I/1nQgFh5J9x3SZILpUjst9izO E8w+MqcL5Y884JWZG9tno25lVJxqtd7FMUOVi10u4SEUsrNIr4Iqli8pkzpkHISU6G e0qRvj6WQG4dQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F358BCCF2C2; Mon, 5 Jan 2026 20:25:04 +0000 (UTC) From: Sebastian Krzyszkowiak via B4 Relay Date: Mon, 05 Jan 2026 21:24:40 +0100 Subject: [PATCH 1/5] drm/panel: mantix: Enable DSI LPM Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260105-mantix-halo-fixes-v1-1-1ebc9b195a34@puri.sm> References: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> In-Reply-To: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> To: =?utf-8?q?Guido_G=C3=BCnther?= , Purism Kernel Team , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sebastian Krzyszkowiak X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=876; i=sebastian.krzyszkowiak@puri.sm; h=from:subject:message-id; bh=ranr7EXhYO2dHs5BA4aYCo8Op/vp1BIUidKU26E9D+M=; b=owEBbQKS/ZANAwAKAejyNc8728P/AcsmYgBpXB4fO3h3CtAiFssxXnaLfy8p9UQeh2skVa7wq Pw6PiGUgfSJAjMEAAEKAB0WIQQi3Z+uAGoRQ1g2YXzo8jXPO9vD/wUCaVweHwAKCRDo8jXPO9vD /36nD/9ZEHP3wwbu7iRj/w4bPjdu7Akmd9Wsay+D5b/l4rEdvqdzdG1b7nbixPCPiO8vhHvyPBz 385E/llSqbZjaK2J3SI5gZSHJ4gswJxTFjTktedOgvPFv4fZcHvFT4aqX8PA+EDo17bJOtMyOfV ExZ1xI8hw+Ot3ZPKS3f8yiFOYHskYv8M3OUt7ZJtLNXR0Ba5nL4e11wsA2zHLlyU7EgObCqZx5n VrYgQ4PKZST6jog3aM3aTacUNuJPD74zlW1FB116vrznUt0ikOoj6GMGWgyJ1SdLwMm6w8NliUP yybleFHCqTV1yL7Vz20/87thgnZv8E1Gwy5/QENfuCXC5XbSd+n+f65YdmP1heaFnNxaK7aYR4T hkXbH/P1UWA6m62Y38yzSK7qXUJhnN91P+6bO3ZBTLTNTha8kbtaKlBueW4p/6M75fq3+LE+djA DvMlL4k5eN7Q7YVLqUzoEvNvUaz0Hfq12y8RZ/kW/hYf1BtbN77+DIKtTJpAKpollaIHOD/45gL 0OordlYds5ZIcga/3aXMCkeosBRpyMn7g2OO58xVqMDQNYxB3fhRcSVKc7cMpIk6IBnQCnkmvar WI+XRAy3oQ2qopxSx+3mtR5eL6pwZu6YUtWG8Zj8D+VvsihDqWNUcIa84B7Dq1/4ekLgQN2ZKbf hMJ8SPtJeBNliFw== X-Developer-Key: i=sebastian.krzyszkowiak@puri.sm; a=openpgp; fpr=22DD9FAE006A11435836617CE8F235CF3BDBC3FF X-Endpoint-Received: by B4 Relay for sebastian.krzyszkowiak@puri.sm/default with auth_id=32 X-Original-From: Sebastian Krzyszkowiak Reply-To: sebastian.krzyszkowiak@puri.sm From: Sebastian Krzyszkowiak This improves reliability of sending DSI commands. Signed-off-by: Sebastian Krzyszkowiak Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu= /drm/panel/panel-mantix-mlaf057we51.c index 55664f5d5aa5..fafd80f3e952 100644 --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c @@ -258,7 +258,7 @@ static int mantix_probe(struct mipi_dsi_device *dsi) =20 dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; - dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | + dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_VIDEO_SYNC_PULSE; =20 ctx->avdd =3D devm_regulator_get(dev, "avdd"); --=20 2.52.0 From nobody Mon Feb 9 18:48:17 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 494D0241139 for ; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; cv=none; b=ZZKini4IxMT6VDg7hlRs2UZqGuQ78a4QQWCSgLKnXtoZRislZBkO+vrDGr82cXBgJMu5fbfRZ+YdK83KgYiwM+d+5S+zsO3puXze1K/xZtYH74FP2tZtXYsSi5hojymrC7pSg898NuoXwEnqVl4b3Hevb4BogwnTeQnqcloC3fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; c=relaxed/simple; bh=3rxe3rmT1bk2LVddtFgDhbwvJy5XvcZCpn517/udXR0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t9dsc6so3Hj7dOFHAM7upM493ySs9i/F6Dq5o7mAHunk1S6wL22/5vdaBa0CYZAmKDe//UWZ25SU/lqmom+RzyK+jgZ74s+z4H4A8jzfTF7rV9MvVjjTPo7657nDWO/FBq+70dAzmHqD2wzlwRG/3rES/w5PjM1b2C1WhJpEd0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qD3wGVrl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qD3wGVrl" Received: by smtp.kernel.org (Postfix) with ESMTPS id 190FDC19423; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767644705; bh=3rxe3rmT1bk2LVddtFgDhbwvJy5XvcZCpn517/udXR0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=qD3wGVrlGPMmIuNGArI/I0zkicv1CMomY8jlm/vcKQaH5d7nMpuqCfDWm2TmFBZxX n7mhDylPQAMMWsxtRAazJp/RiBDiWcUabzagXW28BXd99P3aJ4HfRnj/Pfsuh0/q9P EigYUeJ+pUWzGxgKeDe4Qt5fwWGYRZOm2TKh0KXr8cSnw1hotQkiv1J6Dcmwp2NOGU qLTCFUF4ay6QfsO7tCx8IxE5saF1oUMsEmkvGP/IOsLdXbVor1Kog9bf1i+IE3TrYX xWfYE0fwMmnCYscn0/NiDjDcJGAZyMVeskZbTCVjh8fhux9k5qAagYMiMRIc1VMnV0 FDQYavqyPULCw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DD4DC98333; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) From: Sebastian Krzyszkowiak via B4 Relay Date: Mon, 05 Jan 2026 21:24:41 +0100 Subject: [PATCH 2/5] drm/panel: mantix: Improve power on sequence timings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260105-mantix-halo-fixes-v1-2-1ebc9b195a34@puri.sm> References: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> In-Reply-To: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> To: =?utf-8?q?Guido_G=C3=BCnther?= , Purism Kernel Team , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sebastian Krzyszkowiak X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2841; i=sebastian.krzyszkowiak@puri.sm; h=from:subject:message-id; bh=+lx7oCnZsmz/hc+E2uLHt5Sr9SJYKGdqkUO7Y9TOBro=; b=owEBbQKS/ZANAwAKAejyNc8728P/AcsmYgBpXB4f/GmJrvlrjFV+kFaqlM8tsoozNtfq0l8re dXchf5Xx1eJAjMEAAEKAB0WIQQi3Z+uAGoRQ1g2YXzo8jXPO9vD/wUCaVweHwAKCRDo8jXPO9vD /8aLD/0XAsfH4wAd4HcK59CrMKyM3EmfoTOGwWMw6CA4VKIkQd52yS7TnCLTm/E/MvSZqsIXfIX QeckWjjUpwyHg3I43k/GF/OYYFfzYvvX5VZIeq7pEmWrWbSJnGT19QktMgk2fAB3h7IgrUzFx3u MwElljOjJdbesFzbKOWXxnKlZCg7uJ86otSt58uydb1d5T5ZicbyUXwSQdS1vR8Iz0rTIRjhp8e +14CBtT62UzXz/g/NcNjezve/U876rBgDeTXy3JttC1rhuIpyzkkw9NsdbEcrDdcKS4P/j8pQ1q nLlqei/TZP+hy+xqNwSJWW/K7dsBXcza/y9mTXMbA+LZcTokQoah7cEbznpCY/rb/82O6s9lySs iYtGXBT/PqK6kfkGkK7Xp0ORRe5ehke6AJZMqSAICYeBzk3nlcejCgtWrUJaSJMUQJxxTkr4fyt hj4hc3X75LvxRb9LUK1KL03SHF9iFMYLomH2RutZDA11ra1s1YJVQjjNqbUEVYtjjdrWKffjhZO F5lY+YZdaZ750pG9EsyfW/rPq/qgzlsX5c+ME4MKExoowkX86Si+zSLWEPATtlFH6qcz3v4CWpM 35YiWv5YER+jwhUVXoZ0J487Ar4HQEdoNtLhbW/KXZTrxOjwHBpn+kuJdZ9LnEQlUcNcqLohX95 ekitXjoGK3cReKQ== X-Developer-Key: i=sebastian.krzyszkowiak@puri.sm; a=openpgp; fpr=22DD9FAE006A11435836617CE8F235CF3BDBC3FF X-Endpoint-Received: by B4 Relay for sebastian.krzyszkowiak@puri.sm/default with auth_id=32 X-Original-From: Sebastian Krzyszkowiak Reply-To: sebastian.krzyszkowiak@puri.sm From: Sebastian Krzyszkowiak FP8006P datasheet mentions: > It is necessary to wait 15msec after releasing RESX before sending > commands. Also Sleep Out command cannot be sent for 120 msec. This hasn't been respected by the driver so far, which could interfere with the LCD init code sequence performed by the controller. In some cases this leads to VCOM voltage being set to a wrong value, causing "halo" effects, temporary burn-in around the edges of the screen and degraded image contrast. T3 and T4 are counted from when VDDI is enabled. There's no need to add them when we've already waited more than that in T2 and T2d. While FT8006P datasheet does not mention a delay between exiting sleep mode and turning the display on, code provided by the vendor uses 120ms there and it happens to be the same value as required in newer datasheets for newer controllers from the same family, so it seems appropriate to use it here as well. Signed-off-by: Sebastian Krzyszkowiak Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu= /drm/panel/panel-mantix-mlaf057we51.c index fafd80f3e952..bb5489e4d7a9 100644 --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c @@ -58,11 +58,9 @@ static void mantix_init_sequence(struct mipi_dsi_multi_c= ontext *dsi_ctx) =20 mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI= , 0x5a, 0x09); mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0x64, 0x00, 0x64, 0x00, 0= x00); - mipi_dsi_msleep(dsi_ctx, 20); =20 mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_SPI_FINISH, 0xa5); mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI= , 0x00, 0x2f); - mipi_dsi_msleep(dsi_ctx, 20); } =20 static int mantix_enable(struct drm_panel *panel) @@ -75,8 +73,11 @@ static int mantix_enable(struct drm_panel *panel) if (!dsi_ctx.accum_err) dev_dbg(ctx->dev, "Panel init sequence done\n"); =20 + /* remainder to 120ms (7.3.1 Note 4) */ + mipi_dsi_msleep(&dsi_ctx, 70); + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); - mipi_dsi_msleep(&dsi_ctx, 20); + mipi_dsi_msleep(&dsi_ctx, 120); =20 mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); mipi_dsi_usleep_range(&dsi_ctx, 10000, 12000); @@ -147,10 +148,10 @@ static int mantix_prepare(struct drm_panel *panel) return ret; } =20 - /* T3 + T4 + time for voltage to become stable: */ - usleep_range(6000, 7000); - gpiod_set_value_cansleep(ctx->reset_gpio, 0); + usleep_range(100, 200); gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 0); + usleep_range(100, 200); + gpiod_set_value_cansleep(ctx->reset_gpio, 0); =20 /* T6 */ msleep(50); --=20 2.52.0 From nobody Mon Feb 9 18:48:17 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FD9D338F55 for ; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; cv=none; b=STmWl8mSxTHpvVAEDdPYeSAqmWXiWsZNAN5vEKKknE4hNgDdkeYdDuhty9LdIkwwhZfTfn1lkMgL5ZiVm93nY8B6M7R+UeTilUorG9C0A+7tYMR4Swl6IZZ1tiqTJQq+lvudIRONR7KJeJZCe8OAnuIOyAIXPBGXcgaC9jroNMo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; c=relaxed/simple; bh=zfQVRzbGancd/dU4asYi2E0hnd0cNIecEX20zJbsHaI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jK1gNtnrTFYT9JoQGGdQxYFMHLZ08eEwSNtNRJfu/Z9InTtq9M6jiZdtZC+4ZCWev0SbH44tJI6zgKUaWYKlgpuirGFtl/xjZ6RhPawK5+wtv7pKeFaMjy9n5MWdWjczAYsVdl2Vnj9hRYdzG0lHQ/BZWDpJVXxPqZQyZyWIRCU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cd7+QTX5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cd7+QTX5" Received: by smtp.kernel.org (Postfix) with ESMTPS id 27585C19425; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767644705; bh=zfQVRzbGancd/dU4asYi2E0hnd0cNIecEX20zJbsHaI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Cd7+QTX5HS2bgbreSDFhCjffph//+3khnw8V2q9r/WA7O6YOiATbIQ+UCMe0BwStR MjDLTOWhH79l8fbARyBN+3v7OZfbBGQiZsXdva9/3ogx8EMOJzwlZbo6pgvuhk2PAc 1Pgb62MD0ZZ0WSP6dsTHusAcjpZh2+x31uyvwYwpOqVSaGEkU0OivDlD8/eYdmnI5c c/kafyJftMabKiEVceYkbE0xM/OjXpz+xGuKmbWdzwyZusbC8nTVLJJTNLghlt4CrS yxQntUkS4+tKxXStMdzsmsmY1rlVOWpwNA+Pv4lQGf4gAw2pTtPGtdB0ixwp7Q0I7K Qmsr6ciRjrZaQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C018C98331; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) From: Sebastian Krzyszkowiak via B4 Relay Date: Mon, 05 Jan 2026 21:24:42 +0100 Subject: [PATCH 3/5] drm/panel: mantix: Improve power off sequence Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260105-mantix-halo-fixes-v1-3-1ebc9b195a34@puri.sm> References: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> In-Reply-To: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> To: =?utf-8?q?Guido_G=C3=BCnther?= , Purism Kernel Team , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sebastian Krzyszkowiak X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1555; i=sebastian.krzyszkowiak@puri.sm; h=from:subject:message-id; bh=Dh/WLymhJdMwIFAEyjNt9y6Y69wAsTgzXgbPUFyjE2I=; b=owEBbQKS/ZANAwAKAejyNc8728P/AcsmYgBpXB4f8uRY1ZjG9N97EnweMqwiHxMBjoTGniYKv bWVUu38hIOJAjMEAAEKAB0WIQQi3Z+uAGoRQ1g2YXzo8jXPO9vD/wUCaVweHwAKCRDo8jXPO9vD /0PbD/wOg8dkELC2fI87ZLxwvGJT7X3J685RUQ9xUTJWewx1+EgONaLuHKqdy2ccAdSNKGE36Hg uSTEkZDkCKhq6eDB2w6pP/w6sMq/CZl1+2HnpKfewgER/LaLIQNvIe0t7bWDocBY8wp/j0xeMcj kFubhYNrbzw2fBTLDZ/rxfVIxsKYvoLgLmTUvF0iOWhLE54cXYsUw/773J64ou+/dVb3Udtv+3t D0AOUfB5RpoLZQQXNeiYLknTQ/Jw+sIWcJBKIiY8qzi+eOVTEfMfYCv8efVnUNVkmYQ69yeuIU2 rzoete1Cq9TywCCGV3IZfTFPCN9U3A8ttmg+rmBwNvJVsL6MuqOMT5Rmjm71bneJXq9JjXq6i0+ WG3k485viogjiLrw3xfVcRQOWumzsGPIhWIG4QcGUNWBx/JsPn13PXprQD25JkqnCu9bX+Hy/0R WRlf9kZqCUhE8Nhl4bvTZCQbm0V4/n7BxBqYVGo+o9oXBbReoGUpoYugF0WL3A6MiSFOcfgNNXF OZhpoX7qv0zBlHFXmfZXmmwgbqWX6uWzxoMc1GgB8JJN0gP785JCHb7Z7w1U4iaaYVMeCfD8UyR hkmhFhky5Eex1mIMCdH7KcUGQiCz7hh2TWWjhTFaVHogaD2SouDfnDFNOLKZ6SJZC33DTZOg5pw rljEfVOKgX0DmIw== X-Developer-Key: i=sebastian.krzyszkowiak@puri.sm; a=openpgp; fpr=22DD9FAE006A11435836617CE8F235CF3BDBC3FF X-Endpoint-Received: by B4 Relay for sebastian.krzyszkowiak@puri.sm/default with auth_id=32 X-Original-From: Sebastian Krzyszkowiak Reply-To: sebastian.krzyszkowiak@puri.sm From: Sebastian Krzyszkowiak According to the sequence from section 7.3.4 of FT8006P datasheet, TP_RSTN and RESX should be asserted after disabling AVDD and AVEE and together with VDDI. Also, AVEE power down needs to happen at least 150ms after entering sleep mode. Signed-off-by: Sebastian Krzyszkowiak Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu= /drm/panel/panel-mantix-mlaf057we51.c index bb5489e4d7a9..0e66ee7a727d 100644 --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c @@ -96,6 +96,9 @@ static int mantix_disable(struct drm_panel *panel) mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 + /* T10 */ + mipi_dsi_msleep(&dsi_ctx, 150); + return dsi_ctx.accum_err; } =20 @@ -103,15 +106,16 @@ static int mantix_unprepare(struct drm_panel *panel) { struct mantix *ctx =3D panel_to_mantix(panel); =20 - gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1); - usleep_range(5000, 6000); - gpiod_set_value_cansleep(ctx->reset_gpio, 1); - regulator_disable(ctx->avee); regulator_disable(ctx->avdd); /* T11 */ usleep_range(5000, 6000); regulator_disable(ctx->vddi); + + gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1); + usleep_range(5000, 6000); + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + /* T14 */ msleep(50); =20 --=20 2.52.0 From nobody Mon Feb 9 18:48:17 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E8CC33A01E for ; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; cv=none; b=M8UbMn0HaPsr3cHytYY6N81N5tWr3nJ6q+RGXAv7QoPexTXuuA0jzznVQx4LUa1kT/XdcFrHMyPScdRG7oJrGpV2zkvjIvqPL1IX4beyHPfbNLfBUtvjQrGyxTTIlaNrqH9hFt0Pl2RnnzrxpERxzmZLrQ2B7ok3QVI5udTa4GA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; c=relaxed/simple; bh=mcbobS0/nLFdLVEHHe81rVV3FetOs73mgF92KpKfKZk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HdItrXoDmQlTTReDghTedUzvN6y7mvA7gWXRkvBDciAfEHpdXCQzckJHN7Z75rNxuKpehxYxHqBvi8Nk7vjLkAUtjcHDRszDJKR9Lo4BEx/CnxXFzIr+ahlvOMpPoKJo+KIZfzwU1ngRO97PmDq/Hl96IaycIDfBDSEiiE2egxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Av/+BWh8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Av/+BWh8" Received: by smtp.kernel.org (Postfix) with ESMTPS id 34C28C2BC86; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767644705; bh=mcbobS0/nLFdLVEHHe81rVV3FetOs73mgF92KpKfKZk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Av/+BWh8QRLqn8ZcpjcgjHvnckWqA61J2oIxZFu6qkOz3BJylnEHiFL08A38s1JJR I1l49azEFUVVmV+CEAcE7UU8vpzoFYyoYmavnJBZLga42JH32CFLSXNiLA1VHjtntm HFY/0cnLbeJYAvTC/NnU0klUNJW5rvjsxyzZB33j7NhQ/m9t8as0iPeqK9UA5HVuDK A46stB+dch4BPeGj9rEi4seq5ezjYvu1N2LSJ6ihRtwL54V+Rr4/7BiVy6zsZCxXrU Tj315l9BzzVbX+cGuIBx5r6zAtmWSzQZt73tYx9F7AfkWLVAA9/ziGoyw/PBt6/BWP 3+mwDK6ya6zlQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D4FDC98334; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) From: Sebastian Krzyszkowiak via B4 Relay Date: Mon, 05 Jan 2026 21:24:43 +0100 Subject: [PATCH 4/5] drm/panel: mantix: Drop bank 9 initialization Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260105-mantix-halo-fixes-v1-4-1ebc9b195a34@puri.sm> References: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> In-Reply-To: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> To: =?utf-8?q?Guido_G=C3=BCnther?= , Purism Kernel Team , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sebastian Krzyszkowiak X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1501; i=sebastian.krzyszkowiak@puri.sm; h=from:subject:message-id; bh=fTacoISDzrsIe/qkVdq5L0I6TElHekwwcldH8QJ1a6M=; b=owEBbQKS/ZANAwAKAejyNc8728P/AcsmYgBpXB4fC5NgsqchE/2gem2pBTgPEsSA3MSi0AeWO a0p6kjY03eJAjMEAAEKAB0WIQQi3Z+uAGoRQ1g2YXzo8jXPO9vD/wUCaVweHwAKCRDo8jXPO9vD /wgLD/45bdk37+Gb53U6QZv9uoKXGGwyUaY8L/3KxnZ816JREFJ49oc5oHv/swwujzDgNXYSkTb TOu04mrc8hU7YVfkAKfW7Rrnxk5tSvHSbBntHTQEglk+9gneSqqPpx8YmIUs4v1OVBqMzvVtRBO +ss7uwqEF0/HLv+FP26GrlqYCCy42NOR0peZmsR7uZ/+a+qdMEj42FZfRDd7CFe2iH22RyNA+tU 0+obpqQicZCcvunr340lUFVO3WdaNNOM+cpEK9kaar1s0y0BTdgCtG3yxeT2nJrxp+3fsDOK/qd rFw4YI44HHP1IetZFwZafTIkaSVJgFO3MB0eq0SY7gNRa9KFRn/bFBrWtWGoi0t+HO/VDNW6xY2 lE04/oOuxsjWkEKDGCXh0TNgW6XR9Ujzuyub1FfhXn9SoUXMm2+G06lmPrSHCUbXXAz6jHfVAuU WtxCoZ2z0ViH4vxCn0tcXlZSbkRidO3ggWreQslxGYCZmhZkCzJrl0D3fLZWoM/UvqidBCRHYvR lqoqA+f5XAS1G8EZG/whvSPJd+rCgbykUt6WfZK8SSnYOgxyxVmSiWUELfNEBAAucoD5e1L+OOq QomC7CuMvCoZNosYJcbIPKyqVKztZCypXTOhGA5hkRh9E7toX83m1xALZqgl9D4x61e8wBWIu6U A/VGE19oyJt8jhw== X-Developer-Key: i=sebastian.krzyszkowiak@puri.sm; a=openpgp; fpr=22DD9FAE006A11435836617CE8F235CF3BDBC3FF X-Endpoint-Received: by B4 Relay for sebastian.krzyszkowiak@puri.sm/default with auth_id=32 X-Original-From: Sebastian Krzyszkowiak Reply-To: sebastian.krzyszkowiak@puri.sm From: Sebastian Krzyszkowiak This command is part of LIC sequence included in FT8006P firmware. There's no need to repeat it here. Signed-off-by: Sebastian Krzyszkowiak Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu= /drm/panel/panel-mantix-mlaf057we51.c index 0e66ee7a727d..30e378faafcd 100644 --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c @@ -53,11 +53,9 @@ static void mantix_init_sequence(struct mipi_dsi_multi_c= ontext *dsi_ctx) mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI= , 0x5a); =20 mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_INT_CANCEL, 0x03); - mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI= , 0x5a, 0x03); - mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0xa9, 0x00); =20 - mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI= , 0x5a, 0x09); - mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0x64, 0x00, 0x64, 0x00, 0= x00); + mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI= , 0x5a, 0x03); + mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0xa9, 0x00); /* VCOM */ =20 mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_SPI_FINISH, 0xa5); mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI= , 0x00, 0x2f); --=20 2.52.0 From nobody Mon Feb 9 18:48:17 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E849339863 for ; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; cv=none; b=Iu7umdH1itwJIy/gbtZlfCWLOwbaS1Fnbz8Ia1S6sKv+sq160qlVJn5kJ6qAq6ly6geZ9p7Y33+T0TmLTiAYXE0lIZhdRgVaQn5gylMAc1x4hM5V5WsDIy/g7ImA8EvtwHpKjLTcouVrWvb4WfYDseu20Bd/a9680AqeAg8buT0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644705; c=relaxed/simple; bh=AN1ycg2Jr3+tB67FOAfEQb1zF5xQdZOCWe8LjDKTZNM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WcZczlfkoPLXJd9vekGPKJBHqML1DmzDAp9vZBE/ehFKbBCu+ldYbq8ig4goKNdUNYo+orvLEgGU1fZ9hT4E6k18D0MX6t1nejTgC87MVr4alYelEogqeRnWY6d2XPe0byvv2SKn9ysBCpIHgWMUHT62oJOZSa2DzklugVXB7vw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VLcr5pzP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VLcr5pzP" Received: by smtp.kernel.org (Postfix) with ESMTPS id 443FBC2BC9E; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767644705; bh=AN1ycg2Jr3+tB67FOAfEQb1zF5xQdZOCWe8LjDKTZNM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=VLcr5pzPOBz0QB7EVg+m6xUumRpkCLphdzBxtFaGfb5/LugWZ2f416MSmcFOtjE4H 3o1w2MoaTnMkRnltmcUFvU5/XvWpdqlX3lhFIJtLn2hsNXK3UyT//HYj36c+DLDLTb 00r/hLWg0LRL/mYyM2+2JuTB1fCKTLjsQx1lxj5x/q3vjxeudYzPjD2ISeP0QsfMxX qKeJC0OIGv8Sa50DrxbnM7L/uLa83I7ObQW4HRg/9ZyrNiqsRxSY4vMH5GaCJH5lz3 JNdJhMZCjWEwGx4ApzIMy7i1tzDhDrX+x+LzqxDm8sNTddmfhuS/Mltk1j+O5bBEX2 a1sgfQ3NgkLHQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C6E4C79F90; Mon, 5 Jan 2026 20:25:05 +0000 (UTC) From: Sebastian Krzyszkowiak via B4 Relay Date: Mon, 05 Jan 2026 21:24:44 +0100 Subject: [PATCH 5/5] drm/panel: mantix: Don't turn on MIPI peripheral Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260105-mantix-halo-fixes-v1-5-1ebc9b195a34@puri.sm> References: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> In-Reply-To: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> To: =?utf-8?q?Guido_G=C3=BCnther?= , Purism Kernel Team , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sebastian Krzyszkowiak X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=750; i=sebastian.krzyszkowiak@puri.sm; h=from:subject:message-id; bh=wzX3EhJOQLlO3siwfFm5QsCfUWD8LUAgzLS3TEqb+Y0=; b=owEBbQKS/ZANAwAKAejyNc8728P/AcsmYgBpXB4fA4zf203rKJwuSpxRbHLhNyBMcGZElCcow ikVSWuREM6JAjMEAAEKAB0WIQQi3Z+uAGoRQ1g2YXzo8jXPO9vD/wUCaVweHwAKCRDo8jXPO9vD /6XQD/9YRWHVJHTuVsWdmpefFhuqrkdQ4Mal2qi/muZg0wXJqkQakGc7qMqEwWdsiqdgKTVAyaj T4gDxtULVY89EYuiHMRYT5Apk9mmPjm+P4114lOTV5Jr8XGXq8Rww4DijAoXDR5esbJbh6A+Cfl S9azg+ADcfhtfIzD+GOspjmgpXh0GTP20Ywhzucb6Eao65KbmE39A/Wvqo1QZAeX1BDhH6ErqSH dx33Ea7AoZ+es4qfpVmKtBw2aO8buKlzdKmH13UfTyO0kO7Q49WgeAKweuIcwvGZ+w+ga8QLkea VvuLLOQW+AJrdunHSAXuqrYjKCvCJa+ikPZpLE/qVJQJvYxSEAti09Gws/GwooftgBOImtAI/gz eVvW1AqfAexss1JiBsL60eyepD4u6W4rsegdKq9RZG5ZEJzpNmPKGUx8P+Rwz0xqORbirtk2Ves 5uafx7i8Hdfkfr5XdAuRxTMfJcFXHA1FDNVMYE2wkoRmzgElx0U/kuLDZgSOzx5MgymTwGH+88W 06lHpDwdKBobcjMcXPdGc9+rFqh9+7jpVKh6PIo0K8ylElkJFjk+4PMOyt6JcLH+IimHgeOh7/D yZlzhGY8A9JkQvTf2BVyLsmUTF2sagYt/n73ejLWlvAggj8K5ZqMTIz0V4ocz6/cKZhL9GsHMdg 6Kz4zgVb/FdQV1g== X-Developer-Key: i=sebastian.krzyszkowiak@puri.sm; a=openpgp; fpr=22DD9FAE006A11435836617CE8F235CF3BDBC3FF X-Endpoint-Received: by B4 Relay for sebastian.krzyszkowiak@puri.sm/default with auth_id=32 X-Original-From: Sebastian Krzyszkowiak Reply-To: sebastian.krzyszkowiak@puri.sm From: Sebastian Krzyszkowiak It's not necessary with these panels. Signed-off-by: Sebastian Krzyszkowiak Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu= /drm/panel/panel-mantix-mlaf057we51.c index 30e378faafcd..13352cb4ad77 100644 --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c @@ -80,8 +80,6 @@ static int mantix_enable(struct drm_panel *panel) mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); mipi_dsi_usleep_range(&dsi_ctx, 10000, 12000); =20 - mipi_dsi_turn_on_peripheral_multi(&dsi_ctx); - return dsi_ctx.accum_err; } =20 --=20 2.52.0