From nobody Thu Jan 8 00:13:53 2026 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACF732E62C8; Sun, 4 Jan 2026 19:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554113; cv=none; b=uKtW8UV5/2clqbjHMtK0LAenA73W8PzqKsA3tYK+/V/tU4chl4mL4ZfSonbTWPQhrBRiMYXNqwKbEJDrYDHlqm7UZznZ4knybc9kH/JjWUdVdMmug9tDtIARwomjaPyoiX2yPgkSeJK6S0Gk4IyGcmGkBaFpTnl9f/bfnFuDR8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554113; c=relaxed/simple; bh=Ku9ej+6KxThLUXufGtRshx/9PlSlNlku+EFMKkd34hE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QtV0uOupKfHNNvW8g7gr4sb1uI3CiXFIU8j6GAf2g/KUW0waN2cqEFrWBDGdXcT9E4jFYwTjgDggVMKt2r2kBmx5CMiCroakMA5IRWvK1YIBmQm/NeSklD+lcv5dW/JjzPPgtoGNLdBxJLKR8mYABsUcxh2k70he3VYVcV3Y8Rw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=2UgbNcUt; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="2UgbNcUt" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=Df3Z6RKlukZJKt5/tUtKTYu9n9DGWqJ7aW4/X5F1X/Q=; b=2UgbNcUtaOV3ZgkWhQudl2hpQL 81ZGCkf8pW9ZdPmy5rbFnbWlsp0wuoa4BebETcdh1wgiOusFgyWxUtzjOW/jPspSPDsV4eAGykeMJ F2aE32RHnig6hiOL+vlz66UVFFk4uAokMJEq4ML5yJP0i51dO3xhTFTnNlstcVRe6SQI5N2gVGqDO Di66ZEbeVQ9gL23RFCzFmBvyGlgZ2AzHwyu/yz4dmGQFTx6Mcr4v6nBH8oCSur1TCsNSGF77pZIWO DPiYrqjV/4Vbl1rJwod9epdOImkzYTsFnBKimJTcDg+KOPIY+Q2u+l0d1noBA69GL9r9z2aa2ecQy 996HMpqA==; Received: from i53875ac4.versanet.de ([83.135.90.196] helo=phil..) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vcTZ9-0012Mf-Vb; Sun, 04 Jan 2026 20:15:04 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, uwe@kleine-koenig.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] arm64: dts: rockchip: Move SoC include to individual QNAP TSx33 boards Date: Sun, 4 Jan 2026 20:14:44 +0100 Message-ID: <20260104191448.2693309-2-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20260104191448.2693309-1-heiko@sntech.de> References: <20260104191448.2693309-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The TS133 while mostly similar, is based around the RK3566 variant, so needs a different SoC include. By moving the SoC include to the board devicetrees, we can still keep the shared common setup, while supporting the different base SoCs. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts | 1 + arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 1 + arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi | 1 - 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts b/arch/arm6= 4/boot/dts/rockchip/rk3568-qnap-ts233.dts index f16d1c628793..9a7d58e7ccc0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts @@ -6,6 +6,7 @@ =20 /dts-v1/; =20 +#include "rk3568.dtsi" #include "rk3568-qnap-tsx33.dtsi" =20 / { diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm6= 4/boot/dts/rockchip/rk3568-qnap-ts433.dts index d1e3b7e7a280..02d0974d79be 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts @@ -6,6 +6,7 @@ =20 /dts-v1/; =20 +#include "rk3568.dtsi" #include "rk3568-qnap-tsx33.dtsi" =20 / { diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi b/arch/arm= 64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi index f009275c72c8..c372ca40fd50 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi @@ -1,7 +1,6 @@ #include #include #include -#include "rk3568.dtsi" =20 / { aliases { --=20 2.47.2 From nobody Thu Jan 8 00:13:53 2026 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACF062DC332; Sun, 4 Jan 2026 19:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554113; cv=none; b=gxa83dSX0yJCy+2rt0cblC+/VP8T1RCNAIg0O4DKOIdLdf1hcWLDYV/ivfi1vcPFFh+bdytCHbxAhpmRhe0E8oqdZPz/Nj2nwhRpu5ctWbL2KgqyuD7C7HYvo1Desqq9IYK2aPEg548TLJ8fFZsp0tbyOyWhG5Qe28tli98g5Hw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554113; c=relaxed/simple; bh=hJ3jrEEjkN3O32GbC6qCB6f4VASXfHjg6HAUsL9DwWQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GDYgd9UPCuDJm1z0iS2NfvlHxA4rfR+2deRrnrMMlFgSusTpQPgGj/hCFigfnuak+xSVK3GWgsuyMbbQmnaT3UAqs6rM/Gh1IczTUlq3k6m15H8uE8ovKLsxzBSMEs6+3hpyIFeCJmfFyiMaWWG17ZFJWxn9Li56ddVznG30uz8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=xy8zIJpA; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="xy8zIJpA" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=HSw1IaweIkWmZgcN12gmjxMT6CneZYi7udZOkO6OjGE=; b=xy8zIJpAk7m1GpF2Bkk3AECZCe LKk6E0njVq1w5pJ36IxnE+1tb7mLD52w0SgJxFINIE3wYmIw3fLwuNXpk3+gmW+VAOJr5R+GCK7sY RqpCJYtgaXYPBQuC0wpdCp58wWzlbwf+z3kyVstq8WjOm6fQNIiq2Nyzjekk5sAHm84s39IlVU+XM Ric9GhEp09mRkW7IMbiZIYrHPUpX/QQN8BgIGBosSYPyQh9iiK2JZrwmx19f4Tv0xZhGk822G6QK6 B/KdyhtCHLSN+DgDHmGAIH1rsAf9e+mWHCdfHDYeDuSoMxYLvm7ku9wWLzZLJ9GqKvQr5APp/JQ9z CfA+wWag==; Received: from i53875ac4.versanet.de ([83.135.90.196] helo=phil..) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vcTZA-0012Mf-DJ; Sun, 04 Jan 2026 20:15:05 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, uwe@kleine-koenig.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] arm64: dts: rockchip: Fix the common combophy + SATA on QNAP TSx33 devices Date: Sun, 4 Jan 2026 20:14:45 +0100 Message-ID: <20260104191448.2693309-3-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20260104191448.2693309-1-heiko@sntech.de> References: <20260104191448.2693309-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The common used SATA controller on all TSx33 devices is actually SATA2. So move the SATA controller + combophy enablement to their correct position between shared dtsi and board devicetrees. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts | 6 +++--- arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 6 +++--- arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi | 10 +++++----- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts b/arch/arm6= 4/boot/dts/rockchip/rk3568-qnap-ts233.dts index 9a7d58e7ccc0..e76502180788 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts @@ -18,8 +18,8 @@ aliases { }; }; =20 -/* connected to sata2 */ -&combphy2 { +/* Connected to usb_host0_xhci */ +&combphy0 { status =3D "okay"; }; =20 @@ -93,7 +93,7 @@ hdd2_led_pin: hdd2-led-pin { }; }; =20 -&sata2 { +&sata1 { status =3D "okay"; }; =20 diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm6= 4/boot/dts/rockchip/rk3568-qnap-ts433.dts index 02d0974d79be..708e7f1f8d0d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts @@ -28,8 +28,8 @@ vcc3v3_pcie: regulator-vcc3v3-pcie { }; }; =20 -/* connected to sata2 */ -&combphy2 { +/* Connected to usb_host0_xhci */ +&combphy0 { status =3D "okay"; }; =20 @@ -151,7 +151,7 @@ hdd4_led_pin: hdd4_led-pin { }; }; =20 -&sata2 { +&sata1 { status =3D "okay"; }; =20 diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi b/arch/arm= 64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi index c372ca40fd50..482d8584ec88 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi @@ -112,13 +112,13 @@ vcc5v0_usb: regulator-vcc5v0-usb { }; }; =20 -/* connected to usb_host0_xhci */ -&combphy0 { +/* Connected USB3 on TS133 / SATA1 on all the others */ +&combphy1 { status =3D "okay"; }; =20 -/* connected to sata1 */ -&combphy1 { +/* Connected to SATA2 */ +&combphy2 { status =3D "okay"; }; =20 @@ -484,7 +484,7 @@ &pmu_io_domains { status =3D "okay"; }; =20 -&sata1 { +&sata2 { status =3D "okay"; }; =20 --=20 2.47.2 From nobody Thu Jan 8 00:13:53 2026 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1818319A2A3; Sun, 4 Jan 2026 19:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554112; cv=none; b=SI1FppigIMViq0X9KjEkGXIKL4znRPFFI2qemxWGZNL+jCkFs3QnmF+duBqYIN2duyGJioorejBPDfwqY27yC3D9OWJdSzE4AQHHdJ8fGOHkvfpwJhcqhJHnvvoSLfuun4BPRl9cwdrTN2QpIHvfpndisIzOp9UEuxIGB0v8ql0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554112; c=relaxed/simple; bh=En3XVu6gdM49sFTNSWGCyipNBQVyg8ZT8P0Sqx0lpag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Tmt34iIBbZgjjwOmWD1M9/rC+Epwht1pnFP2QKloNV1gN8i3F7QpOwOELh7Xpc8sOoGiDCCSPACPEl1kLmgjV0gTvKmpAxh5ZtJhluvdPxYs7u15l7NsyHoni+fGFO6TeAM+GtqgDYGsO8eeG/l3m4uo7qxFculpmzWlbVXDKzk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=QK2PW0Sf; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="QK2PW0Sf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=lUuUqLfpAlmABnYAK2UNaASJ2eI1qRm0coIFUL1U6Yk=; b=QK2PW0SfBWpNRaJHKZfD3qKV/k 6L1Jvy0BUw9t4pOUmspyT8qOOPIhf20WFQ/Ot4uB8p/+jXC5Las7ORDD21xqk8v751O2NbHr/QBqW nz0w7OQlXjDqoM+ljNZpDcB+JVQalfq837xS1XDzso9G5emQUjOdKkVZqKIsbW8/mwuXVxsQbRw3s +V3Vu8gOviKW1i41w89gcR33PkG0sq5KLmx7MlVRpC9xV3ivYD///Yke55Pfdh0VLrgB7fLDPNyMD S4r/UPRezw3CiGmv9TME+hZa5Rvq5zZhIv1k6ytUXEqyI+Sh4LWTYn5IrhYFfT5a2VwfTSMYpEWtR aw6ibmmw==; Received: from i53875ac4.versanet.de ([83.135.90.196] helo=phil..) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vcTZB-0012Mf-5q; Sun, 04 Jan 2026 20:15:05 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, uwe@kleine-koenig.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] arm64: dts: rockchip: Move copy-key to TSx33 board files Date: Sun, 4 Jan 2026 20:14:46 +0100 Message-ID: <20260104191448.2693309-4-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20260104191448.2693309-1-heiko@sntech.de> References: <20260104191448.2693309-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The copy-key is not present on all device variants, so move it to the individual boards that have this key. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts | 11 +++++++++++ arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 11 +++++++++++ arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi | 10 ++-------- 3 files changed, 24 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts b/arch/arm6= 4/boot/dts/rockchip/rk3568-qnap-ts233.dts index e76502180788..52b741376ef5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts233.dts @@ -51,6 +51,17 @@ eeprom@56 { }; }; =20 +&keys { + pinctrl-names =3D "default"; + pinctrl-0 =3D <©_button_pin>, <&reset_button_pin>; + + key-copy { + label =3D "copy"; + gpios =3D <&gpio0 RK_PB6 GPIO_ACTIVE_LOW>; + linux,code =3D ; + }; +}; + &leds { led-1 { color =3D ; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm6= 4/boot/dts/rockchip/rk3568-qnap-ts433.dts index 708e7f1f8d0d..7d2aedfe616d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts @@ -61,6 +61,17 @@ eeprom@56 { }; }; =20 +&keys { + pinctrl-names =3D "default"; + pinctrl-0 =3D <©_button_pin>, <&reset_button_pin>; + + key-copy { + label =3D "copy"; + gpios =3D <&gpio0 RK_PB6 GPIO_ACTIVE_LOW>; + linux,code =3D ; + }; +}; + &leds { led-1 { color =3D ; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi b/arch/arm= 64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi index 482d8584ec88..cca7b7d0685f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-tsx33.dtsi @@ -12,17 +12,11 @@ chosen { stdout-path =3D "serial2:115200n8"; }; =20 - keys { + keys: keys { compatible =3D "gpio-keys"; - pinctrl-0 =3D <©_button_pin>, <&reset_button_pin>; + pinctrl-0 =3D <&reset_button_pin>; pinctrl-names =3D "default"; =20 - key-copy { - label =3D "copy"; - gpios =3D <&gpio0 RK_PB6 GPIO_ACTIVE_LOW>; - linux,code =3D ; - }; - key-reset { label =3D "reset"; gpios =3D <&gpio0 RK_PB5 GPIO_ACTIVE_LOW>; --=20 2.47.2 From nobody Thu Jan 8 00:13:53 2026 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 181F823C4FA; Sun, 4 Jan 2026 19:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554112; cv=none; b=H6NqMmlixmDaC6ph+mrsNkJfxjAc2cdH2yy//9CRsSX5Jl8jJF+fgSaKBvt8g06ioxVgWc12uqngEjQaSnewSUv0F9tfttKX1Wwega87Nf3PL5el4pFOPTg/HZEXxFV/iDUlY0Hr+QeZxKri+E7TVJCyBFa12K0dSACPBQzs9mY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554112; c=relaxed/simple; bh=axSuozYbjyUDhCZ0jEyJ6KpdNE+PSR+/LjKs6SCQirs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ftfHs5efOqkJK4BZGB9ZOUXnAZP/9GUBv4lKk2l7/oP5LFMjlKjCmeHS26y7UZj6JRE0sOmNAgqeDRjeniz0ab0sqVWQNaeDgTRYicpmg6M3X6PvGJBknVTNbFQ6OwaAHV/HtBly1elaO+LC20VP3hRjKJ+vd9sRO9/PYr57Foo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=o4Y87TTh; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="o4Y87TTh" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=krUEwvQtFBfxhDWJO7NHKWidgy0n/k7HYBmF9kBHcZE=; b=o4Y87TThVKhJGNENMgptNDzxC9 0Bos1zVLGBH7Y/NT4m5kd2ah+v+0u97/rug+/6f1SmNQsoN0W+LfyBCSr55sQkWVm9aHZKXsiLv8D fWB3amjeQh7UdMj6/+qOyH845mWSVirpS66Ea5ZAwK6wAv4JEJFEB41463xXWjqTlGm7jVe58zLkE 72kavU9ayuFFVbCvOmZByoo1yumfkPD0pbBdpO6tZgU6gjWFIU+73cQCrjWOpr9TrMInvtJ8ToykK ES9WycngaP0ViBhok1b361V8kjVanRxHTIuKQEmTANX54fQj3LjEFfFVdwvPuy8aJqBznzvQKZ/vb bCZMcOcw==; Received: from i53875ac4.versanet.de ([83.135.90.196] helo=phil..) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vcTZB-0012Mf-IS; Sun, 04 Jan 2026 20:15:06 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, uwe@kleine-koenig.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] dt-bindings: arm: rockchip: add TS133 to RK356x-based QNAP NAS devices Date: Sun, 4 Jan 2026 20:14:47 +0100 Message-ID: <20260104191448.2693309-5-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20260104191448.2693309-1-heiko@sntech.de> References: <20260104191448.2693309-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" QNAP builds a number of variants of the RK356x-based NAS design. Add the 1-bay TS133 variant. This one is a tiny bit special as it is based around the RK3566 variant of the mostly similar RK3566/RK3568 SoCs. Signed-off-by: Heiko Stuebner Acked-by: Rob Herring (Arm) --- .../devicetree/bindings/arm/rockchip.yaml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Document= ation/devicetree/bindings/arm/rockchip.yaml index d496421dbd87..2a5105be3d34 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -894,11 +894,15 @@ properties: - const: rockchip,rk3568 =20 - description: QNAP TS-x33 NAS devices - items: - - enum: - - qnap,ts233 - - qnap,ts433 - - const: rockchip,rk3568 + oneOf: + - items: + - const: qnap,ts133 + - const: rockchip,rk3566 + - items: + - enum: + - qnap,ts233 + - qnap,ts433 + - const: rockchip,rk3568 =20 - description: Radxa Compute Module 3 (CM3) items: --=20 2.47.2 From nobody Thu Jan 8 00:13:53 2026 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACE372D876B; Sun, 4 Jan 2026 19:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554113; cv=none; b=M7F4/MG7Ja6IXbgN/DReORO3Zip9qqtu2AY8rEdaqPartB78/1pAE1eb+EQ6jUo02FWTq1K/Q1Bne/oplNb9ldapysvuSVdQCL3SPE3fhbdD7Gq9Cqc0C/4KvQKk9OjbJYk/1ZdMpWuemjnCevBuB3sXil0+gXmOsbJWB797aNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767554113; c=relaxed/simple; bh=A6Dd/tWTq33VvOCoViFwSfBrD00jajTs2OOtqEnq8is=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RIQ5D+IFzvsIvhqaCrUs7svhrG6bcZiX1tuY8zyolbcRnMoWpzweixPfVF7wVGK60E6wCuNYSnWfQ+KPpQZvO7Frwi0mz0GOCLYd588n/ejLHAuGIh3tZ2je7d+P6dOS3HVIaATiviAZITOmhv/faB0Ap9MjgH/7Ou9Mj8j98EU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=rkigdu15; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="rkigdu15" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=W6lmQ9DjqLP6DPzdLF3chcc4DApxeE68U6zeYUwkCCw=; b=rkigdu15dRRod3itKUb1tP3RJx b03wBt6K+1ZxsPjNBZFk15QGYhzlAVt6GcMTf+S6vtgEL0wSmBaBznBniwJhxMeoptraxS+J0EQuF 2ipz5vPy7Y5iAFdRri19rHFnL/2z/LZAEC0jt4YnkPhDIbzx8uMKrGTV2HnKl9Tsq6HpfvY2fMoEQ Xo4934vTu1DTBN55P6TFZCwJfwuuaWCxXcOunyDjC92g0lpedI6KEOZlFi2QjhrO1WSkBW2VwmaDN GRXsk9new8bgQZEx1vIEQwWV2Y2rXA662i2RPGUBUnKjZmZXwLlC07DKUK44AHzygfltUClDoyKAR 0440nSJw==; Received: from i53875ac4.versanet.de ([83.135.90.196] helo=phil..) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vcTZB-0012Mf-VH; Sun, 04 Jan 2026 20:15:06 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, uwe@kleine-koenig.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] arm64: dts: rockchip: Add TS133 variant of the QNAP NAS series Date: Sun, 4 Jan 2026 20:14:48 +0100 Message-ID: <20260104191448.2693309-6-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20260104191448.2693309-1-heiko@sntech.de> References: <20260104191448.2693309-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The TS133 is a one-bay NAS mostly similar to the other devices in the series. The main difference is that it is build around the RK3566 SoC instead of the RK3568 variant. The RK3566/RK3568 are mostly similar with only slight variants in both speed and some specific peripherals - the RK3568 has more. The specific for the NAS series stay the same though. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3566-qnap-ts133.dts | 71 +++++++++++++++++++ 2 files changed, 72 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-qnap-ts133.dts diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/ro= ckchip/Makefile index dbdda9783e93..ba992860c8a2 100644 --- a/arch/arm64/boot/dts/rockchip/Makefile +++ b/arch/arm64/boot/dts/rockchip/Makefile @@ -114,6 +114,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-powkiddy-rgb20s= x.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-powkiddy-rgb30.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-powkiddy-rk2023.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-powkiddy-x55.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-qnap-ts133.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-quartz64-a.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-quartz64-b.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-radxa-cm3-io.dtb diff --git a/arch/arm64/boot/dts/rockchip/rk3566-qnap-ts133.dts b/arch/arm6= 4/boot/dts/rockchip/rk3566-qnap-ts133.dts new file mode 100644 index 000000000000..d605a712de5b --- /dev/null +++ b/arch/arm64/boot/dts/rockchip/rk3566-qnap-ts133.dts @@ -0,0 +1,71 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2021 Rockchip Electronics Co., Ltd. + * Copyright (c) 2024 Heiko Stuebner + */ + +/dts-v1/; + +#include "rk3566.dtsi" +#include "rk3568-qnap-tsx33.dtsi" + +/ { + model =3D "Qnap TS-133-2G NAS System 1-Bay"; + compatible =3D "qnap,ts133", "rockchip,rk3566"; + + aliases { + ethernet0 =3D &gmac1; + }; +}; + +&gmac1 { + assigned-clocks =3D <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>; + assigned-clock-parents =3D <&cru SCLK_GMAC1_RGMII_SPEED>, <&cru CLK_MAC1_= 2TOP>; + assigned-clock-rates =3D <0>, <125000000>; + clock_in_out =3D "output"; + phy-handle =3D <&rgmii_phy0>; + phy-mode =3D "rgmii-id"; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&gmac1m1_miim + &gmac1m1_tx_bus2 + &gmac1m1_rx_bus2 + &gmac1m1_rgmii_clk + &gmac1m1_rgmii_bus>; + status =3D "okay"; +}; + +&mcu { + compatible =3D "qnap,ts133-mcu"; +}; + +&mdio1 { + rgmii_phy0: ethernet-phy@3 { + /* Motorcomm YT8521 phy */ + compatible =3D "ethernet-phy-ieee802.3-c22"; + reg =3D <0x3>; + pinctrl-0 =3D <ð_phy0_reset_pin>; + pinctrl-names =3D "default"; + reset-assert-us =3D <10000>; + reset-gpios =3D <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>; + }; +}; + +&pinctrl { + gmac1 { + eth_phy0_reset_pin: eth-phy0-reset-pin { + rockchip,pins =3D <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>; + }; + }; +}; + +/* connected to usb_host1_xhci */ +&usb2phy0_host { + phy-supply =3D <&vcc5v0_otg>; + status =3D "okay"; +}; + +/* USB3 port on backside */ +&usb_host1_xhci { + dr_mode =3D "host"; + status =3D "okay"; +}; --=20 2.47.2