From nobody Thu Jan 8 00:14:41 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E52DC27A93C for ; Sun, 4 Jan 2026 19:05:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553560; cv=none; b=LGQr/VP2ej/9tKqAryFdFT1yFgQCJf8IOrh4tObCGtim8nbqFWD4p4yFY2Va4khD+nFZZpREnBgPPRjneqDaKaYw9FCskjQ7lSVvE0T4/HM++cwTjnuBa0yERvhhlh23B9vhvL0q/NI8CoQMIxAeonL6ntOTtVLRO0VCCgYpkLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553560; c=relaxed/simple; bh=OyC+g03aFlX7lZSthSQHkxNGwEsoEs0Tb0cf0wHv4Gc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qaufC2h+l+kaaW4AbLoKiGzG7jNan6ecKvry3tcMtjCzhCw1eBEGQKYhjfnkEu6ItoHfwU6iQQIxQrdWk6nl4IHznTHMrbkMC4SoNTY7DLJ6Wd+lHltvXPsnx49Z44uQISGHxiIbVkqj2WYVZJUxy8gTCWFpJqUj528Y+MF7iBs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DgsI0eA1; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DgsI0eA1" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-430f2ee2f00so6192955f8f.3 for ; Sun, 04 Jan 2026 11:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767553556; x=1768158356; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PWgc9+y+yljidHQMYhQLHs/5E2QnwKnp6O+oSXf5cSk=; b=DgsI0eA1ccl1d6XKUCif/qWvr+LWl+7q2rWeBJKnf1Bo4eZUlkJ7/5laTHZ+hAZ7gM BPtRuyIhxyAfBsnbeG0rXWhXvVhBuOPu0cbjtsYV96aacXX3fhZwBstxFn4M/MQOZ5Hw U3fqeo9Sg9/yBmCoEllUvrTTMKEXQ/zqy7AMeO/7mqCcSbhp/0dUCCB9MIPh1+4uGSDX xv3CBMs76xEje104vJbchXVum4OFqJbctmgS5c7EbAgbcXp5ns3PPVMfOdV2/aEaUBxY qMAMMnVIPGcMX5p3bgNI9gCgO32eoJAtL1/SXUL4QJWvS8aaxfhTXf2shbqVlsKV+WkT wl/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767553556; x=1768158356; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PWgc9+y+yljidHQMYhQLHs/5E2QnwKnp6O+oSXf5cSk=; b=wzi21RS59oCBUWrH8ZIF9oYtL6BGtXmRRXn6P3LVuJKcSQC+io/NXzSw/48EPiErD+ Vn0u1RnscC9EQ3lw2iQ5g7PUNtbTJ6xFGOrWD85811NV09NeNnPdVnXGK8c1dDTVTaqt q8/LBpf7g0QGrffh74xmCzYT4r3DxIpjw1h0kDsvCdyUIo6VLON3RwBEClpUck6+4xC9 +b6+6BxmiuWtNCNFwTw+Z85jz4jk3OJd5gT4s3kRDb5ipsF2/iD3iMv4PMgkNGMYzBgT SdjYH+AB8M+en/PqU7v9U4FpY28qij9VjGHNtw3Id51jsXPs/DISGvxiE6WURYn01uT8 yJpg== X-Forwarded-Encrypted: i=1; AJvYcCWu29hyIvuIE2pouhg5SQU+l807Gw22LThGYMG1bYDVYufgnwNUfrAyREm5JdLPMyTq4Ndvz7ilkqwStFk=@vger.kernel.org X-Gm-Message-State: AOJu0YygCtPzFzp3DSCNfso2MlUjq/agvs5LCS/QcF+mMncLyNKX4o6L 6bG/WM5a7D7Ak/bnkPE6mZtcDgrqNyjE0TFL4NPhzZnQPeD2V9U6jt/w X-Gm-Gg: AY/fxX7zFUYOUi6AqA9q51XSMilCLzHSpMcgsQbdYGlic+7ws5TFbgslCOGuCsEz4fH ZvC+tR1PDhUy4HvtLvCrz8VJuwOefMVz2qtz0PGqthpe7/x4D/7OoqdZMhHiQnAWY0wrM3Ly+1j lr+wUCgbfE8YsraqWtxm3TJo4FSnCtb3Yg2DSwOnHI5G8LKIKX9Eqwrf0YqIcOjtAe6QuU1mA5B r7u+FVbRhjh1cp0Q1Z662blCw1tDr91JUDmbqh3aOflushz3+p4juIqkmAEuTREF0/GYKhmM9nN PGro7bmo2urFpLI52xLoW8/WeVZmX117zjfqvlSiPgIyij+TSlPrehhmr7rBc2r/s8pQZ76Tror 0RSm5hnc1k3dkvU/p+i5T57Ab4m69XnvayxdCLmJF5+/4C7F80Y378Iq58O/AJJTIPSFQhExu0I cfwxppobSD6uu2IE5pxDr8Ey72GdfsWt7146/bitGRqFnMU2I5Pg== X-Google-Smtp-Source: AGHT+IE0wNk1jmGNWpzD9tmrWUTxX1bKR2z9THWxZWvHHtqvM339Z8w94MLeOag/HytCXIrXR+WPrA== X-Received: by 2002:a05:6000:2203:b0:42f:b707:56e6 with SMTP id ffacd0b85a97d-4324e5035d1mr50944550f8f.34.1767553556057; Sun, 04 Jan 2026 11:05:56 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2c4fsm96505089f8f.42.2026.01.04.11.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 11:05:55 -0800 (PST) From: Mahad Ibrahim To: Mahad Ibrahim , Hans de Goede , Mauro Carvalho Chehab Cc: Andy Shevchenko , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/5] media: atomisp: Remove redundant return statement Date: Mon, 5 Jan 2026 00:05:05 +0500 Message-ID: <20260104190509.19683-2-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> References: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function mmu_reg_store() returns void. The final return statement is redundant as it is followed by the closing brace. Remove the redundant return statement to simplify code and adhere to kernel coding style. Signed-off-by: Mahad Ibrahim --- .../media/atomisp/pci/hive_isp_css_include/host/mmu_public.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h index 1a435a348318..2fc137ef46da 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h @@ -63,7 +63,6 @@ static inline void mmu_reg_store( assert(ID < N_MMU_ID); assert(MMU_BASE[ID] !=3D (hrt_address) - 1); ia_css_device_store_uint32(MMU_BASE[ID] + reg * sizeof(hrt_data), value); - return; } =20 /*! Read from a control register of MMU[ID] --=20 2.47.3 From nobody Thu Jan 8 00:14:41 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC13D3148D8 for ; Sun, 4 Jan 2026 19:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553561; cv=none; b=NfERn3QvbCBCiISZKbR1Pwes2QiJR6OiOucDq+ZXPGlywJ05gr+3VpLq1UrrMNjktK2OjDn04+6aSotAABXQztoi5hodbPrU7iPzXIOKgUndwo0TFo24UoQ8nMt8J4qKg98EWKAApWqDs2sDDSAuLashmeis4yaBXwxLPjhGuqY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553561; c=relaxed/simple; bh=W6NyjsgqJpje0GxOZQmAwqJGhMN1MSoT9QtbYe3sD84=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dt3ZmBlCW4xGinAbUbqhq/iw/HDIUvjsgDj4wYInWpY3l9oia+1K3UOyM1utjtMU9yZZGAUxi2IsThMKrSLUoo/DBtCvxa4ihrvTx5Dk5Ciq35cyGX0lRz3uSCMwtAq2SdBdeK6GdfQ9qCr90odAeUG4QXowJP5GhJcU+gLbKQs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cHW2JD1c; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cHW2JD1c" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa9so5439088f8f.1 for ; Sun, 04 Jan 2026 11:05:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767553558; x=1768158358; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mPN4xTgI6JHPvReSWeqoK8IgjRhln3sF5NWInwVvHG8=; b=cHW2JD1ctGV9jl/zTZxE3kqvjnsLhDScY+NXucRTI2zVeNEwugupJLi6fbJ/0Hfk3p 1k1oHTC8gc1SnyfN+0GU4DxQX2JF517GRs1k4Gpm01/hf0yvbNxNV3icKhol7fLOSAcS 8mtfKDnguV5R4oH2LUvNwQxYjD/Nd2Drop+ItHI2s95yVdHyLQvoXAP6JnrosAg5s/Di bn5m199o7LzhV0i9CkaORhkq7lCgt58jmvyC9+gN3xhPOcpbWfOjxjbWSuAOT9SVV01+ QdVIU3q5fkwKbgt78ST4DdbYSl+JCXd2KB+uvx3hBOrjTs/aY7uJ6H2yC12o+VHU/AaW Z5Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767553558; x=1768158358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mPN4xTgI6JHPvReSWeqoK8IgjRhln3sF5NWInwVvHG8=; b=aB/NBwUmEp6H5pHsAbidUT99QCfATs51HR+0Jg1HXD4pzNrBz+rlNL3onTbmnWPHKd WXzSs1T7DhLVgXxJK1yA77GkGOLP8/KBFTLBD8Pmxn3NUn2TDISiWvxMoVFSsMaWK/0n krEWa64uhuahuUJUSOBfoHsKXYhgyHpayTJ+V6i1KbFku6SEE5wC1HmdvkdSZVHGmghU 2luZBOy2k8S4ETNbTSIAhePhQRCBjyG3/0/8SyOvD7q2znGkYt+zDz7LCEOV3mI5aV0A iTA8tYykG67xfesLBgYej+UyuC0tUn8oeUSpcGfJq2Q04Hqml4bvuttm2mm3ujGeZL8S q6TA== X-Forwarded-Encrypted: i=1; AJvYcCXDKhIsaiCXEJQQtY+/LyAKNnq+dulwDcEOvqcjB7OfUnbuiMrV+/6gcvnRYp0/duaAJ0Xc/vNd3VbIzmo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz42VvGzTotrrMf9f5Qw7Cum1lulXdwW4DO8JE4igZp6ssJUTzD N7tgNmfeWTfQz5eh4OWsrRlgVJVJwhZwnM7+DzMpv51Z0NkUs6aUopJF X-Gm-Gg: AY/fxX5sqOd6GmkahdiIedHtib2OJJeYMRPLrnK6yrQ/qjhRSUJoIO5YDjLggyp+svS WTLCYy7Eu1lFnoa2lqWoB2B2nr/a4StCu032OZk5qjstg/iF9uGaxyDsg69Luy6mudSI6UW+T7e CEvwEEiGipcsoqezbFgk+dzXD3IUyvu8Ta9YnGlNfqQGXNzRVnc/suCf7r9qmy1ohUyug6TkTvW uaf0ta+mnjmZhFVFo2lvQP9Lm6nynKSX1iHnMAazxDwMmsGvOrTCa9VvDwcTphYQsaXcSZgNikM IGV3lPVMacl4cIalQhk5kGwxUm9A+XRiCEpwf1764NyQOTs9t7j9X96QbolsEvZViIii9E/jCAE BszJVhlL+y96r3VbgNrNTGDIe2oCKmO1kJngdakTctp8fIAT38SujF0TTkzH7XBCSUEnRteqiVO HmY0h2ojMSKRNobTUFqEL8O+cMmltU1TQEGb+5X9I= X-Google-Smtp-Source: AGHT+IGG1wvzUbObPV/Nlzp0VzBlVYRvQA5fZ35AlHFfaESwLJK1dRu09w7xLw8bYO2P1pz4+O+HKw== X-Received: by 2002:a05:6000:290b:b0:430:8583:d189 with SMTP id ffacd0b85a97d-4324e4fb659mr64947627f8f.39.1767553558167; Sun, 04 Jan 2026 11:05:58 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2c4fsm96505089f8f.42.2026.01.04.11.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 11:05:57 -0800 (PST) From: Mahad Ibrahim To: Mahad Ibrahim , Hans de Goede , Mauro Carvalho Chehab Cc: Andy Shevchenko , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/5] media: atomisp: Fix function signature alignment Date: Mon, 5 Jan 2026 00:05:06 +0500 Message-ID: <20260104190509.19683-3-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> References: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warnings regarding lines ending with "(" and improper spacing for indentation. This change fixes the function signatures for both function prototypes and static inline function definations in mmu_public.h. The kernel coding style prefers arguments to start immediately after the open parenthesis. Signed-off-by: Mahad Ibrahim --- .../hive_isp_css_include/host/mmu_public.h | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h index 2fc137ef46da..90a2e4e8f510 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h @@ -18,9 +18,7 @@ =20 \return none, MMU[ID].page_table_base_index =3D base_index */ -void mmu_set_page_table_base_index( - const mmu_ID_t ID, - const hrt_data base_index); +void mmu_set_page_table_base_index(const mmu_ID_t ID, const hrt_data base_= index); =20 /*! Get the page table base index of MMU[ID] =20 @@ -29,8 +27,7 @@ void mmu_set_page_table_base_index( =20 \return MMU[ID].page_table_base_index */ -hrt_data mmu_get_page_table_base_index( - const mmu_ID_t ID); +hrt_data mmu_get_page_table_base_index(const mmu_ID_t ID); =20 /*! Invalidate the page table cache of MMU[ID] =20 @@ -38,8 +35,7 @@ hrt_data mmu_get_page_table_base_index( =20 \return none */ -void mmu_invalidate_cache( - const mmu_ID_t ID); +void mmu_invalidate_cache(const mmu_ID_t ID); =20 /*! Invalidate the page table cache of all MMUs =20 @@ -55,10 +51,7 @@ void mmu_invalidate_cache_all(void); =20 \return none, MMU[ID].ctrl[reg] =3D value */ -static inline void mmu_reg_store( - const mmu_ID_t ID, - const unsigned int reg, - const hrt_data value) +static inline void mmu_reg_store(const mmu_ID_t ID, const unsigned int reg= , const hrt_data value) { assert(ID < N_MMU_ID); assert(MMU_BASE[ID] !=3D (hrt_address) - 1); @@ -73,9 +66,7 @@ static inline void mmu_reg_store( =20 \return MMU[ID].ctrl[reg] */ -static inline hrt_data mmu_reg_load( - const mmu_ID_t ID, - const unsigned int reg) +static inline hrt_data mmu_reg_load(const mmu_ID_t ID, const unsigned int = reg) { assert(ID < N_MMU_ID); assert(MMU_BASE[ID] !=3D (hrt_address) - 1); --=20 2.47.3 From nobody Thu Jan 8 00:14:41 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1745C314B86 for ; Sun, 4 Jan 2026 19:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553563; cv=none; b=jYYzQCBm0xjvCXsi1zp+bg4flhtzWF/4Zvy+TkM1RwirrsfJ0lvAbSuZtkf9Y3c6hS4y10ZrabBANTedxB/+M3vnwHHXLp8jeGMPGuQkZbYNUuSppbuDdaIxQDogSdEBGQYo1zvtvW5+SC3QXLWtYDkFtdVL6KclNj/bZyqrZoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553563; c=relaxed/simple; bh=NSa0ydNb2NewPQiwrxnfe27gMuqCMYdIWFpwwvfk7K4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Yy+TuJCWZm47eu8rA2m0M29hjY7vWzHBq2C5Vhnu4V8kvyok7lii+9ynB4eNsS1qU/zqWPNx/KL44YEEl/IEplU9QIexjveAj7ypXlkln+s4Qq2Ti3kkQxVt9iLLrBZg2W1oGDkudl7NxsepxSEZCtyVoW8bzz5vTJnExqxhiZw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZdaOSVNg; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZdaOSVNg" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47aa03d3326so86415365e9.3 for ; Sun, 04 Jan 2026 11:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767553560; x=1768158360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eRnKQCftC330uBXvExSnKK33O3Emg004thzOz4/211g=; b=ZdaOSVNgNcI/Bf0AMbzJ/1xmjFerZF06sUwqFSRmMMKDIor0HpedwVTWQOn8ZZzytZ RmkHRQcoPxagMk1ijhLFhwe1GyTrCi3vfdp8X3fXJfRlkO1Z8fIx7pra78wmOYIzntod UWpiYzJRe8kX3pAc57kV1i8ExpAbN/baekv4NSJJuk/gJFgs+4Cw7jL3Zez4R4FETsjr le/mmkge/g+5Jh3qjXatkInV2+msWDQ3bpfnYeN4Zr19BeWzKX0XHoeEDFGNAoOyLX+V pZUceW2/Mjm2VPrE+y1ZrqkY5MJUveFsK3GYlSAagC3ic01Ob3D4aqzDp0SeWAoVpaz4 qQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767553560; x=1768158360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eRnKQCftC330uBXvExSnKK33O3Emg004thzOz4/211g=; b=vJBa5yOWHSb5Uoos6WGeIkNCRfhTZercGHeUrpIJ17QV5Xr2QTRV0BJelBLGP1tHX3 OynC3IiIY7V6lEu90CA6JwgLfGtTRe21rp5Nrn/rarG5KKKWwB9kmewMX3QBnjq6QXJa ytbDxOhDoJEh6oZFVw+iyJN9NPGUj4Anlr3r3s38sxJzm8ESeXG/EKUMNU1H9YM2NRap 7Mi11YaAxzAOeFa5XUNCZxNtGvWDzWcZjt8XMO4MX7hOMZpeX0Z7Whoziqzw0yfuz4WY cQybr2LoziSgnDe3cqQSN7MgA9pFPao38qWADn0O/Spg9wJh2N1u/+0WUkQIwStwpHzL kKnA== X-Forwarded-Encrypted: i=1; AJvYcCVWeRTRWYGUzyorFTVV6rrGVaXH2n5eAjux/y//VgfSBeNSPn2Bstz3ZJ+cj3PEZt7I4rolhfKR17SSeLM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9qCOp7k6WaXZdzA89nXw/Vl3nHuKSoDQujlhFHPBRuW9p/cdV CYbcgqXJxLJrJY7fi0aCYJiSBaOzyeCRDJnjyplr/nwY+iVIuLz/Yyaj X-Gm-Gg: AY/fxX7JBQoRFD8D7hTkNp18IvkWciliN7R488znPSUKbM0j49KglrYVABwh9qTweTr 3mti4efCzekT8uE81SP9CP5pRocRlN2RYaKe1t+Iur3kPcxjhKWrWzgV+l1OMK/TSQP1H95aTPs wp/40/efw5j/C/FgiOM7JIy/8WdUPyBcCudVN/f4nob7D7HTE0fg5XnvCiK2CzKZnUC5fmpj6kq KIdZcu+3OJgFjDDVdmTLE+E2ILM2sbhLjGLZcaw27z1yNxulhMF7vKyacXWHq1zgaQLYEyo9EBv fxehCnhiOIAxQ4bjQzBbL7OzA8TPX6IAZHIpeTKDirCR523xO92HzZHjdHmlawSUuz9rwLIFuY1 n7RCY3OrZBffw200RuKas9zm0VZt9XdjJFaCtfF87PJYA6VsdoVQYdzM/s8nbscgvpLUvrvm2ok fIKTN0bv7hEYXZv6lb15zZ1WqDISfPjPTmo3vUWjQ= X-Google-Smtp-Source: AGHT+IHsQnN2VPxYp9iDD0AHlXOkhb01+CEtZhlhG8AY1CequXMX/3Y8Lilm3EOsO9rHTI988aVnkw== X-Received: by 2002:a05:600c:470a:b0:477:7b16:5f9f with SMTP id 5b1f17b1804b1-47d1958a61fmr575821605e9.31.1767553560265; Sun, 04 Jan 2026 11:06:00 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2c4fsm96505089f8f.42.2026.01.04.11.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 11:05:59 -0800 (PST) From: Mahad Ibrahim To: Mahad Ibrahim , Hans de Goede , Mauro Carvalho Chehab Cc: Andy Shevchenko , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v1 3/5] media: atomisp: Fix block comment coding style Date: Mon, 5 Jan 2026 00:05:07 +0500 Message-ID: <20260104190509.19683-4-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> References: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warnings regarding block comments. Add missing asterisks to block comments to adhere to the kernel coding style. Signed-off-by: Mahad Ibrahim --- .../hive_isp_css_include/host/mmu_public.h | 74 ++++++++++--------- 1 file changed, 40 insertions(+), 34 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h index 90a2e4e8f510..c3495ec4835c 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h @@ -11,45 +11,50 @@ #include "device_access.h" #include "assert_support.h" =20 -/*! Set the page table base index of MMU[ID] - - \param ID[in] MMU identifier - \param base_index[in] page table base index - - \return none, MMU[ID].page_table_base_index =3D base_index +/* + *! Set the page table base index of MMU[ID] + * + *\param ID[in] MMU identifier + *\param base_index[in] page table base index + * + *\return none, MMU[ID].page_table_base_index =3D base_index */ void mmu_set_page_table_base_index(const mmu_ID_t ID, const hrt_data base_= index); =20 -/*! Get the page table base index of MMU[ID] - - \param ID[in] MMU identifier - \param base_index[in] page table base index - - \return MMU[ID].page_table_base_index +/* + *! Get the page table base index of MMU[ID] + * + *\param ID[in] MMU identifier + *\param base_index[in] page table base index + * + *\return MMU[ID].page_table_base_index */ hrt_data mmu_get_page_table_base_index(const mmu_ID_t ID); =20 -/*! Invalidate the page table cache of MMU[ID] - - \param ID[in] MMU identifier - - \return none +/* + *! Invalidate the page table cache of MMU[ID] + * + *\param ID[in] MMU identifier + * + *\return none */ void mmu_invalidate_cache(const mmu_ID_t ID); =20 -/*! Invalidate the page table cache of all MMUs - - \return none +/* + *! Invalidate the page table cache of all MMUs + * + *\return none */ void mmu_invalidate_cache_all(void); =20 -/*! Write to a control register of MMU[ID] - - \param ID[in] MMU identifier - \param reg[in] register index - \param value[in] The data to be written - - \return none, MMU[ID].ctrl[reg] =3D value +/* + *! Write to a control register of MMU[ID] + * + *\param ID[in] MMU identifier + *\param reg[in] register index + *\param value[in] The data to be written + * + *\return none, MMU[ID].ctrl[reg] =3D value */ static inline void mmu_reg_store(const mmu_ID_t ID, const unsigned int reg= , const hrt_data value) { @@ -58,13 +63,14 @@ static inline void mmu_reg_store(const mmu_ID_t ID, con= st unsigned int reg, cons ia_css_device_store_uint32(MMU_BASE[ID] + reg * sizeof(hrt_data), value); } =20 -/*! Read from a control register of MMU[ID] - - \param ID[in] MMU identifier - \param reg[in] register index - \param value[in] The data to be written - - \return MMU[ID].ctrl[reg] +/* + *! Read from a control register of MMU[ID] + * + *\param ID[in] MMU identifier + *\param reg[in] register index + *\param value[in] The data to be written + * + *\return MMU[ID].ctrl[reg] */ static inline hrt_data mmu_reg_load(const mmu_ID_t ID, const unsigned int = reg) { --=20 2.47.3 From nobody Thu Jan 8 00:14:41 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 746AC314A6F for ; Sun, 4 Jan 2026 19:06:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553568; cv=none; b=HVOq5rzjPXO22sUv/QoJ0mVdGNqME/MY+u8OuDXFj2UGnXuPXLL73DhkDL1YYoovfJqU0NoqwFAMCXajBvDe+3Lzidef4b009oFSq+vwcfCBV30UYzA+fnCJRw8LnK0QgirhUxNu8Z4BsdR3VfSC5WX+9YnnsG4lqMMW5wvuSG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553568; c=relaxed/simple; bh=OeWqv3x4vXNpequnFxYPQjSTl4yPG1PFNq+yGKZsjK0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=abwgncIdGVl9zoLvd72vGqPdw0st8wop5q8u1dJ2PIypJyAqCdgEuurJPH5KGHaCMBXPtw+g6AFTHtyOVtUjDgSvloaBVBkWI1RwOetWCrGjxDtt1UKzeXUzD2sKWco5vyWSz7sxaNvgDN6caAM8mpXm4fdTnkUERvWOGBXdX3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LKV0XPw/; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LKV0XPw/" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43284ed32a0so3002128f8f.3 for ; Sun, 04 Jan 2026 11:06:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767553562; x=1768158362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lZ3Vo4XDf8d33cecZM2n9uZLMWmVIB6ElfJWOAil5Sg=; b=LKV0XPw//lThm9LXf6hqFegl4QsYZXyxGVQcs/zFNeX7IWeG4knUingu9xhdwqcLVX y/u4aDEr70w0/Th21nlmqhuSnUF88Y++nV1/Ft/v62U0mtpVo7qvGZBScXpBV9+NhSMu dkH76pdQv3H7o8o2GpwjuFp6KErgSzndBT78jMgAgQ/Yl4QgGjlzy92/0ZLW7Aq6fcpk i97oz7Zx3NIbeYt3Q+Aalhf5N7CXiM/UahjXHH013DCQygdP26mLqda4jRriqz4W2/mu +xJ7/ewhZg3ljTFR6VVMWN8dmQLVvHPJTgJbblcqa7t3oKP8rbESMh9LTRmDzf6hW6eN vVUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767553562; x=1768158362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lZ3Vo4XDf8d33cecZM2n9uZLMWmVIB6ElfJWOAil5Sg=; b=hzh7EB4KhdnWf47Z0plMNT3v2846xchQgEnwN7DcCGx7h+xHvAmHH/Vczxa/Ad3GCo Le4rqtIBcNzT/YHH4ylyiAB8RRtQQBrzTLDbf8vVKalvl+bK+sS5130xnoMiQS3aPcVV BPRU5FZBquspMNhFvkXQ1f/+zr5VsiCF8UfaHteUhrewfXrmI1lbn/aXMInNJngYX8Js AegGTfDdwCpjLN/dAc9YbWeboMcMjeqmVJh5MHA/IsjITHFN6YFJVrJQKhX07EsT3C+C RY6xwXOaPwpMFpK816ASYwsxqXWV7N0iEXr8+YTlDk+K9Qgdpypo7lIgn8cy+AW/eVdJ MbRg== X-Forwarded-Encrypted: i=1; AJvYcCXfn5/QEar2Nd6Ium3jbi1OqHGpsq9jzFEb0K8KuS4HLfse84sTupwhHDk+TEP9PpbWNQVajEYpnayXdj8=@vger.kernel.org X-Gm-Message-State: AOJu0YzuTXMJeKPOiaA+n9/+zLcjFVlZfPuAyHr9cf0U4yahtjQzd7MN PSYVMFGd6DyvLRgHXruWU+vSuGy4b1SzaeUDVytyUZRlN6kSw51KG5ef X-Gm-Gg: AY/fxX5hcT7sTMBViZkpa/j0IdLkxc4tOtt6+ekrTebJH7FdgB03OqIchloFxaY6NjW +VBuA6rsqqlc+ER12BFtDawM2RoNNHW/2j6SougkQwJeLBHUPErwjClXSfHZ0T73t29UfnQBiGo ryeqSqG90UTB73C0vT5AfkXid5Me1+peZiRRdCWCBv4sv50PddDPBQWrOCb3usQ+FnEBvLRzbgh Ea3ZGixq3/ScVQ9Mnxrfr5jKFvlto1kVnRmVjuASncPIShhCd9bOPm6odDJ0NhuaQmltj6JLSEo BEYd1DtSeSPb/pxcwRmEQ4h39aoA/P1xFJkhb+ipNxwZh25lRzSNYAZFxSD0D295iTLbaji4Mp5 KjyvxJDnf+o0HOe2lN2l3Gqw3O0LSVz5qi75VYPQTH1kkJVgAR1yDlhcIjWgfVpUMmUZhyeTGZG fnf5pXL8gkIPLzQfjrbe0Na0q/+eSugZq+zLqGTdM= X-Google-Smtp-Source: AGHT+IFMqb+P79D6s0rZ42eMiSzskYTFWAxJDYuPAZrqbcUt6nli/XEunoys89ausHc9hjH5F7sVwQ== X-Received: by 2002:a5d:5f54:0:b0:431:907:f307 with SMTP id ffacd0b85a97d-4324e506ab1mr61282976f8f.48.1767553562427; Sun, 04 Jan 2026 11:06:02 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2c4fsm96505089f8f.42.2026.01.04.11.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 11:06:02 -0800 (PST) From: Mahad Ibrahim To: Mahad Ibrahim , Hans de Goede , Mauro Carvalho Chehab Cc: Andy Shevchenko , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v1 4/5] media: atomisp: Fix erroneous parameter descriptions Date: Mon, 5 Jan 2026 00:05:08 +0500 Message-ID: <20260104190509.19683-5-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> References: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function mmu_get_page_table_base_index() accepts only one argument mmu_ID_t, the block comment for it shows an erroneous additional argument base_index[in]. Similarly, mmu_reg_load() only accepts two arguments, however the block comment explaining it shows an erroneous argument 'value[in]'. Remove incorrect documentation lines. Signed-off-by: Mahad Ibrahim --- .../media/atomisp/pci/hive_isp_css_include/host/mmu_public.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h index c3495ec4835c..611755e88e9f 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h @@ -25,7 +25,6 @@ void mmu_set_page_table_base_index(const mmu_ID_t ID, con= st hrt_data base_index) *! Get the page table base index of MMU[ID] * *\param ID[in] MMU identifier - *\param base_index[in] page table base index * *\return MMU[ID].page_table_base_index */ @@ -68,7 +67,6 @@ static inline void mmu_reg_store(const mmu_ID_t ID, const= unsigned int reg, cons * *\param ID[in] MMU identifier *\param reg[in] register index - *\param value[in] The data to be written * *\return MMU[ID].ctrl[reg] */ --=20 2.47.3 From nobody Thu Jan 8 00:14:41 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AAAF314D21 for ; Sun, 4 Jan 2026 19:06:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553568; cv=none; b=d7EO4L03ndnKPAL6Gk4UpL/2RDGI1eqG0qDb0Q5xyqnTLG9+4baHjldQDl+XnrAYd+DcqfJ8D56lW1Cpc7O+1zIkgpZpfKPDHqjIgOM4wmCezKxX4DNUtyMDPcW4E38LPurdQW487aZJRJS7ucI/RRQxp4yuQPUBqFXHv1iFl80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767553568; c=relaxed/simple; bh=ZK5uX/GFgJyLUCjHyioeL6D474O5WD3tQ+XmE+pnOXY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wyq8ExsKSlP4ABgF+1+cJbN3MQ5M7mF6MQ/tVAG2mq/2/V4UrDU2bl/oteB94kuOUk8gBKoLHxBTtza8PojjPwPr8FmDa96r+Vg4TOcT0AycICOZn/8d1PBkRJQLQEgWJU0f3S1N4hHD0kGgQ7bUSKQKJXl/Ug5RJnH2VsPpqYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M/KXFfz4; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M/KXFfz4" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42fbc305882so6341914f8f.0 for ; Sun, 04 Jan 2026 11:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767553565; x=1768158365; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ebOgnSrN48fxkQK6SNZdklEbQHgjDwwzirduEj6RKHM=; b=M/KXFfz4uhkYjYVd/3lHbuegZWbcG7ha/fgAZApixkl1N3lYBzm4OUi6rHLNnY94yF mcrNIHtl1aiVOTDc2GujyWDQDL4RAt4WGyhONM/qycMYwOrWSo/Bw4T6orFGpTjdnGG8 7FOgVaBRuwYICbBpECQqJikEwt5kxN+AgIF8vwFTyPf6kew0W8HvhE1VS2BFac7LPDgv b1NLPL+5VWYv1GxawfF1Ti30U8fF0AvNr+2fYu0DtOb2h0bdyMk53ITisT8CeadP05L4 hDvFjGonMXNnVDbjCRhH1XwQxoqcvn/i75j2ybebO5r7EX/koWSqICEHmSdVPft+LCQj /kmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767553565; x=1768158365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ebOgnSrN48fxkQK6SNZdklEbQHgjDwwzirduEj6RKHM=; b=nuCMEDrGnqfUPtYuJaPBWk5DMXOna3j9Bx5BGXgg+ZuFVzbzuep2ggd012jvuvRell p7UEUFlGlwbRa0UlQxaDsgiKI9BZvlg1upv/6hTE/5u078lb+yb9WsxUMxMGFKTV98dC Bw8QPCBqEmNCWkq8RZjtiuqw5+JRB7Dv2iSSYP5C+/fVxQhX0ryi9Q0Jse5tCQyYVpDD Py8WFFGIn2dBe7mna8bdoYk5docX0uTrW7nTpWpNaYGGN6ivM+Lktoorz+Xh6vRORgmQ 5lo/7ClRtOnhhJ6DK4DOGVoS4/pEMCpX3Gpc7GkV7HlkTt2ZXPFYhvPh0/Y0quvYlRV2 gHlQ== X-Forwarded-Encrypted: i=1; AJvYcCVdthsb+iMXXFRDu12JH3SraUbz/TRNdDzkd0DCQTmXMqZPRAYB7d3U1OMbVuyZXD3hglgaNwmTK2XRuE0=@vger.kernel.org X-Gm-Message-State: AOJu0YwBof8s0DnUiaKPnuVH85OLfuNqPWglv1a+HIiZxfx8epJ68IJJ z68mRbOJQtb3vFSpQ/yDurATP4Z6s9lze3Y88PQX5uD4ddXXJNqc6/4C X-Gm-Gg: AY/fxX7oUvHNUpCnmjAg6sSC6MB4xDvyOzFlROb1gz77/s9YhIArVo7nzKHxS3Ylgq+ u8S59NG02bEwqlKtIUyBi1fCKg5VktV3gLA4PxKacB9aKU/L4th+kqcrn4qtph2Xaqjj0bhVVWq oVJG9Z03rrcjXAi7W1E0LXvOAzJ+UBXcX99kSq6kuEv6Es1Ebre6OrDvq0efnFzBdba4Q2wN5I2 iP5/6T83frRkIV3WcQDQf50gjyai9EUzERY63mdG+1rJhjuPUD7co6A71n0tz5D/b7840dHjRgi SDpiEf31oIiOJaHa+A0Tvzh4k3aelS20oevZ1TacX1Qe7QyoL4PougS9ZgI4jmRHNvCdsUdge9Z W3MQycXmPE9mJfPjYXC3imcai1/56MDLEnW1plHlFYG4uGIs7mzr1VsZbCYtbzGmuZit0zTS9Ue fumLObgZXq0TqgTHQEFO1jiY/ape6TMTgcm7CRXpY= X-Google-Smtp-Source: AGHT+IHIP5Wv68Zp/SZhZsLMise/WRvMupz/fef9S9rk4hz4fUw3ic6mFpAGlWl+s7LC1UyZTgG9FQ== X-Received: by 2002:a5d:584e:0:b0:430:f622:8cca with SMTP id ffacd0b85a97d-4324e511553mr63803347f8f.56.1767553564535; Sun, 04 Jan 2026 11:06:04 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2c4fsm96505089f8f.42.2026.01.04.11.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 11:06:04 -0800 (PST) From: Mahad Ibrahim To: Mahad Ibrahim , Hans de Goede , Mauro Carvalho Chehab Cc: Andy Shevchenko , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v1 5/5] media: atomisp: Convert comments to kernel-doc Date: Mon, 5 Jan 2026 00:05:09 +0500 Message-ID: <20260104190509.19683-6-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> References: <20260104190509.19683-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Existing comments in mmu_public.h used Doxygen syntax and had inconsistent formatting. Convert the function documentation to the standard kernel-doc format to adhere to the Linux kernel coding style. Signed-off-by: Mahad Ibrahim --- .../hive_isp_css_include/host/mmu_public.h | 59 +++++++++---------- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mm= u_public.h index 611755e88e9f..b321f4101193 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_publi= c.h @@ -11,49 +11,45 @@ #include "device_access.h" #include "assert_support.h" =20 -/* - *! Set the page table base index of MMU[ID] - * - *\param ID[in] MMU identifier - *\param base_index[in] page table base index +/** + * mmu_set_page_table_base_index() - Set the page table base index of MMU[= ID] + * @ID: MMU identifier + * @base_index: page table base index * - *\return none, MMU[ID].page_table_base_index =3D base_index + * Return: none, MMU[ID].page_table_base_index =3D base_index */ void mmu_set_page_table_base_index(const mmu_ID_t ID, const hrt_data base_= index); =20 -/* - *! Get the page table base index of MMU[ID] +/** + * mmu_get_page_table_base_index() - Get the page table base index of MMU[= ID] + * @ID: MMU identifier * - *\param ID[in] MMU identifier - * - *\return MMU[ID].page_table_base_index + * Return: MMU[ID].page_table_base_index */ hrt_data mmu_get_page_table_base_index(const mmu_ID_t ID); =20 -/* - *! Invalidate the page table cache of MMU[ID] - * - *\param ID[in] MMU identifier +/** + * mmu_invalidate_cache() - nvalidate the page table cache of MMU[ID] + * @ID: MMU identifier * - *\return none + * Return: none */ void mmu_invalidate_cache(const mmu_ID_t ID); =20 -/* - *! Invalidate the page table cache of all MMUs +/** + * mmu_invalidate_cache_all() - Invalidate the page table cache of all MMUs * - *\return none + * Return: none */ void mmu_invalidate_cache_all(void); =20 -/* - *! Write to a control register of MMU[ID] - * - *\param ID[in] MMU identifier - *\param reg[in] register index - *\param value[in] The data to be written +/** + * mmu_reg_store() - Write to a control register of MMU[ID] + * @ID: MMU identifier + * @reg: register index + * @value: The data to be written * - *\return none, MMU[ID].ctrl[reg] =3D value + * Return: none, MMU[ID].ctrl[reg] =3D value */ static inline void mmu_reg_store(const mmu_ID_t ID, const unsigned int reg= , const hrt_data value) { @@ -62,13 +58,12 @@ static inline void mmu_reg_store(const mmu_ID_t ID, con= st unsigned int reg, cons ia_css_device_store_uint32(MMU_BASE[ID] + reg * sizeof(hrt_data), value); } =20 -/* - *! Read from a control register of MMU[ID] - * - *\param ID[in] MMU identifier - *\param reg[in] register index +/** + * mmu_reg_load() - Read from a control register of MMU[ID] + * @ID: MMU identifier + * @reg: register index * - *\return MMU[ID].ctrl[reg] + * Return: MMU[ID].ctrl[reg] */ static inline hrt_data mmu_reg_load(const mmu_ID_t ID, const unsigned int = reg) { --=20 2.47.3