From nobody Sat Feb 7 18:15:34 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6956C21FF38 for ; Sat, 3 Jan 2026 09:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767432616; cv=none; b=lWVo8og0OrSAJLmC83WPeJpbz3EJd87LWVwzTvVAnZ1CANJHQAObBuWP0TMgIgOujw6jYPjFfoY6ousLoP1OS539xoK6bHkf4N+X/g0CGhI2vIruglpXbzMiupdZwrTz37ArPVJf6+gL8tzRtpDpDG8Ol33Pep93Jr5MYYE45Co= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767432616; c=relaxed/simple; bh=xPBhV3xf/mEOLNuM1+djpRv2cyMz8fzyttuoGbo3704=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GHmrimOs+WZNp+xMwOkwh0iTmheaU+LIeHOL2E0UUzJaZ4x4fXMQz7nmpjcbZ85LCK01sIo/bmSGH8mUIT9Bc0g3MTwiC7NMJv6159SAEfDbijBG7l5IebgBKN6H1nBfjb8NTYEXSfGWPJ4k8MSRNwDUtYg64g0MVzsYmS+hY6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ShMfDIrT; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ShMfDIrT" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-34c868b197eso14084957a91.2 for ; Sat, 03 Jan 2026 01:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767432614; x=1768037414; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Bt9tJYP4C9GkuKYSjvH8xQ7Gj8IEbQo1GeZTVx+trAY=; b=ShMfDIrT9kJHvQ9U234fvxLmd8cQjvS9cbTtwY63aasR7XL9QrARVtQPraAD8vUDpV 1P+zgHtEaKXJi48xPlaTzSzoS+gBIIqTpSv49sgZZPpIEECfPxCCmKZ4rDo2CC7rm3Le t0bkfdzUjKpE0vrxtxU8hreIeMs2w7Rj2ZQ0IiWwcHPD9P9oOL9YV+HjTv4+kzWd4Fpi U6hiSrnuvqo71emA+8QFHSzSjx2irh/MD3+PIuit4sq08QQLIGf/oMPWrlif+BzEBRDR GZGm10TzW8CQogK6gB093h6sVxdOIwOxgS7z6Jr8lRn1KOSw9UNcf/xyFkEGCk8E5t8Z 3YKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767432614; x=1768037414; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bt9tJYP4C9GkuKYSjvH8xQ7Gj8IEbQo1GeZTVx+trAY=; b=SgrVIu+ic9qqzxXJyu4qq5AIl+bQ0CPqiJVnerK7Nlto867/HIjQsvYve75vg4X3tE h8heoT6Xm0iLhIo/M+vNBAJ1PaF1H9YDjCDG+r1Hc6nH9tsbbKcy8X+3un6n6DXqh/Di Lq3BPBdoIcAJhen7k9AhhLTRfJrhOT/5qqT1BgtMFciaCnI1+AHUQvxsdIUyuvgUOa8m mjoyM4/NMuGg1nEuHG3Uu1V5Rq35rMtIVnRAaLo51fRoPTclBS5Vpzls2yCZPGkADnka PUsI5ud6Z4OUFgnBO0aaCeVAOT2hFS5hPrYAhRoit05ELjZIx859tlvtHYm9C0qcFieE /luA== X-Forwarded-Encrypted: i=1; AJvYcCWGPjIULvZLRKjxqZztTXI58XQnL3giU8iUQLKKy0ks9v83scagfSWmqj8C0w6QvqhBEIuoPym+hDUYsJg=@vger.kernel.org X-Gm-Message-State: AOJu0YyK/OlmAYPa8wK5emsbGFm1WTs7qBx3Cy9Cw1XafQcIWXY/+faH 2apJ3JrrloUU2K01QIdodVaw6u5jnj86qQnrPTgVG9R+BXnY3nVF+mga X-Gm-Gg: AY/fxX4afXUVwfKZ0fopZdzwYCeMLsgdI+zOgSh4m7L02qejMw5OvTpnGtPnXBrvr+q rb8WKdC3n3qcQP3S9EgWZIO4z7DPgolCwGlol4Jbp8dVqxxcLjIUcxhqOyfiq5xMMxpR8TDfXcx phYzRef96FZJPL1hVyauoEBvpWoVhk4205iCSbdfUdXW0MAjc5px65Zoh1KtCBkbeVlPPJ9VYDv WaEtvG9QcboSvTgGmG5mOObCGijmsWeRMTrTDoy310AscO5DuWNEPkAnRZauDN+EidrUSZsx70F 8cpZLLrdINBRPfE0/FDz7YN0vjVB/ui90jRY6+SbJ4CrnFamn6h6IP/52B31qjVu0OXf11gaYT5 lfGoBdh/kzM2zH+v713Xe4IU1YlSUIEwAPpyNCoRVv7t+jgLdC8spVQ1E2pa45e/t9axXcaWFeZ a8ez4jUJejXgHwn3gY6KM= X-Google-Smtp-Source: AGHT+IH5m1iMRPHgBJ6TJtBzdLg/1Zcz/w0B39ddDknVSCVCLeF7pbZ57H5QL0PYLZNutuZ6eRJTVQ== X-Received: by 2002:a05:6a20:1611:b0:35d:5d40:6d75 with SMTP id adf61e73a8af0-376a7afad8cmr35575798637.29.1767432613559; Sat, 03 Jan 2026 01:30:13 -0800 (PST) Received: from mythos-cloud ([61.82.116.93]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f476ec31dsm1331875a91.3.2026.01.03.01.30.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jan 2026 01:30:12 -0800 (PST) From: Yeounsu Moon To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yeounsu Moon Subject: [PATCH net v2] net: dlink: mask rx_coalesce/rx_timeout before writing RxDMAIntCtrl Date: Sat, 3 Jan 2026 18:29:05 +0900 Message-ID: <20260103092904.44462-2-yyyynoom@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" RxDMAIntCtrl encodes rx_coalesce in the low 16 bits and rx_timeout in the high 16 bits. If either value exceeds the field width, the current code may truncate the value and/or corrupt adjacent bits when programming the register. Mask both values to 16 bits so only the intended fields are written. Found by inspection. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Tested-on: D-Link DGE-550T Rev-A3 Signed-off-by: Yeounsu Moon --- Changelog: v2: - drop unnecessary cast v1: https://lore.kernel.org/netdev/20251223001006.17285-1-yyyynoom@gmail.co= m/ --- drivers/net/ethernet/dlink/dl2k.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink= /dl2k.c index 846d58c769ea..74e0fd08d828 100644 --- a/drivers/net/ethernet/dlink/dl2k.c +++ b/drivers/net/ethernet/dlink/dl2k.c @@ -590,7 +590,8 @@ static void rio_hw_init(struct net_device *dev) =20 set_multicast (dev); if (np->coalesce) { - dw32(RxDMAIntCtrl, np->rx_coalesce | np->rx_timeout << 16); + dw32(RxDMAIntCtrl, (np->rx_coalesce & 0x0000ffff) | + (np->rx_timeout & 0x0000ffff) << 16); } /* Set RIO to poll every N*320nsec. */ dw8(RxDMAPollPeriod, 0x20); --=20 2.52.0