From nobody Sat Feb 7 21:15:01 2026 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7BFA29E116 for ; Sat, 3 Jan 2026 08:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767429185; cv=none; b=q5JsBYB4OfImNie7XvV5k19Vgkscqooe4w5OEv7vamLkN0e34Cx3gUr/WEa6iLwi0fDgdE1Wbr7wct0MTqBdJjioGZMNooxgEXun1dk01Zefm6c7TxR9ZOB+j3Il72bD0igVSmkY7yXfQmF8BM1Oj277+eGhfHSqPtCtSm/V5Cg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767429185; c=relaxed/simple; bh=TE3kngwJ0Q/M8PG4jM5YkANzvwJ2ZBoXO6QH83Kep4E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rs/4U+WUofi1Nu2oGJfQr2GuUnBOCj9XFt8ncAlhNu77pB8lyTO7u4oAeWBbN+hYbAX7+KFpR5Ia93Cnv7x/bTKSKvS4qoYO9gTkMh95m0ym+PZzQuXvDBvH0cTs7T59eqAxsrSKYUDv3fUBLuLAeKOBH+M7ain5HU6SJ0nycPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AFOxU7nW; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AFOxU7nW" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2a0c09bb78cso3296345ad.0 for ; Sat, 03 Jan 2026 00:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767429183; x=1768033983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mtp/dZW9ya4TxwOta3UUFMIrN/FXohK03+kMMLH28dY=; b=AFOxU7nWtCWWzSNkNkmJETzPS85qZfZP3Njn4VUqNOOErbFLC72SwO+B1JojwTXJqr EBwYx3xmyRzrMfY5k8olfkP7pYCVT+GVW1iKmyGT0onFEfP/J3XEpeJMa5399vmn59FC JajQE9t9vuL3/nObQcTSh5QRvujZtmR7rJpAEd1rhjv9sNsP1G8+Ngd9K8Y2tbz4gpKu C/kkwFYU7pLpZSH2jsjEPn3PiDG+1fJO4RXzayFQEskdxzk2mlQ5xaStWAh/8Ib6Zwr+ se0LuvC+Wh1SuJNOh8aSRna1I5P1JFtlNsIJstxKjuwspJiapfr//XoVPtFrSrEWpMAV 8j8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767429183; x=1768033983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mtp/dZW9ya4TxwOta3UUFMIrN/FXohK03+kMMLH28dY=; b=lQRQEgG69KTUqjqESv53hxyY3/kS1HwNWEQHw9bYZpKnckwx23E89Yrwa1/rwCkQRw R4t7klLxC3y4ulgnh2j6FDLVQ30pJiiOriPGGU34hOF3Op3XDoHiQrCuoaiA0FmWDzjd 1Tvhsb2mwzw4aPAY3i3+SKxRvW0gAYoBzO2d7kcviD2XgRV4Mr00N5uus5RrSVtH1eXu e4pV1Los9MzOwkggQTwZX9HkS+yzLb5l55iHu5I4ukUvKh5F0BgYzwrsEoDSI/u46tfi vVug8+33aY9XmCT5oY4RzXHSiNz1A0NPKKcCoR45GNSlJOdYc1H5SztpVmXCFRhbf0C1 pmLg== X-Forwarded-Encrypted: i=1; AJvYcCVJVmntM5cnhCjzgpW3n8Lp8ECRmmsc+t+US6gAnFy6H2lEI/eTLk6e7THSNJCOfsH1/+9CxdTQpvMAcsE=@vger.kernel.org X-Gm-Message-State: AOJu0YwIpHwUH5SmMkWbqrIoVehsEGVKOWYeXue1IvrZqZA5chSssSgf PcKxh4mhgO+oVv2uGrouFlJci0RNVGBTHtRI6TmPOLllYelImKBC4FAo X-Gm-Gg: AY/fxX59KjD/x58s3p/tgSldmatavmqT2Xa2ucMScJ1I/H/j/FjawVQJ1pKgPEmQQIx xS3wuG4eiYZAPobShMt/m1EFDwhRT/FYQRWFENEYrOeaeSlD03qaQhWmvSkTOnUDgBxfX/MKcPR +iKLLR9fI8HGOHIiTVNC4c/Tbka49UxakFQbBdQQepfU/cNmEPY+4sQAEpnv+mqajgEdj6RaFWh 9EHFhuMX6rC8sQ6unSMb/VKw4/8eIiwGQ4p6CvfvFlLTrOtN7pTXoS0japQ9/UA9QoWpXhqPbAF MX3GEzZIR24M879j0ZCkBU7kVFTT3CBQShFU+20yxEdN8kS42Rjn+GgZFUdkxyemqLtC3Wh4L5J VHHlAVqwsVK9YsWuOhD5/zKWpnAL6BnDYnuTq89zZf0r3glIyDDlWYAzICdvsTyjK72CZ7GO4hk 8qUn4MfA== X-Google-Smtp-Source: AGHT+IF4+KGquo7ddnKSZYTeA5YRjfMxJO2/EkJueXQkQkzBA1/AjlzM6p5PsyRepGJBGL2j9Swfbw== X-Received: by 2002:a17:903:2442:b0:29f:1b1f:784 with SMTP id d9443c01a7336-2a3c0940a8bmr16854045ad.4.1767429183029; Sat, 03 Jan 2026 00:33:03 -0800 (PST) Received: from rockpi-5b ([45.112.0.8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c666d5sm391700365ad.21.2026.01.03.00.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jan 2026 00:33:02 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Heikki Krogerus , Greg Kroah-Hartman , Sebastian Reichel , Nicolas Frattaroli , FUKAUMI Naoki , Diederik de Haas , Yongbo Zhang , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list), linux-usb@vger.kernel.org (open list:USB TYPEC CLASS) Cc: Anand Moon Subject: [PATCH v1 1/3] arm64: dts: rockchip: rk3588-rock-5b-5bp-5t: Correct Type-C pin bias settings Date: Sat, 3 Jan 2026 14:01:17 +0530 Message-ID: <20260103083232.9510-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260103083232.9510-1-linux.amoon@gmail.com> References: <20260103083232.9510-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As pre FUSB302 datasheet interrupt line (INT_N) is an open-drain, active-low signal. It requires a pull-up resistor to maintain a stable high state when deasserted. Similarly, the TYPEC5V_PWREN_H enable signal requires a pull-down resistor to ensure it defaults to a low state, preventing unintended power delivery during the boot sequence. Update the pinctrl entries to use pcfg_pull_up for usbc0_int and pcfg_pull_down for vbus5v0_typec_en to align with the hardware's electrical requirements. Cc: Sebastian Reichel Fixes: 67b2c15d8fb3 ("arm64: dts: rockchip: add USB-C support for ROCK 5B/5= B+/5T") Signed-off-by: Anand Moon --- v1: As per the shematics CC_INT_L interrupt pin is GPIO3_B4_u As per the shematics TYPEC5V_PWREN_H pin is GPIO2_B6_d --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch= /arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi index b3e76ad2d869..0cd8ac7bf538 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi @@ -537,11 +537,11 @@ pcie3_vcc3v3_en: pcie3-vcc3v3-en { =20 usb { usbc0_int: usbc0-int { - rockchip,pins =3D <3 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins =3D <3 RK_PB4 RK_FUNC_GPIO &pcfg_pull_up>; }; =20 vbus5v0_typec_en: vbus5v0-typec-en { - rockchip,pins =3D <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins =3D <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_down>; }; }; }; --=20 2.50.1 From nobody Sat Feb 7 21:15:01 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F6A72D0610 for ; Sat, 3 Jan 2026 08:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767429204; cv=none; b=AxsIsi86NqKBLT0GGjkVC0z/ZWdghbxnLKY1LhNAs55UAmjizVVyumQUjEEl6dqILsDZGISQWFqWzTePZHxQdCwoAu5idNTGkZrA2AR6iJ4IwUcq7m0SiTu2FlYFEAvyUPurFQf3cBb2qvI+1l981xP/H4nzrBCI49aaeozesE0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767429204; c=relaxed/simple; bh=izi4VvU/qHkp/nGvi/OJ7celFPcbQBwlswNh4vYfIMk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jjkdDRJJyC2RukSQtNz33YPmpxKeEJmxpShCnbjNu61D4CfGp2MFl9g8Soc2SDAH05SRDmKqppfbYiY7XgbwVXJN5cF3AoTzucQj2f58uG2GVgOmBppj++iUIH2/wn3qGTJIO9A1RIECfmD+D+v9Fs5h07/I2q9GhTBglE22ML4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fyl7+60J; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fyl7+60J" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2a099233e8dso106348255ad.3 for ; Sat, 03 Jan 2026 00:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767429202; x=1768034002; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=29VsiJqR0uFBbQHYC75VBavG4DpR3+cDRVjS52nwMSM=; b=Fyl7+60JpdPVFOBSwjT60+F8rl1CPaxLMz1yXxZLezLVX3nANOrDhW6yB21uyG42kS RiSgzPOiB3iwMKeCtBZSOmWhjkEcbuTqbABosuEn1bU0AFLy4A7BDp5klMKJc4/YQL3y 9hlGLrhfEvmnH23G69GPULiG/IuHAUOZiTl5d9p1Uv81PeaaoR9hPCfrp7kyRZzli+/p byPdaNHodC9QNMeg8ETBmX7jIr2aA2Rv4Hz6soGXJk3DB4CKsj7zsOChbLfvHTp/BaTa 1QYKC7RaLqOjLLq3qrsyMaLIyDrGiQlrWFZ1utYhtUKiMW6ZvrtiGn9JceI3PBs52nrV oh9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767429202; x=1768034002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=29VsiJqR0uFBbQHYC75VBavG4DpR3+cDRVjS52nwMSM=; b=naN53idbRv72jLwZtexDVCB5bDQw9QQg60+vFRyFH4u1pnZmlBUdniXRgpAyOg/KhN ynXVb6aomPa4fPoAW/ClLHdSf1YQGHiSpLzeISH/HSTB3AFfnpZhYi+TKY0NVEsUZZn3 p21HvjlURFSXZx7SltsYKSGyqP7COAQENVegDxNK+XYCOVYME8+qTe/wMofMkAuiNUd1 OUwD9Gm2npxWAbuc9RY7YJO+X4YDC2aAWpckXWheq0kZWFPyDr0pT2EHs/pD1LmbuvCy X5eSEuPpGSKeuFk0qDuXtwxFJQA3EHSeXkQ0yNCshcYrGOK0U/RY9Iie9V/cerBm0czg Ophg== X-Forwarded-Encrypted: i=1; AJvYcCWciOqxyM5VexNH5np+RobXfVF4v0v6ijra96tafd+5ptooxy0nnCBbEBvmlGPp2M/N6lRHsUe7UZglCEs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy12wLrNqRYBPYAY2fEIcsZ7v97xZOvo4nbPDeBvnIMmcESYLbx wjgLb3Y4mFxRA291luYOH5qnDgEkwUJ3lHFv6pVJiR+t8YlfyBpJDw4G X-Gm-Gg: AY/fxX5hZFsl2WxoTRgrDAaIHgqq+8YC2hOIZhjsHF4bUNOyjPy/EeB7C4XTXnz9tZo FJODhpiprjq2lNIo6Iant5sJ6pgZ5AecOhvSp9Bh1y+H4OuFDDXJTglLyZliqpETa8J45hEe6/6 vTQcQNJtLFxlCgicQN8YJtPwPusAIMGzudf+a3r2VH1pF8dWDq+wjAhhpl2cWClXwMpsGgP8cZA zpwb4KDqYBanplgQeMiI35Lc9Q7F74XLuJP7smAlrPC7vZBo1uGylkH5X++tJIXfl+srW403N2T cCCtsegZyg/4I/m28ilanySkzcKeM9H7TeHVLOHmLNme3Nrb4BJmXOZL1+R1Ir3+z95YYOMBkTb BtHNGHiGMzI1ZdAWzewWXB0Q23cXhbmYxDLXOYqt2tJZNbQV3+rsxRBvffAtavehV3Wu5qYUkKr vSlRsMUw== X-Google-Smtp-Source: AGHT+IEdATA9P7k2n5CWUx8yOsmhm/F/9su5pYtPk4wylobkfRFEAHqb0+3yD3t4l4QDFzSZPoWtgw== X-Received: by 2002:a17:903:1c8:b0:2a1:3769:1cf8 with SMTP id d9443c01a7336-2a2f2734d5emr447661885ad.33.1767429202381; Sat, 03 Jan 2026 00:33:22 -0800 (PST) Received: from rockpi-5b ([45.112.0.8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c666d5sm391700365ad.21.2026.01.03.00.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jan 2026 00:33:21 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Heikki Krogerus , Greg Kroah-Hartman , Sebastian Reichel , Nicolas Frattaroli , FUKAUMI Naoki , Cristian Ciocaltea , Yongbo Zhang , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list), linux-usb@vger.kernel.org (open list:USB TYPEC CLASS) Cc: Anand Moon Subject: [PATCH v1 2/3] arm64: dts: rockchip: rk3588-rock-5b-5bp-5t: Fix USB host phy-supply on Rock 5b-5bp-5t SbC Date: Sat, 3 Jan 2026 14:01:18 +0530 Message-ID: <20260103083232.9510-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260103083232.9510-1-linux.amoon@gmail.com> References: <20260103083232.9510-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The USB host USB2 and USB3 on the Rock 5B, 5BP, and 5T is powered by the USB_HOST_PWREN_H gpio pin which is used to enable vcc5v0_host host regulator which ensures proper power sequencing and management for onboard Double-USB-HOST. Update the u2phy2_host node to reference the correct phy-supply. Cc: Sebastian Reichel Signed-off-by: Anand Moon --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch= /arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi index 0cd8ac7bf538..886d788572fc 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi @@ -981,8 +981,7 @@ &u2phy2 { }; =20 &u2phy2_host { - /* connected to USB hub, which is powered by vcc5v0_sys */ - phy-supply =3D <&vcc5v0_sys>; + phy-supply =3D <&vcc5v0_host>; status =3D "okay"; }; =20 --=20 2.50.1 From nobody Sat Feb 7 21:15:01 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9383329B22F for ; Sat, 3 Jan 2026 08:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767429224; cv=none; b=l8ILfqXx13LpXbrF/Fv1EVXSLdBIFpenkDWexv5Rc7N6FUNKvl9m5hK2rImOKz8OQXj+YMVrokwcwuktwbaLeLmqq4hNlll/7S6rxWXTn/WC6+pVsA+Va/CtNFqoM9s3EYfuZXtF/q4F9cbHuyz5F4qKWOfXVbZ4WEkiL3uatwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767429224; c=relaxed/simple; bh=PC93uMu0rTtqYTL8EEurWx5EXMnuM4BeV1/KFTTmfBs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=paIEQgv5xWQdelbmzfHjm++glZuy+rB/OjP2OQJ8iWtON+A7PJ4BUZ8KOWkk3dTBRXtyHC7iAJbrBI5JFjFGHssiy4OGSuSvlWPIm4jyzkMexk2eVoc4J60ak/fdxuWz+9Pv8DfOvE1xyTbevALDimLTq+ruRTuAlJPyD+HrHYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PgXEpvok; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PgXEpvok" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a0bae9aca3so180627585ad.3 for ; Sat, 03 Jan 2026 00:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767429222; x=1768034022; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hHyG145kzFXnOFjXe++Sub24U1Sr0jpUyn5t+Vf48Jw=; b=PgXEpvokEvj/gEAjDGNV/XiN9lwieYES3UBT08ebktFVQmuoYiNU+RN0U3DEA4Yywr ZVp+veiKgRqeDMfaGXqJPqF9E2VsHegdHexep5pwQ9XxY299Ws50AGqrEzlN+v7khEW2 IBr9nihckKzuAM7xsiL6fz0cS5gJvHZF1IdKFKVI7kSoxdbSMIqTTTF4CZy5K29j30Gh zjaSl8GX7XOdO0gHgK/9h182VFAZuQYUdGQaTxPQ9kFfb+0NzV4BOGyshlxGqWyPhcl8 Rw4y4rK+lMLtezn2JkDs3tAesGuRijikRPFOfmEJd8wymgQEbz0DiC+Bdpa3V5npFfhe qcXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767429222; x=1768034022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hHyG145kzFXnOFjXe++Sub24U1Sr0jpUyn5t+Vf48Jw=; b=JPqfvUaEYza00UfSMlZfb/7bWoLzYXZ5shVXjY1vJJJoHOrMBAPaf7WFTnCkEWX4ji EhMglW09qIuQLb9YntiQ+y61RW4fCjXCvPYFWBvqSMGl1Qt6dMJ63MwioknNK7kpaIA1 42VnnI+DK5LKdJUOWj5SjFcN3MkkT+KyMHxrk+VSOxtoKGt3H4zauuvfWif8zRCxdOX9 QvIXFhHIUR17vJiinQWJ/EkJCo5rKlE1uxPubLQbdgbqq6JHpWJC4yk2hxPk/AvenL17 22GqW2Y8W1ETf0/o9QsD78I8hpt1H9U8IdFs2pc4HbeUKIz5hg9FXfz2avl3n+R2N3je IERQ== X-Forwarded-Encrypted: i=1; AJvYcCVm9IIIk2DMo18oXmyc0WX3kVeAp8qF5RnUqsNjH/g1ZFOT/bOPKvvWRQXf5V0BNxS8VfPnsNsL6a/+YdU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGZOpTMmZ1lByissoL0m6pxUxOiceS9p0u0ZrC0tnXMlIKR4Mr 8gt4dLkiPJOToxK8G7KmFPyVFkkeNqFsGUbmHdkz6hZT84/nia2PD+KK X-Gm-Gg: AY/fxX5XHKhKAXYxNSEoG/ySjBpoDtAHzY0A9lHoVDBDV4zsMEH4qxJu58Djho/lxPv g32j46jo+iTYXxezpAf6H474zZVQsre9EI0Lss4vvKc6NVCVeYiLOPQZhVzQTShg95BYYEEke2g JdVnEuWOfUUmKAPf69jtjdw9xSerg8wlI6Xuso3o+2jLRTjIvptFN75sR0tiUsPuLarx+o8W5uS Jmx/M29dyQ7Gwswb7sWtKgXCy0ufV70sEuXcT3SVJRmWv6pevgIKQ125gnWyf3g4NwoDPYuQ+4j 5TrzM/+SkVFr4+8QE05NcAUNHZv+kWi6z52PC8EXJMtWpcF+jSVvm5hfD8K6ZbgQ7FK/vlBjNs4 l+bQ+hbgtvnmSYzfrXlWIZW/skd+YHnAriX9cpRIZUSzmkYvIMWatlGWnKIeQc5SM7dBMK3aFWK L/tXbIBA== X-Google-Smtp-Source: AGHT+IHxDotaAPgTf9hDSRmjhQO/IAis4W0EptEfWvNWpf1X8rcKBg8E34x8vTt2toQFaw/FLYg8Jg== X-Received: by 2002:a17:903:1c7:b0:29e:76b8:41e5 with SMTP id d9443c01a7336-2a2f2830f94mr467517465ad.30.1767429221879; Sat, 03 Jan 2026 00:33:41 -0800 (PST) Received: from rockpi-5b ([45.112.0.8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c666d5sm391700365ad.21.2026.01.03.00.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jan 2026 00:33:41 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Heikki Krogerus , Greg Kroah-Hartman , Sebastian Reichel , FUKAUMI Naoki , Nicolas Frattaroli , Cristian Ciocaltea , Yongbo Zhang , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list), linux-usb@vger.kernel.org (open list:USB TYPEC CLASS) Cc: Anand Moon , Hans de Goede Subject: [PATCH v1 3/3] usb: typec: fusb302: Switch to threaded interrupt handler Date: Sat, 3 Jan 2026 14:01:19 +0530 Message-ID: <20260103083232.9510-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260103083232.9510-1-linux.amoon@gmail.com> References: <20260103083232.9510-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fusb302 driver triggers a "BUG: Invalid wait context" lockdep warning under certain configurations (such as when CONFIG_PROVE_RAW_LOCK_NESTING is enabled). This occurs because the interrupt handler, fusb302_irq_intn, attempts to acquire a regular spinlock (&chip->irq_lock) while running in hardirq context can lead to invalid wait context reports if the lock is considered "sleepable" or has incompatible nesting levels with the underlying interrupt controller's locks. lockdep warnings: [ 38.935276] [ C0] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D [ 38.935690] [ C0] [ BUG: Invalid wait context ] [ 38.936106] [ C0] 6.19.0-rc2-2-ARM64-GCC #2 Tainted: GT [ 38.936716] [ C0] ----------------------------- [ 38.937129] [ C0] kworker/0:0/8 is trying to lock: [ 38.937566] [ C0] ffff000112c04190 (&chip->irq_lock){....}-{3:3}, a= t: fusb302_irq_intn+0x38/0x98 [fusb302] [ 38.938450] [ C0] other info that might help us debug this: [ 38.938953] [ C0] context-{2:2} [ 38.939247] [ C0] 2 locks held by kworker/0:0/8: [ 38.939670] [ C0] #0: ffff000100025148 ((wq_completion)events_free= zable){+.+.}-{0:0}, at: process_one_work+0x224/0x4b8 [ 38.940645] [ C0] #1: ffff8000800fbd90 ((work_completion)(&(&host-= >detect)->work)){+.+.}-{0:0}, at: process_one_work+0x24c/0x4b8 [ 38.941691] [ C0] stack backtrace: [ 38.942010] [ C0] CPU: 0 UID: 0 PID: 8 Comm: kworker/0:0 Tainted: G= T 6.19.0-rc2-2-ARM64-GCC #2 PREEMPT(full) bd73c5afc1bd41f04ef9699c14f038= 1f835f4deb [ 38.942017] [ C0] Tainted: [T]=3DRANDSTRUCT [ 38.942019] [ C0] Hardware name: Radxa ROCK 5B (DT) [ 38.942022] [ C0] Workqueue: events_freezable mmc_rescan [ 38.942031] [ C0] Call trace: [ 38.942033] [ C0] show_stack+0x24/0x40 (C) [ 38.942041] [ C0] dump_stack_lvl+0x90/0xd8 [ 38.942047] [ C0] dump_stack+0x1c/0x3c [ 38.942051] [ C0] __lock_acquire+0x5e8/0x9c8 [ 38.942059] [ C0] lock_acquire+0x134/0x280 [ 38.942065] [ C0] _raw_spin_lock_irqsave+0x80/0xb0 [ 38.942072] [ C0] fusb302_irq_intn+0x38/0x98 [fusb302 634bac905a09= c450b54f88b96019accd2820228f] [ 38.942082] [ C0] __handle_irq_event_percpu+0x138/0x3f0 [ 38.942088] [ C0] handle_irq_event+0x58/0xd8 [ 38.942093] [ C0] handle_level_irq+0x108/0x190 [ 38.942099] [ C0] handle_irq_desc+0x4c/0x78 [ 38.942106] [ C0] generic_handle_domain_irq+0x24/0x40 [ 38.942113] [ C0] rockchip_irq_demux+0x128/0x240 [ 38.942120] [ C0] handle_irq_desc+0x4c/0x78 [ 38.942127] [ C0] generic_handle_domain_irq+0x24/0x40 [ 38.942133] [ C0] __gic_handle_irq_from_irqson.isra.0+0x260/0x370 [ 38.942141] [ C0] gic_handle_irq+0x68/0xa0 [ 38.942146] [ C0] call_on_irq_stack+0x48/0x68 [ 38.942152] [ C0] do_interrupt_handler+0x74/0x98 [ 38.942158] [ C0] el1_interrupt+0x88/0xb0 [ 38.942165] [ C0] el1h_64_irq_handler+0x1c/0x30 [ 38.942170] [ C0] el1h_64_irq+0x84/0x88 [ 38.942175] [ C0] arch_counter_get_cntpct+0x4/0x20 (P) [ 38.942181] [ C0] __const_udelay+0x30/0x48 [ 38.942187] [ C0] mci_send_cmd.constprop.0+0x84/0xc8 [ 38.942194] [ C0] dw_mci_setup_bus+0x60/0x210 [ 38.942200] [ C0] dw_mci_set_ios+0x1c8/0x260 [ 38.942206] [ C0] mmc_set_initial_state+0x110/0x140 [ 38.942211] [ C0] mmc_rescan_try_freq+0x154/0x198 [ 38.942216] [ C0] mmc_rescan+0x1cc/0x278 [ 38.942221] [ C0] process_one_work+0x284/0x4b8 [ 38.942225] [ C0] worker_thread+0x264/0x3a0 [ 38.942230] [ C0] kthread+0x11c/0x138 [ 38.942236] [ C0] ret_from_fork+0x10/0x20 [ 38.969307] [ T11] rockchip-dw-pcie a41000000.pcie: PCI host bridge = to bus 0004:40 [ 38.969995] [ T11] pci_bus 0004:40: root bus resource [bus 40-4f] Following changes resolves the lockdep warnings and aligns the driver with = best practices for I2C-based interrupt handling. Cc: Hans de Goede Cc: Yongbo Zhang Cc: Sebastian Reichel Fixes: 309b6341d557 ("usb: typec: fusb302: Revert incorrect threaded irq fi= x") Signed-off-by: Anand Moon --- drivers/usb/typec/tcpm/fusb302.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb= 302.c index 870a71f953f6..089722b52fbb 100644 --- a/drivers/usb/typec/tcpm/fusb302.c +++ b/drivers/usb/typec/tcpm/fusb302.c @@ -1755,9 +1755,10 @@ static int fusb302_probe(struct i2c_client *client) goto destroy_workqueue; } =20 - ret =3D request_irq(chip->gpio_int_n_irq, fusb302_irq_intn, - IRQF_ONESHOT | IRQF_TRIGGER_LOW, - "fsc_interrupt_int_n", chip); + ret =3D request_threaded_irq(chip->gpio_int_n_irq, + NULL, fusb302_irq_intn, + IRQF_ONESHOT | IRQF_TRIGGER_LOW, + "fsc_interrupt_int_n", chip); if (ret < 0) { dev_err(dev, "cannot request IRQ for GPIO Int_N, ret=3D%d", ret); goto tcpm_unregister_port; --=20 2.50.1