From nobody Sun Feb 8 20:00:17 2026 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2840233D88 for ; Sat, 3 Jan 2026 00:45:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767401137; cv=none; b=Q5lchq9OKUJzscJTOsxBwoKek2Lbh8vtP0Tk+jtNCLQKQpsUyU1YhamwzKuXmArKAGDgHTwa4uekfn7RT85Juh7RVf6fcdWKPJ9clTvF0kmL7sO4SnonxFnwI5RIPlKZNO38DKlBrh97Al6NEq6p5O+lHro/J+8RmBI3ZCRNuMM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767401137; c=relaxed/simple; bh=5ZbhlwdJGs2ocx8rdiMdEFmrOh3BfoureZRS1/aRzms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nWf2TcBQ8mAGLcUF/YVyJst8vOdopvfeIAxIm7gyAJwEQu168jQhg6KaPvhyyquU9jqEdBjf5ezPk+Dt/z7xMW/SvMHi6EaKFFEQe+zRowTaBaDAhoXkfanL9FAEGSZ0aSxZZnH0WSofraNmLzfIvVesVLJvL/k2TTXDUnRKo20= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=INLMepEP; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="INLMepEP" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2a097cc08d5so32621505ad.0 for ; Fri, 02 Jan 2026 16:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1767401134; x=1768005934; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EVsMc3vMt4H+YWE9AtvMgTt+thJkmCxQ0FHNoV75l2U=; b=INLMepEP6YjbBQz3CsZscUBrc3UgwsGiZP+qpjN9GG1/9LLyxWzJml57Lwlo8GKzPu qPun7x3/CRyfU9qyHSLCmODpXD6pi1aQSbyJ3gCk1LILQu7/ESXOsp1BNFNNyCQvCfz9 XTjcWEw4zGzxEIYWBsgio0kNGv42JWOMEOaMpgfLR1AvmBa75Hws9LkwAQlxZ0TCdJRU 2/Dyg3aDUwvlUe9dL1zM1/Pmaxum1juAT9JDuwe9b4FQebqdCJs1Qqr6QdKr6NDXr2fz 8rJ1wRy+hc4/at7IJGSAIPKw2TofzSHE0Mf2ADoNjac/u5fG2ViWOepG5IuoTypZ7I9S o+lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767401134; x=1768005934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EVsMc3vMt4H+YWE9AtvMgTt+thJkmCxQ0FHNoV75l2U=; b=W2e+xQnWT3mFM39QBBymtCNwI2na6Is8pn+mAm8lSraWVUDbXQGBvTT0ayYajRcZ6M p+6Whsj+5ITSccFb4ZmGvhtdS5tEGrNCmQ73I/nGDbG7BHs9jMO16AJmzA5ljALy4gK0 WSzFgzdnXClsUK+nbQTtSbgxgL72P5BbHw3iWjSglTJIkCth4YqN44zG+h5WHLGO//l5 3S/TfaEQIhBFKTCV5/A8Xmkv58pzstUh/Z8EM8FzKOL6cdpGNLWuQ1ap3KxrRV/4WIgn VfwkK1BrrWTv7X0WPUHJt4xo/Ti0zEWSecu3GWSfMGgnzH6bMC7yjQWPyaFN2RIb/+VN UbpA== X-Forwarded-Encrypted: i=1; AJvYcCXJXaOLXZt83Glev7yKo9WvG8mtzaM+fk/xvst8gtOMw5a5lQoUAOpQeN0iYNF+zBnZD2zB4/vsLwNVipg=@vger.kernel.org X-Gm-Message-State: AOJu0YwdZGEMLJ4m2ZG3/hmDNOEHrnkvBYGE2mTeDCX0cfsdhQiKfpgU 4G5ysaXSQjfYIX8bqg7oEAqbM5et62P3a1AXKppmpuRS79a9kLJx+SZH8hRgN0MPvET/ESV+Us5 3mHjjWtWrnG78lkBi5dbnd5k1QsdZvTxnoVWL X-Gm-Gg: AY/fxX7adSN0/J98kUNS+HSqVQTiowtUJ/tLCZAgvj35J/nIVzZRb48uCEhLnLUAD1G wwfhfVxET8JnR44nzHtcXh4NJAVwSGRcSUVh9cfh3EbcNMp2IOgeUH5/zk3MLHBd0jbgkwaehy4 8Z4li7uWRYzZjyd4338c+XS9E1KkmsLje1kpNLPVVe0bepiGsnM1QUheVnRuk1ueHhxPsnA84yz 0n4cqJf4Td7GNVB3Zx/Ec4i6n7yU4xgU/ni1VRtANvreJsBCr9xWXE0SFp9c6WET2aYLVV3ToXi ERE2h9/xAFeXEK1IsawlwpJx1WeLa1A7cDnvV/ulChsDwq6W2qxw+cl4qFpYX8hJqhH/T+szf4W cU4nPBIl1CJ9Ttjd+bZF8yTjdPosLJ0ADNgbniNvtnA== X-Google-Smtp-Source: AGHT+IEsDo8UYO1hwGaARm6NPNqEWHL/GaiHYG082SNQvgge6Pe4hDg9H7li1KCyXrHUdfe7Aqai4q4oPqI5 X-Received: by 2002:a05:6a20:c916:b0:35d:3b70:7635 with SMTP id adf61e73a8af0-376a583266cmr29062142637.0.1767401133655; Fri, 02 Jan 2026 16:45:33 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.129]) by smtp-relay.gmail.com with ESMTPS id 41be03b00d2f7-c1e7b68fbe0sm3104866a12.10.2026.01.02.16.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 16:45:33 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.49.34.222]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id E5A30341C73; Fri, 2 Jan 2026 17:45:32 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id E10B3E4426F; Fri, 2 Jan 2026 17:45:32 -0700 (MST) From: Caleb Sander Mateos To: Ming Lei , Jens Axboe , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Stanley Zhang , Uday Shankar , Caleb Sander Mateos Subject: [PATCH v2 06/19] ublk: split out ublk_user_copy() helper Date: Fri, 2 Jan 2026 17:45:16 -0700 Message-ID: <20260103004529.1582405-7-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260103004529.1582405-1-csander@purestorage.com> References: <20260103004529.1582405-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ublk_ch_read_iter() and ublk_ch_write_iter() are nearly identical except for the iter direction. Split out a helper function ublk_user_copy() to reduce the code duplication as these functions are about to get larger. Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei --- drivers/block/ublk_drv.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 811a125a5b04..73547ecf14cd 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -2727,42 +2727,36 @@ static struct request *ublk_check_and_get_req(struc= t kiocb *iocb, fail: ublk_put_req_ref(*io, req); return ERR_PTR(-EACCES); } =20 -static ssize_t ublk_ch_read_iter(struct kiocb *iocb, struct iov_iter *to) +static ssize_t +ublk_user_copy(struct kiocb *iocb, struct iov_iter *iter, int dir) { struct request *req; struct ublk_io *io; size_t buf_off; size_t ret; =20 - req =3D ublk_check_and_get_req(iocb, to, &buf_off, ITER_DEST, &io); + req =3D ublk_check_and_get_req(iocb, iter, &buf_off, dir, &io); if (IS_ERR(req)) return PTR_ERR(req); =20 - ret =3D ublk_copy_user_pages(req, buf_off, to, ITER_DEST); + ret =3D ublk_copy_user_pages(req, buf_off, iter, dir); ublk_put_req_ref(io, req); =20 return ret; } =20 -static ssize_t ublk_ch_write_iter(struct kiocb *iocb, struct iov_iter *fro= m) +static ssize_t ublk_ch_read_iter(struct kiocb *iocb, struct iov_iter *to) { - struct request *req; - struct ublk_io *io; - size_t buf_off; - size_t ret; - - req =3D ublk_check_and_get_req(iocb, from, &buf_off, ITER_SOURCE, &io); - if (IS_ERR(req)) - return PTR_ERR(req); - - ret =3D ublk_copy_user_pages(req, buf_off, from, ITER_SOURCE); - ublk_put_req_ref(io, req); + return ublk_user_copy(iocb, to, ITER_DEST); +} =20 - return ret; +static ssize_t ublk_ch_write_iter(struct kiocb *iocb, struct iov_iter *fro= m) +{ + return ublk_user_copy(iocb, from, ITER_SOURCE); } =20 static const struct file_operations ublk_ch_fops =3D { .owner =3D THIS_MODULE, .open =3D ublk_ch_open, --=20 2.45.2