From nobody Mon Feb 9 06:26:54 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB7D2313529 for ; Fri, 2 Jan 2026 12:48:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767358137; cv=none; b=b4fQDNFtIYtEazHf0DEsJ9PIHNzfdpbv0f611WSmAnMgd1on5yewUe/Q+ketsqqrseIQsb7gL1dUqI/x/kYWldMrppziXbkzTZuW2olhkJRo+18k4AAVoyKjyvb7ODNgVDy7wOcIQiIcmDUCjiMVItT2jZCEGl5882KcsSLUMn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767358137; c=relaxed/simple; bh=MGJHIfZm/ZSovOzFuDJPmTHZ9rvV5qLwwkrNIcbV0ec=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sI/nMsya8As3Dav1RN/VtgvODelpleGI+rjCXv2Bz2xseRrMfNoY+q2JP40oYDFVyqiqgl1iofU4YtYsFFOiAPPPKaxtoCKvO5kfv1APYBO1gXGLpj9PZFuHk/Xoywz/QPIbeM7HRKObDose0/+irTMu6/yXWlOAnf0Z7MJldNI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=clMmV/bZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XcgU92sw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="clMmV/bZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XcgU92sw" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 602C0CxP315144 for ; Fri, 2 Jan 2026 12:48:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=Xgm2AP4vgmTYsv4aRX1OSL+r1z4YHLOddud 0aXq4pOU=; b=clMmV/bZXWsnQ5eoNle29tagaqRGohdRKKxKPROAXCJUNuV+QZT F9Fh1qEslLwty5OoK3NiwS7q7pXbTo+YrVzx5Wa7j4Hr2Kg/5jyhBd8eMmThdluJ pDQUrnx5VWuO2uCNog3PGO+s9uqIWKVS6ZX4G8r1y7Xgv2CLpvNFo5u1SQj8JQr8 w2FVegM8IEOlqTOrAAdGuumEKChXHjLyI+6E2OqCrW2tOYC7sOH/KxZXISxqmZXr IRo9YJs3hctdZTr54ik/6N02RxciUQXXsz0PK959ttFBVj+3CjHf8xhxWVqDwWF+ Fx+PoA7yBMfk6datIvPgQKkZ4XGSb1hIJyw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bedmxr2pk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 12:48:54 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4edad69b4e8so258522781cf.1 for ; Fri, 02 Jan 2026 04:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767358134; x=1767962934; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Xgm2AP4vgmTYsv4aRX1OSL+r1z4YHLOddud0aXq4pOU=; b=XcgU92sw6ds6tMNa7tZ0tczc/ICVjFOqFFOxGIoOuslGdacn3rdtz0HVevT9x6pKmd ynBIADN1xbvXjKimoo8fcqTv3xFfHipprf13R9df+TTYZI4xc9xiqlUaWFk51JFIbZ0b 11Q+oNkR/nhMeb282Ea7ZlkT6NFNhtG1OoD2Hwh5YZDov9lsljvjfIxKCG55lgYVRlHs xt2Q4TW7fynxzPJdxFJbolIYNemyFIU4PJyKIlXaTdIkP01kx+4hPMR/r2/yHS2CsQJB 5gN8AMx5zkcpYOIFi4/FIibW6mOY0xPr2BuI54YAPfKKgpN5O6jrlc4KL/dktyjNBWJy mKeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767358134; x=1767962934; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xgm2AP4vgmTYsv4aRX1OSL+r1z4YHLOddud0aXq4pOU=; b=KR3n8L7dckxHH0hMpETbd9qx4TTcH+olw09LsY9fkv9SuB0ilW5+QfJ7xmVKOyhIVI Jpw8GVfjrLJLh5//REM3iAPxf5ECZo1llkCiuaWfr3SW+RwaF3P5DuidYLdm9InqThJv 1LdFLij+KCjvWyN6yYnVJZcp3HTXCFOoQVWM8s6GX9h93lgtFeQytZf4785gnsdm5WDD Iz5fnD/pjvCkpCz7dqr+Tu4hT2c2BaD040SKnHy6KSak7NoC5ZvLowSi9MMs9MSTiF+o TS3+KQy5D7YQA0u4YVmXFWmh0SX0mBR8nVJvLJsfKyhaDR6c+GtUuePgho+1GkFRB2Kl J0Fg== X-Forwarded-Encrypted: i=1; AJvYcCWlAlEHax3pnNLeS3EZY1zqJ/MbJAIrVfU/sCh7wfUzfta1WFrBkhdqzoqaivtBbjWBNIcesjMQjVkoQOA=@vger.kernel.org X-Gm-Message-State: AOJu0YzyY2D8M6J3D8PVZ2ciWrMpJHNugM9FAdEz6ByX6XT/7Ksp/DOj vRCz0sKTfuzw7Ykdqj3pdtGTJ//eE1U3BzVWRb02GrI2jbrWV0qb408Fxn/cg9tjoeA6Phr+m4i lqorDtfOtXuE1eLmgXu2StDH6ivU6c1qefezQ4/9ArzHNCYQQ5qTzBJRqVHQ1+u4Z9b8= X-Gm-Gg: AY/fxX6QOrTYm/h+thTrfYdad7NBg7zkth1A7gWitru3+XGcU8z34Joyx+6CsUHUhUg Hv+4LjLVnUEWSJHl0EkiV7hJun+osWopwVJpaS2Q7WEkCuDELeRXpWcnFRjEUyBmp+kQ0OXZnHq ZQ0l7nnyBH4zdY3x5tCsgEJV/PG84k5OIQAc01jNrVvayXippJsGfD8egWB5/qBLO5E0j5aJvri Akam0hQDwP2aQpJXi2d//sE0VxYIHQ5SAkdd7J5RC3SXGrLVgPjAHlNeaIc4dmDbw8DOHp856ge gHuxKsKj4uBcKynM33uzRtth6pjA9JkoyGtWjZlqPUfoX1AYPPgnfCo/eIQ+aTy4ca6+zvC8R1C T1Nny8nG7bvXacnYTxTW91/EfeQ== X-Received: by 2002:ac8:7fd6:0:b0:4ed:a6b0:5c14 with SMTP id d75a77b69052e-4f35f43aaacmr649488701cf.23.1767358133924; Fri, 02 Jan 2026 04:48:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9lzJSbr57E+UeRW2oJCNK0mPboU52nQHVzE0PmuhD9prUEOymF4yHJXijw7/81WAH7eXrcw== X-Received: by 2002:ac8:7fd6:0:b0:4ed:a6b0:5c14 with SMTP id d75a77b69052e-4f35f43aaacmr649488501cf.23.1767358133483; Fri, 02 Jan 2026 04:48:53 -0800 (PST) Received: from quoll ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193d5372sm767135185e9.14.2026.01.02.04.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 04:48:53 -0800 (PST) From: Krzysztof Kozlowski To: Vinod Koul , Neil Armstrong , Kunihiko Hayashi , Masami Hiramatsu , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] phy: socionext: usb2: Simplify with scoped for each OF child loop Date: Fri, 2 Jan 2026 13:48:49 +0100 Message-ID: <20260102124848.64474-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2449; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=MGJHIfZm/ZSovOzFuDJPmTHZ9rvV5qLwwkrNIcbV0ec=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpV76x6RPnyCz1ZXcH9iipQhqZbpkWAdtCRlIT3 Os/LlocJD2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaVe+sQAKCRDBN2bmhouD 147WD/9Pi8XM9s0P+ZCcmIyS22LS9QmnLCHb8krpSRow7SeKYpCEgb42zGoyfXk/B3KDFWv8eAm vYHBTW3jd7FxcNcoC9XfNvZyslvcYeqxhGltA14KeZxa6roWn5oVMv1M6Z7yxdvx1v+UaSs0a9A 5VfJfWpJaRDgJpDlTkKw7xzIfZZVaBa5KQ0w2oMzPqeqhlVjsxAX/22n0w1Lyhr4eLLD+VU1cVe L128Ovys41Ay35thB6BIyvCUitg9azfmIIAvT9WXzIDOQORFne9h25GMF33UECuN4Ia/haB9pC7 ZSNxItRXC4xDAZVKYZ/S43QjgeubweDkqd8I/5pfq+3rN6giR9XULdBiStbaAf2bfaGgAJYVvZ5 d9UaA0Ph5LGX4P+2QN/yLjlf2vu0vl0Afb3rxJVE1ZWmutYabLV7VdzaNTd8pSCasPrxJ4WVN1p iGmzldFBqDeDaNztixdwi4RoFg8YhjZ4bQoKGkbPh483PCiRnq7tgRL1YOpa2EElZ24pUi/caWw VHNL/xqIvY7NjS6ywq56OIVUHEoazOkBxU6NVnQ3N+r/mJvwQLUlFXg70hoWZDKyoM84FjEWlhS rMvcbIMd0h/QY7Asc+ILNJinmmF2/gvSLOoNd1vuDcbxeX2JQkm1nWj50ryY9ERT4d/AZG6RNBp CiuswbRMew02DTg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=GupPO01C c=1 sm=1 tr=0 ts=6957beb6 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=uI6G-Or-YwyI0Z_CgVEA:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDExMyBTYWx0ZWRfX7uTCDTY987/y SejoT0c7a9mQ3Y9a4zvOk0FvtDKk7jz9kRB6TAGTZE/sxAsE3Etq+nsYOcxzzeIEDRGc2u7T4Gt Onq661dvzaKCROViNhtFCMzslJ0yMipeLTg8wceo1IF1IMm/rCW89PcXkkprRc9Ljcvg9tiu9xv OzTrf3m+lS9yqMfxPlhH6A5vGHPtx0rP+K2ZV48qgVIA+9nPKV7/8f0t19aJs+lCNPhwUldkBbt jmDJsC34OFScn/4vq7LqvosEUucM29zoCXxzJGoRvXOp1SPEVskTCA8ZXYdLt8wOaGdMbKaK5sO fyllcsoh93t8b1sjZrpGGH1VgrbH43riWOM3tRgBIvfN0hPrqRSiyoH9uZGW5J5dqom4Mh346YS 6Czfy1+BElCKW5B0AuJ8RYHR+vlorTJVtxtAjsdwiiP3Ruggg3jgr0Aw1X2dabEk8PwPQ8E465Q Brvbp0ioFdDx5Fm/AEQ== X-Proofpoint-GUID: EpJWzxnjS8m--5EQ76nEaYjJGm0XPMSf X-Proofpoint-ORIG-GUID: EpJWzxnjS8m--5EQ76nEaYjJGm0XPMSf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-02_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020113 Content-Type: text/plain; charset="utf-8" Use scoped for-each loop when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Kunihiko Hayashi Reviewed-by: Neil Armstrong --- drivers/phy/socionext/phy-uniphier-usb2.c | 28 ++++++++--------------- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/phy/socionext/phy-uniphier-usb2.c b/drivers/phy/socion= ext/phy-uniphier-usb2.c index 21c201717d95..c49d432e526b 100644 --- a/drivers/phy/socionext/phy-uniphier-usb2.c +++ b/drivers/phy/socionext/phy-uniphier-usb2.c @@ -106,7 +106,7 @@ static const struct phy_ops uniphier_u2phy_ops =3D { static int uniphier_u2phy_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct device_node *parent, *child; + struct device_node *parent; struct uniphier_u2phy_priv *priv =3D NULL, *next =3D NULL; struct phy_provider *phy_provider; struct regmap *regmap; @@ -129,34 +129,31 @@ static int uniphier_u2phy_probe(struct platform_devic= e *pdev) return PTR_ERR(regmap); } =20 - for_each_child_of_node(dev->of_node, child) { + for_each_child_of_node_scoped(dev->of_node, child) { priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - ret =3D -ENOMEM; - goto out_put_child; - } + if (!priv) + return -ENOMEM; + priv->regmap =3D regmap; =20 priv->vbus =3D devm_regulator_get_optional(dev, "vbus"); if (IS_ERR(priv->vbus)) { - if (PTR_ERR(priv->vbus) =3D=3D -EPROBE_DEFER) { - ret =3D PTR_ERR(priv->vbus); - goto out_put_child; - } + if (PTR_ERR(priv->vbus) =3D=3D -EPROBE_DEFER) + return PTR_ERR(priv->vbus); + priv->vbus =3D NULL; } =20 priv->phy =3D devm_phy_create(dev, child, &uniphier_u2phy_ops); if (IS_ERR(priv->phy)) { dev_err(dev, "Failed to create phy\n"); - ret =3D PTR_ERR(priv->phy); - goto out_put_child; + return PTR_ERR(priv->phy); } =20 ret =3D of_property_read_u32(child, "reg", &data_idx); if (ret) { dev_err(dev, "Failed to get reg property\n"); - goto out_put_child; + return ret; } =20 if (data_idx < ndatas) @@ -174,11 +171,6 @@ static int uniphier_u2phy_probe(struct platform_device= *pdev) phy_provider =3D devm_of_phy_provider_register(dev, uniphier_u2phy_xlate); return PTR_ERR_OR_ZERO(phy_provider); - -out_put_child: - of_node_put(child); - - return ret; } =20 static const struct uniphier_u2phy_soc_data uniphier_pro4_data[] =3D { --=20 2.51.0