From nobody Mon Feb 9 03:31:26 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 128E1311942 for ; Fri, 2 Jan 2026 12:48:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767358082; cv=none; b=QTnrrCgPt8Ga/uwi+MzdtnHwVFEGdV8V/HlVoD1HlUQDeQSvnNdswjrCakyibWzevyi9AyROAYCzwXBpVFHeGB8+EJjvFkn3nhiTDxKwXB/Bi0Pq94WN4GCUZ42zsW77zAGp2lmO8Gf0Xd2GX6dODdfeiA9Kb1wikuRBSFcjG98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767358082; c=relaxed/simple; bh=BwMUVIqgHsSLXsWLr/yHkduFe3TEnk8MGFxiheJTEoQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O51+pgFqB9lO4igOBB8s86aUiICaopHePCdD8DJ8okRlPodrFRDSsol6mbd8ebHhJ7iYdS3eHYjaSXw0K1lN4yeQN2hnUZxzhEehtwlCNbPGbXEQFY2NLBLOB2jLPphpJFQmziv/Sj7fqZcx4ZTOBvXIJ3v8jivTpWkWyr20ekU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RE3plvr8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g3itC7Fi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RE3plvr8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g3itC7Fi" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029WF0u427436 for ; Fri, 2 Jan 2026 12:47:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=rQrbwl6SmdVqWhNW1JcN758niEOl9CpKuKB qxGA0kOA=; b=RE3plvr8h6rM1ecLb9HQA4myYXVKSWq0f8+rHt1kkFZcCd/PUN0 KUJu+Jn+T7L/0+E/K4R8wjnOTa20Z7ZBd42JSC1C73EAUbAz7E4gkTz3VPzPGQOh c5nkTc+fgN7YqrQSnj4QfM3Tc5KmUE/rRx0Cyc9bUXlbyPY35CTZY1mSgkus0Lng yqrgl7d8FdSMwqevIKigXfzqJfMhwyO2vtwVShpmVoWZBOz/ViEXmh4QXcN+qmIK ukg3v7rkKAV4V21qK3UvIXfNw9j0n959HJzKS0rQIVw/ov5KQQfzmdgHIS6lX8F6 TkLjzGv8m1KuLfBHfww/5gzCAFmrhnTuFbA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4be6fjrxm2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 12:47:59 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-88a3356a310so335307336d6.3 for ; Fri, 02 Jan 2026 04:47:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767358078; x=1767962878; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rQrbwl6SmdVqWhNW1JcN758niEOl9CpKuKBqxGA0kOA=; b=g3itC7Fi+93/j9e2sBN8F9JxgueJ4GhMDPgDvJXqQRQVRzNVOWj+kry5M9fbCzmtMl ZymGc2SlRUK64EWhkg4rtPldEY7R2Ngp+w0VV8wQasXWxe0K8UNqupWDpbQXBEfGwt+u /JWKHIKKd2yGbTWsVW8j1vq++xaEGSWrGBJvejxY5RpxY7oWwQ2f7BRJYB22+VOw9yZN /ZkrUBWogCnkhkR8dipyVWqpgsawm3KfevO4XBJOtMjTpVQ9PcWy7ZLw+wkplftLwyxc a4J+XnIfncnzy+qHr+9+xnmJQRDhdd2B1Bu+IKY1SJWiKTzp9BRo/vmKZnJ5NVJE0LnF rnuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767358078; x=1767962878; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rQrbwl6SmdVqWhNW1JcN758niEOl9CpKuKBqxGA0kOA=; b=lO3ChY/so3PgM00O8uepnMYcfW2VVH4bMbmLB1Mv313LjuoKc/49dapGI4zBYwvs9q CAQWeLL+Z3PJ/aNgapZU0ZxOP8mM4LoJclpSRvtBEiRNDRhQwNe0AVRgtnhyB95zpfI1 dFQQ3am3BV4bSRWlNcWPIo5NN6R8Y76DeKY+IlRa4Rpc4depAd3u26c99lBx8Xxa/g42 p/CN3gT10xVa1iViSNNw6VNAsyySUiUuCcY7RixWB9NWeP30lxS2kzQFpbg6LprFUXZX 5T2bEYF4XsKrlNHFcStNjNaKIsAdEc/l15rgY27jw+78/mQEWCW18zGpkGovjo+I0MEa Rxag== X-Forwarded-Encrypted: i=1; AJvYcCV3RTS1z1cLm5kAwB7721OtECA4sVQV4aBVEa8PCCd6ly6mzhi2cIkdHrY5g773OsLJq6k01XeV+Nc+RrI=@vger.kernel.org X-Gm-Message-State: AOJu0YzCV+SjFCrUWxrkq9/jyQ18pSXMP8zHdPbORqmGsO4/ebGURb46 5+tsA3lFL+u30KxyBZu8m/eOKSDjI3ZLrSiMKEewljCQLdzExvp3YBKh46UgLgGSAUGJ9zTvxtL 6G+NQGpgqmm8/TE708PGG9Ff6IEhTOxQT5Ag5xjjwihe5C7hb2nNX48XcW7O6fftqobg= X-Gm-Gg: AY/fxX42Wxz4ux4lajy7cuN29Y244ldrOoPR8jIKwnEeRLpoQUiYehklDY1lK7mD+yt 44pcOHt4c23i+WGxWQk+eny3OutO1+xYbaG8kEOQtrf2ZH6+Pl3TKltVKy8SZdF/j3wqN2PiSLT Fhm9v/GNt+wb9lUCn9qQb1LsypLZdN67UXNDJJgbiNBajg/Tkgq7rcfIW+QVFsDOVeWR2N9jK4q 0XMS+Md3nt8cqRIuev5jkzsWZgY+I66lvt01Lgh0Jf5Uh3opgzLUnzFbmzgtUrl4Za531gZ7A5s 5NdyLRQWQFhZLeOzga99IL2Mj9DCdS220gOsdMmy/WbRXojCvkh+OrDm7hizPab3UYtSXttWsiN 3J6V392GSmiwaI/J/D1iTvBkGTA== X-Received: by 2002:ac8:7dc6:0:b0:4ee:b4b:a4db with SMTP id d75a77b69052e-4f4abdf1570mr562010291cf.82.1767358078487; Fri, 02 Jan 2026 04:47:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHt5R2wR9jhv6LNUtPbAFm5e41MAtMTk2OQVaV00K4MpUB0p78vFUF5TlqbcNz+3hdxbBi+cg== X-Received: by 2002:ac8:7dc6:0:b0:4ee:b4b:a4db with SMTP id d75a77b69052e-4f4abdf1570mr562010141cf.82.1767358078087; Fri, 02 Jan 2026 04:47:58 -0800 (PST) Received: from quoll ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa0908sm84197536f8f.31.2026.01.02.04.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 04:47:57 -0800 (PST) From: Krzysztof Kozlowski To: Herve Codina , Qiang Zhao , "Christophe Leroy (CS GROUP)" , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] soc: fsl: qe: Simplify with scoped for each OF child loop Date: Fri, 2 Jan 2026 13:47:55 +0100 Message-ID: <20260102124754.64122-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2492; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=BwMUVIqgHsSLXsWLr/yHkduFe3TEnk8MGFxiheJTEoQ=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpV756G8AhvfrUbvLgeAdmB00yW+jqEhRSn5I3U MvBeDKFz22JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaVe+egAKCRDBN2bmhouD 1163D/9yjVKt1NJDhqAFymdk+oeVkcbK/AvZYdXTCE9keCAp5fzJlxteLIkJFXXRwSHiVoVgBJu iLzmVZTllS2CdQYt8HoXw6afnlJds3WT/bU4xf8SnnufL3XiV6dI6sEatblrTkZgVIWQd+FE7Ho xVdq71lHc3Xkn8O55KDWUiQad0rUdxvRWKNzxkfIArwchQt7Eac6QXrq5Rxyng8c9fXPXhAAGkg xpmy6NZd5tjSPPw+LKS6WY5AKMRoWsIbhDJACnwhHqDBwVFrjYSQvtpCZSk+pp4NFnv9N0/Mu90 Uyaj3xZAf/CkYYGQTdz0s7bLO8vk5HplDfEMUXxq6b2jUM5qUyPR43E+4XXMJYDVjC3MNqdC/k0 2AxH64OiTaoq2y/Fnpff5Mti6ezV6keRQNgM6sR0zzNf4pYHogY7QvcPzXoN3ddxs/yvEi+6aGh 9OQJcFCXho7mYWWlNo/ED9EJ5go/zffcC16e6pjInkzSRxOwfj6vIlHmVrYz1JejD71AIMuuopM 5rrjcNKBcNoXvJhlZrZo8oDPP+m2QV1KIlY8xWSIoMbdL0kCePRO33UP/l+u/L8ya+jrPfOdkea r/fzuaq84mIZvSZBA7ZIDDNWCvwc+obMDHI5Svx7A4N9wL4UJTjPdZApZkJC5XABAgRxE90qCDo WpmAC7x5E9svkRA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Av7jHe9P c=1 sm=1 tr=0 ts=6957be7f cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=1gcOjtyiWqLwmlW-95EA:9 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-ORIG-GUID: PJK0o_5FkdE1NIVRtAVA2wSknaqr8f_e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDExMyBTYWx0ZWRfX5IZSfrVvnY1U l7xm8kHjcDOGPg2teppR2F9+Gl8PBSvZHWrQSpD9T4eebT46rfSS3g1y5JRuxUOa1ZZtoK+rEtz 4Uavcg3oqru5bcTyIxBiWsmEUtSqcqhs7U5+O/P3ocl9KKtwcLNhBrrQ3yOWZI6KxOreUFFeTAC uFMnoC8p/9RaCf9EECASSfudAl8Q0RC+RqaZD0ds7AkyeXjqjQUVY2OWeJNH1Gtr1B7Anw1DZYg 9M+SkLgDvszgXq0z13Dr3VuUUlx4Y51ccx8QM13iNJF2xfBLtZtYcm3Lz0yDBgKgvD7hmhKLpZl 3JhuPp1f85lnc04wWMx8GARIi05g0+r2zLSondOttLAakqWk7Ynlgo+eaBVYigZAX9b24IlH02N nDaQ0pt3KWg5j76JiDStEonPo7omDmYJw+4XQ+Ubac2PKwp2h6+n3+uwmvH6/cYNEgF5MxzO7y9 RLBCXuDI5ow/oEh7ZIg== X-Proofpoint-GUID: PJK0o_5FkdE1NIVRtAVA2wSknaqr8f_e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-02_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020113 Content-Type: text/plain; charset="utf-8" Use scoped for-each loop when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski Acked-by: Herve Codina --- drivers/soc/fsl/qe/qmc.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c index da5ea6d35618..c4587b32a59b 100644 --- a/drivers/soc/fsl/qe/qmc.c +++ b/drivers/soc/fsl/qe/qmc.c @@ -1284,31 +1284,26 @@ static unsigned int qmc_nb_chans(struct qmc *qmc) =20 static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np) { - struct device_node *chan_np; struct qmc_chan *chan; const char *mode; u32 chan_id; u64 ts_mask; int ret; =20 - for_each_available_child_of_node(np, chan_np) { + for_each_available_child_of_node_scoped(np, chan_np) { ret =3D of_property_read_u32(chan_np, "reg", &chan_id); if (ret) { dev_err(qmc->dev, "%pOF: failed to read reg\n", chan_np); - of_node_put(chan_np); return ret; } if (chan_id > 63) { dev_err(qmc->dev, "%pOF: Invalid chan_id\n", chan_np); - of_node_put(chan_np); return -EINVAL; } =20 chan =3D devm_kzalloc(qmc->dev, sizeof(*chan), GFP_KERNEL); - if (!chan) { - of_node_put(chan_np); + if (!chan) return -ENOMEM; - } =20 chan->id =3D chan_id; spin_lock_init(&chan->ts_lock); @@ -1319,7 +1314,6 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct= device_node *np) if (ret) { dev_err(qmc->dev, "%pOF: failed to read fsl,tx-ts-mask\n", chan_np); - of_node_put(chan_np); return ret; } chan->tx_ts_mask_avail =3D ts_mask; @@ -1329,7 +1323,6 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct= device_node *np) if (ret) { dev_err(qmc->dev, "%pOF: failed to read fsl,rx-ts-mask\n", chan_np); - of_node_put(chan_np); return ret; } chan->rx_ts_mask_avail =3D ts_mask; @@ -1340,7 +1333,6 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct= device_node *np) if (ret && ret !=3D -EINVAL) { dev_err(qmc->dev, "%pOF: failed to read fsl,operational-mode\n", chan_np); - of_node_put(chan_np); return ret; } if (!strcmp(mode, "transparent")) { @@ -1350,7 +1342,6 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct= device_node *np) } else { dev_err(qmc->dev, "%pOF: Invalid fsl,operational-mode (%s)\n", chan_np, mode); - of_node_put(chan_np); return -EINVAL; } =20 --=20 2.51.0