From nobody Sat Feb 7 15:09:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE9D7285CBA; Fri, 2 Jan 2026 11:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352625; cv=none; b=UCupfxydU01+rfwJc1qD1uyD1y8dTXQhnBPSfxDyioAEKykFCkVmyI9gJrpSNHwzMu/r/Frjo98xM9g4Dr6Ks0sQwI1iMZSAz/+ETSSh0M0sZjVq3haG1NCpFrDc8Bhx+24jRY3Hxj3q8cb5Gjn14cHxoNm7sEe5sAsozKhoc+E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352625; c=relaxed/simple; bh=LkyXlikqJ4zX4OMQnM6hSqcg84kjMZQKiZgJpBP1y64=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rl1Hm6T6dEGGQjv1pCYIQULqt5Kf7cQ1zMMty7WQlWLqJ070UuNTCgo+kR5jlVBsplHYJBy/BTB6lg+sa6mA9SZDUxBDB1mbFVHPc85tTn/t5Hl9vj2FLwfLSM0n+6MbeMq6sUwjugx0PQC8jlHRYB+1TZKUxXhjA4PzLA1TN+E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bqazDRPl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bqazDRPl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75E1FC19423; Fri, 2 Jan 2026 11:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767352625; bh=LkyXlikqJ4zX4OMQnM6hSqcg84kjMZQKiZgJpBP1y64=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bqazDRPlHO1aRXTyjYtJpxwl8o4uthbwbDKVWE2cWZPXKysc3sLaxZrEtWvphbMzN JxKgAA/GfPOVBuSkSwQAVcEBc26Ktl+A6z2pAXYja2bmconDD9aLh9yj8G/fBQoMhB IHmWe/QzAqmQtV3l/bSWX4jKRurT2vW6ucR0eb7Tw79mQaImIHVYe2irvoK/GR+UVr kdGMUiw3rH7NZTvTwI2CMSR4PwsNMV+akDWxGLpyfmVZJUf7PvOCuO6Vz3FctvhYQn xorl93HUjwcyPqRlvxGv82U41ig7zh32G8WgvJPysum5BDQvlbNfag5KebO8X5UwkX w3OsqI+4jfg/w== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vbd9I-00000000450-3oz0; Fri, 02 Jan 2026 12:16:52 +0100 From: Johan Hovold To: Srinivas Kandagatla , Mark Brown Cc: Liam Girdwood , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 1/4] ASoC: codecs: wsa883x: fix unnecessary initialisation Date: Fri, 2 Jan 2026 12:14:10 +0100 Message-ID: <20260102111413.9605-2-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260102111413.9605-1-johan@kernel.org> References: <20260102111413.9605-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The soundwire update_status() callback may be called multiple times with the same ATTACHED status but initialisation should only be done when transitioning from UNATTACHED to ATTACHED. This avoids repeated initialisation of the codecs during boot of machines like the Lenovo ThinkPad X13s: [ 11.614523] wsa883x-codec sdw:1:0:0217:0202:00:1: WSA883X Version 1_1, V= ariant: WSA8835_V2 [ 11.618022] wsa883x-codec sdw:1:0:0217:0202:00:1: WSA883X Version 1_1, V= ariant: WSA8835_V2 [ 11.621377] wsa883x-codec sdw:1:0:0217:0202:00:1: WSA883X Version 1_1, V= ariant: WSA8835_V2 [ 11.624065] wsa883x-codec sdw:1:0:0217:0202:00:1: WSA883X Version 1_1, V= ariant: WSA8835_V2 [ 11.631382] wsa883x-codec sdw:1:0:0217:0202:00:2: WSA883X Version 1_1, V= ariant: WSA8835_V2 [ 11.634424] wsa883x-codec sdw:1:0:0217:0202:00:2: WSA883X Version 1_1, V= ariant: WSA8835_V2 Fixes: 43b8c7dc85a1 ("ASoC: codecs: add wsa883x amplifier support") Cc: stable@vger.kernel.org # 6.0 Cc: Srinivas Kandagatla Signed-off-by: Johan Hovold Reviewed-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wsa883x.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c index c3046e260cb9..3ffea56aeb0f 100644 --- a/sound/soc/codecs/wsa883x.c +++ b/sound/soc/codecs/wsa883x.c @@ -475,6 +475,7 @@ struct wsa883x_priv { int active_ports; int dev_mode; int comp_offset; + bool hw_init; /* * Protects temperature reading code (related to speaker protection) and * fields: temperature and pa_on. @@ -1043,6 +1044,9 @@ static int wsa883x_init(struct wsa883x_priv *wsa883x) struct regmap *regmap =3D wsa883x->regmap; int variant, version, ret; =20 + if (wsa883x->hw_init) + return 0; + ret =3D regmap_read(regmap, WSA883X_OTP_REG_0, &variant); if (ret) return ret; @@ -1085,6 +1089,8 @@ static int wsa883x_init(struct wsa883x_priv *wsa883x) wsa883x->comp_offset); } =20 + wsa883x->hw_init =3D true; + return 0; } =20 @@ -1093,6 +1099,9 @@ static int wsa883x_update_status(struct sdw_slave *sl= ave, { struct wsa883x_priv *wsa883x =3D dev_get_drvdata(&slave->dev); =20 + if (status =3D=3D SDW_SLAVE_UNATTACHED) + wsa883x->hw_init =3D false; + if (status =3D=3D SDW_SLAVE_ATTACHED && slave->dev_num > 0) return wsa883x_init(wsa883x); =20 --=20 2.51.2 From nobody Sat Feb 7 15:09:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A45952749C7; Fri, 2 Jan 2026 11:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352625; cv=none; b=oIDCX+/ycMcpvt1RpsjFLN/FiAg8RhNdilaB6tB4Zxf8VUn/+/eE82gjRyWsXM7RWHrDozfYtFMkYOznDoeU8zru7t9UwP9EULe4K19+gyHnNDFNJ3I2mvXJLafUSaFX9L750/AZleSNGVqQCNnZZYALesmhL5iVlRuu6EpPQCU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352625; c=relaxed/simple; bh=IFoXMfoprHJcdPGJphjp51fna5ofwkM47nNwJSe0jY4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t24AMjVuMbyZj3GwuVCa2JdgIfxcXYXpmU9gRPXv7HMUFEBIrsRNiopvATiKseVuZSVgIyE1or5JfZdd3dEhx0YcQjCv34l3smNnJwtX+MQwuyNk3FTAhRFsoGcMb2jxyFF2usG446BTIrAtzLy92BSqDyRcZISxvt8SY/tiO+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FM+FNuB7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FM+FNuB7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 487F9C116B1; Fri, 2 Jan 2026 11:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767352625; bh=IFoXMfoprHJcdPGJphjp51fna5ofwkM47nNwJSe0jY4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FM+FNuB7vPVnwKoCbhzpNea/MI7eAf1KOwWsWBMgnJsSLSKV9vW6QH1AU8rQtXqim tks2S/R9QZ8/c+rBFdEw9i17qYVG3Tmtvz0fZFLGzOlodv8RwNOtkhtMycbeMXUIHU +5Ea6y5NNkTck0AbNSwYww9W8aONjCq5khAH6of9COAD/Q3CUgbLxlZtCQg05uLrrX Rjf6nZBaBkCWu3awiOvwIseOJqs0Negr2CaVBs+XNFwMYwFEJMZlsqxXNpO0C4gs2c QdZvCtahtALs3Vi03OoBCrUu8lPTiUsJigcsnFmMYF0AxfcE8Vbu3CL00ekUzb/8oh 8QnZnJKbwd86Q== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vbd9I-00000000452-49Pz; Fri, 02 Jan 2026 12:16:53 +0100 From: Johan Hovold To: Srinivas Kandagatla , Mark Brown Cc: Liam Girdwood , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/4] ASoC: codecs: wsa881x: fix unnecessary initialisation Date: Fri, 2 Jan 2026 12:14:11 +0100 Message-ID: <20260102111413.9605-3-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260102111413.9605-1-johan@kernel.org> References: <20260102111413.9605-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The soundwire update_status() callback may be called multiple times with the same ATTACHED status but initialisation should only be done when transitioning from UNATTACHED to ATTACHED. Fixes: a0aab9e1404a ("ASoC: codecs: add wsa881x amplifier support") Cc: stable@vger.kernel.org # 5.6 Cc: Srinivas Kandagatla Signed-off-by: Johan Hovold Reviewed-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wsa881x.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index d7aca6567c2d..2fc234adca5f 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -678,6 +678,7 @@ struct wsa881x_priv { */ unsigned int sd_n_val; int active_ports; + bool hw_init; bool port_prepared[WSA881X_MAX_SWR_PORTS]; bool port_enable[WSA881X_MAX_SWR_PORTS]; }; @@ -687,6 +688,9 @@ static void wsa881x_init(struct wsa881x_priv *wsa881x) struct regmap *rm =3D wsa881x->regmap; unsigned int val =3D 0; =20 + if (wsa881x->hw_init) + return; + regmap_register_patch(wsa881x->regmap, wsa881x_rev_2_0, ARRAY_SIZE(wsa881x_rev_2_0)); =20 @@ -724,6 +728,8 @@ static void wsa881x_init(struct wsa881x_priv *wsa881x) regmap_update_bits(rm, WSA881X_OTP_REG_28, 0x3F, 0x3A); regmap_update_bits(rm, WSA881X_BONGO_RESRV_REG1, 0xFF, 0xB2); regmap_update_bits(rm, WSA881X_BONGO_RESRV_REG2, 0xFF, 0x05); + + wsa881x->hw_init =3D true; } =20 static int wsa881x_component_probe(struct snd_soc_component *comp) @@ -1067,6 +1073,9 @@ static int wsa881x_update_status(struct sdw_slave *sl= ave, { struct wsa881x_priv *wsa881x =3D dev_get_drvdata(&slave->dev); =20 + if (status =3D=3D SDW_SLAVE_UNATTACHED) + wsa881x->hw_init =3D false; + if (status =3D=3D SDW_SLAVE_ATTACHED && slave->dev_num > 0) wsa881x_init(wsa881x); =20 --=20 2.51.2 From nobody Sat Feb 7 15:09:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEE582E2DEF; Fri, 2 Jan 2026 11:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352626; cv=none; b=ilEZWUneKtd506t50wtTk8HARfn0iko4yghai73iH47fz+Tplq8pkWiQeXdJCCMFGPsVD6eZc2+bCV9Cfm3/95ZlqaNw664nB9XcBIPu1iOGWYOMWGbTxdNaRATvvE12HAtQI9TGE5Czs0TAOi00nmkFQHecJU75ibSz3h5XwV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352626; c=relaxed/simple; bh=rk+cbJM2wJVxZ4T/W4bzG9bPA0LS3+V03lvoHPlAkJU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V8b5qRUBDfML4q+rJfRR+2AhaPB7FZkLzh4vKb3qo0QOxZ3CSmEAUrQaMebO9eL6ZgeC2k/Ut+oIKMJfUUkP7Pq1HgKPUAK6Yerrjywli5t/PbdAtc6vy+fT+MNMSJ9vmsr9fDVT+vTA9epyLEDkbnGD/2qTG+ptkH9dHaksrQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=czRc/2FO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="czRc/2FO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8359BC19424; Fri, 2 Jan 2026 11:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767352625; bh=rk+cbJM2wJVxZ4T/W4bzG9bPA0LS3+V03lvoHPlAkJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=czRc/2FOyiMyaNEVpvk+bPGhwKREEYslOKIpuglmCIMUehSA+GKPklsY0/nq0NmqN +RiD0VEALUDJNfZ1uRA54z2NBo93dy93sVYt97Gi5HWrJoa54Q8E51CMBV/PAqdFq+ /iQyDtNXg2Qw4jKtVYwwyM0x4ZyzqOhRlMZWxbqxALgtOl/FsaMivNd2vXKaBe+PUC 0Xn+eXYsda6U0kYFRB6yTwx6Ki6I7cZXnc4cJVJnGuHxeOUkw6jrtwAb41Y2OWFdJG eX50ziWOEVYorhMZS0dhs6fzS564CJezC/98mNLz2jjbjKHlmb578Pa+mvykUAvcX5 31/qobGj07tOg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vbd9J-00000000455-0HEK; Fri, 02 Jan 2026 12:16:53 +0100 From: Johan Hovold To: Srinivas Kandagatla , Mark Brown Cc: Liam Girdwood , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Krzysztof Kozlowski Subject: [PATCH 3/4] ASoC: codecs: wsa884x: fix codec initialisation Date: Fri, 2 Jan 2026 12:14:12 +0100 Message-ID: <20260102111413.9605-4-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260102111413.9605-1-johan@kernel.org> References: <20260102111413.9605-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The soundwire update_status() callback may be called multiple times with the same ATTACHED status but initialisation should only be done when transitioning from UNATTACHED to ATTACHED. Fix the inverted hw_init flag which was set to false instead of true after initialisation which defeats its purpose and may result in repeated unnecessary initialisation. Similarly, the initial state of the flag was also inverted so that the codec would only be initialised and brought out of regmap cache only mode if its status first transitions to UNATTACHED. Fixes: aa21a7d4f68a ("ASoC: codecs: wsa884x: Add WSA884x family of speakers= ") Cc: stable@vger.kernel.org # 6.5 Cc: Krzysztof Kozlowski Signed-off-by: Johan Hovold Reviewed-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla Tested-by: Krzysztof Kozlowski --- sound/soc/codecs/wsa884x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/wsa884x.c b/sound/soc/codecs/wsa884x.c index 887edd2be705..6c6b497657d0 100644 --- a/sound/soc/codecs/wsa884x.c +++ b/sound/soc/codecs/wsa884x.c @@ -1534,7 +1534,7 @@ static void wsa884x_init(struct wsa884x_priv *wsa884x) =20 wsa884x_set_gain_parameters(wsa884x); =20 - wsa884x->hw_init =3D false; + wsa884x->hw_init =3D true; } =20 static int wsa884x_update_status(struct sdw_slave *slave, @@ -2109,7 +2109,6 @@ static int wsa884x_probe(struct sdw_slave *pdev, =20 /* Start in cache-only until device is enumerated */ regcache_cache_only(wsa884x->regmap, true); - wsa884x->hw_init =3D true; =20 if (IS_REACHABLE(CONFIG_HWMON)) { struct device *hwmon; --=20 2.51.2 From nobody Sat Feb 7 15:09:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0487B2E7631; Fri, 2 Jan 2026 11:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352626; cv=none; b=hWIbNRZwFpemeQdHLLcqC6VRl9gAdZWe3v+a0z7o+dJwnGWuCZ6fAnh4RRzyDwM2noIa3ch36pQ+3IoxsVu6xpXSOF5VM9RZ0NnKwe/VZfQQfCEXrtqyKQPHm0nf6vjQ2mKbq1KSzdDWV8tUhYe5wYltt2EjhAwCPM1HE7tno4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352626; c=relaxed/simple; bh=c52ToyZxPNlAtJN0TxL3rQ5RMuuxuHDx8yn1dQa3AEA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uz+NWtRl6meLmuODV1dI7Q6Hi1sh+f+A+U/Fm+98FuyY3ERtO+h2b74nuQBmyoh0Nx64g75BVPyRXxR74zz29hMGcaZiLGJjhpa6cR0jBYJeZswktyxFWDAU9JMt8hr5hK+JWAFyzOcDe0MwM8P0VYTB7ArtkRBfuABA+uDSPJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jXsHVxtP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jXsHVxtP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B81A4C16AAE; Fri, 2 Jan 2026 11:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767352625; bh=c52ToyZxPNlAtJN0TxL3rQ5RMuuxuHDx8yn1dQa3AEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jXsHVxtP+bBOxlbbrvfdMvwLxG5gFnTZ8epUPGkLcat5Es05GQgT8rYThgk99w/zn UKF+6Bqsm80mfVI6Ig+s+kEJ7xJ5U77M7FmAkyDVejJhalbDfAvlCzYS2r+8iWGeWd +uAGo47lrJsOIT+3/YRgYhw73FAkUN1nPBpfS0OTCCxItRD3Yush4EzOY9qhwHX/o1 1ymAZ+aWQOyXPC9u5eEYOBDYCveUp7XOmWtvc2T5uAA925XlXn5SfHjU4BCZVNi+/P JfJJG6OQ0E2YUrsjKgpkJ9OYfRftKbOQNF17UDdrs6uTOq389wEafF2QFCQPMs7h2f rPV7AKlTtM5vQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vbd9J-00000000458-0Ylq; Fri, 02 Jan 2026 12:16:53 +0100 From: Johan Hovold To: Srinivas Kandagatla , Mark Brown Cc: Liam Girdwood , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 4/4] ASoC: codecs: wsa883x: suppress variant printk Date: Fri, 2 Jan 2026 12:14:13 +0100 Message-ID: <20260102111413.9605-5-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260102111413.9605-1-johan@kernel.org> References: <20260102111413.9605-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drivers should generally be silent on successful probe. Demote the codec variant printk to debug level and instead add a warning in case an unknown variant is ever encountered. Signed-off-by: Johan Hovold Reviewed-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wsa883x.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c index 3ffea56aeb0f..468d2b38a22a 100644 --- a/sound/soc/codecs/wsa883x.c +++ b/sound/soc/codecs/wsa883x.c @@ -1058,22 +1058,23 @@ static int wsa883x_init(struct wsa883x_priv *wsa883= x) =20 switch (variant) { case WSA8830: - dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8830\n", - version); + dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8830\n", + version); break; case WSA8835: - dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835\n", - version); + dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835\n", + version); break; case WSA8832: - dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8832\n", - version); + dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8832\n", + version); break; case WSA8835_V2: - dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835_V2\n", - version); + dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835_V2\n", + version); break; default: + dev_warn(wsa883x->dev, "unknown variant: %d\n", variant); break; } =20 --=20 2.51.2