From nobody Mon Feb 9 06:28:07 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E62AC2D6E5A for ; Fri, 2 Jan 2026 09:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347009; cv=none; b=q5Ptb9FadQ/zXjcxMT6jMIOT4E2WC3NXDyTk1cbs7sLUn7qkog/7o1sho2ZfrvlFxRRt7LYti0TUNrmt/S8Dko2AmjGgYf2NJfirMPIHZCVRBTNHFXDhNOmLM4EwdUmhU/GFef8tDc0tooQaxRTfxkoG432wtEOYK4QrwRaGsXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347009; c=relaxed/simple; bh=H/C36gL+Yrb+Bh92JefNcIpyT4nYFYN7IMeGQbA2MK4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CV/t67wSij4bYpK/RS/B4uy4qVLYlEBFOUb8eBACYsF6YGgFYCdVINwXBmo5RepIh8te+MaZDhkP5axoskjWotCnL/jIJ5Xj/Yi0lrdAKGcw5idLCBogzMJfekJyI3hV8nSJ/+RYYzEkROrO80qHDLb+lc6Gac8IP7zz0QKayoA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nMcERtV4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T2lEXZBV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nMcERtV4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T2lEXZBV" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029WF1p618063 for ; Fri, 2 Jan 2026 09:43:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UAdgTr82fRaDbVD9ciZd2KlmhDIkhQ8w583Xbnh/HTU=; b=nMcERtV4DouDwmJk IqRlGcCq/xoKfBQ++D1cVgLU00Afc1jRdJ9q0NfhwBpbzv0FZZ1RAjGkUM8B23rg /5GZ22+9jPTuWCcK6Wr4sL6mc9OiGzjZP4adwtRXttKeEIIjdqQQk0qKHKSVfwqJ uTu78s3M8mD96ijGcufYfbx/cKupoPo2KKQtb888ZA5NlAX86x83XOtMpagNsZho wHJCidzwyJMleKbMZbTTUQxMk/b3d6ZujdhtkhdouKE13Un1eM6BrQcfbKVuiaS4 uO6gNvNFABn/csF5Yw9MQfax0jACiitw0ZIpQEtzOchoPyeLVjY5ggaNeDAxlJsf 0TShlg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4beb4wr2ds-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 09:43:27 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2a0f0c7a06eso243431965ad.2 for ; Fri, 02 Jan 2026 01:43:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767347006; x=1767951806; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UAdgTr82fRaDbVD9ciZd2KlmhDIkhQ8w583Xbnh/HTU=; b=T2lEXZBVnUnR0iqt1b9vCQwZiSrWqBsZpgBb+n//WZLTHtRjJnVtK4eUZb1ItYEWUn CC7b2z7srOJlwzw26A0bI2UaKXLC1CsFOw/CyvgRyZ4OWdw44Pc1m3/gq4EfCHhFuONT c6aoY70ydsQ4sd+vCWQvDxr9WIJ54T9H6kntMSO8DPDJPX5hQioNJtaL5HaB3z8ybLcY uMWXv6VYWvmSWWuYJazi2vXTNYX++vo/F5anC1EovDaKd/22y3c1gYTO30d3ewEfIhuk IqAJKfW53fozuQn8rBWXbdRCYqoT8K96jOT2tn+ntBo2lSHHcbxE8MyBWXgqOAGWzF/4 5DjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767347006; x=1767951806; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UAdgTr82fRaDbVD9ciZd2KlmhDIkhQ8w583Xbnh/HTU=; b=WMhtA8MGft3Q06SA5plcUBkAnXZVcGsobpObGhU3LSyNU53rMFgmvclYXolA2yxRUN iWi4VLo1Osmc/skkVpiWhDjj1p6Tdbw0Ci2JRAvjcCYsNia5LgAVwc5AhveQbke++lA0 2VV68NGN8J5zpknzKHELMOP2mnVbTQjg3t9IlZhzD0ZrFcFPHsbhqUyVCTJEaEsa6Mmz nUGMqesesGvPMS2B3zOaROQyXhTyUIaJdTwcC6NwaUyw84iwrjrqMFLmScVo+VjXbFCz uqQr6Eaw2JGNGxxEzeVcywB/TdvWFt+Brcd56etyzBlf53zquDGIYbJD/PTx5sbQR3/x t7PQ== X-Forwarded-Encrypted: i=1; AJvYcCVsCntDQrfFUYSlhBoEzy65/+rnzQt9/eCuXvfW1GLk1iPRhHuC8sAKrAKDdezRmho1tdvXSOvFyUEXvxc=@vger.kernel.org X-Gm-Message-State: AOJu0YxUUgAloLlBuDnZn0Ch2gQ3tV+3/4H7FKwJqVVDEgmSmlhn/qbH nZ5rDPzWkeT2HZFz9Ox3ARR2BAH9TYPvkXcfO/JCUesay/0gWbMHzMnK3x5PKGImhc/+RFuD2W4 w8BDVUoL9XO5jx6p8AaijBxniAeZz9G2ysT62jP53XlBpblwwZfiAGl3lVdVSslDpSzU= X-Gm-Gg: AY/fxX4/iMwyRz5R5gHsxIoOZcRO0lkJtSx1Cto/gUDssY6S+eqRHuGI5cdWUXKcyFC UmZlhIssGndvf+kVzIlKcrSXpSlsQDUmQ/fPZk19MqYJj4NaFnpRUB/gQc8fUpL6wGplFwWtmKh yHeR575z4JeMqrn6ZXwS/PgB7uxT/kw7tC4BsAESgaozpicNKDcL5WuZE3BfSr0laA7ZQDz2Kwy EdscF0WBqgEdD4FNHlwBTARjjYCR03KNEKUAR6lpIs2o73iYXlTADHGo1kl/b+lIB0aBdwDPrcd ANe6TNLCC2aBn6If4P7QpsrZ5eiClLCy/ILsnylZ7I6LE6VLCh1hG5KVgbTYD7oErJx3lZ8hQju erIj8nfHVdbVT03/g/ShKsuVSnkRGaEjQQkDjxDntHwJ0 X-Received: by 2002:a17:903:3d0d:b0:295:28a4:f0be with SMTP id d9443c01a7336-2a2f2212882mr382556105ad.10.1767347006430; Fri, 02 Jan 2026 01:43:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEA8g1A/hUJ7nczdE+jHrP3es6vTCouix1JiJva41okHtH++OT1LmvUGLP4pOQ2g/oVbraOfw== X-Received: by 2002:a17:903:3d0d:b0:295:28a4:f0be with SMTP id d9443c01a7336-2a2f2212882mr382555855ad.10.1767347005933; Fri, 02 Jan 2026 01:43:25 -0800 (PST) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66829sm376154255ad.10.2026.01.02.01.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 01:43:25 -0800 (PST) From: Krishna Chaitanya Chundru Date: Fri, 02 Jan 2026 15:13:01 +0530 Subject: [PATCH 1/7] clk: qcom: gcc-sc7280: Do not turn off PCIe GDSCs during gdsc_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260102-pci_gdsc_fix-v1-1-b17ed3d175bc@oss.qualcomm.com> References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> In-Reply-To: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Bryan O'Donoghue , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Konrad Dybcio , Imran Shaik , Abel Vesa , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, Krishna Chaitanya Chundru , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1767346994; l=1162; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=H/C36gL+Yrb+Bh92JefNcIpyT4nYFYN7IMeGQbA2MK4=; b=wGfik/XmZpvIMsYR5Pp/+STb8LGwBKYKFcGx0r0ttt3h5PYoqbNueWqTJk/vUDR6sDISr5Fe0 tNnLQbrEKe5D3kCL9PoR3F8XFWujkBj8iRKnyKAFHK+KWGg97+BmBq7 X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-ORIG-GUID: xdUL4cfXFximH1kyLhsLF-Jx3aLOVvYK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDA4NiBTYWx0ZWRfXxNKBMYKGzKO5 gfRrHqvd71U0eAvahzCUoJqzcEhIm03l3oIFg+eltJ3olOg9VpSz31iU6bAsZY2tIsFmEAwCDnY /eHisjlnLFMOJDGxT0ANuPo3pUKQb+UyqBQsbF/riXuaoQU1iGFKlTmiOmr7Xtzn+F82cnR/hhj ZkAOmI9Liy4/Df8R+8IVrJinEVSlOizAVIElyWpz34NGKPc0iHwo/i2NmzSayp4Ml+MEuoTV0cD zuptdsmaes/kDT7q7EhoBSl3t9NJPG+GCwgQEaIqynxPJOIQn+rUFID93GT2dt7Zg92/xBdevtE 2/0gs2tUaLSA1iASgFvOFfb4J4rihOod8U3sY7Z8OyaTMfFn7wV4lrXTnakI2VC65ksGm6vqfqu 7uT9bdlONXxdkaMbsBUOaTP3Kjl0j8L634pqJ9gC13lg7u74iBPbdaifezIuIxFbPpb8GyEjutg YN+UzN4P7HcaMf96m1w== X-Authority-Analysis: v=2.4 cv=I5pohdgg c=1 sm=1 tr=0 ts=6957933f cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ByFm4HHrRE6C6VNyrcUA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: xdUL4cfXFximH1kyLhsLF-Jx3aLOVvYK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-01_07,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020086 With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Fixes: a3cc092196ef ("clk: qcom: Add Global Clock controller (GCC) driver f= or SC7280") Cc: stable@vger.kernel.org Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-sc7280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c index 4502926a2691a773003631f822c121a043607a64..2432abcf487b9c813326adac242= 77054cc59cfa5 100644 --- a/drivers/clk/qcom/gcc-sc7280.c +++ b/drivers/clk/qcom/gcc-sc7280.c @@ -3101,7 +3101,7 @@ static struct gdsc gcc_pcie_0_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_0_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D VOTABLE, }; =20 --=20 2.34.1 From nobody Mon Feb 9 06:28:07 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4870B2D7DED for ; Fri, 2 Jan 2026 09:43:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347015; cv=none; b=hL21xJXOZl76ARpCm1gaYgghREJMQSK3gOt0adEaFjuoC/zW4/IsVJ3OTUeOkzWxnplUsbjUJTSlRMlJO3ClZctjy15ps9clivXdtf3WMlJwBW0wDQgKdTrUmRPvSXUQxKRpLAvLTMu1/ZVuVsXQ4Twah3t+p/pKoRLDJwLjt+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347015; c=relaxed/simple; bh=XWV/wiMti0j+LrV/v/Z4jEKFQZ3FlNsqfF/Lgy82Fcg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gl0dUPNhzz4YRc23dS47kKiftJYddUukm6CBB6yXL743Djr1B7A8tiK1Zinjfa+axIDism/4omoQiibpEtTUkEzfOYhfUeeY2uDivodLkFJVbHGUaf/SxJdwVaUUcdHgk0ittrmb3goHNMeqEFJdMFCyYvcSF6IinkfSSeSL9+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gRUSGiR+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=STEK9dbk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gRUSGiR+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="STEK9dbk" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029VxpK784419 for ; Fri, 2 Jan 2026 09:43:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JB7hwuiRZo4xET1vDRIYfFg56T6wWX3e2ytUVrjm1QE=; b=gRUSGiR+yflpye64 q2KRm2VriGAIlxLq1ffiinjm3E9SiwhoHA4/ABk38GUh9Au4ooNRA/ynIN4LkpcH Dh7IF6gwldgVjkMBaRNOAYD5PLCAtMx34oq7rv6TYRMSp4etOjMh3mK3duRycvCY 8eXjjm12LEDS8icAAKP4jhSWhx3sK6tGc06SBrueoqtzw6gEJ6U+UOFn1Lhba728 5wTy5f2ELp9eyHtHKKtZKb80JM3rTkzrgFWtomCbnrOzpq+Sff5wgy22WCUz8WqB UPBmRHnmM3+52r9CTnH7j3DWV0WlypCc21YjvURN98xjQqQVJ2gXEXsRdVY+91au brjlFA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bd7vtk399-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 09:43:33 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29f1f79d6afso168629425ad.0 for ; Fri, 02 Jan 2026 01:43:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767347012; x=1767951812; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JB7hwuiRZo4xET1vDRIYfFg56T6wWX3e2ytUVrjm1QE=; b=STEK9dbkQXtOKQ/ldKRlHo91w+sX8HiX3PT3hArT0RLYNXPzupAbUY+pqTCwMJzYhM in0Jk/8AAfmdC27V7CI9adTyGch2eg6tuwMvoYMfuSDzQEfrjn/KQVH+aS7h5Abmq3eh xu1mq6sDF/OAFxKnCjMHNibJW4+d8WDLq9mWgsPh0Ybij7TUVU/Nj2nKixGIv0Ew/xir YD+/ozXjkblGnwJGFfeTTP/tcYXw8Xzp163VZsNag/deH71QK7oaY8lHPhoOqn+AIXj9 qPkCTB8Jgxq3e3JsMPGcYxzBkor0EPTY7lCNMG4AzJie6676qpn03J2CXBssYrDpznSA T3Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767347012; x=1767951812; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JB7hwuiRZo4xET1vDRIYfFg56T6wWX3e2ytUVrjm1QE=; b=XA8ejOGSLdfKHaqSCMsBoId/rlcj2OytSjzerRYFX/YjTm08B5OA7bZf+rXHvzSpYq 3tVl71DeHxiem4PEknO9Bq9ThoXe7exZfRfcxIIVK6ZT6KZudoqCGXjNzXT6oymLjE2t OLyYGW9gem5Wo8R2UY2L9ZlqlG57EwvBCp8HgGL3CgkyrC3BxwyIKUodIOc9FuRlr2+P WuXeTtc6cayUFrjKYAKGg7+iV/ExThlnZz6Z0ls1Kwy8KVRENxM2tklB5klQIE55KfMJ dhH5HSvPMbiV8tqZrs1LHwmSaTWb/ipNy0UfpSHgVuk/e8LNsZNG021QKUan4DhILy0j VLHg== X-Forwarded-Encrypted: i=1; AJvYcCWJ/cezcms5tmGIs1zDinMqsom0hdcXgXcS+Wn6EIdBLNAe639zdzg1MsXtuWwgj6otuhg/V1PleVF5E30=@vger.kernel.org X-Gm-Message-State: AOJu0YzCGXvOIEB5XGDgsZ+HR9PVJW5JkRfXO0mJxTwHV4OrQyAzNoEN i8xTrFEOnqtLfPI6D2GM34wJ8A1ryXMLS/71k1ILoOcD3TADaDKTd7ig+VOQ0ao4B1SxX6B8ad9 2Zj/Nn7JtYLK2HY6GTJpCSPwKK+rfblZmSUXKTsPfbgjB+5PVr5tOq5xHqfSNa4+3Jb0= X-Gm-Gg: AY/fxX5ZbOcnIopsd2hC2rZa94vT4yLH4PmSpkefvdpyNH13cLVEMeoqcaES1/mYJ6a FSeaNxTiE7UIQUeWYdZQTfY+7OgncU7T4noQX0q8QdkJQik21rKkPeKyoTnNTcbRNCMgdW8sCs2 42se1qd4rF6/QVJ9GjSfn3NLb3L/ru3MkRyUt+5nf1YCBzf+k1VTUnvvLZysapGxTOnNb9Fe1wI 6o4OcxNoPPYhFuwK2IYHobBuZwItHh4G2ue+OR3VvopTIItnLPfFz1VF6E9Lzigo4Pe+rIlAd/H ZavU4yzrD1QnT4GEVBvqo8JnD+i5wibJJzWzJklqLEwl5luw/oQKfXLb4mQS8R5jk1DWQSO4u9p T6ONS5koGhi7tostRVQY4IFVla6gLX1Vzd/AUyl2AX5F7 X-Received: by 2002:a17:902:f68f:b0:29f:1fad:8e56 with SMTP id d9443c01a7336-2a2f22049acmr450584225ad.6.1767347012261; Fri, 02 Jan 2026 01:43:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhlhtaXG5OsG1h0mp8RwKg+DT8zDGhYOuhsQqle7zgqDlMdejCBeYAk6HCuBnd1vNMjgoFSw== X-Received: by 2002:a17:902:f68f:b0:29f:1fad:8e56 with SMTP id d9443c01a7336-2a2f22049acmr450583995ad.6.1767347011783; Fri, 02 Jan 2026 01:43:31 -0800 (PST) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66829sm376154255ad.10.2026.01.02.01.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 01:43:31 -0800 (PST) From: Krishna Chaitanya Chundru Date: Fri, 02 Jan 2026 15:13:02 +0530 Subject: [PATCH 2/7] clk: qcom: gcc-sa8775p: Do not turn off PCIe GDSCs during gdsc_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260102-pci_gdsc_fix-v1-2-b17ed3d175bc@oss.qualcomm.com> References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> In-Reply-To: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Bryan O'Donoghue , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Konrad Dybcio , Imran Shaik , Abel Vesa , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, Krishna Chaitanya Chundru , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1767346994; l=1401; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=XWV/wiMti0j+LrV/v/Z4jEKFQZ3FlNsqfF/Lgy82Fcg=; b=ZiOafuSgqrNoKWzDz10Fp18Cn71VALIMfXhyts5U4XInt2ii753CsccSOLhmicHetirjzDRWj Xho+N0leocCD+zTjaoK6QQ+GsIOpkeDq4s4NMJCwfR2mkWIr9an42ZL X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Authority-Analysis: v=2.4 cv=NMbYOk6g c=1 sm=1 tr=0 ts=69579345 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ByFm4HHrRE6C6VNyrcUA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: Siz5yXirCL1-UaO4eDKsIFQMhyyhuZDj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDA4NiBTYWx0ZWRfXxr/PT3/ZWmRz XJEz3dNEIa7yIiVpVnFbtUNhnFvjhGuKolRUd2KNSmOUmti3DQrk7s26t8nlaOG9DNCfWIkpMez Cvr0Md3xMlT+aOee4QU+p2v5y/f+9lTx1wfZUwMoib5KE7OBNq7lVple7vPuSMt7NSgJOnISphY VQTcn+TEkoONCaO9s4LHHoN3lPjJRVBMrZCkus5sRjvx+x2Cy5MN+e8geM1PjOnITeDMeZW3VK6 lFOg+JrbW+xZP82J2q1NeP8nbB8/xysK7ZEkMiec2IIB4jGbJ4uxbaipRVuX7LXWU6mCRBCijZN TJ36TmoJmtOGXXDBYZVp5/guSK3+DgPT2RHcPy2T/6KjsBnGtcomely9mBDUKLzBtNAtBp6qak6 a903Y/J1/WlxmS/k3nAxLdCc1divPZQ04y0Gdsje5QcPQvvXwbCi4hzTTiSIhsda/sb6QJaHgKI k3X7JLvuiOdGs1ZahoA== X-Proofpoint-GUID: Siz5yXirCL1-UaO4eDKsIFQMhyyhuZDj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-01_07,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020086 With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Fixes: 08c51ceb12f7 ("clk: qcom: add the GCC driver for sa8775p") Cc: stable@vger.kernel.org Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-sa8775p.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sa8775p.c b/drivers/clk/qcom/gcc-sa8775p.c index e7425e82c54f2355015b58f5a25f11d2fb5020e6..b2e8639e9f09194fccde927466d= ab0f179e08e01 100644 --- a/drivers/clk/qcom/gcc-sa8775p.c +++ b/drivers/clk/qcom/gcc-sa8775p.c @@ -4211,7 +4211,7 @@ static struct gdsc pcie_0_gdsc =3D { .pd =3D { .name =3D "pcie_0_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D VOTABLE | RETAIN_FF_ENABLE | POLL_CFG_GDSCR, }; =20 @@ -4225,7 +4225,7 @@ static struct gdsc pcie_1_gdsc =3D { .pd =3D { .name =3D "pcie_1_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D VOTABLE | RETAIN_FF_ENABLE | POLL_CFG_GDSCR, }; =20 --=20 2.34.1 From nobody Mon Feb 9 06:28:07 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 957382D7D42 for ; Fri, 2 Jan 2026 09:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347021; cv=none; b=sV6aWc7vWabgY87K4LiRw+IqE+hak4/MVumBr5xgvKRU8AYNYBj1tWIfTQAtY+/1Lv6ORGdTKaR2E9R4AgURU3UEcuMoNXKQGBPZOkejNKVndhBDhblizTGQXPDsWneubHCUWDA8YWL0Ys/Zx1icudvBlHASr6q4TFZZNxNZZv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347021; c=relaxed/simple; bh=NSkQnKJcfadz3AF6tccNlZKti0/dp5ZM6ojEWXzzpxc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dgkJXkeXzbmYdCRfeg5ntE1Q97j23e9DmdostEk3jALuHuzQ97pIGZetcnAfW1BSl5JAT3KokdpUd4lN81QkNRGbti6YQDIrd4Bm2vypIOD615Rv/Y/zegnYDLzHfO3uNmgfOm7yKWCUIOl/1VModxF5mb7WwQ7vpIP7ucXvEoU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Glm26REU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LXPjEdA1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Glm26REU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LXPjEdA1" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029W1kP010335 for ; Fri, 2 Jan 2026 09:43:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= a6B0Mr1Iv6eduvsLfOaq+Q/gOOfWzJbBtPGlP1TnbnQ=; b=Glm26REUyfy9oAF+ o6hgIAVw3mnpInprMfXYqpaU4AQJ4+e9jizt2N6QVAZ7sSdcCu7JpRZlyPP4E6Xd /+ik4CuLKddfAx5CPRszlPwLw79lo6t9744SB+4oR+PDNKzSFoR0YX4KkdtoYI9j qZ5gTkcCWB6JIR+hogFdWboLUFQSJNjFv7gZu6KQCdEVtAu01Q/S50n3aQ8JPnMN b+kVqeWO7Q8JBr9yWHosTUDsJvVAsyRv7KTT3mLUISGm/Hw6FpHgJbE9+NrHGD6f EfrNZHNI3BaapJvEcoiK9ugDdsVZFEg7LHd/qC2FrJghN34JssMUcb6y081gLQdo Xu9uLw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bcw5e4a1b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 09:43:38 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29f13989cd3so356618565ad.1 for ; Fri, 02 Jan 2026 01:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767347018; x=1767951818; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=a6B0Mr1Iv6eduvsLfOaq+Q/gOOfWzJbBtPGlP1TnbnQ=; b=LXPjEdA1ZCxtICmBBUBjXQgeo255LD9If4c5mokQ2/BMnFsdHDhyw7wwpPt/e/dxLp OujmWMOTVZH3WtokBRe7+I3k9n5xImWxNdAsRGFAAPYcZHcYHr5qmuKQLJgGFmWe9Nss ROhw/AbtResIpM6TCO4sbbl4RCBj6Dlx6dCIbO/cToyPZ3K5mApa0XC+A2roc8cxxWmy haSNm6OYlqSk1KMWxk6x9i7BNIkSK72HAm3Eww/ef+AEn3MHytwImatH09MIK7fiZuNU 2+bFUii/9Q1wMK+2LSibxan3C3cJc1lDSc45cFYEcuSCvefdxoxcbQelx97/5ciCZW6V jNVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767347018; x=1767951818; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=a6B0Mr1Iv6eduvsLfOaq+Q/gOOfWzJbBtPGlP1TnbnQ=; b=HI/foEWXZRJA14ADPuwORG/nlnc45KSgDXK331PNNwA305/RM8AR8dXxtDnFTdrKZ2 U9CtdibpfvqV/5REC24sTMODKRxpiVHUJKB935kd8SdrJNhYu/PswwfDPjNcT37kITem 3J0PWYeDptQBDmYwArQ2ti9OxdSdQf1rdrOmE21DEzCHA/LYg2d3VGKbjQW7gmUhsBqs 8pL60nypqR0QwhvH3TDS9ZwkRFss6KRu9nmfg0i+puwYAu02CjBgmIo56LOyel+njW4g uQ1vY1I0S7DIxtsFc+oIaz5WLJA4v+uqpt1qjIkkpVjV02G0JNsuGgqt3T6as56FahUt hvoA== X-Forwarded-Encrypted: i=1; AJvYcCX1kh7FMl50X+AKd7XShKZ1zunJvwAZNrUayYP5ESTen0vaxFPQYGu6wRrE7HB2oEne7xE8/9iTtQpIuCM=@vger.kernel.org X-Gm-Message-State: AOJu0YypNOiIzyyNrZ6cs5iBNRQwA5vIKZC/hwX9SOWYOm/oVmi41eHK N6V+YFEFCg4xGYd+D2SuLDvjsNB/lKoElhdqwPzC61dzCarpPWvKh6fERjh6KGHClMI8Rdn49Aq Zoj2fRy3FkE1AX3PYBgFqds5UhxXlCfAyX6lnGDqgfJW9mx437zQ7e7wMS0GdmrD0N34= X-Gm-Gg: AY/fxX4b+y7cm1LDRP6peqh3SFchB1Yn4rVzAptzEQCBE7Vz1wg/9EMXS1WxKpjlKwS DTs7F+ZWOJDAgjKamNPkPTdQK7gcHBxyfGG3iNwRxMxJzoGpTS8aE2MQ/QPPHtNEq2fTpfKlUuP sV3zDOFgilCX6dhJsmRj40orodrN5AIIoUc4Xm2N47qaCcIRJGXjdLUEd2hYm9sR5UrBnGuvLWR uUA1gwIAaN50xQNoDamL2morWm7/aObjLnT3YXvd3b4z6vh1zOFz9Q1pbnd/q6wyLymxSqPnKuG jkDoL/0jctQca8rTYJol7CYsulk5sVAQ0UUUx5wqU271wmlOds3R46n7LeFl5kkm+P4+OyS2ZXp cuepxcykQGEgeerEuuESlnUHIx34PywSKxvo8lyfk3k6w X-Received: by 2002:a17:903:19e6:b0:295:96bc:8699 with SMTP id d9443c01a7336-2a2f222bc5fmr447730975ad.20.1767347018116; Fri, 02 Jan 2026 01:43:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/KTc9e40CfrkuA0sDQKGRGgRN1IJNNLflSBZ50gGpN7B4a7iFbpOPyYm5WRjRBzLPJY6AxA== X-Received: by 2002:a17:903:19e6:b0:295:96bc:8699 with SMTP id d9443c01a7336-2a2f222bc5fmr447730795ad.20.1767347017661; Fri, 02 Jan 2026 01:43:37 -0800 (PST) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66829sm376154255ad.10.2026.01.02.01.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 01:43:37 -0800 (PST) From: Krishna Chaitanya Chundru Date: Fri, 02 Jan 2026 15:13:03 +0530 Subject: [PATCH 3/7] clk: qcom: gcc-sm8750: Do not turn off PCIe GDSCs during gdsc_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260102-pci_gdsc_fix-v1-3-b17ed3d175bc@oss.qualcomm.com> References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> In-Reply-To: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Bryan O'Donoghue , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Konrad Dybcio , Imran Shaik , Abel Vesa , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, Krishna Chaitanya Chundru , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1767346994; l=1176; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=NSkQnKJcfadz3AF6tccNlZKti0/dp5ZM6ojEWXzzpxc=; b=HV/XpdIiv2DoZjDrSjFt71b7G5uTUfB364AH7QNl/EwI6irz9v+3eSIUJ/GdoIf2tUL9wW87W eb6fTQEhKjzCWQEr7eLXKsSRlfzsBsDHsrva7NmKOu3s4CIDnHAdsTm X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDA4NiBTYWx0ZWRfX8m+sOMuFVpIz RaX32p3WeIKp0V3kpJtVK0eOngIir7sPHcKnXofqRXT733SD7zGyZyxlmkXgJdCzQgqzYNci0D5 NieCfiIv+J3a4YyZO+iu1L+M/BE5bMRe4KyjG/RKZU+ETIQpgS/GWkYEN1eM5Gd8pLAn+R1DKPH o46mE0zuCERLT++Lu5wLqbbpzM7DDGrAbAE291GxwacdekwsdYZr2uIORUlqQK3Dt4v5bMop5wT 1tvuVTXuv6h9dq/qldJ9daO4DFoKCL3xtYCpIgziKatkQEsregRSPWDiCV6zK+sbIz7zeN5tyTZ 952Ofs/wFN9+WBb5nBhvM4C18nuZE+AMuowt4+newBcVIa/DTUPG2TPnB8Sdm+YLR4KZv0Yt+Pe WDAqeZScE0G2ILgokbrijQKbdCQZzs7aqkevEXXTHq19SvayXTDqrJcAvXow2jzWuTdYk09/1WL CQqyra2r3jXaK36RxaQ== X-Proofpoint-GUID: 7KdKXGXr_5i1GOjAo-HU6oMaI1Bq97BZ X-Proofpoint-ORIG-GUID: 7KdKXGXr_5i1GOjAo-HU6oMaI1Bq97BZ X-Authority-Analysis: v=2.4 cv=Mdxhep/f c=1 sm=1 tr=0 ts=6957934a cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ByFm4HHrRE6C6VNyrcUA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-01_07,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020086 With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Fixes: 3267c774f3ff ("clk: qcom: Add support for GCC on SM8750") Cc: stable@vger.kernel.org Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-sm8750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-sm8750.c b/drivers/clk/qcom/gcc-sm8750.c index db81569dd4b17de1c70ab5058d4ea186e08ce09e..ef072e6e4d9aeac5bf24116407e= c75aad290a571 100644 --- a/drivers/clk/qcom/gcc-sm8750.c +++ b/drivers/clk/qcom/gcc-sm8750.c @@ -2891,7 +2891,7 @@ static struct gdsc gcc_pcie_0_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_0_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 --=20 2.34.1 From nobody Mon Feb 9 06:28:07 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70A482D838E for ; Fri, 2 Jan 2026 09:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347027; cv=none; b=uuxKWFVbSwZvXFmuSXJ792iRg1lHroKNuFZqwHmelmGiK9djH6ZGDOfY+f9DGGMiMKkWUpH27B6lbhRFrDig1idmY/5huC9lFWXJBznzPFWfEAohnHIijZZhSLjnSXPZHFltrtTq5Bk5tY/AtpyOiVAzz4oJxdCs3JE0RWXrUT0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347027; c=relaxed/simple; bh=za17AyB+OVyeZLPZNTqwYBIrPw/xf4d5/jl5MyUbBm0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D0b0a8owYWKmF0Re9qQidtFOFybUVNlgpJA6LDJ5boGju7DlQ6yGLfse/YuZgF3T1A3l2wBSyMwW5b9eWmRaUSvlf+dX51hPo2E6bOsMRPQOqI3CWs+D4ycWHnCIRZ/WeRQVCNFG67YDhxwX4575YGRjwT61RGZZ4KGM4OxsHBM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rx7sDcN1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N/0rG5kq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rx7sDcN1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N/0rG5kq" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029VwG9504469 for ; Fri, 2 Jan 2026 09:43:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V6AViQbxqIjmWyoB7J5651UUNS9Vltag56jF+QUUjts=; b=Rx7sDcN16xgEg9NZ O/JlvYTDierU4FrvSARTnsmy7AkUmdwMI+335Ie0NpnBHpJuGn5/NZdrW/17r9p3 bvqbd79x8eArbzRvFt+xxdDP4r9k00No6D7ob2edjsKAOb+uTp18LtP4HWUZd23t FtptWE79hfDa4jSmRkDMVYvGSBXG2gwiYRAEy0sbDFaUnsrN5BLTan453HWsmcXd Hj3TVKPKtVRPU6/vwAiTxfZw3krbJrx0X9pjYMiOpvOADQur9iE5kjq+FXp0zPws 49bzS3O6pWPcBDF2TIdwkceMPi//N1K8i/6tRt5jCtBPzf7ikexCI5YYozFPXByE osyuiQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4be8bk8d18-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 09:43:44 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29f13989cd3so356619395ad.1 for ; Fri, 02 Jan 2026 01:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767347024; x=1767951824; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V6AViQbxqIjmWyoB7J5651UUNS9Vltag56jF+QUUjts=; b=N/0rG5kqy/R6s46/kHzLNTMbvitWwFLh9RRTvlgsAYRbNKIkQdzk1vE7Yb6w7TFlGf Mvq7SI1OU44Uzp6qGagf5xNGktZqdvYytbiE3tgwUzHqz+vB/MWJKoIs65CgMWQMlOqZ zHgTdxyxiPDQ2Pc8FlSl7T/fjBUX93vtc2x1fZG9Jw7tc9C4NZrVhMDeXe9SuVTfOPq5 P7xLy9UgkQq2J8boxCTGSVoE2QceklBXLOXJbBE2RY0rN0FIp9zr+uHP/uL4bWoaY2Lg 0RQsd08WgWM42tbw5Si/IsZRQsiqZCnr9tW+PkoiLlAVtms8j+288eV5Mv4tUme4HgOh EufQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767347024; x=1767951824; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=V6AViQbxqIjmWyoB7J5651UUNS9Vltag56jF+QUUjts=; b=cQIplhpIAV26MPBTXHgdV1CmVTmtu0EUCUW2qOmqBoFHJ/18nnIHd4IS7tZLEZ02mN nzIFNZpCStrw69dxo17l/ZrIBWKs1JBlaPQgV0AQKkv+6Jnp5apaYoDbi3tICq4YcvSX YYJQjxojDbYHlHV/1Ob68IEaDSUbzGPO/DaVx3rTLcn9flTJCFe5RvZIbmBvwmcw421x +51Gp9GG40PaG6XhlZ3jCd8cSq9mF3swhVKkWpUVE12htclhZHBP8K3kVj++ewDN9MUS HNU0hZBaCXeuHIID3MRRbuq2+yuMRNjFQiC/IgJY89fHxAtPv6KsG/Z6xFwYVXOkLMvb qkjg== X-Forwarded-Encrypted: i=1; AJvYcCU1wBHYL8k676GhR0byHbPumbXUZ5qph6PCntwQEWIQqlhBvrWxG/5Q8m/MpvxuKMdoyY1TEqrc5Gvjl04=@vger.kernel.org X-Gm-Message-State: AOJu0YxXq5r57viEcdD8FMnCGuXtNDq0sIO5rccClYecI7woY2sf7Zwi SajxJNhoJw4ndxAnxNVVjRB/B+a8xSepJFnLu0YuD2YXWPyvgCr9azbg3hkAtTpiRXJHN+s748j 1puxbE2gRXNCqm6+ptLUsPFr+hkr6zfg16WRk8gWpu8T/93APt20U3SEdPhjTh9EcgaM= X-Gm-Gg: AY/fxX4kiXMoilCaoIVuMHmefROmYd9fpPzye7y6DF2pZpY62JXxLR0JhQFzupd4EpO 7d6g26t8FmrX5CbTDlZ8kwJxKmcHrJ5AUpeTcJayOoFHJYOpfwPsNPqCJVVg9etN6dSOnOY4ZU0 TUIHpNxTwEHW83CzQ69q8F/bppUMPrfo2XuAlpWhL34zOlsD64gleEbxxLLigvEYyWw4W58Tdrx n5FIDx+SuuFMPpn19SadCg1u0OftOZZVf15fbr80d9Y6Yl/E858BWpI1qjxWXOr3EgdH7yiMvXz b3OJsnX7KwCxUg4fh3HqNo4SW2PWda2X3wlxhOdprOrLjEepd+4AwtgFV0t4EKxYGk1fGg4vzDy +O4Xe+mUaujV97vQ13CM0WKqCpHUJ/h+6MyG0dyjK/4jq X-Received: by 2002:a17:902:ce82:b0:2a0:c1ed:d0d9 with SMTP id d9443c01a7336-2a2f29359b3mr405469925ad.46.1767347023953; Fri, 02 Jan 2026 01:43:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEidZlQEw2lZuB/a9A1tSdgI/rgTD2eYdotce7/zJyLNRyh1DHBKjtZsDc7imB5NUctN0yew== X-Received: by 2002:a17:902:ce82:b0:2a0:c1ed:d0d9 with SMTP id d9443c01a7336-2a2f29359b3mr405469765ad.46.1767347023495; Fri, 02 Jan 2026 01:43:43 -0800 (PST) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66829sm376154255ad.10.2026.01.02.01.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 01:43:43 -0800 (PST) From: Krishna Chaitanya Chundru Date: Fri, 02 Jan 2026 15:13:04 +0530 Subject: [PATCH 4/7] clk: qcom: gcc-glymur: Do not turn off PCIe GDSCs during gdsc_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260102-pci_gdsc_fix-v1-4-b17ed3d175bc@oss.qualcomm.com> References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> In-Reply-To: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Bryan O'Donoghue , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Konrad Dybcio , Imran Shaik , Abel Vesa , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, Krishna Chaitanya Chundru , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1767346994; l=2871; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=za17AyB+OVyeZLPZNTqwYBIrPw/xf4d5/jl5MyUbBm0=; b=I1uC5RFV0qWbiD9rxeFWOBy+/xhlePZID/MCvmI9h6Rgwup6M6VvJhkQbEM1/Wj0OCPz3TDb1 Ld0VVOBH/hJDrC2RAjJzg76gwUSycPdFg+ke2a5u1LLhtgXF2hxfnBN X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDA4NiBTYWx0ZWRfXxxyaVeSspw37 GaOKXNgClbcM5od2hyIAOwLfCPTQ9xMk93nrHL7iT31ir/PeUKucwfi43/v4nizQJImi5dtJy19 5Phd71bTNAbzUWuvKrZqejEizmHn3RiUBkoGi1lkbvgUv3meQBcz0UfGqBfGmAlH2+JC27Vsm77 xD5914aP8+YOlJvoekykkj1OXwffO//rlUJfXfD/yfqkh7Xj8VjzopBFPheyxm3wNyQFHSq6Y5y zj0UomN/AJXAGLwvWJ6E5Lu369ScAHlJIsj/LC5nczxCP3baIC1sGQwes8NikcLHfAtfBNucrlJ 6Q/kLfF4ONbKBqd6+9SeIHiVve4o6m0MgpspCzMeS5LdzYzsHZC0bHdH4iJpU2SfuEwIPuxISWe mjgwObJ15CJcKzxrdMY7xFrQw2MmSS5hAXGJ0fxll4VZ/bywVW6MRNPQAw1BYC9BYSGaBr+tNSG jnYNw7LgW8+Q1wE5rLQ== X-Proofpoint-ORIG-GUID: KqpNtGw8TkapnG0k0QOTvSciOHtcC7Gv X-Authority-Analysis: v=2.4 cv=d5/4CBjE c=1 sm=1 tr=0 ts=69579350 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=APsdKiKIpUGVn09es9MA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: KqpNtGw8TkapnG0k0QOTvSciOHtcC7Gv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-01_07,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 bulkscore=0 spamscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020086 With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Fixes: efe504300a17 ("clk: qcom: gcc: Add support for Global Clock Controll= er") Cc: stable@vger.kernel.org Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-glymur.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/clk/qcom/gcc-glymur.c b/drivers/clk/qcom/gcc-glymur.c index 238e205735ed594618b8526651968a4f73b1104e..5c66c1264f35b083d046d2c11f4= 30f0f113001ef 100644 --- a/drivers/clk/qcom/gcc-glymur.c +++ b/drivers/clk/qcom/gcc-glymur.c @@ -7647,7 +7647,7 @@ static struct gdsc gcc_pcie_0_tunnel_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_0_tunnel_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -7659,7 +7659,7 @@ static struct gdsc gcc_pcie_1_tunnel_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_1_tunnel_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -7671,7 +7671,7 @@ static struct gdsc gcc_pcie_2_tunnel_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_2_tunnel_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -7683,7 +7683,7 @@ static struct gdsc gcc_pcie_3a_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_3a_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -7707,7 +7707,7 @@ static struct gdsc gcc_pcie_3b_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_3b_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -7731,7 +7731,7 @@ static struct gdsc gcc_pcie_4_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_4_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -7755,7 +7755,7 @@ static struct gdsc gcc_pcie_5_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_5_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -7779,7 +7779,7 @@ static struct gdsc gcc_pcie_6_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_6_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 --=20 2.34.1 From nobody Mon Feb 9 06:28:07 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FAF82D77E3 for ; Fri, 2 Jan 2026 09:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347032; cv=none; b=LUa/11QdyAbe3HyRGHvxKcTmAp8wYwdTsD1cFfiGUugg6sjilmVZ0Lni3dn2LV/Q8phnxG4+MeWdrEfXtFb5brUnU6WTAfnHNqi0fIR22aripsWPKgWL5ePOPbXwOpAF0Z5xUFmIR4jt1JItOh5rLZL0ybVbCaqPM+nT+QI7MX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347032; c=relaxed/simple; bh=u7E+JsBFtSP2Aq79SX7r0MLZ8E+3lGXEhvVfek+8kDs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JsrXdYtF7sfphvITTfncmOJqUy3kvjj4Uzl/PbubAs8cYAlapYS13TJBNleGrG6kcfYjUWXKnNpHRwolTy+q24z7nfOXMUecAPyP95lhXbziYxxJYSfLYoEp7Q5UrvoCAiaX14P4P0wHImgmdqLK3iEwKoWLxKXwnBJY5l37Jgs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZOXwlXQp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kMp9wCT+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZOXwlXQp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kMp9wCT+" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029W1Lb010332 for ; Fri, 2 Jan 2026 09:43:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= viTJoTt+fY6CVrcrdzVYmyIcj6URFL2FJNsEU07SeTA=; b=ZOXwlXQpzJkqmYIE ZewEzVPQD7o8JJDY7VP2F1ponzpxQ9N7zF3H5xN6CEgz7ZX7FPi2IAPm1p9rpLJl Ozy1Nr6AGhB5ONhm/1O7QVJPrO1EbuOBcEATd3U2ZHzd7NPkUbMoNtQUM4lGcaj3 Gnf7xgtt6AmUtd5BhM+31txCkMvpLRvjQ7TgnBNeJkdt3LJxH4ob5ozmKD1PFUw2 POLA7yWLbFDJxKquyUwRQUYTCjegj2u4KCSN47pO9/bNrbCipGkl4Rp9qKdyMeJV 27Wtfx66/LZ5ZgCe38Db/al/WE08i8eciX+lvSGfMgJnYZ86yHq5AHk1hZaIMCnb hUajRg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bcw5e4a20-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 09:43:50 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-29f177f4d02so276014845ad.2 for ; Fri, 02 Jan 2026 01:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767347030; x=1767951830; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=viTJoTt+fY6CVrcrdzVYmyIcj6URFL2FJNsEU07SeTA=; b=kMp9wCT+nl09A9T+Ui8BCHfGLOcxugyX+op/wvCePEAyCfR41sV9RWIji5LweTCk0N hsVIZ46KhuS1qsmOlxHij6MKFsf1W16+24Z+TO1WY89xqY2yDcG6fQadlkNWe8VMGTXV wilH6hsEPpWhDC+zJGrfFqtD4bW5lzsEuf4mboAvlLKsX7nmgxanGHWzP+7f/x6aaaM5 GlLkt/zdlVi8SIydrzp1/M2JWPKLjRuUnfMWZmlR8/h9fiaU5k+OaFVxyZeh5xpZbqNy 5zF9Q9kZRwWAy+ex39EC+zXohCisTBwyOBrZynzd0h/NYbSj5BNCgqe4A7MX9uiRibmH 4iFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767347030; x=1767951830; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=viTJoTt+fY6CVrcrdzVYmyIcj6URFL2FJNsEU07SeTA=; b=WT3ITwQWtiLHYN4vQo+OgjZweYv6KvwWT0iGRsaaADnjzuysvrLAiz6mt050dPere6 6qBGw+9jhpGErhUztntX2NgPS0XOvoaVsY1YVSg0QW+Sz6oPD701yiDMmUm/2SdHbKro KHUSsVXErKRg3sH3TKO3UEYtysOl2OXnl/ZflOmojvufp82Edi02Qv5ZPJ2EBoiR+9/N SeuNz+F3YxZijRYkrdvzgdnzphaV1Rd4dhzjVbekoyx3np2t8tICrBsbZhx6GxjdngdN uc2ODPI1cLkSOsly+LtPhK8JiUb2uYA971e8xZQFlRcI79tyPc2GV4JYJskxUegpGVoJ zIGA== X-Forwarded-Encrypted: i=1; AJvYcCVcg8E7eublRGnAcsMc90rT19eY2Vimtu0+v7A9uaEcqlWY3XNU7SifeXvwAVQH1p+yVNMOntfbQcPzJlY=@vger.kernel.org X-Gm-Message-State: AOJu0YwSU3Qdi6WgpgZEFUoRWMBrVzWoFFk/oeqVKFfRfDn2EtDwcJ+v 0Rhjt3lQowYUUUn5pFgiAQ9fRQGOToNVjeHgGxFz5+vzW/OsfaApo1BS12EvwXdNoGvhP0pMjdU 9UzSbYx9HfiZm2QeVefr7vpFtteyrP955dIwvCIPzG9r5RJlmf4n6dN2JP0OmCI/PW/s= X-Gm-Gg: AY/fxX45DCLvPbGCIW9jxLbTi8aX03EcU4MDdjs7DNwCOkrr7PoneN3XwEKNzILj0De boqajxMT4kcnCEgQkSY+hvQ1EAozB/yM9vm7XW2KKUW0GKzdf5HXGQAurFd8RO/ETZd+3X8Khul PJOt6272vUoSQBDKu3UacrE5nQUwltb/QIP0Yvaq42Z+9lDPQYmqnPqSTpOqxe+A/9spgDOSggT qG/gKFFDlAu7t0lVGE4+5gfzLE1Q9AHyY5nvMP5giCEvOYbGgquPCjvfTf0w9DrBgmhaHzemOxR 7+uAcNRfk0shc+1A4MUFqcKJyxQSo5WHy2SPdfTlHXDrsdC7lako825iOk61OEOfJp5UwWAdo8C Td7XQpbyYYSKtnjIJ7agzZ2PISewTYGu5KCRYuceEKBgr X-Received: by 2002:a17:902:e552:b0:2a0:8360:3a74 with SMTP id d9443c01a7336-2a2f2835cfdmr296990705ad.51.1767347029743; Fri, 02 Jan 2026 01:43:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IG99w9kGvmU/akNsiKNiP9c9Yd1UyuMwX3o8fit0vRApV/y9Gq7EiMqWPo3SKK1au30ydlmww== X-Received: by 2002:a17:902:e552:b0:2a0:8360:3a74 with SMTP id d9443c01a7336-2a2f2835cfdmr296990465ad.51.1767347029272; Fri, 02 Jan 2026 01:43:49 -0800 (PST) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66829sm376154255ad.10.2026.01.02.01.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 01:43:49 -0800 (PST) From: Krishna Chaitanya Chundru Date: Fri, 02 Jan 2026 15:13:05 +0530 Subject: [PATCH 5/7] clk: qcom: gcc-qcs8300: Do not turn off PCIe GDSCs during gdsc_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260102-pci_gdsc_fix-v1-5-b17ed3d175bc@oss.qualcomm.com> References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> In-Reply-To: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Bryan O'Donoghue , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Konrad Dybcio , Imran Shaik , Abel Vesa , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, Krishna Chaitanya Chundru , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1767346994; l=1437; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=u7E+JsBFtSP2Aq79SX7r0MLZ8E+3lGXEhvVfek+8kDs=; b=RJFKvTyOagR67CMBwF37mQF7o3oIncFgOLlUIkbsKuTa9uLUqkCjDQVXtCnQRYot8z0Vw3LTO xvzwJxCZF1pA2j3cEBmCY5mhEN0Fy1RWGLOdgMCpaT/qcRRz3z5m7cP X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDA4NiBTYWx0ZWRfX5rd1RW4ZgAZk KfPkRNJKzYKFwUc/FPov7U/HV5oicX6qyTEenDTq0ARmYVX1PgZd/9+mtNZCNle0NqXitS3cZGT OdJnr/peaZQQ+81a17lXfETQyvxA34UMYg8m399Q53AUwrdK3RhFG51PWxD1/nYBHjY9i5YxtWC HBJxBE1ml8vrW9x+uWLGsATLzqUiFw5b7cqmae4wtHNeq4RNYbhIKrBj8gvO4KlbxAL6wX0Owys sFFn2uBLMxfaHWLyzTGwNviEV9ksIaN65zlxi91VN+XFMLCgZdUfENn/PlJ32C0akitQ7dvvJRY CxN2DaIuX1WPnytwIMVt/q4n448sdzwIlaVxBw5DHTV02PXqJSTVKRtBA8UyZ/46IqdmOkrvIBI 0B0c7IWFVK/jsndGp/xHriWngupndJyNQRioo68ZDHsB0oI60cSyoVKjQ2Bt/UEQrrO6OAk9f/X PrZTyNHDfq4Cr8WCeZQ== X-Proofpoint-GUID: waFUKA54GaTCVBY6dSQGSvUUofs0VGzB X-Proofpoint-ORIG-GUID: waFUKA54GaTCVBY6dSQGSvUUofs0VGzB X-Authority-Analysis: v=2.4 cv=Mdxhep/f c=1 sm=1 tr=0 ts=69579356 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ByFm4HHrRE6C6VNyrcUA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-01_07,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020086 With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Fixes: 95eeb2ffce73 ("clk: qcom: Add support for Global Clock Controller on= QCS8300") Cc: stable@vger.kernel.org Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-qcs8300.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-qcs8300.c b/drivers/clk/qcom/gcc-qcs8300.c index 80831c7dea3bcde0ced46054783df02b07a985db..009672b75fb9099cb0c6db7af38= 63654f2fa6648 100644 --- a/drivers/clk/qcom/gcc-qcs8300.c +++ b/drivers/clk/qcom/gcc-qcs8300.c @@ -3268,7 +3268,7 @@ static struct gdsc gcc_pcie_0_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_0_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D VOTABLE | RETAIN_FF_ENABLE | POLL_CFG_GDSCR, }; =20 @@ -3282,7 +3282,7 @@ static struct gdsc gcc_pcie_1_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_1_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D VOTABLE | RETAIN_FF_ENABLE | POLL_CFG_GDSCR, }; =20 --=20 2.34.1 From nobody Mon Feb 9 06:28:07 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13E2D2D839C for ; Fri, 2 Jan 2026 09:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347038; cv=none; b=C2jzEC6DrTRVW8R0Ojh2of+I5eEH85UqLH6/gPtA7iO4Act5c4sgbzVcA1gR3tQPLx/2Ctpuv5QxoKhN2LQMbxwShjcKcNSFVPV4Eiz1cxbks5HiqU2kTQHZIPhv3QuPGD6p5xPyNoguxZ9Mb2PW1Sqwss8l4T/AYGrt6ipNddc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347038; c=relaxed/simple; bh=XOkRcbE8VNIcaH72U7IUKRFd2thHuZrA+nnkmZR8f54=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gH8w1pkhFD3VjSmRh9xtj2+vJICEEHYo8mxi/TIjPPPBXY2XDUrutHtMFmVa4xIqAFYJckn1iLPN5aLB7wvJRO4m2y/B2tjOhQyIMMpVw9vVMkMXUSO1useMEf6cq+y1dUPsP0BTVNPZk8gq2I0XDRfselXpHtZumS9QJK09YcI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PxQnKX3V; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FvZnHEu1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PxQnKX3V"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FvZnHEu1" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029WMtl427841 for ; Fri, 2 Jan 2026 09:43:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VOB3/Mj6YEEp2iQxLvfoYJN8gYJUopTS6O2MzTLgi4U=; b=PxQnKX3VyQiRuG0G nSnOLCfx5jkOruw24HWijrmFHmjdovTfpsWMRxbMIPK9khBflY0cGAT0q/C7cV3x sCrIxLKagRfLnRtEccmzAO3t6/za9hdZ3v1RKy8VhY0dep4dyT7XKnINcCe0bfVj 6WNp9VwLnU+2/1h1to4i4NvhDMkIgwtmR797jgM3hkA/UqNWzfghV9EmU+vv8s5K iafLOXC7lo8aEnKWzYczVkCSrdjttdwU+LBCLWjBlkjgOW1QBPbZrq1PzzQQsWfy OW7Frw6Xptwux2I3I/3PzgAvSlXu7D4Z3zdliQAx2uQDXnDwLFnYbgB5InZ362U3 4ro4gg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4be6fjrksd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 09:43:56 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a0a8c465c1so78411575ad.1 for ; Fri, 02 Jan 2026 01:43:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767347036; x=1767951836; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VOB3/Mj6YEEp2iQxLvfoYJN8gYJUopTS6O2MzTLgi4U=; b=FvZnHEu1xZKOvP8N8hMNVQwN2G1PbpC5xI80J0oEeGcHoYQ2oY7PuV84hbhv6XKizX 8DfM1aLGWo19oMksjXzQrFEGRd7QK0T6iMEnhtwlT6ZF2rcHmudoqZ1LiXCQnfVMpU2W ngVz8BZr9Zw8AUsfrDLA1nSkBd4AmSUR5uItMQY7vddPQHUw5QtBQgCe7WOlOd+fnNX0 JUnhWkrUPp38S3BProLIqW4KhHBOeotwmaqBtYNeKGCy6zGgy6L5h6jp7Q62jLQ33Esm QLz1NVTZFrK4FsSSOCXFn95MgcakRZr0iNtdGMkpjhquWJCzT7iq6czQX3N61SjfeGD8 8vEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767347036; x=1767951836; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VOB3/Mj6YEEp2iQxLvfoYJN8gYJUopTS6O2MzTLgi4U=; b=DUYVK08ah2OnXvQFNr/Ej8f63UElw0daMaHBGtI7eyQZE7LR5WdK5RjWxkPcrbmDcw AEkG0Ky8UkXj25skhAq7UHDEG80IdpUkFhx8CMkANxx3desC/nQLxUN+SFmeYfVy5eaJ 4J56sFN4HBCMp/BPFxZbEU+E3uAOg5antbGasgIpfzKnpr49RMlEhnUm8ILlkghS4D7p T4sJWM8v5bSRgNiQNCvElUpsY5jB6e+b4PxLFCAotwg4YlhJ2pWbJo/jFlIC4MWvEXeD hvp5U3a1wk84oWrGeYsB1nM2hXGnnNDhYmMrg9bQEnwEem4LN20DoZtioqhMTKU8SCcw OZ3A== X-Forwarded-Encrypted: i=1; AJvYcCUK3LLJAGEJe7a3XN6ltNFt5VYBCtrHx2LugIvlOFNjNkGoP42JE0dEc3x0mqLojTPM8xGH8jd2dDF1Pbs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2iZsbhgeCoisDuB9DV3hE6epZk+OGS6xyZ2CAjU9NxTCJvTWo 7wwLWhm1b9/oZSgI3tiT5gCiNpN/3lFkh+Z0gOPq1KPzZnvsqqjuPu9VQsBbIuMLp/qqJrN4szF QlWDXDY1y+O7iJBQbzo1xEv9duHmrWosGC/8omKc1l5AsvT8QwwXDj89Xw42nlV6mG6o= X-Gm-Gg: AY/fxX4e0Dcl4k3QYAGup7Rw+0ssv0rdgtGm1o1yDXJT4USTMgqKlRhPljtOwF2oYkp k4K+wmkyc3fJ3aldo8MuEZ1tqEqvqMafr4HvFCm+REhMy9kDnX0A3L9pI//mgck26NVYkB+6YmX wUQ8Tq0cqyq6YVHpNzBVAcljXMcu555slmoj4HGC1mi0nejwGjZYtdXHmKXFE4AvoLtTRepD+U9 qsMAA+tD9E/Faw7gkDsB5Mka9ThGm33Ew1NLXl4txfYMhz+egbGIZ6Eq1cOfq7DnnnSqTnWkx3S Ey1SomLLkyfGDZacYtAmv95LpSLR8FKxaUSRw+Ko87wRJ46Wwg/6q8swrNWTLV4ODa0CWOnRtEh pTkgMkdzaCOsm9moQMwgA/TN1K3o5mb8swDSzz4pfodle X-Received: by 2002:a17:902:ce92:b0:295:99f0:6c65 with SMTP id d9443c01a7336-2a2cac808c8mr473754925ad.30.1767347035591; Fri, 02 Jan 2026 01:43:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEke919yfCWNZoHyxZwMBFBZAVTXKnc3GjZ0LA3ZosF28wiOBSbRO02LbB0Gbt21fRWjNr44w== X-Received: by 2002:a17:902:ce92:b0:295:99f0:6c65 with SMTP id d9443c01a7336-2a2cac808c8mr473754745ad.30.1767347035105; Fri, 02 Jan 2026 01:43:55 -0800 (PST) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66829sm376154255ad.10.2026.01.02.01.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 01:43:54 -0800 (PST) From: Krishna Chaitanya Chundru Date: Fri, 02 Jan 2026 15:13:06 +0530 Subject: [PATCH 6/7] clk: qcom: gcc-x1e80100: Do not turn off PCIe GDSCs during gdsc_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260102-pci_gdsc_fix-v1-6-b17ed3d175bc@oss.qualcomm.com> References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> In-Reply-To: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Bryan O'Donoghue , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Konrad Dybcio , Imran Shaik , Abel Vesa , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, Krishna Chaitanya Chundru , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1767346994; l=2890; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=XOkRcbE8VNIcaH72U7IUKRFd2thHuZrA+nnkmZR8f54=; b=0lEpbA+NtXZaGfYZfqD7BMu6USHFAdGSoxKy6fsm8Qv5CX5UPMkw7AeRdMhwVUuKINcq+KX2V 3Y7ItxyFdHBAV3D28EafXpNBRIZANTx7XWom0Hc4uuwcP5TDNbSu/JO X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Authority-Analysis: v=2.4 cv=Av7jHe9P c=1 sm=1 tr=0 ts=6957935c cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=APsdKiKIpUGVn09es9MA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: yRSkRLIpmoBJCYtEDeGmWQtpRpPyBWjn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDA4NiBTYWx0ZWRfX31a0DvCV8eag Uu/1Omia6YzgNy2aBLJ+urHxC0dmYMFk+IMXbluPpZhcNGjAC5DT983aW7B/aGdQ/ky4Fxsh+ia FlMHwEYHEgNi76c3GNRxa8CSCx/vPGUDj7RkPbPtLcjZNsspXm6Khy03pVjNWDE6hv/ekznju3e BdCz00OcBbBt/Nr0I0vjnwAnWkuWK4MrDP/kloZaglMYjnP50cblpgOu3uvsejNG0JuT53IfsD9 WpmJAUU9w/19bcp4vCkUA44hpf0A6rfUjTR1HYGYnFeCGrrHZKVOf5AHXSNWxNMxfy3/ZkqP1Dz mHQTUT9OnJQSkcDIZ+ouLItWuCIJnJnHVy47t0FkZFLOAhLGtvS4aLQrFh0OyMQ2oHn6xbTWiml Y6kLPCWoGdY4Mv97ZsuQwTsHSu+4x0qT/YgyKe1cNT1Kr9hrLjsaqFp/6BSmAyvjnIPsNP8PVCY /ag4rOCkrF1u/kBwhdg== X-Proofpoint-GUID: yRSkRLIpmoBJCYtEDeGmWQtpRpPyBWjn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-01_07,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020086 With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Fixes: 161b7c401f4b ("clk: qcom: Add Global Clock controller (GCC) driver f= or X1E80100") Cc: stable@vger.kernel.org Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Bryan O'Donoghue Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-x1e80100.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e8010= 0.c index e46e65e631513e315de2f663f3dab73e1eb70604..d659d988660ea5e548fcae6f9f2= a9a25081e6dda 100644 --- a/drivers/clk/qcom/gcc-x1e80100.c +++ b/drivers/clk/qcom/gcc-x1e80100.c @@ -6490,7 +6490,7 @@ static struct gdsc gcc_pcie_0_tunnel_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_0_tunnel_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -6502,7 +6502,7 @@ static struct gdsc gcc_pcie_1_tunnel_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_1_tunnel_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -6514,7 +6514,7 @@ static struct gdsc gcc_pcie_2_tunnel_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_2_tunnel_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -6526,7 +6526,7 @@ static struct gdsc gcc_pcie_3_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_3_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -6550,7 +6550,7 @@ static struct gdsc gcc_pcie_4_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_4_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -6574,7 +6574,7 @@ static struct gdsc gcc_pcie_5_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_5_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -6610,7 +6610,7 @@ static struct gdsc gcc_pcie_6a_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_6a_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 @@ -6622,7 +6622,7 @@ static struct gdsc gcc_pcie_6b_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_6b_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 --=20 2.34.1 From nobody Mon Feb 9 06:28:07 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C38892D8782 for ; Fri, 2 Jan 2026 09:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347044; cv=none; b=Qbp+IyM0aaW+tkSpENkcHtQ17fBixTnzdGc+F/tpG7fO59jNUmaSC1AoE1o8qMwPv0Zl4DLmUGTAADzSBbq2KFQEjbFddSlIuiJrVnq9zOlb4A/04QjXYOO/AphE0oriuC5+V+ueczIr0ZOGKv/Kn33expUvpOe9/VqZjw18Vu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347044; c=relaxed/simple; bh=FqGhFooRf3dVZrhD2545Nbq1W16XkG+oIz5X5zYASlA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ty93hgz8V/mUEyOtCgoTQC5tUF8wLNQed1bKYgmOqeLVPwlk5NVZ8ENDx5F8M8WU5CnP8W6ecvSldXiFKnPaxWsWYl9/HxQxGVgL4vtguGJWhl45nILmix6qUyhlRVx1J9yt6T6c/sXLQODNks6TNMPW5yb3t7GMP+Eza6PZrHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pStqnwwa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EMuYYIjj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pStqnwwa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EMuYYIjj" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029W3RF617879 for ; Fri, 2 Jan 2026 09:44:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5NO2ywtEGxXnmmSDCb36UkShK/n3vc+3TebRaQCb+gY=; b=pStqnwwa9UAMD0FQ 9oEvOSHACcwjer3xAJHDXYyewB3FMs+J/xRaN7OboAI28hq0wuCWWusHc27upbcc i+ia8KL2BzUxQu9toRvcT/LlPcXEwBreoonmbkZKnRWFuOwwRPZPt4GV0I6OxaGq Qw9FI/Q0+wyfSIurs/15DdJgcQ4JKOQueelUCyWNyD3gbruoiJXW5bShf5jr63i2 6ZuIEVJYN9yJ7uAG0e7wJEDYC+XDBSsvoGxwxGNVmygNlJGVvjNeGDAEZ0nbGq+D 3K6zeNPEsv5FGkcedtPPV9gKnsXopJwvV5prAmjnW46DY/CI1SAezv9OVyyUowpK gpsWiQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4beb4wr2fn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 09:44:02 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29f1f79d6afso168632085ad.0 for ; Fri, 02 Jan 2026 01:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767347041; x=1767951841; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5NO2ywtEGxXnmmSDCb36UkShK/n3vc+3TebRaQCb+gY=; b=EMuYYIjjqGfIVlwduD+OrEu+gf7PHOZShYwiWkZ/O/14GOGxXW9EnpMWvFpAHjvI3g VFdozFHCF97d7ytJHxZ5ywovVNqIsnLeKBU7qB9psaUceIO9ME0z5b1jrYsG8ZREigkH 8q8bGA6xgS8nYie6xUwBRVe1tPnb+lzoy/k3wlOh9GsGOl2T/+pwKTDg/TuaEWhXCDS2 z5Jyl+HCw005hts0Xyw/aDlaHRioY62jc+ftds5HhM48xN1uPiojzFMUmcP2+VHLTev3 amMWxkY2EiqMceDgem00nbFnXYa2YXngjSrx8MjPZam/s4DJrzK+nhss3wK2p4ewSM8B wK3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767347041; x=1767951841; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5NO2ywtEGxXnmmSDCb36UkShK/n3vc+3TebRaQCb+gY=; b=BPPeUktDYjWRvKWraXXfz/U5vapv+2+uBR2sC7mjJr1gxQgh0C5pD/feGxT5EGluU+ IcVvfZXXqsjukVwnEZ4tvn7kP0X9Ev5jcGAbMhn3M9nEi1KCFPkjvnMAsgtE2+E2GjyG yHTST0Kv8qK0d55G3m9Zc9WUi2UOeoqkC9AcpaIq8evntPAc8F/Y2WHwdH35ss7y5Acu z7CqRpz20JssVy9OhXvtYqqEsxkeUDrAKX+4Ew1gl2EpPKxKFLuts4QCOU6k4tqXkxwI d8tSS9NJ+bMYoD/gJHzniEtpkk50YwlSJyeCT7bZ9YSGQDyOyJdOjFAvGR/OmujXGsiU WMdA== X-Forwarded-Encrypted: i=1; AJvYcCVdsX+dXyEmSmUJwVfO/XLNJ0dZHRTo29ou6PVfuHhmNZ5oqot/HoLpdv13ZWcpwL7LWJWA/YxfH+NaCCs=@vger.kernel.org X-Gm-Message-State: AOJu0YwDLMeaQ4LSDUOxm9PpPqCSnivTyAgbOPG15ipgGdfe/6wB6PCd WQ240KUertnh/wVFZAqCu4zawwJNB279pNp/NIkFAO6tgk7TAA1G9ciycBzNLMK4wDJdWlSTYiH 5Bl88mRiHHQ5NvGhuP8XRYO3NOxMJIO8//WKV+mhPKWqPPVbxYaXs9ev7H0tsSku2Yjk= X-Gm-Gg: AY/fxX5NMwiaucTV/8jr5ucpesMIpR1rcgLDQOlaYhtypklhs8kWUB/Qs32RQoOcG/h KbhWei+SejeeoBNfZmztHX9ns/rxL2r2O9yIV8ZYmyyXSex7C6rDbr8Gx9F1XuY8y+o+WNkQGRB vYhWJqn/HuLj71MVysVw7Oo+kjmRyPED88lCXjkgExAp21Cae8SLZINEfyDrI23BEJCt2jp0N6m 93/msgCQ6L+C2BjsjHUvCZdljeGRwH/Ir++8Cd+yy2s+FzEtN8OwScAZaNed9mHxaRyClM38dUd 75SYIzo2KqezZbTL4KizEBG5siuk3WXxxC/19vY0wIz2RfIQc52CslXTsyu7/0x8T/jISBsDlb3 HrlUrs1osenTDOP2yC9jnxbAW0Jk390Fim8sT83qty8X/ X-Received: by 2002:a17:903:3c50:b0:2a0:9040:637b with SMTP id d9443c01a7336-2a2f2423178mr429122585ad.26.1767347041413; Fri, 02 Jan 2026 01:44:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlAfJ7GPX4WaV02+Q6/Jii6uP9NcsKWMUgcvCnfmuvI0T8Wm1INga2Wpus+2H/d/9fftVldQ== X-Received: by 2002:a17:903:3c50:b0:2a0:9040:637b with SMTP id d9443c01a7336-2a2f2423178mr429122465ad.26.1767347040946; Fri, 02 Jan 2026 01:44:00 -0800 (PST) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66829sm376154255ad.10.2026.01.02.01.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 01:44:00 -0800 (PST) From: Krishna Chaitanya Chundru Date: Fri, 02 Jan 2026 15:13:07 +0530 Subject: [PATCH 7/7] clk: qcom: gcc-kaanapali: Do not turn off PCIe GDSCs during gdsc_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260102-pci_gdsc_fix-v1-7-b17ed3d175bc@oss.qualcomm.com> References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> In-Reply-To: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Bryan O'Donoghue , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Konrad Dybcio , Imran Shaik , Abel Vesa , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, Krishna Chaitanya Chundru , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1767346994; l=1214; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=FqGhFooRf3dVZrhD2545Nbq1W16XkG+oIz5X5zYASlA=; b=0JXIyA4A3ptKPWqvekt+GnVKHf05nsknUmZQS3bwYlx7RZdB5HqrDTuiGBpawaWnuJVCJESLO OzZ1UrjVbwMCgUpJFwHuHXOsShb+Dx+bp8WIM9psPB8oH6XFa3tR9P5 X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-ORIG-GUID: HDuzNIOHf_KGqfWtu7_BsgS8ydsRvQ-V X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDA4NiBTYWx0ZWRfX1WB7OOyeQXGk 5IZEPwP55sxbM9v2uwRcIJWbrAYnzfrNG7fXiolej+Nayw3bWaTI2BD2zqzOim+Kmtn+f7jDuqw UuKoeMS8180fbRQCA9xrJ5LAo14mbRgi6BAJipVSudMXVs4iDgJDAXQYvw+yjpIx9IkLpuLu6Uy wX7N4bbc/A7gIPffpkGEeoIs9hi/7vRz+fgmQAQrrsaCkdaRpokAiecA7JBXMcLRx7/fLWNorhl PZ8LhfgVomTWEOQfRfNrxewfJTAoRfV58KbxifXI33U3StJFfNoMvRZBNa5dMAxjwAKEVX8uGmF PhqlG50TLBxaT/yCDDKnvgoKkp3VP7doIjOWlg+EJKTVjEMKB4YLWEgP8lxk30NvG+hu7YQPChE Eo0AySch4QwyRWaDk+4He52FsGBU8Jgotk9zYkgpSsO8uuW0yGlhoRTG0JPso6Ex4DCwQTHbq6i l5kaiAejfHjhWDFtSNw== X-Authority-Analysis: v=2.4 cv=I5pohdgg c=1 sm=1 tr=0 ts=69579362 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ByFm4HHrRE6C6VNyrcUA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: HDuzNIOHf_KGqfWtu7_BsgS8ydsRvQ-V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-01_07,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020086 With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Fixes: d1919c375f21 ("clk: qcom: Add support for Global clock controller on= Kaanapali") Cc: stable@vger.kernel.org Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-kaanapali.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-kaanapali.c b/drivers/clk/qcom/gcc-kaanap= ali.c index 182b152df14c252035fb28adb2e652bbfa22114a..1bae1c9dbc7764996e7c0228f9f= ab72d5e630cfa 100644 --- a/drivers/clk/qcom/gcc-kaanapali.c +++ b/drivers/clk/qcom/gcc-kaanapali.c @@ -3141,7 +3141,7 @@ static struct gdsc gcc_pcie_0_gdsc =3D { .pd =3D { .name =3D "gcc_pcie_0_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, }; =20 --=20 2.34.1