From nobody Sun Feb 8 04:12:53 2026 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB23155C87 for ; Thu, 1 Jan 2026 18:41:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.161 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767292912; cv=none; b=aYxXmrw8K+MUd3HihUApRBUJUVspzErAJ7pSUpvD3zz2NwRdnMAn2V9xfqrhO5YYGhPMJKkJOF1lLascs8h5l1vOuHcBAdSF9nJMzrSNRXwRdtBeF0sXqmH6MEvK1v5yEqlXdU6KGqmOTZgotMxPk8XsyXj5MOgE+syG/2pO9e4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767292912; c=relaxed/simple; bh=22LanzPOsu2iSQcdiwPXzxw5LxEeMllGDmba6gKezhU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=f8G1qK9s7THTfZDxWlEoCocxWKJUoiRnCBH0FIgsPeDv8ddyXU8SDJokzWTyoC7nBvMbOCN0/jvnDrApiFGyR5NzzALjEbY3kCMgvawy/VPz2mLeucj97w8yL4pNhdfiB36d4a9RkD0Zg1p2nr6BY6fxWYg6XnagjSSWbGYbnXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=tJcLEqXv; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=tJcLEqXv; arc=none smtp.client-ip=80.241.56.161 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="tJcLEqXv"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="tJcLEqXv" Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4dhwdz1pjqz9srM; Thu, 1 Jan 2026 19:41:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1767292903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0KsDstpxPfEmoJFxxat6nI8hzti13oPVPYmI3WSj8wg=; b=tJcLEqXvymLZHN815RIrk2fYTlMW3jISiUz7afjzHgptbU78t1/YvU/1dsj7Sj5w+ZhYNZ vNC1TUdXsU01VdtZddiRwKVQMNlB85lTJv8CJEj5rUoXBbwBHFy9kxPx2PbOLKPllqXZ6l Pc+9/qUofD1G2tdjGF75u2Ycb1pl0jx1MqgOncBz6r0lVgrrkpu3LoclG5DRwy5CiuuXP/ +6quJBThUABiBy4hV7Ti+Y7e0+J78gAWq8e8ZTiFdDdVv7ebcsZq3AeSBWTGwc96DlUIMX hSB1nz5sjmt4VC0UKwjF9sgpHbbMgl8dd9nfW03xseICEzctp/QbBIU6gZ5Wjw== From: Maurice Hieronymus DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1767292903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0KsDstpxPfEmoJFxxat6nI8hzti13oPVPYmI3WSj8wg=; b=tJcLEqXvymLZHN815RIrk2fYTlMW3jISiUz7afjzHgptbU78t1/YvU/1dsj7Sj5w+ZhYNZ vNC1TUdXsU01VdtZddiRwKVQMNlB85lTJv8CJEj5rUoXBbwBHFy9kxPx2PbOLKPllqXZ6l Pc+9/qUofD1G2tdjGF75u2Ycb1pl0jx1MqgOncBz6r0lVgrrkpu3LoclG5DRwy5CiuuXP/ +6quJBThUABiBy4hV7Ti+Y7e0+J78gAWq8e8ZTiFdDdVv7ebcsZq3AeSBWTGwc96DlUIMX hSB1nz5sjmt4VC0UKwjF9sgpHbbMgl8dd9nfW03xseICEzctp/QbBIU6gZ5Wjw== To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter Cc: Maurice Hieronymus , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpu: nova-core: use stable name() method in Chipset Display impl Date: Thu, 1 Jan 2026 19:41:36 +0100 Message-ID: <20260101184137.80445-1-mhi@mailbox.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MBO-RS-ID: c12ee0ab6ccfe1fcacb X-MBO-RS-META: 4myaz3cqa73rzs77hg741bizctpyjbpu Content-Type: text/plain; charset="utf-8" Chipset's Display was using Debug formatting ("{self:?}"), which is not guaranteed to be stable. Use the existing name() method instead, which provides stable lowercase strings suitable for firmware path generation. Signed-off-by: Maurice Hieronymus --- drivers/gpu/nova-core/gpu.rs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 629c9d2dc994..be8c882338ea 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -107,17 +107,9 @@ pub(crate) fn arch(&self) -> Architecture { } } =20 -// TODO -// -// The resulting strings are used to generate firmware paths, hence the -// generated strings have to be stable. -// -// Hence, replace with something like strum_macros derive(Display). -// -// For now, redirect to fmt::Debug for convenience. impl fmt::Display for Chipset { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - write!(f, "{self:?}") + write!(f, "{}", self.name()) } } =20 base-commit: b69053dd3ffbc0d2dedbbc86182cdef6f641fe1b --=20 2.51.2