From nobody Sat Feb 7 21:16:02 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17F902264C0 for ; Thu, 1 Jan 2026 06:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767248731; cv=none; b=s6pGrXfMJLD6lrXIyBQLHAmQpOgqPnk/0ZWMvdXKfWm3QLIBoi55c77h1MYkES8atIkYCnBPJhB4DH3wk/Gj0KyKyqfywDitoZAh623RKkYAdn18EonFQ32j4ctiE3EikJCx5vaA3zdCnUI76wHb2JZG6/91dHFcuoBYz5UEpSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767248731; c=relaxed/simple; bh=pQc/vzHBPofjPQzffq9tp4UYlSjbwrE9yDJCnGfjw0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UyY0bfGqo5r/0aZa5Gw5KLMCfNGjKXWelI1hsatayGcc9g91UT8hwg8O8DvGMcL79/ugEun9ctyQGA2GKHV4F22ZLb+BEZnCxhRURoWg1QXTb4bhrYJR9XqkNC8WdIkDG1Iw/VDju1E6DphurN5T691Iy0sGnGCUHP9nyccX2dU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QWppzZjI; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QWppzZjI" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7aa2170adf9so8317954b3a.0 for ; Wed, 31 Dec 2025 22:25:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767248729; x=1767853529; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kgbiI2XInQRR+Vqs16mnpbyaWQyjL6O2oXRYN+hsObo=; b=QWppzZjIIkWUMr1USq9RuBkgumytNPzxesg9SOzbA+nWgt4pRkviMh9f4h8bnMYN65 WShznzgHSnPX2BH8KqJrwUjyAoQ4z0xsWSeOdd5SyJpTogp7q4eEGMNTNJj7q5EB8/NS ky8mQyDMcgn+tCf64jRNElqiFI4jxCtjWavkA99EnnibvPmANEZ7pq8OFtRnm6As8tm+ XpJ97pahlj4TRKW2TG039YG+mPQIi49bRmQo5xnn3kJqAmjqMxiJQumfGoeXmgXEgRUY F7dJZ+0xWIMlIYjJBo2YwfMkI8Q7BqUjlH2AMe4tlHn8k7jBgUVTxMrHE0dLCx8LAitJ RP8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767248729; x=1767853529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kgbiI2XInQRR+Vqs16mnpbyaWQyjL6O2oXRYN+hsObo=; b=uZDwBD/3dfSrBLuHKnKY7kR05mysN5ufKfZuouRfPjyWBVTiWZ4wRKNc6zjeg19zGN xYOPaWNI6tk5LSJeFsRv9MUAt4AU0ioU+ltsvOh2MTadgMC6xgwbb/gNCkil62suFd9V Z6UJ91c2T3jjYi6AhHI/zgC3sX0SICsE9PlJZtqFoNS9h1ReUfFKoxatf+2clrA5+UTd CqMoripApaDsyFo9LyRSE1pCUNb4Gu5jJA1IwaQedLRaKgwHNQKYY/LI1kcmEX80T95U pgib9iazsHLFb8Qf4EFX0v7Gx9/P0gQLJXo9uxeQzAEI4lOF6Ubk83psvi094n8IyVrg OumA== X-Forwarded-Encrypted: i=1; AJvYcCXdFdQm5oSwdc8K/4Moff0KlzRArP8WyvpXUaLNaF4UGcdNqeJcCU1hvYgNR+PG57FiDcPshECJqANnfTg=@vger.kernel.org X-Gm-Message-State: AOJu0YwhxChJnFdbXdc4A8HrpH9ddjGefh79x6aO1fJENkfeWHg+gg1a alwRVAVdtiMkdvHhvYVvqWcneSlLBSXGxtkI+out2CPkN7ODawf5VBJR X-Gm-Gg: AY/fxX5xbXtpTgIBLn/E3S8a/CAtesHdYRpzS430/Om6/80t+Kyt021jJFrKR8wvPy1 D/Ous6XoR9viPVlEssFsavqJ1PDofQrBUTIXCLJ5y94YdbiiweBa7/TaKib1QXjfn7Dc818BVLF fA03P3Twwp1zBgZG3dLyEfFjKwIeKkFp3p0me4coCeAU+JqNdovdiQTC+oxyJl4LNjai9UaMe4s sWehdc/IbhVRKSRBykOijg3Z1xBeXJoQWWDd+iCXBRcl63VktBx6RHj5Ag6Pw2rFwl8PCOzhzp5 LMiAZA599I09E4grns1Hn2nuLcYOZy7Iu4ucYuPkL1MNPLxg9GzY/APi4sLVFaZP9G1xmuEX7f0 jAin9eDxCf/W0KEagv1f+zKk8928TgJYJ0EhXLE6nmSSPbXEt7d61X1A5gelWLTQdXo6VW0auJP ZryQndsPIkGUu/W1i3fWWDsK+szcPdwf4FvF2l3hGxnwG3INvkHgWNgKuQW86RHkJxvbG3xwxY X-Google-Smtp-Source: AGHT+IF0EsKgw/v3geh0bknpZ5PAnHW8mZQz21B6hYvNqEgoKWU6U4GCafgpBsInjUAAOIATUbBYTA== X-Received: by 2002:a05:7022:2214:b0:11a:23fb:16e2 with SMTP id a92af1059eb24-121721aab8fmr37787196c88.9.1767248729358; Wed, 31 Dec 2025 22:25:29 -0800 (PST) Received: from zubuntu.home.zacbowling.com ([2001:5a8:60d:bc9:9ebf:dff:fe00:f8f2]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724cfdd0sm144361662c88.4.2025.12.31.22.25.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 22:25:28 -0800 (PST) From: Zac Bowling To: linux-wireless@vger.kernel.org Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kvalo@kernel.org, lorenzo@kernel.org, nbd@nbd.name, sean.wang@mediatek.com, deren.wu@mediatek.com, ryder.lee@mediatek.com Subject: [PATCH] wifi: mt76: mt7925: add error handling for BSS info in key setup Date: Wed, 31 Dec 2025 22:25:25 -0800 Message-ID: <20260101062525.186192-3-zbowling@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260101062525.186192-1-zbowling@gmail.com> References: <20260101062525.186192-1-zbowling@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zac Bowling Check return value of mt7925_mcu_add_bss_info() in mt7925_set_key_link() when setting up cipher for the first time and propagate errors. The BSS info update with cipher information must succeed before key programming can proceed. If this MCU command fails, continuing with key setup would program keys into the firmware for a BSS that doesn't have the correct cipher configuration. Reported-by: Zac Bowling Signed-off-by: Zac Bowling --- drivers/net/wireless/mediatek/mt76/mt7925/main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net= /wireless/mediatek/mt76/mt7925/main.c index a7e1e673c4bc..058394b2e067 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c @@ -637,8 +637,10 @@ static int mt7925_set_link_key(struct ieee80211_hw *hw= , enum set_key_cmd cmd, struct mt792x_phy *phy =3D mt792x_hw_phy(hw); =20 mconf->mt76.cipher =3D mt7925_mcu_get_cipher(key->cipher); - mt7925_mcu_add_bss_info(phy, mconf->mt76.ctx, link_conf, - link_sta, true); + err =3D mt7925_mcu_add_bss_info(phy, mconf->mt76.ctx, link_conf, + link_sta, true); + if (err) + goto out; } =20 if (cmd =3D=3D SET_KEY) --=20 2.51.0