From nobody Sun Feb 8 04:12:01 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9AEB21D5BC for ; Thu, 1 Jan 2026 06:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767248730; cv=none; b=RMIkC8aTCeDZs2XVKXVwVOY1pXwC1gujehZPk2b932VjrCqUf3kJwNHoGcMFahQiCQvm64QFs6gE5cG1AReHPsisVtX4RAvQTvCM87lf3lCR5or4wMGPlCgj7qlF3DaAPcgVSBYrub+4Myo1ctJT+QlhxXgeusYSOa/QNpelbzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767248730; c=relaxed/simple; bh=wcmb1FEOOBYPubFb7fxU72z0oELyD36jEenfQJlFRws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X008Sj0XxyiIrhTTjXvlchNxag0K2/aL5kLU01E/YUzqywVx7DRyTCTuic59DbItUCGHc81UHkKtNw4UGGz7Dc5k8/fnUdOgsavI46HTIuNXiQd5crEERohIPSiBfyV4RDnZCl+e/8EetjJyFffl8iqzqVUQg+w5r+OGprRqIlM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dgmWqzn/; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dgmWqzn/" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-bc17d39ccd2so6961367a12.3 for ; Wed, 31 Dec 2025 22:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767248728; x=1767853528; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eSmHMTLFLYMPOGJAvXcJayrP61cSU9U9a7LGizFttZk=; b=dgmWqzn/mRrIFOOYPkaBblv58QjWkVrOHog4F7sKFC1Re3T1yLFC876Zbt+k4LULJt nK0dn/4Tfthv7+25UmSCp7L4RK79LgDNXwh+74i/gu6Gx9O+eOoPXxS3569u20EC3zsm 6BhUnNHTgpAfj317G7gUG55VCYvEs/AWoIjc6R161/jBmCHUn+n5D5xMZNfoR9FYrw/+ DE4HNMQobVixmJ4txpSHlj2SO5iokFVAjDMh125c7NfWL13jfNrp2vXVVXkwOwFqElGI rtrRv/GLd9Wy0OuIpmpVghQ8JycFK6SirrHA+KTks8pg7vn5yyIX2lcsBO4RT8KtfXc5 +yUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767248728; x=1767853528; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eSmHMTLFLYMPOGJAvXcJayrP61cSU9U9a7LGizFttZk=; b=rtOHnN6l8jkjDvOKzaB8zSasKGhmkDdoQFLCHTwbhauOyx0VCKWRjdH7WdblryveX2 6yj29IZpsNOXUS49T3JACpp/vqWKby09h+J2kyfpN41zLEoIqMgGh9TdgelhJk2cOFA8 ss6RmeqpSoZ5R8mrbz59pL00NAcoKmYyhB2H5xxWEus4ARGs1gC79CsUoz1k+LOKVK56 Jha7CydoRqEqIuJOND1F8fkZWUd3S52Q3Q4TQl1B+mzCtu5MEuuAduNLLE/aEFfbHVQe T/B83rM4I1kMrxzCDFBpWtSVcOE+BxDq9sYGFyNmhvsg7YFX6XzWSeUoumwJJ+XEd66k OIQg== X-Forwarded-Encrypted: i=1; AJvYcCWWCjgEJOYJLvM0zZXmdMjtlkC3unFRlwwaUhnKUyNDV1ak0K9MqWaw22OaeessiDca2S2ZQc7X6X5f5cg=@vger.kernel.org X-Gm-Message-State: AOJu0YysFDpopJo1UyQR37ZTrtpvEJ6oJUDWF4dSfU3vtFNPP5x/lf1Q HeiZSaD5RH6585Dh21721tvVi0KCos4q7A0371z8BmzdlNjQ9ICKLQsG X-Gm-Gg: AY/fxX444/0jXv6YykxqtWVffOXA5zB3mCm8KktB/uvbrBdVorl+0ImZg6oovhKW5tF AWGdPQaxK+Cp642zPapA+BOyp1Zsx6xX6CqhmBUcSZsrGBZCh6Q91zIspVahJtYlD3x7CM3RjCM j03bH1xs/IppZm7xQpRvweRszkqeMgF6p5Zd2L4v0ljYccCdISBMySwCFykB8O9X9P638SVhVg3 U555DN2upRJBlsJvqpDsnxth/nfL1C0vB11OG9D1MSNzlH1tcagXNThY1DTRNbWbkkNfJ6tTWsu naLSkw6zzCQIgCYHnn6dtR6DX2YAR0VBFl5gADyfClUR8bW07GV1UMFg1bRyqOozWT/5QTfxbcy CHV2aYNdhyhhPh7CK7rSAMiM9b9/UE550yaqvE6AlhULD1ZiAnq3gatvl6Wi6HKnT8KMlio14ZO doQIXo389CJbQBc7X4upFyduV6Z3ucWbWxnJ64kbXOtnOYuzuN6kL82UH5Ah5KLA== X-Google-Smtp-Source: AGHT+IFh5Ad9Hf+dAEhjt2TJYJtae2RoTDAfQaXTCyF1NBh3Q++Urs2DK2jMl3q8CvHI8h3zssad6Q== X-Received: by 2002:a05:7023:907:b0:119:e55a:9c06 with SMTP id a92af1059eb24-121722e89ddmr39548902c88.34.1767248727941; Wed, 31 Dec 2025 22:25:27 -0800 (PST) Received: from zubuntu.home.zacbowling.com ([2001:5a8:60d:bc9:9ebf:dff:fe00:f8f2]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724cfdd0sm144361662c88.4.2025.12.31.22.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 22:25:27 -0800 (PST) From: Zac Bowling To: linux-wireless@vger.kernel.org Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kvalo@kernel.org, lorenzo@kernel.org, nbd@nbd.name, sean.wang@mediatek.com, deren.wu@mediatek.com, ryder.lee@mediatek.com Subject: [PATCH] wifi: mt76: mt7925: add error handling for BSS info MCU command in sta_add Date: Wed, 31 Dec 2025 22:25:24 -0800 Message-ID: <20260101062525.186192-2-zbowling@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260101062525.186192-1-zbowling@gmail.com> References: <20260101062525.186192-1-zbowling@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zac Bowling Check return value of mt7925_mcu_add_bss_info() in mt7925_mac_link_sta_add() and propagate errors to the caller. BSS info must be set up before adding a station record. If this MCU command fails, continuing with station add would leave the firmware in an inconsistent state with a station but no BSS configuration. Reported-by: Zac Bowling Signed-off-by: Zac Bowling --- drivers/net/wireless/mediatek/mt76/mt7925/main.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net= /wireless/mediatek/mt76/mt7925/main.c index d966e5ab50ff..a7e1e673c4bc 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c @@ -899,11 +899,14 @@ static int mt7925_mac_link_sta_add(struct mt76_dev *m= dev, /* should update bss info before STA add */ if (vif->type =3D=3D NL80211_IFTYPE_STATION && !link_sta->sta->tdls) { if (ieee80211_vif_is_mld(vif)) - mt7925_mcu_add_bss_info(&dev->phy, mconf->mt76.ctx, - link_conf, link_sta, link_sta !=3D mlink->pri_link); + ret =3D mt7925_mcu_add_bss_info(&dev->phy, mconf->mt76.ctx, + link_conf, link_sta, + link_sta !=3D mlink->pri_link); else - mt7925_mcu_add_bss_info(&dev->phy, mconf->mt76.ctx, - link_conf, link_sta, false); + ret =3D mt7925_mcu_add_bss_info(&dev->phy, mconf->mt76.ctx, + link_conf, link_sta, false); + if (ret) + return ret; } =20 if (ieee80211_vif_is_mld(vif) && --=20 2.51.0