From nobody Sat Feb 7 18:21:14 2026 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFEE325B662 for ; Wed, 31 Dec 2025 23:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767224799; cv=none; b=Ppu8JNx3CEC0E4Ah7+Rs3ZfQLHJfkC8L/qCpz/QM4ljgVjqcitaqSwIm6amBdqdTAuikqR6lOxnvKCLbo+kPz/m6k+P7FZnAZ3HECFWSBd8lD6DKWQ+bMWV7NS/6U7IsYmYZ6pCI443wa3mTlAb14q7iDuXB0LK715Ox8QLY+o8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767224799; c=relaxed/simple; bh=MWL/eF5/iegDIKlHPGSEIEhG52xmBM34mqqyx/kIhm0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=COuRz30K4Rd2wc/T1e054WRolZZ4hDTfsWmR/wlZE8xSGJkTWHrdEpL3EAf/rqhPfpeUjZWQasHKdMxDLCfJvNyOqWhtTRlCjetWgIH1IHam+MNVGSMXGevEkc8mfTbgJSd49+ailT2SSFInYM7OwUbOYWG2eV8imT6W3fsLby8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZdEmJUjk; arc=none smtp.client-ip=209.85.210.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZdEmJUjk" Received: by mail-ot1-f65.google.com with SMTP id 46e09a7af769-7c6d13986f8so9290434a34.0 for ; Wed, 31 Dec 2025 15:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1767224795; x=1767829595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6lECKX6HYn/UFgYHW3Lep9ULLvDa097/tngl+1jpf04=; b=ZdEmJUjko1si9FrQp6ZuU44K8tQ2QA0zGm58CwGGsij2pQpK1ZizNiZCvNc4/cVLwO EALs4yKtR7AUrlBpsqhMz6cU5X442Be77NZiXV1pMnxjaY8n9cbk2BObXZ0h8dU2KWCC 68MPucIDVmE5yoMRUe3a5bcTXkAAmPkV3F0K0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767224795; x=1767829595; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6lECKX6HYn/UFgYHW3Lep9ULLvDa097/tngl+1jpf04=; b=MmC9U+4n5efdv2Knk6xe4cocTPZXcUoxSgYV+vlSJfp8e32aGyzFd9qRDzg5/IIn7f JE/8sjKZyDcEweAKJG5Vdzfb/uLxCLALQ0ZzfFuGxN0MU+Aw1qgz/noO6Bj8PXB/LOcu YP3eiYP3hHsUTH2Xh2cZsbM4vaZ49v3HPuypumnOWthrCwC2REzgtV9Q774B3IbtQMvK WmyPwFDW3SHeNhu+L02HK1X7sjvbD++hpF/kzRqD0zy/1dsoXFymXTiIgn0Gr3GCbj1p Qo76/EG9g9JD+LP41Ir0m0iAELGL7JN4TdBJTprl9Z3yksGYIZL5mcsRqDaG866BxSo9 2waA== X-Forwarded-Encrypted: i=1; AJvYcCUzK6YcJIbXPGhk32XYUaP6/uWjxuUYzTuWIY0lH5lJuoqc/C/hRuyyrv7B+CdMdM4nD6ICi2Iv8rvsR4o=@vger.kernel.org X-Gm-Message-State: AOJu0YymAR9Uk+42wSmKjJZ3Q6oL5c3MVagi20dWAvC19ZAcYJH7Xm5I Vl6x6z4EMrmP5sjg3lHU1eyfxWTnP+ovfFE7MDgZjUu/BtytJ1w++phNtSYcyCsAv+Q= X-Gm-Gg: AY/fxX4O2nc2xIPNcjzbmz/26ih3NdW38GhlRqWgqs6ukSkP2ZlOyxgOed58oUS/ktB glK261w0vOrKaSQH9a12WaND9WpE6Xwzca+zVOTJyYjZMH7WkhYMwb5cSDsGPcCKhj6JjCen33Q esQUjV5nFHPi/APBLeqo7mv8YpaXe0MwD7KUnew8+tuPdSQ+wqZQoAsxI74E0vbHxqnj/uXOIA6 Z0GtBlXW+DwAQPegS+DyrYDmHD61yEsjZXvInCBRWmyUdhHk4KSySo64ADcFe/uFisj1tnlqc8q rZIaL+xHqgWjvM2k2r5lFL+oqUDGJjAGrVWZaBqGRef/6fuY3R02s5Bq11tcAAm8zYwQQorgxqL XOfu7aDCd9LHgAqMksD/iFRU3hiCnuHxD8yrVaBvGEiJBPVIF2UJ/I8z6iJ53xqa762UkTgGoEV AzEryoKeRE6dZKg20fk7n51fqh6Qf5qt3kS45V X-Google-Smtp-Source: AGHT+IFV2BaGqD0BAddR/5VHavfl8Mnol7saz3Bsj0Em4upn6uAvpba1yOclRSKtiPCjPQk30vcWYg== X-Received: by 2002:a05:6830:2e06:b0:7c7:64f3:690a with SMTP id 46e09a7af769-7cc65eb8a4emr20258833a34.18.1767224795618; Wed, 31 Dec 2025 15:46:35 -0800 (PST) Received: from shuah-framework.internal ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cc667ec367sm25187288a34.23.2025.12.31.15.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 15:46:35 -0800 (PST) From: Shuah Khan To: nbd@nbd.name, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, torvalds@linux-foundation.org, johannes@sipsolutions.net, ebiggers@kernel.org, matthew.schwartz@linux.dev, linux@weissschuh.net Cc: Shuah Khan , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Mario Limonciello Subject: [PATCH] wifi: mt76: Remove blank line after mt792x firmware version dmesg Date: Wed, 31 Dec 2025 16:46:26 -0700 Message-ID: <20251231234627.11867-1-skhan@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" An extra blank line gets printed after printing firmware version because the build date is null terminated. Remove the "\n" from dev_info() calls to print firmware version and build date to fix the problem. Reported-by: Mario Limonciello Signed-off-by: Shuah Khan --- Note: adding discussion threads about revert and simpler fix for this. Mario sent me email offline about being away for bit. Sending the patch since I have it ready before I disappear for New Years. Relevant threads: - Revert for f804a5895ebad2b2d4fb8a3688d2115926e993d5 https://lore.kernel.org/all/20251231035645.5545-1-skhan@linuxfoundation.o= rg/ This patch depends on revert patch. - Discussion abour reverting: https://lore.kernel.org/all/d7f3b00d-beec-41f0-b157-7cfb871f9a46@linuxfou= ndation.org/ - Proposed fix for reverted commit https://lore.kernel.org/all/CABXGCsMeAZyNJ-Axt_CUCXgyieWPV3rrcLpWsveMPT8R= 0YPGnQ@mail.gmail.com/ drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers= /net/wireless/mediatek/mt76/mt76_connac_mcu.c index fba7025ffd3f..0457712286d5 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c @@ -3019,7 +3019,7 @@ int mt76_connac2_load_ram(struct mt76_dev *dev, const= char *fw_wm, } =20 hdr =3D (const void *)(fw->data + fw->size - sizeof(*hdr)); - dev_info(dev->dev, "WM Firmware Version: %.10s, Build Time: %.15s\n", + dev_info(dev->dev, "WM Firmware Version: %.10s, Build Time: %.15s", hdr->fw_ver, hdr->build_date); =20 ret =3D mt76_connac_mcu_send_ram_firmware(dev, hdr, fw->data, false); @@ -3048,7 +3048,7 @@ int mt76_connac2_load_ram(struct mt76_dev *dev, const= char *fw_wm, } =20 hdr =3D (const void *)(fw->data + fw->size - sizeof(*hdr)); - dev_info(dev->dev, "WA Firmware Version: %.10s, Build Time: %.15s\n", + dev_info(dev->dev, "WA Firmware Version: %.10s, Build Time: %.15s", hdr->fw_ver, hdr->build_date); =20 ret =3D mt76_connac_mcu_send_ram_firmware(dev, hdr, fw->data, true); @@ -3124,7 +3124,7 @@ int mt76_connac2_load_patch(struct mt76_dev *dev, con= st char *fw_name) } =20 hdr =3D (const void *)fw->data; - dev_info(dev->dev, "HW/SW Version: 0x%x, Build Time: %.16s\n", + dev_info(dev->dev, "HW/SW Version: 0x%x, Build Time: %.16s", be32_to_cpu(hdr->hw_sw_ver), hdr->build_date); =20 for (i =3D 0; i < be32_to_cpu(hdr->desc.n_region); i++) { --=20 2.51.0