From nobody Sun Feb 8 02:56:08 2026 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17CEA221F1C for ; Wed, 31 Dec 2025 14:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767192111; cv=none; b=GqQ5YcJtn01FuW1dRc3/wUA+5hM9BciBiWnQ5t+KvvSnuuiscz8r2nBEQzzBmtmEWc0a4vJHJ4SJpiMOL2aWD0KLcJtCMz+xnPkopbUkpZ1ayZoPW3ub7JM7BmYWXNH237b8lvDdSaN3WZxbdWAgfgqMM+ytRb+gE0sPrSI4P/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767192111; c=relaxed/simple; bh=JWtZZOP75gkYf9I3WDfHYLZ0J1D4OB5LFiqOaPQ762A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fwKWcWvpykvREKk8tWlwF6xWb6WehGkKSN9VBKtDYK4eHPrXnKfrvBAH47Z/Yt9hwCY4Lga+1ZDonyxiLAarsKzz7BpXEJDcCaNbLF1hvkLppgmO8oawsE9RJn9pbONqQkCZjYxkKjqYRGTsSnK/zNgTsUmTSTHqwQL7A8S8d7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mze1LWNs; arc=none smtp.client-ip=209.85.218.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mze1LWNs" Received: by mail-ej1-f65.google.com with SMTP id a640c23a62f3a-b7277324054so1759039966b.0 for ; Wed, 31 Dec 2025 06:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767192108; x=1767796908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6n3OW5NUfOZx0lkTNPzw5JAKuD6biTxM7bek7HtmsL4=; b=mze1LWNsM0FB1bCCfIv1T1G6KRsy4DPVQu9do7JmhY34per29DmyDj5JGZKC6Xgckc tI08iNswU9PbsBa7nkvfuJHm//45iKOEPXefdILZoDNCfHA5MAYQMUH0we3Aqm/vzGeH BYgtvZAXiQ9PTyl6BKvlxZA4IrABAbNwxe5crJUmHokajTQSig6XPXM8/5fD+mdQQYaV mWhWqa/mWILtQLBuupz4Y8kDqn0Szq/9D/UykVLR87QFU2TSfEp7126hIPcZkT9EULrO GrvPAXg8S96xOshfWyeKKK++904ndqsiRlUA8VpfGzWlKnWxoeXFAHAF7YtOaEw5d9U/ XoMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767192108; x=1767796908; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6n3OW5NUfOZx0lkTNPzw5JAKuD6biTxM7bek7HtmsL4=; b=C1UtOFzU+uvIQTVoVLKvEK5CQkwdIlM1N6Y0fhSXo9U4UC3qmU29NE1rhFxHJSPB5v 0OU3G7eRRE1mQvRcEoJJ1IzO1YXziXvRoPa69fkW2wkF4lA2M7tVqlZ4XYO8YZDcg1Sj Se9phqC+Nh6vVg7S/KK9YE+NtRZgA6jh0dU6rcK/7MRU23fCkIEvhSRJY3tmoS0+p+m6 S5YJAIrsuddnZLG1ULvfJRIoV+cGXZfqdXrIc3HUNTKUWd58yKtx1TBjexUDvEVX21U0 NofJrCgrKZESbT/fDN2mBN0XOtIjhjMG179k8V+X8E6S1bZEUfPC3Bm7OohnAkSNOfjn dCNQ== X-Forwarded-Encrypted: i=1; AJvYcCUQDDAeW9J9925IecCT6CMVg6chdyGFpxHJDOd+6FYVEwLxzYlxrdslspHHjW7jhZQJcbDzB9LlzdmB4uM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0qORJvOIeZ1JDUyOCm1SvqPJTfdhlRO45rjLFAdsLwhP31gxK Cal4VIL1Ns/JJAarwCAqDfWvXhRxbTYdv8zKKycmStnKLJ88U6Jbby2w X-Gm-Gg: AY/fxX5vKcwDVL4TPfjb2bsT39gEbrg/EuF6Vn+JMDwd/GgmCTWwKJkRWSRyq3xsr9F hM8ItfbeItxABakmnEz+vYkxipnAmUeyhFrtA6JYea2StH6yKS4JS18CB81A+bplShobFDWzqRv 3HkHaaNHSzOJa3AxKO2kPKzX9EORGRLRsE58/C51WIC+OEs6dicaK9vJiGClujWGIiTE/51OABK aJbXHecGU5aCUghmz3dEit7ktNfrCDJ8LfHQwycsyKA/HHcemo4E11GOPB2AKxhXewQpcSbuhps sMAg9S6rKH4emcWuon04Xxlk2jJaOa90HzkPA82Nn7H2Td0N8x+ZwuyWb4iVfYab48rz+6jLWVt LGhjM2Obwy8kYl0xauKnVoumWkiIYD5sOiThX8pWxM/z6GLyK6EL8YJffATrsK36nNmszIFgryD GHf3bc4UNu2vReF0s= X-Google-Smtp-Source: AGHT+IEUPzBdPCEuEHiEfsb+kEeP0YSRVpplBMnvJmaPjfjYKXuuxhE3L0J+JXeCfF8KIokhLTjB0w== X-Received: by 2002:a17:907:984:b0:b72:3765:eda9 with SMTP id a640c23a62f3a-b8037256c76mr3755521366b.60.1767192108066; Wed, 31 Dec 2025 06:41:48 -0800 (PST) Received: from osama.. ([2a02:908:1b4:dac0:75b2:7ca6:1e15:d2e6]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0cc52sm3909242066b.52.2025.12.31.06.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 06:41:47 -0800 (PST) From: Osama Abdelkader To: Andy Yan Cc: Osama Abdelkader , stable@vger.kernel.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm/bridge: synopsys: dw-dp: return when attach bridge fail Date: Wed, 31 Dec 2025 15:41:14 +0100 Message-ID: <20251231144115.65968-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When drm_bridge_attach() fails, the function should return an error instead of continuing execution. Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support = library") Cc: stable@vger.kernel.org Signed-off-by: Osama Abdelkader --- v2: use concise error message add Fixes and Cc tags --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/brid= ge/synopsys/dw-dp.c index 82aaf74e1bc0..bc311a596dff 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -2063,7 +2063,7 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct d= rm_encoder *encoder, =20 ret =3D drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CON= NECTOR); if (ret) - dev_err_probe(dev, ret, "Failed to attach bridge\n"); + return ERR_PTR(dev_err_probe(dev, ret, "Failed to attach bridge\n")); =20 dw_dp_init_hw(dp); =20 --=20 2.43.0