From nobody Sun Feb 8 05:59:09 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB17A30FC2C for ; Wed, 31 Dec 2025 12:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767184855; cv=none; b=O+gSKVrD0nH4mQFwaxuICCtAvnNECFVmEv1x2XaL6ra+Mpu8T/L6cgdhKHYB4DOtIoni8WygXKVswkczWymASI195nyue9s7itBSFhyfN0FgDVLZx+PgxeKmp1ZGxWo634jmc7xOFJtp2u9HYA1VlmBmOJHhOjZsuLEYeG+reCU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767184855; c=relaxed/simple; bh=bpc64xTes/6DSqbbfKw7utwCw290qXBNArmOt6zd9U8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z83vkr8niwwLtHHRkRwFhoRazojDlKWbSI6rhOOfFQtJ+vkt5wNgVGZatwPLZ1iJ5ks1PPSnvx1Zls7L0feJfGC4gToCLHUOs9g4N5cK2doIFpOOfIjldQW4EPIkmZvZoEaTJtO23+rlDlA98zCCwzDoQsPNMIT/4gtC6Hj916s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VbcwKfHj; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VbcwKfHj" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-79045634f45so18548517b3.1 for ; Wed, 31 Dec 2025 04:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767184852; x=1767789652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MMZ9zgZdVr3pbZQDIH7NpdxYpjnjDbphEYD5vgBclQo=; b=VbcwKfHjmJPyojiLD2Ehe76AtAOZ0xAOszb0e8C3Npgqv2EOB1vNL0VU5wMSzxqqoS aa31X+bxkM8AQhNNvcejoYiFuG2dlYCA83aPGnXj7y9QBQcUDMhwpVcv+YBsf3XHzFfq xVHWm0XbtfI2yr1DtUrywH5yKwY8nWBHl0QtcGTI92R0rWsifUkTrya6z01s6SR4Ovit q/Z77f4AglJoOzr+q9ARFgYHIO0X5zzWWtfeFnh+3mhBVrEt/OE6PJ6u0P4iPIRFu1tr 5AoHxAJcbHhXoN6ttYiORUxrflhPh3uq6s/iJ+/uh3VbffmXRi5XDbDuIZ7fot+3/VfX xC5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767184852; x=1767789652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MMZ9zgZdVr3pbZQDIH7NpdxYpjnjDbphEYD5vgBclQo=; b=El68tNNMJ7v8f0uz7J9JSVbS7jWYKJcM7cQzEuoXolmrjAcc0GZpWb1QfoY2GbWKSj ukYkB6Ro+RRRF+zxrR+jm5YkYBiNfhFGtWnOztfRwWxsvkPFDg0agHUhtWhEve+KMtVM cgXWh/DtGA2ldj99DAsELWthKLNsGPRISoS0IjaFFn0Vh7YgZeqybolKxMugqnfrqHYt wsLi+ghXpO5lDwjemfXJQmX7KoKHnmQ0yuCm2W6EWJi/3A8J5vUEN6y3Je7niZOO0mg0 GEJANS3HZIhdE6kQehZCfX/WOTlXDFFXGhx6m6sp5OhecNLqBZyhL44UvWlzl+xQ3L3b 4jAA== X-Forwarded-Encrypted: i=1; AJvYcCWWWBVPE8lVBQd+70RCcFrVO9BLo28dXvabpQwIf2zHatKjyb1m8YKZXA27VTkFapd/S7S3giR7ICvx+qk=@vger.kernel.org X-Gm-Message-State: AOJu0YxT1OhEuYHA3x4XWTHA91XESXqCxL6sRR1gqs5e/zTAo4wOSXQA V4dQH2am9p7bA3s/1IFtb/felTMBL2TBN1DSf+cbXX6n5OdHpRKSEU+T X-Gm-Gg: AY/fxX6oxzwoVOIA5sTpzw91aRl5y5/rRE2HypY9ByoT0WJKM8EZDNTOwicvk4Kbtt0 NVGntcT2umm0tyRMutYRz0k2yB/iX00HdwgG0EyFvM78BdpiN1wZHycxi7PbK+wrKdmf3WES7pW 4SDSxYHs5Z3iJmn2EL8NwS7NMlqcKaKqO8sySCPwmrQdrZRqCqvDkWVpTyJSHguhjs7VMdYCYjH KpWdhSOGbI3frUeZap9UjE84ZouJutJqqGtLraqn9Yoo+GZEydspthcrTfS5LqN8qlSPtqppmTi IOBQeGaFrplmn3Ww9VQXfpCtbJKvjbC6+20nWjICoiubxUIQsMRHhl/lS0bISJ1mavWjtvkU8gm Ey3DWZ0Nj17o3LPBZOv7ObG/PnX6fqRQ8WALEDMduNGGt7+hdFnbdJrGXhrZ+0THk6qggwi0VVw PZiCfp07cSnkG8lT3LoNgiFBFhGCTtpebDVXO9nVv57ZYXFdIXxHf5Sx9EGnzT2y5Gx9GTrTbrm zT3vok= X-Google-Smtp-Source: AGHT+IFrXQD2q7MyIixphdEVMQQUK0nDKmR0bPg/g+JbhcBEInhr1pMYlAHk+OMHNNhDorAD0CekqQ== X-Received: by 2002:a05:690e:418d:b0:644:2c33:42d2 with SMTP id 956f58d0204a3-6466a85b6c3mr26405383d50.23.1767184851830; Wed, 31 Dec 2025 04:40:51 -0800 (PST) Received: from ubuntu-linux-2404.. (108-214-96-168.lightspeed.sntcca.sbcglobal.net. [108.214.96.168]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78fb43b2690sm137555257b3.18.2025.12.31.04.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 04:40:51 -0800 (PST) From: Sun Jian To: luca.ceresoli@bootlin.com Cc: linux-staging@lists.linux.dev, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, mchehab@kernel.org, linux-tegra@vger.kernel.org, linux-media@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Sun Jian Subject: [PATCH v2 1/2] staging: media: tegra-video: move tegra210_csi_soc declaration to csi.h Date: Wed, 31 Dec 2025 20:39:54 +0800 Message-ID: <20251231123955.277384-2-sun.jian.kdev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251231123955.277384-1-sun.jian.kdev@gmail.com> References: <20251229070125.98741-1-sun.jian.kdev@gmail.com> <20251231123955.277384-1-sun.jian.kdev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sparse warns that tegra210_csi_soc is not declared in tegra210.c. The symbol is referenced from csi.c, so it must remain global. Move the declaration to csi.h so users see it via the header and avoid extern declarations in .c files. SPARSE: drivers/staging/media/tegra-video/tegra210.c:1214:28: warning: symb= ol 'tegra210_csi_soc' was not declared. Should it be static? No functional change intended. Link: https://lore.kernel.org/linux-staging/DFCAOR6T9DPE.2MOL0K9O3HP1N@boot= lin.com/T/ Suggested-by: Luca Ceresoli Signed-off-by: Sun Jian Reviewed-by: Luca Ceresoli Tested-by: Luca Ceresoli # build tested --- drivers/staging/media/tegra-video/csi.c | 4 ---- drivers/staging/media/tegra-video/csi.h | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/tegra-video/csi.c b/drivers/staging/medi= a/tegra-video/csi.c index 604185c00a1a..3c3f6e3fd1ec 100644 --- a/drivers/staging/media/tegra-video/csi.c +++ b/drivers/staging/media/tegra-video/csi.c @@ -835,10 +835,6 @@ static void tegra_csi_remove(struct platform_device *p= dev) pm_runtime_disable(&pdev->dev); } =20 -#if defined(CONFIG_ARCH_TEGRA_210_SOC) -extern const struct tegra_csi_soc tegra210_csi_soc; -#endif - static const struct of_device_id tegra_csi_of_id_table[] =3D { #if defined(CONFIG_ARCH_TEGRA_210_SOC) { .compatible =3D "nvidia,tegra210-csi", .data =3D &tegra210_csi_soc }, diff --git a/drivers/staging/media/tegra-video/csi.h b/drivers/staging/medi= a/tegra-video/csi.h index 3e6e5ee1bb1e..609c5952e050 100644 --- a/drivers/staging/media/tegra-video/csi.h +++ b/drivers/staging/media/tegra-video/csi.h @@ -130,6 +130,10 @@ struct tegra_csi_soc { unsigned int tpg_frmrate_table_size; }; =20 +#if defined(CONFIG_ARCH_TEGRA_210_SOC) +extern const struct tegra_csi_soc tegra210_csi_soc; +#endif + /** * struct tegra_csi - NVIDIA Tegra CSI device structure * --=20 2.43.0 From nobody Sun Feb 8 05:59:09 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 207CB86352 for ; Wed, 31 Dec 2025 12:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767184868; cv=none; b=mNXtsO/sxjyjGSE/ljRBWIlqdfoMe+f4p/rtihZPVzXvziky2mTKpqS6c/DvdVXnbaEmva7Zyb6vJ6TFubq/w6nmhp1rZFxBx6fA9AjsDvA6xJib6rwKKyCPf7ukZ9i4s5U9r86ZcSAYnffY7qvoHYdEzVFM1GA9IDtZh0D6SPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767184868; c=relaxed/simple; bh=DnZtX8FMWL3xUvEx9ZwEljqS0Zqi/7F7spPDPYn9XhI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mvwrNdMkW+t6NyLbPEbrZz/VY+4+mnGyMlXoaueU1ohO9/kna99i+4nzNpvnjuxfY1EiQROp8eXbXW9X4dxx8SPgUERbiNiZM5EasVzZkY1/AqstM/of4C6S22lFpuLuD5Umo6I1Y9EjUk/c/LXskIIfSLvC+u2sV54PQYNFHXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FPWBGUW/; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FPWBGUW/" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-78c6a53187dso82050337b3.2 for ; Wed, 31 Dec 2025 04:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767184863; x=1767789663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ASzrwnWe1LPCoc7Xrbs0jLsSOmeBARD1j4LP7Uc0+4E=; b=FPWBGUW/DWr+I0SRVc0J57YjydlAoqbCoP9CaX3NWNLMaEjrU+8JHydrcMvPeJHQfn vU8jfx48e2UWzvFJOm3lGqdhHUbJ59+VaavKwLihWV5TNqkkHglWEdk6TR/Gnfnvkzxi s8vIFCLAAWBDbwH8L04WcP1j3/qFvj7bbYcpg+4jpQQ3Uzo+weYvboFahvrlsNrfRUmB 5QWOKabGfNU3SJABnB5ymawv/PifpXoKqp7f7ZPUVa8daAf8/FCk0hzfH6XzlSI9FzBp bp+SFxEplM6/YM89WxAdCPtUQziTEGEzgw26t4HdLcYX8yfRrOIRxedPBYx8QFUiawiP lrjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767184863; x=1767789663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ASzrwnWe1LPCoc7Xrbs0jLsSOmeBARD1j4LP7Uc0+4E=; b=u0YQ6Gso39Ni+CyuNeftTvFzb3oeRVpOKXTg25jdtGBrtv961XbAlPByFNLM0lv0YN J9kgY/pLEX/YzLypYRwus4XKb3J3ZbU9wIyzFuvnsiGdEfnU3GHCEgJ89WiZycsMQ7KM tE5AzSJ5juX1KOX6YlH4zGdfJzL7pmn0cn/Vtty8k4WdYhPvGsumDyzd/mleWgmi8eSV KM/UbthVDcpdMVhee+8o99OdEhpCEePQcHF/UPnxe5V3myWWYg1ybYYTPPddoZ2inxyh CkYLNPMCVB8KVL7zNFiSiagOW3SumaH9X6wv2PufPkafld4GR/bi/y3Z38bQf6fxDAc8 7C3w== X-Forwarded-Encrypted: i=1; AJvYcCXwJAgrGGE+j6C14QGCSYcTUixZXt6+TOjbAcj9NWeY2OEuS3TTesCs4ztto4RLv2YEWxD6m3N+U/TrtOE=@vger.kernel.org X-Gm-Message-State: AOJu0YzMb+ZdhyUAMnGZUxLJfN8DDD7JrCLkRBM/09DCtAhZopMLOeg+ YwweMNbe/LI2NHS83VouJrTVSgMjTdMbv6nNIQdvP78/AmzQq6iW/AZF X-Gm-Gg: AY/fxX6eO0109qWZGpdawXlxgbKMSOWIYtZCcSSKZqZVkgLwP0YSKLcmkhxcOnxlxzc fksynoaPWlaaimxw7mlZnH2/xeGZ8yMfx0zkVlWqJFdGcxPgZ5D1jV8EvjyuXx0jNsrcIB07bvl r0qC6doYE+ia52gprz9/+nLJdIdj+DxlPEwqt61FBIDF2T6JnQQrXp6e/C6gAXOaHC8Ij8ZO0Jm vD+2nwep09SxoG7+qAMsQwhojysRsvKGWVfiOEDLF0PGLko1/bXSAji66rQwBx595vUaQKE8XOt kIIXU9k17sG6M9uVtafWlSPkuXCf2HE9qxkJ+w/a22CsO3cnQSjdRuixaEzde+H+hWxAF2Bbszm Pitfd1c6rvxx3zsR77QRugov2yBEg/mcIkoNA54dHjbn1yPMXPBTCIvj8pw22nuOSC0bD6zd0ui Tl7ZNi3EzVbXRi2Yh47fiYF1ycUuwyAwvTxRqxNOLgwDmbAbiSDb2RdyjNCvzmTI5OsAjnjVn7T k7XBQw= X-Google-Smtp-Source: AGHT+IEFy0/xAx2AeDnYaJrJhM8NAx65XdkRXLMsI+QKt1RJUDYhZDfCV41A4Srcws0GZCL6Gfr8LA== X-Received: by 2002:a05:690c:6307:b0:786:a3fa:cb92 with SMTP id 00721157ae682-78fb3ec89b0mr240437437b3.9.1767184863093; Wed, 31 Dec 2025 04:41:03 -0800 (PST) Received: from ubuntu-linux-2404.. (108-214-96-168.lightspeed.sntcca.sbcglobal.net. [108.214.96.168]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78fb43b2690sm137555257b3.18.2025.12.31.04.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 04:41:02 -0800 (PST) From: Sun Jian To: luca.ceresoli@bootlin.com Cc: linux-staging@lists.linux.dev, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, mchehab@kernel.org, linux-tegra@vger.kernel.org, linux-media@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Sun Jian Subject: [PATCH v2 2/2] staging: media: tegra-video: move tegra20_vip_soc declaration to vip.h Date: Wed, 31 Dec 2025 20:39:55 +0800 Message-ID: <20251231123955.277384-3-sun.jian.kdev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251231123955.277384-1-sun.jian.kdev@gmail.com> References: <20251229070125.98741-1-sun.jian.kdev@gmail.com> <20251231123955.277384-1-sun.jian.kdev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" tegra20_vip_soc is shared across translation units but is currently declared via an extern in vip.c. Move the declaration to vip.h so users get it via the header and we avoid extern declarations in .c files, matching the pattern already used by tegra20_vi_soc and tegra210_vi_soc. Link: https://lore.kernel.org/linux-staging/DFCAOR6T9DPE.2MOL0K9O3HP1N@boot= lin.com/T/ Suggested-by: Luca Ceresoli Signed-off-by: Sun Jian Reviewed-by: Luca Ceresoli Tested-by: Luca Ceresoli # build tested --- drivers/staging/media/tegra-video/vip.c | 4 ---- drivers/staging/media/tegra-video/vip.h | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/tegra-video/vip.c b/drivers/staging/medi= a/tegra-video/vip.c index 5ec717f3afd5..80cd3b113125 100644 --- a/drivers/staging/media/tegra-video/vip.c +++ b/drivers/staging/media/tegra-video/vip.c @@ -263,10 +263,6 @@ static void tegra_vip_remove(struct platform_device *p= dev) pm_runtime_disable(&pdev->dev); } =20 -#if defined(CONFIG_ARCH_TEGRA_2x_SOC) -extern const struct tegra_vip_soc tegra20_vip_soc; -#endif - static const struct of_device_id tegra_vip_of_id_table[] =3D { #if defined(CONFIG_ARCH_TEGRA_2x_SOC) { .compatible =3D "nvidia,tegra20-vip", .data =3D &tegra20_vip_soc }, diff --git a/drivers/staging/media/tegra-video/vip.h b/drivers/staging/medi= a/tegra-video/vip.h index 32ceaaccbba2..fdded00447e4 100644 --- a/drivers/staging/media/tegra-video/vip.h +++ b/drivers/staging/media/tegra-video/vip.h @@ -50,6 +50,10 @@ struct tegra_vip_soc { const struct tegra_vip_ops *ops; }; =20 +#if defined(CONFIG_ARCH_TEGRA_2x_SOC) +extern const struct tegra_vip_soc tegra20_vip_soc; +#endif + /** * struct tegra_vip - NVIDIA Tegra VIP device structure * --=20 2.43.0