From nobody Sat Feb 7 06:13:50 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01E722DC77B for ; Wed, 31 Dec 2025 07:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767167207; cv=none; b=syEeJV9CUuLotvtAQp4qdf4I6CLpnvF2pJDk2KSsueAtgknxsBCy9/hx9t08Ge7U7QwZt37bOcl9jWOAY9D9rIzFK0CWkBohO4gOup/YjeJ+dgrZdS1teyiSu9Dh4of9HREbfpSYmVhLJcZZXUEd7/2mwHNCAguottaNAACjFgI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767167207; c=relaxed/simple; bh=S+QErFLPAsEmZdXL2ZR61ZlxoWFp4vGhaMp4rKO0qdw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cRG/qX7Tdvjzw+F7lvIOkaAlVaNNHaopaAgCQGhTZKTHXCTkOrHbv16CRVl1Dh8jGM6GTa3T8j82IcFSw4TRm6OoiBXHEzzbBFT1x4/xZJ5g64MQXYd0WyjCih5GEVCZNEk3xnW9t1A8D8Cxfip4xLkvui0XmF42BN7d7A0PqAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cloudlinux.com; spf=pass smtp.mailfrom=cloudlinux.com; dkim=pass (2048-bit key) header.d=cloudlinux.com header.i=@cloudlinux.com header.b=RhQSeVNl; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cloudlinux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudlinux.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudlinux.com header.i=@cloudlinux.com header.b="RhQSeVNl" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa4so8223229f8f.1 for ; Tue, 30 Dec 2025 23:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudlinux.com; s=google; t=1767167202; x=1767772002; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rcK5OWb8lQWwyYY1U8hmUdtzkD50MwR2w8DVGyTAGVA=; b=RhQSeVNlJSug8r8qSJVYFzGN9ytpFGmyyN147pxUPNV3fm/S+QxmzQvF194YqIEXep janSo3sZB+/4Qh09Vd8rO6CBrcO3yh8aSr8On7NdH750U+EChQPmhYO29/0D9sPHxHDu cq0dtVwaokMaRL+krmoT3hykBaB0bOTOFLfy789nKkquTtVqLgbaiXk1zTeCBVKjmKX4 E8oJ4eFQK0SF8C7T7+ewChaYNLRjPc/n3JPML15IGLUq4ERy/EzAB+LvuNPeGXXtokBu oweQlPlfb0/yKaBNvJ4F5wUCOqIcHemAShOSLtY79nbvJtFz6WC8UvNDd5x0s5zWSuwz F5zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767167202; x=1767772002; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rcK5OWb8lQWwyYY1U8hmUdtzkD50MwR2w8DVGyTAGVA=; b=J6/pZ3XVYi6tm9EoMJzVWDEszsQfvKurajzyHoIBwzqNsCa5PWCcIaIa7V1miY0PUY 7JbWvq304QNsMgGQz4qio22Q52b71mvwTKrtSTcc2GISIhOx7nrwR7Pe96wx+kUzONQT ot4tnPgpzxwrG++eVLnwJcIk/FzxeXGd6LkOQZ4aV78N6+AxDU2k7Z93DyaCWJxIXOx3 /cZY78HFhv7OcQPTTg33vtMXLHGmUQboF1ELr4ahpHNFfBvd1LI5FY9OGNvKYHqcPsyj hRpS/Oabhf/Q8ZxuIFJn+my+xQWyK37H5aBTXVD9+qWlMsDobx6irpZ6nd6sUQXVcRWR MoPA== X-Forwarded-Encrypted: i=1; AJvYcCXloPyQ0XD+AABC0uDNLE7OhbaIctN0PNSBcXDyg4l8njbUlfWouzoIwaUl/JQw12TSlWxjc/Svtg4Spp0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8ixoH+rPetUpi62MwSTNXyU3P4Lk1o/XEZwpo4irv1BwVi5sG 4Vn8adJY3lAP4U1kBBOpjuFBQRNitOBZaMu9jzh1CrQ/RUgsa8idmWrJnWAN9/AFJ00= X-Gm-Gg: AY/fxX72jsh/gDdGU/x8FdIsDgC7ij2fJ03boj/2vyIHnZcLDPZVNMeo1/TfsGXtq2G PWpIj8oCQc471Ix0FfUoLqVq7PmQA9pdUGbP4HmxnlcP9DIiNUa97Cx34c1xh3jCNcwyeEcHw32 pXAzNNA7KbuD4hL3L5/nZQVwNIas5Na1IoDJUX1JGp0dy3JR1Z6WKoA4UlA/o1H5ixnYyUBB/5N BrufBYlHC14+Om6C91lrA8atj1rO0D3cBlcRS6uAV3zmQImqmyBQVJcX4MmEg7HqMCS1JyfTLT8 Em7vHaaVTYsV1Sdu8q2pOtI+5ekboUHZ+cX4P+sSm1vxr/cN2iadfqbIZBs4CYHN02oFwqjhP7w tOUxSKfohV0wrDX12aBp6zcN3ZpPyZ046PjUrDrddQINGh65FAHiSKNvdDfxj38OKSXzSYhMNln KTowBSf7l1JsO8awcEBnF4K5rrF0ZK6co= X-Google-Smtp-Source: AGHT+IHgPCTbrZ8SuyzVrzffH6KxGgE30rE6DKiN8ff7CAf5R8oHwTDdgYTozgvOKrd776lNlz+n6g== X-Received: by 2002:a05:6000:2c06:b0:431:864:d48f with SMTP id ffacd0b85a97d-4324e4d5029mr46915304f8f.27.1767167202241; Tue, 30 Dec 2025 23:46:42 -0800 (PST) Received: from fedora.cloudlinux.com ([94.204.137.252]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b36fsm72315953f8f.5.2025.12.30.23.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 23:46:41 -0800 (PST) From: Pavel Butsykin To: hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com Cc: chengming.zhou@linux.dev, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] mm/zswap: fix error pointer free in zswap_cpu_comp_prepare() Date: Wed, 31 Dec 2025 11:46:38 +0400 Message-ID: <20251231074638.2564302-1-pbutsykin@cloudlinux.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" crypto_alloc_acomp_node() may return ERR_PTR(), but the fail path checks only for NULL and can pass an error pointer to crypto_free_acomp(). Use IS_ERR_OR_NULL() to only free valid acomp instances. Fixes: 779b9955f643 ("mm: zswap: move allocations during CPU init outside t= he lock") Cc: stable@vger.kernel.org Signed-off-by: Pavel Butsykin Acked-by: Nhat Pham Acked-by: Yosry Ahmed Reviewed-by: SeongJae Park --- mm/zswap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zswap.c b/mm/zswap.c index 5d0f8b13a958..ac9b7a60736b 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -787,7 +787,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, str= uct hlist_node *node) return 0; =20 fail: - if (acomp) + if (!IS_ERR_OR_NULL(acomp)) crypto_free_acomp(acomp); kfree(buffer); return ret; --=20 2.52.0