From nobody Sat Feb 7 06:49:08 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA90026561D; Wed, 31 Dec 2025 06:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767161799; cv=none; b=uLcXmYaR8w2Q9HqC2XzYOqAQv9IiQI9FeXQ2EBoNBMLkkl+cRXkh+bc/y/6tNpbfufPPGM0nDXog2qEdPNKarXh1tNhYF6kn0zuMZSVah3k5pxDYu+47hDFMDCbQQBbzVnMNi9pOeDTICH1A6uwBxCzD2nJcwLNvqdP9S/T8thQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767161799; c=relaxed/simple; bh=w8YQQYAmqAO3aKMa5LZl+18WRudsUTGz5zj8OinF7hA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X7OL6S90LQPrvUM+Vc8P2dCFa5VcbAvptgu7M+mqv7mB81Ax5cB57XTYVw7JZ4qnppaN4EyIg6xXT3AMG6oBLD2YQVk+UaloRRRvfd8n50LRh+31PClFXRgByzWHk9RqmPQmKRNG/OaAktzjCj3+cMQOwUYH8rKupEpQxgKasJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=Rrhwc3gF; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Rrhwc3gF" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BV1oM931662709; Wed, 31 Dec 2025 06:16:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=S6V2X SjS3u9fkY7zSgFeEATXBM+YWwU4T9wYCUUs3ks=; b=Rrhwc3gFQXnLD6BZtsgC2 KPjvGhHWBRtI0Y8NRS20SzKgsKn762OUvqIzFnZOYYljkSxYQT+dBl/lb0yTYy42 9RAFM56FUBilqk90ttLkpCtZk2icTTKHPL2C4TqI3d0DeqdQx4m+1jBogSMgXZcx 5rw1XVIZ7YQRJqIY+/BURsYWOB5FJ/+MKjeY4wKomFt6szBIgZevUgn1pub9UBG4 T93OL/m3reQ8KxKWXDv59bb2vNEBhb4QZBvO91cLixXHGLKTbUg+sYQKUoqnFK+v DnOWANgTFQGeyxS/3dXLqWGkeckq8tQpqql7diOt4iQAQniG6G08tXvbrFc/G/P+ A== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4ba7gabe01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Dec 2025 06:16:19 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5BV26Dph013574; Wed, 31 Dec 2025 06:16:18 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4ba5w8c7qg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Dec 2025 06:16:18 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 5BV6GE8Y009609; Wed, 31 Dec 2025 06:16:17 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4ba5w8c7mt-2; Wed, 31 Dec 2025 06:16:17 +0000 From: Harshit Mogalapalli To: zohar@linux.ibm.com, akpm@linux-foundation.org Cc: ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, graf@amazon.com, guoweikang.kernel@gmail.com, harshit.m.mogalapalli@oracle.com, henry.willard@oracle.com, hpa@zytor.com, jbohac@suse.cz, joel.granados@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, noodles@fb.com, paul.x.webb@oracle.com, rppt@kernel.org, sohil.mehta@intel.com, sourabhjain@linux.ibm.com, stable@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, yifei.l.liu@oracle.com Subject: [PATCH v3 1/3] ima: verify the previous kernel's IMA buffer lies in addressable RAM Date: Tue, 30 Dec 2025 22:16:07 -0800 Message-ID: <20251231061609.907170-2-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251231061609.907170-1-harshit.m.mogalapalli@oracle.com> References: <20251231061609.907170-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-31_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2512120000 definitions=main-2512310052 X-Proofpoint-ORIG-GUID: k3AHxBCUQlqLreu_zodw7F152KXBxmF5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMxMDA1MiBTYWx0ZWRfXzODjqK2i7DBj w1o7KXyR2nInxIZi9kGbOCuOB2nF3DmNZeP6OdS8NNi8CKRojIbl9vxINj7YsERTWMzbjj8YKd8 VW7nGIiyvXqI+3x8wg15WLSuMActUbLm5i1o4JvcM1gNbTzgqAgxEXSzGAnK1ogKJcJdq0j+qFx HBbrbs0hb/3NuMqiVtTA4wK8qfpBNgbw9gXxBaiaVkKKGa2Nk8XiiCIqA6rkE38c1s+NPrQ57Kw f9htbISavuy0I6z5Qn0dId5nnl29S9rel2R8DuP5FEkDOAEclGEczNRCjkIPX7gtzBpRaLsfdi1 8gGl9kQjl9qXU1IFAzHaTEYIzrkX7WmKnu2av16BDO8gDV37JYSmoCzCa5O5GHkj4qguAujLk+F 6MWCb6q+Wqy7EMMMXD5q6aSbQSArWonAjsmg4onolDqJRjuuDI9Fa8zV9DZKzWxNeXoUikmBUx9 FPlQC0zwywoQqDDswMw== X-Authority-Analysis: v=2.4 cv=T9eBjvKQ c=1 sm=1 tr=0 ts=6954bfb3 b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=jkZM71ibJ-iyurowFaMA:9 X-Proofpoint-GUID: k3AHxBCUQlqLreu_zodw7F152KXBxmF5 Content-Type: text/plain; charset="utf-8" When the second-stage kernel is booted with a limiting command line (e.g. "mem=3D"), the IMA measurement buffer handed over from the previous kernel may fall outside the addressable RAM of the new kernel. Accessing such a buffer can fault during early restore. Introduce a small generic helper, ima_validate_range(), which verifies that a physical [start, end] range for the previous-kernel IMA buffer lies within addressable memory: - On x86, use pfn_range_is_mapped(). - On OF based architectures, use page_is_ram(). Cc: stable@vger.kernel.org Signed-off-by: Harshit Mogalapalli Reviewed-by: Mimi Zohar --- v2->v3: Update subject to exactly describe the patch [ Suggested by Mimi Zohar] --- include/linux/ima.h | 1 + security/integrity/ima/ima_kexec.c | 35 ++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/include/linux/ima.h b/include/linux/ima.h index 8e29cb4e6a01..abf8923f8fc5 100644 --- a/include/linux/ima.h +++ b/include/linux/ima.h @@ -69,6 +69,7 @@ static inline int ima_measure_critical_data(const char *e= vent_label, #ifdef CONFIG_HAVE_IMA_KEXEC int __init ima_free_kexec_buffer(void); int __init ima_get_kexec_buffer(void **addr, size_t *size); +int ima_validate_range(phys_addr_t phys, size_t size); #endif =20 #ifdef CONFIG_IMA_SECURE_AND_OR_TRUSTED_BOOT diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/im= a_kexec.c index 7362f68f2d8b..8b24e3312ea0 100644 --- a/security/integrity/ima/ima_kexec.c +++ b/security/integrity/ima/ima_kexec.c @@ -12,6 +12,8 @@ #include #include #include +#include +#include #include #include #include "ima.h" @@ -296,3 +298,36 @@ void __init ima_load_kexec_buffer(void) pr_debug("Error restoring the measurement list: %d\n", rc); } } + +/* + * ima_validate_range - verify a physical buffer lies in addressable RAM + * @phys: physical start address of the buffer from previous kernel + * @size: size of the buffer + * + * On success return 0. On failure returns -EINVAL so callers can skip + * restoring. + */ +int ima_validate_range(phys_addr_t phys, size_t size) +{ + unsigned long start_pfn, end_pfn; + phys_addr_t end_phys; + + if (check_add_overflow(phys, (phys_addr_t)size - 1, &end_phys)) + return -EINVAL; + + start_pfn =3D PHYS_PFN(phys); + end_pfn =3D PHYS_PFN(end_phys); + +#ifdef CONFIG_X86 + if (!pfn_range_is_mapped(start_pfn, end_pfn)) +#else + if (!page_is_ram(start_pfn) || !page_is_ram(end_pfn)) +#endif + { + pr_warn("IMA: previous kernel measurement buffer %pa (size 0x%zx) lies o= utside available memory\n", + &phys, size); + return -EINVAL; + } + + return 0; +} --=20 2.50.1 From nobody Sat Feb 7 06:49:08 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA88B221DB5; Wed, 31 Dec 2025 06:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767161799; cv=none; b=SHlE3H+HG0VBRMyNyE19+uNMz9WByH2mfucjLSXWPOcwPak0ThwHmMVzMs12PGBZakzJG/rHdA38iQKB5vPeLgWZOGY7aslkyOs3Lh11Wm+c9hQ5x/DcenzgIFoFpa8ZK8jCkmXcWcnfZY3BpFyGLvDvrqbDSPMP7Mc2j7O7ZyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767161799; c=relaxed/simple; bh=mVtPOFCGMGNHE0TVNVloYDBmH5WN0nZnLCbGzaP5jQI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HLcjr0W9ZfAPSmP1qctJBZk5PoWawRg7CASw5D74r1RdkerNus4yaZ9A6jT/75aAPIlaXpMkc9y1d6zGT/Gpgi5ajNEH079OJUOxGSziY90tyfUxxpW43XnxCPQAHuBBPA8s/wsh/aIJkrW1hFC7SHcXKv0oqA8fXec+gLc02W8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=HTSGSnV3; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="HTSGSnV3" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BV1uasH1217347; Wed, 31 Dec 2025 06:16:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=O9L1i CamBEXkxI0wpVy158tFqdIiJVtz1+GqywUzvHo=; b=HTSGSnV31gNgL5n/5deQi HRhwIo4tyqkAGokwmJbkqBE2pT4rNjt9LDq9SWxTXA7o7CLIXBiFLeSV53F5jDmd 8bndpIAzi31Ejf83J9+YZp8Yo4fCsF199X64/L8+6QNUM/y+pKYLim6dwZ69DMd7 cEjk0pUhPmjpXmia2HpODPrKTusDHjuVs4MjZxkKv/AWQeZC/m3zp+qf+9Z+gLNb JPpSQgtCTSXGZkx97Kk+6gWrFSGrygyg74sNuHnZoJB+p4cYASm5fL9JNhtlhio1 nDyjonVNhuy8BrWIqTJi+NOoQGXvK1Lx2X8UrqEUHM3XJVu/ikLy+V2OAP42tIAd g== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4ba680kcu5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Dec 2025 06:16:21 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5BV5nYo8013716; Wed, 31 Dec 2025 06:16:20 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4ba5w8c7s4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Dec 2025 06:16:20 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 5BV6GE8a009609; Wed, 31 Dec 2025 06:16:19 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4ba5w8c7mt-3; Wed, 31 Dec 2025 06:16:19 +0000 From: Harshit Mogalapalli To: zohar@linux.ibm.com, akpm@linux-foundation.org Cc: ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, graf@amazon.com, guoweikang.kernel@gmail.com, harshit.m.mogalapalli@oracle.com, henry.willard@oracle.com, hpa@zytor.com, jbohac@suse.cz, joel.granados@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, noodles@fb.com, paul.x.webb@oracle.com, rppt@kernel.org, sohil.mehta@intel.com, sourabhjain@linux.ibm.com, stable@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, yifei.l.liu@oracle.com Subject: [PATCH v3 2/3] of/kexec: refactor ima_get_kexec_buffer() to use ima_validate_range() Date: Tue, 30 Dec 2025 22:16:08 -0800 Message-ID: <20251231061609.907170-3-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251231061609.907170-1-harshit.m.mogalapalli@oracle.com> References: <20251231061609.907170-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-31_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2512120000 definitions=main-2512310052 X-Proofpoint-ORIG-GUID: EyYdMcQB00pS9vAZuoFkmQXsOm74SBFQ X-Proofpoint-GUID: EyYdMcQB00pS9vAZuoFkmQXsOm74SBFQ X-Authority-Analysis: v=2.4 cv=HPLO14tv c=1 sm=1 tr=0 ts=6954bfb5 b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=yPCof4ZbAAAA:8 a=pjPCvf8BpcJgz2SLxb0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMxMDA1MiBTYWx0ZWRfX1j3WZIKLBWAg oMcR11qFZgBdxeitogJoG4Gi5vIKY/kQBKjl3pCpc/Mhy5xHPoL1++wQwlAL0AhYWMBF32iFUH/ A+IDviXHxAjlJzffAjGJXdrxUPR1Men9kwa2HyvK0Iq9TF0sUvxomyit+RpwLlupWeMih5rCAwE hEezZRGq7JoRibH8Q7jqB7emx/lmXfwJlYFqiA0v4F0idLyqDRniCT1vQpFRaVihWdUFm4E56/T 8RzYmsT4pknJWpQproiG/DQPvZBUR1ksymSQOoXBohToudInG+ianjMzUNqDePlIGsWtuTTb0j1 W3p2QWxpNZ3p22q3v2+lSrZO6Y8c0//Y7MTKbh1qSMDfQ/5cxRKGyevzlce7OH3R+qZxC6H5qa0 y4zE/GVHknJor5O8+jUNoe6eYsgFcMMtfyO2jmW+BNQ5D4OfF7WfDvydGViW5a/3dXEGfsRdORN uBVHF2b4FkBkzc9sYEg== Content-Type: text/plain; charset="utf-8" Refactor the OF/DT ima_get_kexec_buffer() to use a generic helper to validate the address range. No functional change intended. Cc: stable@vger.kernel.org Reviewed-by: Mimi Zohar Signed-off-by: Harshit Mogalapalli --- V2-> V3: Add RB from Mimi Zohar. --- drivers/of/kexec.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/of/kexec.c b/drivers/of/kexec.c index 1ee2d31816ae..c4cf3552c018 100644 --- a/drivers/of/kexec.c +++ b/drivers/of/kexec.c @@ -128,7 +128,6 @@ int __init ima_get_kexec_buffer(void **addr, size_t *si= ze) { int ret, len; unsigned long tmp_addr; - unsigned long start_pfn, end_pfn; size_t tmp_size; const void *prop; =20 @@ -144,17 +143,9 @@ int __init ima_get_kexec_buffer(void **addr, size_t *s= ize) if (!tmp_size) return -ENOENT; =20 - /* - * Calculate the PFNs for the buffer and ensure - * they are with in addressable memory. - */ - start_pfn =3D PHYS_PFN(tmp_addr); - end_pfn =3D PHYS_PFN(tmp_addr + tmp_size - 1); - if (!page_is_ram(start_pfn) || !page_is_ram(end_pfn)) { - pr_warn("IMA buffer at 0x%lx, size =3D 0x%zx beyond memory\n", - tmp_addr, tmp_size); - return -EINVAL; - } + ret =3D ima_validate_range(tmp_addr, tmp_size); + if (ret) + return ret; =20 *addr =3D __va(tmp_addr); *size =3D tmp_size; --=20 2.50.1 From nobody Sat Feb 7 06:49:08 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 468B12D3228; Wed, 31 Dec 2025 06:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767161799; cv=none; b=Q9DQYPeN/rBMk6qJ+0Zh9W+Y9ukDyZ/JBGmez0ju4t7WTBkM+UZ0Tq34sc1HGy9MB9p9jhV5/etsZz9Bg6nq6yTzUV4qFGSObFTJTse5Prkz79Xxa+tNFy3Hxyx+KgRzT59vNdj9SmzWREHh+Jc+0LPQy294j340nv6+dxiPJy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767161799; c=relaxed/simple; bh=2Jt9GsjsSGPC0WcZcDrsd7TH7UQiaJBHb8A2yfsQ+eI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Md2CZc5za3SiLYK8dSw1gmxteez4kKyB1LgEg6CMwHKBt8+wiB3p2XliPmey98XFouH/KXNQShPxkXHdejTH8foF8Od9DnSAM80SUQwg4Ap3OjgB79V6FJG+J8AV2RNHADsUabZeG+xpWMCydy+oeX5+w7gly9/fQgP2kb8k6wI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=bPVqz0D9; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="bPVqz0D9" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BV0HOAp1075540; Wed, 31 Dec 2025 06:16:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=it3f+hcoxO8E8SSBho9WFDyAJ6zTtQDOoPTTP8A0hcE=; b= bPVqz0D9vl5R8PFfLm8+fG45iem2Uyj1nDIXLxXqY044nMCTifhwZzNL8opgUVfi y6DdLbJVHzNCWoUvxJh9oO5TLKatgU9kmTB0emtxvrswjwQ3yOQHWFNj/qPzRdUk MyvjK6BMzOZoNNEQvt0V60LGcjpzg69v4fn9GFPdA2VFtrMCTk7m0w93PiU3TvU7 NATdqbfp8Wdkr/j0N4UI9b4zjkFYaGyzt7YlvE9SqyIGoFvFdhvTKYN4LbiuqUt2 fdAcOLbCNEsE121Niu6YGUfUCkrFxgKGh7C0FrLvfolul59APYxJRI1wbnGhCNzh 3Xft+22gETgM2fTOWDu54A== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4ba5va3cn5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Dec 2025 06:16:23 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5BV2tW97014684; Wed, 31 Dec 2025 06:16:22 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4ba5w8c7tj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Dec 2025 06:16:22 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 5BV6GE8c009609; Wed, 31 Dec 2025 06:16:21 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4ba5w8c7mt-4; Wed, 31 Dec 2025 06:16:21 +0000 From: Harshit Mogalapalli To: zohar@linux.ibm.com, akpm@linux-foundation.org Cc: ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, graf@amazon.com, guoweikang.kernel@gmail.com, harshit.m.mogalapalli@oracle.com, henry.willard@oracle.com, hpa@zytor.com, jbohac@suse.cz, joel.granados@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, noodles@fb.com, paul.x.webb@oracle.com, rppt@kernel.org, sohil.mehta@intel.com, sourabhjain@linux.ibm.com, stable@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, yifei.l.liu@oracle.com Subject: [PATCH v3 3/3] x86/kexec: Add a sanity check on previous kernel's ima kexec buffer Date: Tue, 30 Dec 2025 22:16:09 -0800 Message-ID: <20251231061609.907170-4-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251231061609.907170-1-harshit.m.mogalapalli@oracle.com> References: <20251231061609.907170-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-31_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2512120000 definitions=main-2512310052 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMxMDA1MiBTYWx0ZWRfXwSmACOuqGClY 59+IeJ26iBmw7YWE05wx1Vy2eh2T6l50b/u/yEDHAlSdekoI4PHoE2FMqV208pwoLr/6mjCjrqF 0srpLOU+bOk4Fs8mfPp/Iu1i0I+WoSOv0uWWfQqnkuYaRciDv4OJTwMUlQe5xN6qlq1/vGb/1tU 3UmQXAyUYoKnqFjyjbicV+JuDTAUxH8suwRMCs1g4cWDUo9U/jThRZCwrzGlYlLF5cRaEh1IWj7 nMwAEMtrZzSJHNmMJk9YDJ3x7nTXry732yRmYS2vG+z2oPSylnu0cqonK8w1ri0DwXxGGryelcT Wpm27k46zQui4WuJUia4x7Q4iXwEjgX+gKH0w5kHJPiaXh/wV4A3REGmPe8xyBjdCa06Y77mIew h7e8ymSHAXyyqh3Dywc97JoQ0WRpMmdYe/AepiLT8v5Rre2YdIH52tqBXKd0HSkmNJ0cgTOecDv eZsf1IvvvRbmH7EdFvA== X-Authority-Analysis: v=2.4 cv=NMvYOk6g c=1 sm=1 tr=0 ts=6954bfb7 b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=VnNF1IyMAAAA:8 a=nkYO0nU_c48bT3HRU-QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: FS6XxfocCnB06pXnCy2v5_fDAFVUa4iq X-Proofpoint-ORIG-GUID: FS6XxfocCnB06pXnCy2v5_fDAFVUa4iq When the second-stage kernel is booted via kexec with a limiting command line such as "mem=3D", the physical range that contains the carried over IMA measurement list may fall outside the truncated RAM leading to a kernel panic. BUG: unable to handle page fault for address: ffff97793ff47000 RIP: ima_restore_measurement_list+0xdc/0x45a #PF: error_code(0x0000) =E2=80=93 not-present page Other architectures already validate the range with page_is_ram(), as done in commit cbf9c4b9617b ("of: check previous kernel's ima-kexec-buffer against memory bounds") do a similar check on x86. Without carrying the measurement list across kexec, the attestation would fail. Cc: stable@vger.kernel.org Fixes: b69a2afd5afc ("x86/kexec: Carry forward IMA measurement log on kexec= ") Reported-by: Paul Webb Reviewed-by: Mimi Zohar Signed-off-by: Harshit Mogalapalli --- V1-> V2: Added a line about carrying measure list across kexec based on suggestion from Mimi Zohar. Made use to the new generic helper [Suggestion from Borislav] V2-> V3: Add RB from Mimi Zohar. --- arch/x86/kernel/setup.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 1b2edd07a3e1..383d4a4784f5 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -439,9 +439,15 @@ int __init ima_free_kexec_buffer(void) =20 int __init ima_get_kexec_buffer(void **addr, size_t *size) { + int ret; + if (!ima_kexec_buffer_size) return -ENOENT; =20 + ret =3D ima_validate_range(ima_kexec_buffer_phys, ima_kexec_buffer_size); + if (ret) + return ret; + *addr =3D __va(ima_kexec_buffer_phys); *size =3D ima_kexec_buffer_size; =20 --=20 2.50.1