From nobody Sat Feb 7 09:59:07 2026 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E3D830BBB8 for ; Wed, 31 Dec 2025 03:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767153411; cv=none; b=HJprZPxN0JXEReLQUuup8295Nn3FZZbz/e3/2rUizqQrQPoeia3D77F690CSIiAH3erQ+W3ytpz/fHuIZvCPWUr3K5fryysCwHo+JyhsLRTHk1dzy/yqTspWtt7/iaF8YVTBcKpf78M2XwGFtMs9/s0OxcNyYy396irfjdNfvFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767153411; c=relaxed/simple; bh=7IRQGniC8RV35kb3vf8on4sHktiyQS6VyfUPpC0weeM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EO4EEs9wWQ82jo4xs00HvDksy8FYkwEFK0u+O90qLJ2kjFt0X8mTzfuGHoq8SKRWdgh/dgdZ3SMzeWvxuYpyG3rCoXKPMOhisquTFBu5TOnDk2mN08VIQnMzOWKwNCIEsVAO7hJ799G4jjphXc1Cg+FbYhLIbSBDm4rywjoEeq0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=K2wMiTuN; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="K2wMiTuN" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7c750b10e14so4273680a34.2 for ; Tue, 30 Dec 2025 19:56:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1767153408; x=1767758208; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+ml+CWfuCyt8xPYOA/5JpaBit+P1+CQ1YTe7Xd3yRLk=; b=K2wMiTuNJUwiuMmL1mdfjIZ932gD/ChC5yPm2GlY0M3qoyeVwb90T+lIkGrvxiw7ff FUzmfdxS3dl9rerC/XSSd8aqhBQDL4cliCNDjI6YdegjVpurPlfV4QQ4yJ3fTvQkUkfF +PIgeUzB+GNyQtt8W2As22Tt9zDmYaCjyrWLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767153408; x=1767758208; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+ml+CWfuCyt8xPYOA/5JpaBit+P1+CQ1YTe7Xd3yRLk=; b=GOcnTQkGRq/5X9weFJS8rx/49O6JE4j4nNViE5WUOdF2flC9QPUVxMME56rv2jCEtu DEWfxIPesnavVcP+0HmwE4G5raQXmeXYJMxdTvfDfLcL5CEue7e6+xu3i6+u7uDLohtn qj0T+MhE/n5pd9oNGyZPYeEncuuS6jQ1K2KOiixrO0QmGDoNsHn19MnNKCOq6ONGXO/q Ec+JYMq5yHUHVwIyPU/IzPruNNstWQpuSVqSkOfI+UFjpXDMskFrVsMk9k/tEWoyxxJ+ x+byF5ntGAerrQMkzVQjJwIDq9HfYwyuaSJG1Y/rxaD7chC7uB+x2TD4ilwuB4mVDm+Z ntgA== X-Forwarded-Encrypted: i=1; AJvYcCVLawCYuTUvoJcpatybocmA2b9N1UOHIjlKKdjkKfUrloIXJ5+cwr7axlAUhXYAkgmNerr5DV8foZl2uoM=@vger.kernel.org X-Gm-Message-State: AOJu0YxOSehy+/AczuoKDlhKdOs0c/GZACDgggoaFOV95itnndZATI/C 6JlOq7/Gs4ChkHZNysxUcebAKyVTwN6jgPdlxJBiKHWQAqC7fw99jOrro/RUF06anOY= X-Gm-Gg: AY/fxX5DGr2OnnGT/hvCyITcL8MCUB0lFYW0BPGi1OySbKRNwDcJSmH24L61C6nQttb 5ddvf9i6kZ6X+fDIoxqSLGdDq5/1i9lj2UobFt83WZpndV+fmIFuitTa6VZgwkr+h93303YNoy8 DmDx3aIAW4DMDultfw0Nk5hyvWSrwLwvN6+Nk1IFv25Nw221lkAnlysgyLtonKjrC2hf0vmxJDd W3fTbwJOlzEcPdRLYUtfAzpIRl1JK60l4New5fOSfbTcqOpMFwTT8HOlZCNRrknTrWj/elaTKL4 gkFhWDgwz2+tSrphAAnz8E2J5mZcgx4IUe4BjmZt90M/X7saIfkujhuy4UCM838eQ/BN/gTX6Lj AnsSdP7auDMDlCMWTr3O2z6tOX5iVSFa59sdVbkQk+SVIltdunYr+EDyGytTEtGvpUPvFgyTx0R RIHn+E0+jf6+0jCYIy0bwcYSOtiu6+MbdTFfBI X-Google-Smtp-Source: AGHT+IERNvC/8Px0V8IUK3zXSD3cLtvI8CWOvblwcgNUVpnq5u8i6LLyM/rg8Ub+tY/WiPli4ic1Sg== X-Received: by 2002:a05:6830:8385:b0:7c6:d0b4:c973 with SMTP id 46e09a7af769-7cc66a843c9mr16033899a34.28.1767153407908; Tue, 30 Dec 2025 19:56:47 -0800 (PST) Received: from shuah-framework.internal ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cc667d7f1dsm23582518a34.15.2025.12.30.19.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 19:56:47 -0800 (PST) From: Shuah Khan To: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, torvalds@linux-foundation.org, ebiggers@kernel.org, johannes@sipsolutions.net Cc: Shuah Khan , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] Revert "wifi: mt76: Strip whitespace from build ddate" Date: Tue, 30 Dec 2025 20:56:42 -0700 Message-ID: <20251231035645.5545-1-skhan@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit f804a5895ebad2b2d4fb8a3688d2115926e993d5. This change introduced the following panic, and mt792x_load_firmware() fails. wifi is dead on systems with mt792x wireless. kern :crit : kernel BUG at lib/string_helpers.c:1043! kern :warn : Oops: invalid opcode: 0000 [#1] SMP NOPTI kern :warn : CPU: 14 UID: 0 PID: 61 Comm: kworker/14:0 Tainted: G W 6.19.0-rc1 #1 PREEMPT(voluntary) kern :warn : Tainted: [W]=3DWARN kern :warn : Hardware name: Framework Laptop 13 (AMD Ryzen 7040Series)/FR= ANMDCP07, BIOS 03.16 07/25/2025 kern :warn : Workqueue: events mt7921_init_work [mt7921_common] kern :warn : RIP: 0010:__fortify_panic+0xd/0xf kern :warn : Code: 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 90 90 90 90 90 = 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa 40 0f b6 ff e8 c3 55 71 00 <0f= > 0b 48 8b 54 24 10 48 8b 74 24 08 4c 89 e9 48 c7 c7 00 a2 d5 a0 kern :warn : RSP: 0018:ffffa7a5c03a3d10 EFLAGS: 00010246 kern :warn : RAX: ffffffffa0d7aaf2 RBX: 0000000000000000 RCX: ffffffffa0d= 7aaf2 kern :warn : RDX: 0000000000000011 RSI: ffffffffa0d5a170 RDI: ffffffffa12= 8db10 kern :warn : RBP: ffff91650ae52060 R08: 0000000000000010 R09: ffffa7a5c31= b2000 kern :warn : R10: ffffa7a5c03a3bf0 R11: 00000000ffffffff R12: 00000000000= 00000 kern :warn : R13: ffffa7a5c31b2000 R14: 0000000000001000 R15: 00000000000= 00000 kern :warn : FS: 0000000000000000(0000) GS:ffff91743e664000(0000) knlGS:= 0000000000000000 kern :warn : CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kern :warn : CR2: 00007f10786c241c CR3: 00000003eca24000 CR4: 0000000000f= 50ef0 kern :warn : PKRU: 55555554 kern :warn : Call Trace: kern :warn : kern :warn : mt76_connac2_load_patch.cold+0x2b/0xa41 [mt76_connac_lib] kern :warn : ? srso_alias_return_thunk+0x5/0xfbef5 kern :warn : mt792x_load_firmware+0x36/0x150 [mt792x_lib] kern :warn : mt7921_run_firmware+0x2c/0x4a0 [mt7921_common] kern :warn : ? srso_alias_return_thunk+0x5/0xfbef5 kern :warn : ? mt7921_rr+0x12/0x30 [mt7921e] kern :warn : ? srso_alias_return_thunk+0x5/0xfbef5 kern :warn : ? ____mt76_poll_msec+0x75/0xb0 [mt76] kern :warn : mt7921e_mcu_init+0x4c/0x7a [mt7921e] kern :warn : mt7921_init_work+0x51/0x190 [mt7921_common] kern :warn : process_one_work+0x18b/0x340 kern :warn : worker_thread+0x256/0x3a0 kern :warn : ? __pfx_worker_thread+0x10/0x10 kern :warn : kthread+0xfc/0x240 kern :warn : ? __pfx_kthread+0x10/0x10 kern :warn : ? __pfx_kthread+0x10/0x10 kern :warn : ret_from_fork+0x254/0x290 kern :warn : ? __pfx_kthread+0x10/0x10 kern :warn : ret_from_fork_asm+0x1a/0x30 kern :warn : Signed-off-by: Shuah Khan --- drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers= /net/wireless/mediatek/mt76/mt76_connac_mcu.c index ea99167765b0..fba7025ffd3f 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c @@ -3101,7 +3101,6 @@ int mt76_connac2_load_patch(struct mt76_dev *dev, con= st char *fw_name) int i, ret, sem, max_len =3D mt76_is_sdio(dev) ? 2048 : 4096; const struct mt76_connac2_patch_hdr *hdr; const struct firmware *fw =3D NULL; - char build_date[17]; =20 sem =3D mt76_connac_mcu_patch_sem_ctrl(dev, true); switch (sem) { @@ -3125,11 +3124,8 @@ int mt76_connac2_load_patch(struct mt76_dev *dev, co= nst char *fw_name) } =20 hdr =3D (const void *)fw->data; - strscpy(build_date, hdr->build_date, sizeof(build_date)); - build_date[16] =3D '\0'; - strim(build_date); dev_info(dev->dev, "HW/SW Version: 0x%x, Build Time: %.16s\n", - be32_to_cpu(hdr->hw_sw_ver), build_date); + be32_to_cpu(hdr->hw_sw_ver), hdr->build_date); =20 for (i =3D 0; i < be32_to_cpu(hdr->desc.n_region); i++) { struct mt76_connac2_patch_sec *sec; --=20 2.51.0