From nobody Sat Feb 7 21:15:50 2026 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 798224315A for ; Wed, 31 Dec 2025 00:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767141926; cv=none; b=tH4PI7C1kIc1e2kcfLVm0VHo3QqUTbrvLyicoCT9uGPbdpAWxvyIiCNgj0rq1sHoQVDrlwyT1B5tRLDToNReRgIF3fvvRNzvJzo3vDV7Du9l1c475Q4WxtnyauoNczF/DcZVdE3OUqONEQHeRVuA5PN432ISes0zbZhI+IpYyUY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767141926; c=relaxed/simple; bh=58nJL78mZb4L/r540FIIGmpaC9+0CK1OZCYFmquRRgI=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=VJ4xBeHk/aLxpGlTfpAbfW0glRJpG90UYdYPchbVGVM4rhSmcjjJwRkXqrFq5BH1oGaJd6IqMFLZsXzgxxNzHjqo9PuxeFffsxyPV3qI32mTGA7c/E6cG0gG13w/xsSW74NK+hr2FJyfnx7K5YxSviBexk92eDfE//qoUMF/yuA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ynaffit.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kol/M04V; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ynaffit.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kol/M04V" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-34c904a1168so22998136a91.1 for ; Tue, 30 Dec 2025 16:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1767141925; x=1767746725; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=5fjrjqtIG0QKNagwrK1D4QB/QYPJKmvCpq/Rsho6vIE=; b=kol/M04V0q5tjuz+SYGIyhLb+6zo03x/oSOdkwxJHdXyj0rx6pLjMesrws//FbuBf9 +k0MO6rUHvdka4D4bBxIVS5nfbALCGcUZw/OgZ7XHZaTQCkxBZtNubOTyFFcUO/TqpWH lv2HgAQCNW4mqxjmwEVqOLVOWkZY6V+ak+SnMYG10L9Xv/ajLFeIBtMkPhoLJhv6Bhof u3LDfg/+EXvgNA/+6gXurq14akzzlDGVLxr7iwx6fN/kdWKtuWa2HJSD9hKmrDR3vq4w fgBf+nFocXUrL1XUKLpEfen9EUPn1E7uHHDmg212TT+T+gqNKewltgkc8pWvI02//e2/ zZYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767141925; x=1767746725; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5fjrjqtIG0QKNagwrK1D4QB/QYPJKmvCpq/Rsho6vIE=; b=qWWNY9YjbN+hgCppFmNoDJqC0Oi8yqjwC/0ofKugqfMKWlP2CnTnHG1Y92+1trjoRW ReR/T3OD5nrb1c8yz/R6PB0hKMnmilo4+Tn03QT+CXNZ5bZBdRbBBCaw8XWysBT95svO SEmDRepX8zKXshThNeV6EQMAZC5YZdkSZFQ9HkoJ7sMjwEZ6miQsHaKmiv5FXfvQ0dEq Krgw/fjIvFtyaKXTq2cg0zk7Hmljpbo5BetpT5uQ93M0U2OTDtb680KPtRzHKukRYrxA LL1NvfFr7jUOixSkb2VOfWTpOPdHj39ZAh3RylsHucZuhdDfLSLPAINO6fVcbC4qyQQg 2bmA== X-Forwarded-Encrypted: i=1; AJvYcCXMTOiO4KUGdjuTZRYLV8Rz7rPFblMUqE9LBiFSgI1HNIEgVCQ83OA6TuaChZi32JXgGt/CTM13HCssH/E=@vger.kernel.org X-Gm-Message-State: AOJu0YzpWkmHNW97j0JfWygl6f6vrTDpdu52qLoPwBKZCxhCv4ags3K5 xapAIJxgtNhyyicey5Fu5Et4IkfVdzpCW78Bk/Mj6YLtcT1ZqGw1daqrdFjF1XC/d4oNnHP+7dK 6x3XRSzyvVA== X-Google-Smtp-Source: AGHT+IFzEHBCDGH6fIW5fQdRAN3RJwqMBy9/SFw04+KiP5a94waiEzLW46hMtUUrlVdXoksytpVnCtihLWua X-Received: from dlbpy24.prod.google.com ([2002:a05:7022:e998:b0:120:5c35:c798]) (user=ynaffit job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:3c06:b0:119:e569:f258 with SMTP id a92af1059eb24-121721acc08mr29050254c88.1.1767141924735; Tue, 30 Dec 2025 16:45:24 -0800 (PST) Date: Tue, 30 Dec 2025 16:45:11 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.351.gbe84eed79e-goog Message-ID: <20251231004510.1732543-2-ynaffit@google.com> Subject: [PATCH 5.10,5.15,6.1,6.6 RESEND] leds: spi-byte: Initialize device node before access From: Tiffany Yang To: stable@vger.kernel.org Cc: pchelkin@ispras.ru, linux-kernel@vger.kernel.org, kernel-team@android.com, Pavel Machek , Lee Jones , Andy Shevchenko , linux-leds@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 7f9ab862e05c ("leds: spi-byte: Call of_node_put() on error path") was merged in 6.11 and then backported to stable trees through 5.10. It relocates the line that initializes the variable 'child' to a later point in spi_byte_probe(). Versions < 6.9 do not have commit ccc35ff2fd29 ("leds: spi-byte: Use devm_led_classdev_register_ext()"), which removes a line that reads a property from 'child' before its new initialization point. Consequently, spi_byte_probe() reads from an uninitialized device node in stable kernels 6.6-5.10. Initialize 'child' before it is first accessed. Fixes: 7f9ab862e05c ("leds: spi-byte: Call of_node_put() on error path") Signed-off-by: Tiffany Yang --- As an alternative to moving the initialization of 'child' up, Fedor Pchelkin proposed [1] backporting the change that removes the intermediate access. [1] https://lore.kernel.org/stable/20241029204128.527033-1-pchelkin@ispras.= ru/ --- drivers/leds/leds-spi-byte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-spi-byte.c b/drivers/leds/leds-spi-byte.c index afe9bff7c7c1..4520df1e2341 100644 --- a/drivers/leds/leds-spi-byte.c +++ b/drivers/leds/leds-spi-byte.c @@ -96,6 +96,7 @@ static int spi_byte_probe(struct spi_device *spi) if (!led) return -ENOMEM; =20 + child =3D of_get_next_available_child(dev_of_node(dev), NULL); of_property_read_string(child, "label", &name); strscpy(led->name, name, sizeof(led->name)); led->spi =3D spi; @@ -106,7 +107,6 @@ static int spi_byte_probe(struct spi_device *spi) led->ldev.max_brightness =3D led->cdef->max_value - led->cdef->off_value; led->ldev.brightness_set_blocking =3D spi_byte_brightness_set_blocking; =20 - child =3D of_get_next_available_child(dev_of_node(dev), NULL); state =3D of_get_property(child, "default-state", NULL); if (state) { if (!strcmp(state, "on")) { --=20 2.52.0.351.gbe84eed79e-goog